1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(rustc_private)]
5 #![feature(slice_patterns)]
6 #![feature(stmt_expr_attributes)]
7 #![feature(range_contains)]
8 #![feature(macro_vis_matcher)]
9 #![allow(unknown_lints, indexing_slicing, shadow_reuse, missing_docs_in_private_items)]
10 #![recursion_limit = "256"]
11 #![allow(stable_features)]
12 #![feature(iterator_find_map)]
13 #![feature(macro_at_most_once_rep)]
14 #![feature(rust_2018_preview)]
16 extern crate cargo_metadata;
19 extern crate rustc_target;
20 extern crate rustc_typeck;
22 extern crate syntax_pos;
26 // for unicode nfc normalization
28 extern crate unicode_normalization;
30 // for semver check in attrs.rs
36 extern crate regex_syntax;
38 // for finding minimal boolean expressions
40 extern crate quine_mc_cluskey;
42 extern crate rustc_errors;
43 extern crate rustc_plugin;
46 extern crate matches as matches_macro;
50 extern crate serde_derive;
53 extern crate lazy_static;
55 extern crate itertools;
56 extern crate pulldown_cmark;
60 extern crate if_chain;
62 macro_rules! declare_clippy_lint {
63 { pub $name:tt, style, $description:tt } => {
64 declare_lint! { pub $name, Warn, $description }
66 { pub $name:tt, correctness, $description:tt } => {
67 declare_lint! { pub $name, Deny, $description }
69 { pub $name:tt, complexity, $description:tt } => {
70 declare_lint! { pub $name, Warn, $description }
72 { pub $name:tt, perf, $description:tt } => {
73 declare_lint! { pub $name, Warn, $description }
75 { pub $name:tt, pedantic, $description:tt } => {
76 declare_lint! { pub $name, Allow, $description }
78 { pub $name:tt, restriction, $description:tt } => {
79 declare_lint! { pub $name, Allow, $description }
81 { pub $name:tt, cargo, $description:tt } => {
82 declare_lint! { pub $name, Allow, $description }
84 { pub $name:tt, nursery, $description:tt } => {
85 declare_lint! { pub $name, Allow, $description }
87 { pub $name:tt, internal, $description:tt } => {
88 declare_lint! { pub $name, Allow, $description }
90 { pub $name:tt, internal_warn, $description:tt } => {
91 declare_lint! { pub $name, Warn, $description }
99 // begin lints modules, do not remove this comment, it’s used in `update_lints`
100 pub mod approx_const;
102 pub mod array_indexing;
106 pub mod blacklisted_name;
107 pub mod block_in_if_condition;
110 pub mod collapsible_if;
111 pub mod const_static_lifetime;
113 pub mod cyclomatic_complexity;
116 pub mod double_comparison;
117 pub mod double_parens;
118 pub mod drop_forget_ref;
119 pub mod else_if_without_else;
123 pub mod enum_glob_use;
124 pub mod enum_variants;
128 pub mod eta_reduction;
129 pub mod eval_order_dependence;
130 pub mod excessive_precision;
131 pub mod explicit_write;
132 pub mod fallible_impl_from;
136 pub mod identity_conversion;
138 pub mod if_let_redundant_pattern_matching;
140 pub mod infallible_destructuring_match;
141 pub mod infinite_iter;
142 pub mod inherent_impl;
143 pub mod inline_fn_without_body;
144 pub mod int_plus_one;
146 pub mod items_after_statements;
147 pub mod large_enum_variant;
151 pub mod literal_representation;
162 pub mod multiple_crate_versions;
164 pub mod mut_reference;
165 pub mod mutex_atomic;
166 pub mod needless_bool;
167 pub mod needless_borrow;
168 pub mod needless_borrowed_ref;
169 pub mod needless_continue;
170 pub mod needless_pass_by_value;
171 pub mod needless_update;
172 pub mod neg_cmp_op_on_partial_ord;
173 pub mod neg_multiply;
174 pub mod new_without_default;
176 pub mod non_expressive_names;
178 pub mod open_options;
179 pub mod overflow_check_conditional;
180 pub mod panic_unimplemented;
181 pub mod partialeq_ne_impl;
184 pub mod question_mark;
186 pub mod redundant_field_names;
189 pub mod replace_consts;
194 pub mod suspicious_trait_impl;
196 pub mod temporary_assignment;
200 pub mod unsafe_removed_from_name;
201 pub mod unused_io_amount;
202 pub mod unused_label;
206 pub mod zero_div_zero;
207 // end lints modules, do not remove this comment, it’s used in `update_lints`
210 pub use syntax::ast::{Name, NodeId};
213 #[cfg_attr(rustfmt, rustfmt_skip)]
214 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
215 let conf = match utils::conf::file_from_args(reg.args()) {
217 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
218 // do not require the file to exist
219 let file_name = if let Some(file_name) = file_name {
222 match utils::conf::lookup_conf_file() {
225 reg.sess.struct_err(&format!("error finding Clippy's configuration file: {}", error)).emit();
231 let file_name = file_name.map(|file_name| if file_name.is_relative() {
233 .local_crate_source_file
235 .and_then(|file| std::path::Path::new(&file).parent().map(std::path::Path::to_path_buf))
242 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
244 // all conf errors are non-fatal, we just use the default conf in case of error
245 for error in errors {
246 reg.sess.struct_err(&format!("error reading Clippy's configuration file `{}`: {}", file_name.as_ref().and_then(|p| p.to_str()).unwrap_or(""), error)).emit();
251 Err((err, span)) => {
252 reg.sess.struct_span_err(span, err)
253 .span_note(span, "Clippy will use default configuration")
255 toml::from_str("").expect("we never error on empty config files")
259 let mut store = reg.sess.lint_store.borrow_mut();
260 store.register_removed(
262 "`assert!()` will be more flexible with RFC 2011",
264 store.register_removed(
266 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
268 store.register_removed(
269 "range_step_by_zero",
270 "`iterator.step_by(0)` panics nowadays",
272 store.register_removed(
274 "`Vec::as_slice` has been stabilized in 1.7",
276 store.register_removed(
277 "unstable_as_mut_slice",
278 "`Vec::as_mut_slice` has been stabilized in 1.7",
280 store.register_removed(
282 "using `str::to_string` is common even today and specialization will likely happen soon",
284 store.register_removed(
286 "using `string::to_string` is common even today and specialization will likely happen soon",
288 store.register_removed(
289 "misaligned_transmute",
290 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
292 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
294 reg.register_late_lint_pass(box serde_api::Serde);
295 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
296 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
297 reg.register_late_lint_pass(box utils::inspector::Pass);
298 reg.register_late_lint_pass(box utils::author::Pass);
299 reg.register_late_lint_pass(box types::TypePass);
300 reg.register_late_lint_pass(box booleans::NonminimalBool);
301 reg.register_late_lint_pass(box eq_op::EqOp);
302 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
303 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
304 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
305 reg.register_late_lint_pass(box excessive_precision::ExcessivePrecision);
306 reg.register_late_lint_pass(box bit_mask::BitMask::new(conf.verbose_bit_mask_threshold));
307 reg.register_late_lint_pass(box ptr::PointerPass);
308 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
309 reg.register_late_lint_pass(box needless_bool::BoolComparison);
310 reg.register_late_lint_pass(box approx_const::Pass);
311 reg.register_late_lint_pass(box misc::Pass);
312 reg.register_early_lint_pass(box precedence::Precedence);
313 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
314 reg.register_late_lint_pass(box eta_reduction::EtaPass);
315 reg.register_late_lint_pass(box identity_op::IdentityOp);
316 reg.register_late_lint_pass(box erasing_op::ErasingOp);
317 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
318 reg.register_late_lint_pass(box mut_mut::MutMut);
319 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
320 reg.register_late_lint_pass(box len_zero::LenZero);
321 reg.register_late_lint_pass(box attrs::AttrPass);
322 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
323 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
324 reg.register_late_lint_pass(box unicode::Unicode);
325 reg.register_late_lint_pass(box strings::StringAdd);
326 reg.register_early_lint_pass(box returns::ReturnPass);
327 reg.register_late_lint_pass(box methods::Pass);
328 reg.register_late_lint_pass(box shadow::Pass);
329 reg.register_late_lint_pass(box types::LetPass);
330 reg.register_late_lint_pass(box types::UnitCmp);
331 reg.register_late_lint_pass(box loops::Pass);
332 reg.register_late_lint_pass(box lifetimes::LifetimePass);
333 reg.register_late_lint_pass(box entry::HashMapLint);
334 reg.register_late_lint_pass(box ranges::Pass);
335 reg.register_late_lint_pass(box types::CastPass);
336 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
337 reg.register_late_lint_pass(box matches::MatchPass);
338 reg.register_late_lint_pass(box minmax::MinMaxPass);
339 reg.register_late_lint_pass(box open_options::NonSensical);
340 reg.register_late_lint_pass(box zero_div_zero::Pass);
341 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
342 reg.register_late_lint_pass(box needless_update::Pass);
343 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
344 reg.register_late_lint_pass(box needless_borrowed_ref::NeedlessBorrowedRef);
345 reg.register_late_lint_pass(box no_effect::Pass);
346 reg.register_late_lint_pass(box map_clone::Pass);
347 reg.register_late_lint_pass(box temporary_assignment::Pass);
348 reg.register_late_lint_pass(box transmute::Transmute);
349 reg.register_late_lint_pass(
350 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
352 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
353 reg.register_early_lint_pass(box misc_early::MiscEarly);
354 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
355 reg.register_late_lint_pass(box panic_unimplemented::Pass);
356 reg.register_late_lint_pass(box strings::StringLitAsBytes);
357 reg.register_late_lint_pass(box derive::Derive);
358 reg.register_late_lint_pass(box types::CharLitAsU8);
359 reg.register_late_lint_pass(box write::Pass);
360 reg.register_late_lint_pass(box vec::Pass);
361 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
362 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
364 reg.register_late_lint_pass(box drop_forget_ref::Pass);
365 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
366 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
367 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
368 reg.register_late_lint_pass(box regex::Pass::default());
369 reg.register_late_lint_pass(box copies::CopyAndPaste);
370 reg.register_late_lint_pass(box format::Pass);
371 reg.register_early_lint_pass(box formatting::Formatting);
372 reg.register_late_lint_pass(box swap::Swap);
373 reg.register_early_lint_pass(box if_not_else::IfNotElse);
374 reg.register_early_lint_pass(box else_if_without_else::ElseIfWithoutElse);
375 reg.register_early_lint_pass(box int_plus_one::IntPlusOne);
376 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
377 reg.register_late_lint_pass(box unused_label::UnusedLabel);
378 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
379 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
380 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
381 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
382 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
383 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
384 reg.register_late_lint_pass(box mem_forget::MemForget);
385 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
386 reg.register_late_lint_pass(box assign_ops::AssignOps);
387 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
388 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
389 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
390 reg.register_late_lint_pass(box ok_if_let::Pass);
391 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
392 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
393 reg.register_early_lint_pass(box reference::Pass);
394 reg.register_early_lint_pass(box reference::DerefPass);
395 reg.register_early_lint_pass(box double_parens::DoubleParens);
396 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
397 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
398 reg.register_late_lint_pass(box explicit_write::Pass);
399 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
400 reg.register_early_lint_pass(box literal_representation::LiteralDigitGrouping);
401 reg.register_early_lint_pass(box literal_representation::LiteralRepresentation::new(
402 conf.literal_representation_threshold
404 reg.register_late_lint_pass(box use_self::UseSelf);
405 reg.register_late_lint_pass(box bytecount::ByteCount);
406 reg.register_late_lint_pass(box infinite_iter::Pass);
407 reg.register_late_lint_pass(box inline_fn_without_body::Pass);
408 reg.register_late_lint_pass(box invalid_ref::InvalidRef);
409 reg.register_late_lint_pass(box identity_conversion::IdentityConversion::default());
410 reg.register_late_lint_pass(box types::ImplicitHasher);
411 reg.register_early_lint_pass(box const_static_lifetime::StaticConst);
412 reg.register_late_lint_pass(box fallible_impl_from::FallibleImplFrom);
413 reg.register_late_lint_pass(box replace_consts::ReplaceConsts);
414 reg.register_late_lint_pass(box types::UnitArg);
415 reg.register_late_lint_pass(box double_comparison::DoubleComparisonPass);
416 reg.register_late_lint_pass(box question_mark::QuestionMarkPass);
417 reg.register_late_lint_pass(box suspicious_trait_impl::SuspiciousImpl);
418 reg.register_late_lint_pass(box redundant_field_names::RedundantFieldNames);
419 reg.register_early_lint_pass(box multiple_crate_versions::Pass);
420 reg.register_late_lint_pass(box map_unit_fn::Pass);
421 reg.register_late_lint_pass(box infallible_destructuring_match::Pass);
422 reg.register_late_lint_pass(box inherent_impl::Pass::default());
423 reg.register_late_lint_pass(box neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd);
425 reg.register_lint_group("clippy_restriction", vec![
426 arithmetic::FLOAT_ARITHMETIC,
427 arithmetic::INTEGER_ARITHMETIC,
428 array_indexing::INDEXING_SLICING,
429 assign_ops::ASSIGN_OPS,
430 else_if_without_else::ELSE_IF_WITHOUT_ELSE,
431 inherent_impl::MULTIPLE_INHERENT_IMPL,
432 literal_representation::DECIMAL_LITERAL_REPRESENTATION,
433 mem_forget::MEM_FORGET,
434 methods::CLONE_ON_REF_PTR,
435 methods::OPTION_UNWRAP_USED,
436 methods::RESULT_UNWRAP_USED,
437 methods::WRONG_PUB_SELF_CONVENTION,
438 misc::FLOAT_CMP_CONST,
439 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
440 panic_unimplemented::UNIMPLEMENTED,
441 shadow::SHADOW_REUSE,
443 shadow::SHADOW_UNRELATED,
449 reg.register_lint_group("clippy_pedantic", vec![
450 attrs::INLINE_ALWAYS,
451 copies::MATCH_SAME_ARMS,
452 derive::EXPL_IMPL_CLONE_ON_COPY,
454 empty_enum::EMPTY_ENUM,
455 enum_glob_use::ENUM_GLOB_USE,
456 enum_variants::PUB_ENUM_VARIANT_NAMES,
457 enum_variants::STUTTER,
458 if_not_else::IF_NOT_ELSE,
459 infinite_iter::MAYBE_INFINITE_ITER,
460 items_after_statements::ITEMS_AFTER_STATEMENTS,
461 matches::SINGLE_MATCH_ELSE,
463 methods::OPTION_MAP_UNWRAP_OR,
464 methods::OPTION_MAP_UNWRAP_OR_ELSE,
465 methods::RESULT_MAP_UNWRAP_OR_ELSE,
466 misc::USED_UNDERSCORE_BINDING,
467 misc_early::UNSEPARATED_LITERAL_SUFFIX,
469 needless_continue::NEEDLESS_CONTINUE,
470 non_expressive_names::SIMILAR_NAMES,
471 replace_consts::REPLACE_CONSTS,
472 strings::STRING_ADD_ASSIGN,
473 types::CAST_POSSIBLE_TRUNCATION,
474 types::CAST_POSSIBLE_WRAP,
475 types::CAST_PRECISION_LOSS,
476 types::CAST_SIGN_LOSS,
477 types::INVALID_UPCAST_COMPARISONS,
479 unicode::NON_ASCII_LITERAL,
480 unicode::UNICODE_NOT_NFC,
484 reg.register_lint_group("clippy_internal", vec![
485 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
486 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
489 reg.register_lint_group("clippy", vec![
490 approx_const::APPROX_CONSTANT,
491 array_indexing::OUT_OF_BOUNDS_INDEXING,
492 assign_ops::ASSIGN_OP_PATTERN,
493 assign_ops::MISREFACTORED_ASSIGN_OP,
494 attrs::DEPRECATED_SEMVER,
495 attrs::USELESS_ATTRIBUTE,
496 bit_mask::BAD_BIT_MASK,
497 bit_mask::INEFFECTIVE_BIT_MASK,
498 bit_mask::VERBOSE_BIT_MASK,
499 blacklisted_name::BLACKLISTED_NAME,
500 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
501 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
503 booleans::NONMINIMAL_BOOL,
504 bytecount::NAIVE_BYTECOUNT,
505 neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
506 collapsible_if::COLLAPSIBLE_IF,
507 const_static_lifetime::CONST_STATIC_LIFETIME,
508 copies::IF_SAME_THEN_ELSE,
509 copies::IFS_SAME_COND,
510 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
511 derive::DERIVE_HASH_XOR_EQ,
512 double_comparison::DOUBLE_COMPARISONS,
513 double_parens::DOUBLE_PARENS,
514 drop_forget_ref::DROP_COPY,
515 drop_forget_ref::DROP_REF,
516 drop_forget_ref::FORGET_COPY,
517 drop_forget_ref::FORGET_REF,
519 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
520 enum_variants::ENUM_VARIANT_NAMES,
521 enum_variants::MODULE_INCEPTION,
524 erasing_op::ERASING_OP,
526 eta_reduction::REDUNDANT_CLOSURE,
527 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
528 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
529 excessive_precision::EXCESSIVE_PRECISION,
530 explicit_write::EXPLICIT_WRITE,
531 format::USELESS_FORMAT,
532 formatting::POSSIBLE_MISSING_COMMA,
533 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
534 formatting::SUSPICIOUS_ELSE_FORMATTING,
535 functions::NOT_UNSAFE_PTR_ARG_DEREF,
536 functions::TOO_MANY_ARGUMENTS,
537 identity_conversion::IDENTITY_CONVERSION,
538 identity_op::IDENTITY_OP,
539 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
540 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
541 infinite_iter::INFINITE_ITER,
542 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
543 int_plus_one::INT_PLUS_ONE,
544 invalid_ref::INVALID_REF,
545 large_enum_variant::LARGE_ENUM_VARIANT,
546 len_zero::LEN_WITHOUT_IS_EMPTY,
548 let_if_seq::USELESS_LET_IF_SEQ,
549 lifetimes::EXTRA_UNUSED_LIFETIMES,
550 lifetimes::NEEDLESS_LIFETIMES,
551 literal_representation::INCONSISTENT_DIGIT_GROUPING,
552 literal_representation::LARGE_DIGIT_GROUPS,
553 literal_representation::UNREADABLE_LITERAL,
555 loops::EXPLICIT_COUNTER_LOOP,
556 loops::EXPLICIT_INTO_ITER_LOOP,
557 loops::EXPLICIT_ITER_LOOP,
559 loops::FOR_LOOP_OVER_OPTION,
560 loops::FOR_LOOP_OVER_RESULT,
561 loops::ITER_NEXT_LOOP,
562 loops::MANUAL_MEMCPY,
563 loops::MUT_RANGE_BOUND,
564 loops::NEEDLESS_RANGE_LOOP,
566 loops::REVERSE_RANGE_LOOP,
567 loops::UNUSED_COLLECT,
568 loops::WHILE_IMMUTABLE_CONDITION,
569 loops::WHILE_LET_LOOP,
570 loops::WHILE_LET_ON_ITERATOR,
571 map_clone::MAP_CLONE,
572 map_unit_fn::OPTION_MAP_UNIT_FN,
573 map_unit_fn::RESULT_MAP_UNIT_FN,
574 matches::MATCH_AS_REF,
576 matches::MATCH_OVERLAPPING_ARM,
577 matches::MATCH_REF_PATS,
578 matches::MATCH_WILD_ERR_ARM,
579 matches::SINGLE_MATCH,
580 methods::CHARS_LAST_CMP,
581 methods::CHARS_NEXT_CMP,
582 methods::CLONE_DOUBLE_REF,
583 methods::CLONE_ON_COPY,
584 methods::FILTER_NEXT,
586 methods::ITER_CLONED_COLLECT,
588 methods::ITER_SKIP_NEXT,
589 methods::NEW_RET_NO_SELF,
591 methods::OPTION_MAP_OR_NONE,
592 methods::OR_FUN_CALL,
593 methods::SEARCH_IS_SOME,
594 methods::SHOULD_IMPLEMENT_TRAIT,
595 methods::SINGLE_CHAR_PATTERN,
596 methods::STRING_EXTEND_CHARS,
597 methods::TEMPORARY_CSTRING_AS_PTR,
598 methods::UNNECESSARY_FOLD,
599 methods::USELESS_ASREF,
600 methods::WRONG_SELF_CONVENTION,
606 misc::REDUNDANT_PATTERN,
607 misc::SHORT_CIRCUIT_STATEMENT,
608 misc::TOPLEVEL_REF_ARG,
610 misc_early::BUILTIN_TYPE_SHADOW,
611 misc_early::DOUBLE_NEG,
612 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
613 misc_early::MIXED_CASE_HEX_LITERALS,
614 misc_early::REDUNDANT_CLOSURE_CALL,
615 misc_early::UNNEEDED_FIELD_PATTERN,
616 misc_early::ZERO_PREFIXED_LITERAL,
617 mut_reference::UNNECESSARY_MUT_PASSED,
618 mutex_atomic::MUTEX_ATOMIC,
619 needless_bool::BOOL_COMPARISON,
620 needless_bool::NEEDLESS_BOOL,
621 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
622 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
623 needless_update::NEEDLESS_UPDATE,
624 neg_multiply::NEG_MULTIPLY,
625 new_without_default::NEW_WITHOUT_DEFAULT,
626 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
627 no_effect::NO_EFFECT,
628 no_effect::UNNECESSARY_OPERATION,
629 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
630 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
631 ok_if_let::IF_LET_SOME_RESULT,
632 open_options::NONSENSICAL_OPEN_OPTIONS,
633 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
634 panic_unimplemented::PANIC_PARAMS,
635 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
636 precedence::PRECEDENCE,
640 question_mark::QUESTION_MARK,
641 ranges::ITERATOR_STEP_BY_ZERO,
642 ranges::RANGE_MINUS_ONE,
643 ranges::RANGE_ZIP_WITH_LEN,
644 redundant_field_names::REDUNDANT_FIELD_NAMES,
645 reference::DEREF_ADDROF,
646 reference::REF_IN_DEREF,
647 regex::INVALID_REGEX,
649 regex::TRIVIAL_REGEX,
650 returns::LET_AND_RETURN,
651 returns::NEEDLESS_RETURN,
652 serde_api::SERDE_API_MISUSE,
653 strings::STRING_LIT_AS_BYTES,
654 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
655 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
656 swap::ALMOST_SWAPPED,
658 temporary_assignment::TEMPORARY_ASSIGNMENT,
659 transmute::CROSSPOINTER_TRANSMUTE,
660 transmute::TRANSMUTE_BYTES_TO_STR,
661 transmute::TRANSMUTE_INT_TO_BOOL,
662 transmute::TRANSMUTE_INT_TO_CHAR,
663 transmute::TRANSMUTE_INT_TO_FLOAT,
664 transmute::TRANSMUTE_PTR_TO_PTR,
665 transmute::TRANSMUTE_PTR_TO_REF,
666 transmute::USELESS_TRANSMUTE,
667 transmute::WRONG_TRANSMUTE,
668 types::ABSURD_EXTREME_COMPARISONS,
671 types::CAST_LOSSLESS,
672 types::CAST_PTR_ALIGNMENT,
673 types::CHAR_LIT_AS_U8,
674 types::IMPLICIT_HASHER,
675 types::LET_UNIT_VALUE,
676 types::OPTION_OPTION,
677 types::TYPE_COMPLEXITY,
680 types::UNNECESSARY_CAST,
681 unicode::ZERO_WIDTH_SPACE,
682 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
683 unused_io_amount::UNUSED_IO_AMOUNT,
684 unused_label::UNUSED_LABEL,
686 write::PRINT_LITERAL,
687 write::PRINT_WITH_NEWLINE,
688 write::PRINTLN_EMPTY_STRING,
689 write::WRITE_LITERAL,
690 write::WRITE_WITH_NEWLINE,
691 write::WRITELN_EMPTY_STRING,
692 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
695 reg.register_lint_group("clippy_style", vec![
696 assign_ops::ASSIGN_OP_PATTERN,
697 bit_mask::VERBOSE_BIT_MASK,
698 blacklisted_name::BLACKLISTED_NAME,
699 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
700 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
701 collapsible_if::COLLAPSIBLE_IF,
702 const_static_lifetime::CONST_STATIC_LIFETIME,
703 enum_variants::ENUM_VARIANT_NAMES,
704 enum_variants::MODULE_INCEPTION,
706 eta_reduction::REDUNDANT_CLOSURE,
707 excessive_precision::EXCESSIVE_PRECISION,
708 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
709 formatting::SUSPICIOUS_ELSE_FORMATTING,
710 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
711 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
712 len_zero::LEN_WITHOUT_IS_EMPTY,
714 let_if_seq::USELESS_LET_IF_SEQ,
715 literal_representation::INCONSISTENT_DIGIT_GROUPING,
716 literal_representation::LARGE_DIGIT_GROUPS,
717 literal_representation::UNREADABLE_LITERAL,
719 loops::EXPLICIT_INTO_ITER_LOOP,
720 loops::EXPLICIT_ITER_LOOP,
722 loops::NEEDLESS_RANGE_LOOP,
723 loops::WHILE_LET_ON_ITERATOR,
724 map_clone::MAP_CLONE,
726 matches::MATCH_OVERLAPPING_ARM,
727 matches::MATCH_REF_PATS,
728 matches::MATCH_WILD_ERR_ARM,
729 matches::SINGLE_MATCH,
730 methods::CHARS_LAST_CMP,
732 methods::ITER_CLONED_COLLECT,
733 methods::ITER_SKIP_NEXT,
734 methods::NEW_RET_NO_SELF,
736 methods::OPTION_MAP_OR_NONE,
737 methods::SHOULD_IMPLEMENT_TRAIT,
738 methods::STRING_EXTEND_CHARS,
739 methods::UNNECESSARY_FOLD,
740 methods::WRONG_SELF_CONVENTION,
741 misc::REDUNDANT_PATTERN,
742 misc::TOPLEVEL_REF_ARG,
744 misc_early::BUILTIN_TYPE_SHADOW,
745 misc_early::DOUBLE_NEG,
746 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
747 misc_early::MIXED_CASE_HEX_LITERALS,
748 misc_early::UNNEEDED_FIELD_PATTERN,
749 mut_reference::UNNECESSARY_MUT_PASSED,
750 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
751 neg_multiply::NEG_MULTIPLY,
752 new_without_default::NEW_WITHOUT_DEFAULT,
753 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
754 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
755 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
756 ok_if_let::IF_LET_SOME_RESULT,
757 panic_unimplemented::PANIC_PARAMS,
760 question_mark::QUESTION_MARK,
761 ranges::RANGE_MINUS_ONE,
762 redundant_field_names::REDUNDANT_FIELD_NAMES,
764 regex::TRIVIAL_REGEX,
765 returns::LET_AND_RETURN,
766 returns::NEEDLESS_RETURN,
767 strings::STRING_LIT_AS_BYTES,
768 types::IMPLICIT_HASHER,
769 types::LET_UNIT_VALUE,
770 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
771 write::PRINT_LITERAL,
772 write::PRINT_WITH_NEWLINE,
773 write::PRINTLN_EMPTY_STRING,
774 write::WRITE_LITERAL,
775 write::WRITE_WITH_NEWLINE,
776 write::WRITELN_EMPTY_STRING,
779 reg.register_lint_group("clippy_complexity", vec![
780 assign_ops::MISREFACTORED_ASSIGN_OP,
781 booleans::NONMINIMAL_BOOL,
782 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
783 double_comparison::DOUBLE_COMPARISONS,
784 double_parens::DOUBLE_PARENS,
785 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
786 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
787 explicit_write::EXPLICIT_WRITE,
788 format::USELESS_FORMAT,
789 functions::TOO_MANY_ARGUMENTS,
790 identity_conversion::IDENTITY_CONVERSION,
791 identity_op::IDENTITY_OP,
792 int_plus_one::INT_PLUS_ONE,
793 lifetimes::EXTRA_UNUSED_LIFETIMES,
794 lifetimes::NEEDLESS_LIFETIMES,
795 loops::EXPLICIT_COUNTER_LOOP,
796 loops::MUT_RANGE_BOUND,
797 loops::WHILE_LET_LOOP,
798 map_unit_fn::OPTION_MAP_UNIT_FN,
799 map_unit_fn::RESULT_MAP_UNIT_FN,
800 matches::MATCH_AS_REF,
801 methods::CHARS_NEXT_CMP,
802 methods::CLONE_ON_COPY,
803 methods::FILTER_NEXT,
804 methods::SEARCH_IS_SOME,
805 methods::USELESS_ASREF,
806 misc::SHORT_CIRCUIT_STATEMENT,
807 misc_early::REDUNDANT_CLOSURE_CALL,
808 misc_early::ZERO_PREFIXED_LITERAL,
809 needless_bool::BOOL_COMPARISON,
810 needless_bool::NEEDLESS_BOOL,
811 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
812 needless_update::NEEDLESS_UPDATE,
813 no_effect::NO_EFFECT,
814 no_effect::UNNECESSARY_OPERATION,
815 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
816 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
817 precedence::PRECEDENCE,
818 ranges::RANGE_ZIP_WITH_LEN,
819 reference::DEREF_ADDROF,
820 reference::REF_IN_DEREF,
822 temporary_assignment::TEMPORARY_ASSIGNMENT,
823 transmute::CROSSPOINTER_TRANSMUTE,
824 transmute::TRANSMUTE_BYTES_TO_STR,
825 transmute::TRANSMUTE_INT_TO_BOOL,
826 transmute::TRANSMUTE_INT_TO_CHAR,
827 transmute::TRANSMUTE_INT_TO_FLOAT,
828 transmute::TRANSMUTE_PTR_TO_PTR,
829 transmute::TRANSMUTE_PTR_TO_REF,
830 transmute::USELESS_TRANSMUTE,
832 types::CAST_LOSSLESS,
833 types::CHAR_LIT_AS_U8,
834 types::OPTION_OPTION,
835 types::TYPE_COMPLEXITY,
837 types::UNNECESSARY_CAST,
838 unused_label::UNUSED_LABEL,
839 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
842 reg.register_lint_group("clippy_correctness", vec![
843 approx_const::APPROX_CONSTANT,
844 array_indexing::OUT_OF_BOUNDS_INDEXING,
845 attrs::DEPRECATED_SEMVER,
846 attrs::USELESS_ATTRIBUTE,
847 bit_mask::BAD_BIT_MASK,
848 bit_mask::INEFFECTIVE_BIT_MASK,
850 copies::IF_SAME_THEN_ELSE,
851 copies::IFS_SAME_COND,
852 derive::DERIVE_HASH_XOR_EQ,
853 drop_forget_ref::DROP_COPY,
854 drop_forget_ref::DROP_REF,
855 drop_forget_ref::FORGET_COPY,
856 drop_forget_ref::FORGET_REF,
857 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
859 erasing_op::ERASING_OP,
860 formatting::POSSIBLE_MISSING_COMMA,
861 functions::NOT_UNSAFE_PTR_ARG_DEREF,
862 infinite_iter::INFINITE_ITER,
863 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
864 invalid_ref::INVALID_REF,
865 loops::FOR_LOOP_OVER_OPTION,
866 loops::FOR_LOOP_OVER_RESULT,
867 loops::ITER_NEXT_LOOP,
869 loops::REVERSE_RANGE_LOOP,
870 loops::WHILE_IMMUTABLE_CONDITION,
871 methods::CLONE_DOUBLE_REF,
872 methods::TEMPORARY_CSTRING_AS_PTR,
877 open_options::NONSENSICAL_OPEN_OPTIONS,
879 ranges::ITERATOR_STEP_BY_ZERO,
880 regex::INVALID_REGEX,
881 serde_api::SERDE_API_MISUSE,
882 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
883 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
884 swap::ALMOST_SWAPPED,
885 transmute::WRONG_TRANSMUTE,
886 types::ABSURD_EXTREME_COMPARISONS,
887 types::CAST_PTR_ALIGNMENT,
889 unicode::ZERO_WIDTH_SPACE,
890 unused_io_amount::UNUSED_IO_AMOUNT,
893 reg.register_lint_group("clippy_perf", vec![
894 bytecount::NAIVE_BYTECOUNT,
897 large_enum_variant::LARGE_ENUM_VARIANT,
898 loops::MANUAL_MEMCPY,
899 loops::UNUSED_COLLECT,
901 methods::OR_FUN_CALL,
902 methods::SINGLE_CHAR_PATTERN,
904 mutex_atomic::MUTEX_ATOMIC,
909 reg.register_lint_group("clippy_cargo", vec![
910 multiple_crate_versions::MULTIPLE_CRATE_VERSIONS,
913 reg.register_lint_group("clippy_nursery", vec![
914 attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
915 fallible_impl_from::FALLIBLE_IMPL_FROM,
916 mutex_atomic::MUTEX_INTEGER,
917 needless_borrow::NEEDLESS_BORROW,
918 ranges::RANGE_PLUS_ONE,
922 // only exists to let the dogfood integration test works.
923 // Don't run clippy as an executable directly
924 #[allow(dead_code, print_stdout)]
926 panic!("Please use the cargo-clippy executable");