1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(rustc_private)]
5 #![feature(slice_patterns)]
6 #![feature(stmt_expr_attributes)]
7 #![feature(range_contains)]
8 #![feature(macro_vis_matcher)]
9 #![allow(unknown_lints, indexing_slicing, shadow_reuse, missing_docs_in_private_items)]
10 #![recursion_limit = "256"]
11 #![allow(stable_features)]
12 #![feature(iterator_find_map)]
13 #![feature(macro_at_most_once_rep)]
14 #![feature(rust_2018_preview)]
16 extern crate cargo_metadata;
19 extern crate rustc_target;
20 extern crate rustc_typeck;
22 extern crate syntax_pos;
26 // for unicode nfc normalization
28 extern crate unicode_normalization;
30 // for semver check in attrs.rs
36 extern crate regex_syntax;
38 // for finding minimal boolean expressions
40 extern crate quine_mc_cluskey;
42 extern crate rustc_errors;
43 extern crate rustc_plugin;
46 extern crate matches as matches_macro;
50 extern crate serde_derive;
53 extern crate lazy_static;
55 extern crate itertools;
56 extern crate pulldown_cmark;
60 extern crate if_chain;
62 macro_rules! declare_clippy_lint {
63 { pub $name:tt, style, $description:tt } => {
64 declare_lint! { pub $name, Warn, $description }
66 { pub $name:tt, correctness, $description:tt } => {
67 declare_lint! { pub $name, Deny, $description }
69 { pub $name:tt, complexity, $description:tt } => {
70 declare_lint! { pub $name, Warn, $description }
72 { pub $name:tt, perf, $description:tt } => {
73 declare_lint! { pub $name, Warn, $description }
75 { pub $name:tt, pedantic, $description:tt } => {
76 declare_lint! { pub $name, Allow, $description }
78 { pub $name:tt, restriction, $description:tt } => {
79 declare_lint! { pub $name, Allow, $description }
81 { pub $name:tt, cargo, $description:tt } => {
82 declare_lint! { pub $name, Allow, $description }
84 { pub $name:tt, nursery, $description:tt } => {
85 declare_lint! { pub $name, Allow, $description }
87 { pub $name:tt, internal, $description:tt } => {
88 declare_lint! { pub $name, Allow, $description }
90 { pub $name:tt, internal_warn, $description:tt } => {
91 declare_lint! { pub $name, Warn, $description }
99 // begin lints modules, do not remove this comment, it’s used in `update_lints`
100 pub mod approx_const;
102 pub mod array_indexing;
106 pub mod blacklisted_name;
107 pub mod block_in_if_condition;
110 pub mod collapsible_if;
111 pub mod const_static_lifetime;
113 pub mod cyclomatic_complexity;
114 pub mod default_trait_access;
117 pub mod double_comparison;
118 pub mod double_parens;
119 pub mod drop_forget_ref;
120 pub mod duration_subsec;
121 pub mod else_if_without_else;
125 pub mod enum_glob_use;
126 pub mod enum_variants;
130 pub mod eta_reduction;
131 pub mod eval_order_dependence;
132 pub mod excessive_precision;
133 pub mod explicit_write;
134 pub mod fallible_impl_from;
138 pub mod identity_conversion;
140 pub mod if_let_redundant_pattern_matching;
142 pub mod infallible_destructuring_match;
143 pub mod infinite_iter;
144 pub mod inherent_impl;
145 pub mod inline_fn_without_body;
146 pub mod int_plus_one;
148 pub mod items_after_statements;
149 pub mod large_enum_variant;
153 pub mod literal_representation;
164 pub mod multiple_crate_versions;
166 pub mod mut_reference;
167 pub mod mutex_atomic;
168 pub mod needless_bool;
169 pub mod needless_borrow;
170 pub mod needless_borrowed_ref;
171 pub mod needless_continue;
172 pub mod needless_pass_by_value;
173 pub mod needless_update;
174 pub mod neg_cmp_op_on_partial_ord;
175 pub mod neg_multiply;
176 pub mod new_without_default;
178 pub mod non_expressive_names;
180 pub mod open_options;
181 pub mod overflow_check_conditional;
182 pub mod panic_unimplemented;
183 pub mod partialeq_ne_impl;
186 pub mod question_mark;
188 pub mod redundant_field_names;
191 pub mod replace_consts;
196 pub mod suspicious_trait_impl;
198 pub mod temporary_assignment;
202 pub mod unsafe_removed_from_name;
203 pub mod unused_io_amount;
204 pub mod unused_label;
209 pub mod zero_div_zero;
210 // end lints modules, do not remove this comment, it’s used in `update_lints`
213 pub use syntax::ast::{Name, NodeId};
216 #[cfg_attr(rustfmt, rustfmt_skip)]
217 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
218 let conf = match utils::conf::file_from_args(reg.args()) {
220 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
221 // do not require the file to exist
222 let file_name = if let Some(file_name) = file_name {
225 match utils::conf::lookup_conf_file() {
228 reg.sess.struct_err(&format!("error finding Clippy's configuration file: {}", error)).emit();
234 let file_name = file_name.map(|file_name| if file_name.is_relative() {
236 .local_crate_source_file
238 .and_then(|file| std::path::Path::new(&file).parent().map(std::path::Path::to_path_buf))
245 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
247 // all conf errors are non-fatal, we just use the default conf in case of error
248 for error in errors {
249 reg.sess.struct_err(&format!("error reading Clippy's configuration file `{}`: {}", file_name.as_ref().and_then(|p| p.to_str()).unwrap_or(""), error)).emit();
254 Err((err, span)) => {
255 reg.sess.struct_span_err(span, err)
256 .span_note(span, "Clippy will use default configuration")
258 toml::from_str("").expect("we never error on empty config files")
262 let mut store = reg.sess.lint_store.borrow_mut();
263 store.register_removed(
265 "`assert!()` will be more flexible with RFC 2011",
267 store.register_removed(
269 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
271 store.register_removed(
272 "range_step_by_zero",
273 "`iterator.step_by(0)` panics nowadays",
275 store.register_removed(
277 "`Vec::as_slice` has been stabilized in 1.7",
279 store.register_removed(
280 "unstable_as_mut_slice",
281 "`Vec::as_mut_slice` has been stabilized in 1.7",
283 store.register_removed(
285 "using `str::to_string` is common even today and specialization will likely happen soon",
287 store.register_removed(
289 "using `string::to_string` is common even today and specialization will likely happen soon",
291 store.register_removed(
292 "misaligned_transmute",
293 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
295 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
297 reg.register_late_lint_pass(box serde_api::Serde);
298 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
299 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
300 reg.register_late_lint_pass(box utils::inspector::Pass);
301 reg.register_late_lint_pass(box utils::author::Pass);
302 reg.register_late_lint_pass(box types::TypePass);
303 reg.register_late_lint_pass(box booleans::NonminimalBool);
304 reg.register_late_lint_pass(box eq_op::EqOp);
305 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
306 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
307 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
308 reg.register_late_lint_pass(box excessive_precision::ExcessivePrecision);
309 reg.register_late_lint_pass(box bit_mask::BitMask::new(conf.verbose_bit_mask_threshold));
310 reg.register_late_lint_pass(box ptr::PointerPass);
311 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
312 reg.register_late_lint_pass(box needless_bool::BoolComparison);
313 reg.register_late_lint_pass(box approx_const::Pass);
314 reg.register_late_lint_pass(box misc::Pass);
315 reg.register_early_lint_pass(box precedence::Precedence);
316 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
317 reg.register_late_lint_pass(box eta_reduction::EtaPass);
318 reg.register_late_lint_pass(box identity_op::IdentityOp);
319 reg.register_late_lint_pass(box erasing_op::ErasingOp);
320 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
321 reg.register_late_lint_pass(box mut_mut::MutMut);
322 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
323 reg.register_late_lint_pass(box len_zero::LenZero);
324 reg.register_late_lint_pass(box attrs::AttrPass);
325 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
326 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
327 reg.register_late_lint_pass(box unicode::Unicode);
328 reg.register_late_lint_pass(box strings::StringAdd);
329 reg.register_early_lint_pass(box returns::ReturnPass);
330 reg.register_late_lint_pass(box methods::Pass);
331 reg.register_late_lint_pass(box shadow::Pass);
332 reg.register_late_lint_pass(box types::LetPass);
333 reg.register_late_lint_pass(box types::UnitCmp);
334 reg.register_late_lint_pass(box loops::Pass);
335 reg.register_late_lint_pass(box lifetimes::LifetimePass);
336 reg.register_late_lint_pass(box entry::HashMapLint);
337 reg.register_late_lint_pass(box ranges::Pass);
338 reg.register_late_lint_pass(box types::CastPass);
339 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
340 reg.register_late_lint_pass(box matches::MatchPass);
341 reg.register_late_lint_pass(box minmax::MinMaxPass);
342 reg.register_late_lint_pass(box open_options::NonSensical);
343 reg.register_late_lint_pass(box zero_div_zero::Pass);
344 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
345 reg.register_late_lint_pass(box needless_update::Pass);
346 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
347 reg.register_late_lint_pass(box needless_borrowed_ref::NeedlessBorrowedRef);
348 reg.register_late_lint_pass(box no_effect::Pass);
349 reg.register_late_lint_pass(box map_clone::Pass);
350 reg.register_late_lint_pass(box temporary_assignment::Pass);
351 reg.register_late_lint_pass(box transmute::Transmute);
352 reg.register_late_lint_pass(
353 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
355 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
356 reg.register_early_lint_pass(box misc_early::MiscEarly);
357 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
358 reg.register_late_lint_pass(box panic_unimplemented::Pass);
359 reg.register_late_lint_pass(box strings::StringLitAsBytes);
360 reg.register_late_lint_pass(box derive::Derive);
361 reg.register_late_lint_pass(box types::CharLitAsU8);
362 reg.register_late_lint_pass(box write::Pass);
363 reg.register_late_lint_pass(box vec::Pass);
364 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
365 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
367 reg.register_late_lint_pass(box drop_forget_ref::Pass);
368 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
369 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
370 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
371 reg.register_late_lint_pass(box regex::Pass::default());
372 reg.register_late_lint_pass(box copies::CopyAndPaste);
373 reg.register_late_lint_pass(box format::Pass);
374 reg.register_early_lint_pass(box formatting::Formatting);
375 reg.register_late_lint_pass(box swap::Swap);
376 reg.register_early_lint_pass(box if_not_else::IfNotElse);
377 reg.register_early_lint_pass(box else_if_without_else::ElseIfWithoutElse);
378 reg.register_early_lint_pass(box int_plus_one::IntPlusOne);
379 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
380 reg.register_late_lint_pass(box unused_label::UnusedLabel);
381 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
382 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
383 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
384 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
385 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
386 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
387 reg.register_late_lint_pass(box mem_forget::MemForget);
388 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
389 reg.register_late_lint_pass(box assign_ops::AssignOps);
390 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
391 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
392 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
393 reg.register_late_lint_pass(box ok_if_let::Pass);
394 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
395 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
396 reg.register_early_lint_pass(box reference::Pass);
397 reg.register_early_lint_pass(box reference::DerefPass);
398 reg.register_early_lint_pass(box double_parens::DoubleParens);
399 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
400 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
401 reg.register_late_lint_pass(box explicit_write::Pass);
402 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
403 reg.register_early_lint_pass(box literal_representation::LiteralDigitGrouping);
404 reg.register_early_lint_pass(box literal_representation::LiteralRepresentation::new(
405 conf.literal_representation_threshold
407 reg.register_late_lint_pass(box use_self::UseSelf);
408 reg.register_late_lint_pass(box bytecount::ByteCount);
409 reg.register_late_lint_pass(box infinite_iter::Pass);
410 reg.register_late_lint_pass(box inline_fn_without_body::Pass);
411 reg.register_late_lint_pass(box invalid_ref::InvalidRef);
412 reg.register_late_lint_pass(box identity_conversion::IdentityConversion::default());
413 reg.register_late_lint_pass(box types::ImplicitHasher);
414 reg.register_early_lint_pass(box const_static_lifetime::StaticConst);
415 reg.register_late_lint_pass(box fallible_impl_from::FallibleImplFrom);
416 reg.register_late_lint_pass(box replace_consts::ReplaceConsts);
417 reg.register_late_lint_pass(box types::UnitArg);
418 reg.register_late_lint_pass(box double_comparison::DoubleComparisonPass);
419 reg.register_late_lint_pass(box question_mark::QuestionMarkPass);
420 reg.register_late_lint_pass(box suspicious_trait_impl::SuspiciousImpl);
421 reg.register_late_lint_pass(box redundant_field_names::RedundantFieldNames);
422 reg.register_early_lint_pass(box multiple_crate_versions::Pass);
423 reg.register_late_lint_pass(box map_unit_fn::Pass);
424 reg.register_late_lint_pass(box infallible_destructuring_match::Pass);
425 reg.register_late_lint_pass(box inherent_impl::Pass::default());
426 reg.register_late_lint_pass(box neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd);
427 reg.register_late_lint_pass(box unwrap::Pass);
428 reg.register_late_lint_pass(box duration_subsec::DurationSubsec);
429 reg.register_late_lint_pass(box default_trait_access::DefaultTraitAccess);
432 reg.register_lint_group("clippy_restriction", vec![
433 arithmetic::FLOAT_ARITHMETIC,
434 arithmetic::INTEGER_ARITHMETIC,
435 array_indexing::INDEXING_SLICING,
436 assign_ops::ASSIGN_OPS,
437 else_if_without_else::ELSE_IF_WITHOUT_ELSE,
438 inherent_impl::MULTIPLE_INHERENT_IMPL,
439 literal_representation::DECIMAL_LITERAL_REPRESENTATION,
440 mem_forget::MEM_FORGET,
441 methods::CLONE_ON_REF_PTR,
442 methods::OPTION_UNWRAP_USED,
443 methods::RESULT_UNWRAP_USED,
444 methods::WRONG_PUB_SELF_CONVENTION,
445 misc::FLOAT_CMP_CONST,
446 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
447 panic_unimplemented::UNIMPLEMENTED,
448 shadow::SHADOW_REUSE,
450 shadow::SHADOW_UNRELATED,
456 reg.register_lint_group("clippy_pedantic", vec![
457 attrs::INLINE_ALWAYS,
458 copies::MATCH_SAME_ARMS,
459 derive::EXPL_IMPL_CLONE_ON_COPY,
461 empty_enum::EMPTY_ENUM,
462 enum_glob_use::ENUM_GLOB_USE,
463 enum_variants::PUB_ENUM_VARIANT_NAMES,
464 enum_variants::STUTTER,
465 if_not_else::IF_NOT_ELSE,
466 infinite_iter::MAYBE_INFINITE_ITER,
467 items_after_statements::ITEMS_AFTER_STATEMENTS,
468 matches::SINGLE_MATCH_ELSE,
470 methods::OPTION_MAP_UNWRAP_OR,
471 methods::OPTION_MAP_UNWRAP_OR_ELSE,
472 methods::RESULT_MAP_UNWRAP_OR_ELSE,
473 misc::USED_UNDERSCORE_BINDING,
474 misc_early::UNSEPARATED_LITERAL_SUFFIX,
476 needless_continue::NEEDLESS_CONTINUE,
477 non_expressive_names::SIMILAR_NAMES,
478 replace_consts::REPLACE_CONSTS,
479 strings::STRING_ADD_ASSIGN,
480 types::CAST_POSSIBLE_TRUNCATION,
481 types::CAST_POSSIBLE_WRAP,
482 types::CAST_PRECISION_LOSS,
483 types::CAST_SIGN_LOSS,
484 types::INVALID_UPCAST_COMPARISONS,
486 unicode::NON_ASCII_LITERAL,
487 unicode::UNICODE_NOT_NFC,
491 reg.register_lint_group("clippy_internal", vec![
492 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
493 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
496 reg.register_lint_group("clippy", vec![
497 approx_const::APPROX_CONSTANT,
498 array_indexing::OUT_OF_BOUNDS_INDEXING,
499 assign_ops::ASSIGN_OP_PATTERN,
500 assign_ops::MISREFACTORED_ASSIGN_OP,
501 attrs::DEPRECATED_SEMVER,
502 attrs::USELESS_ATTRIBUTE,
503 bit_mask::BAD_BIT_MASK,
504 bit_mask::INEFFECTIVE_BIT_MASK,
505 bit_mask::VERBOSE_BIT_MASK,
506 blacklisted_name::BLACKLISTED_NAME,
507 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
508 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
510 booleans::NONMINIMAL_BOOL,
511 bytecount::NAIVE_BYTECOUNT,
512 collapsible_if::COLLAPSIBLE_IF,
513 const_static_lifetime::CONST_STATIC_LIFETIME,
514 copies::IF_SAME_THEN_ELSE,
515 copies::IFS_SAME_COND,
516 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
517 default_trait_access::DEFAULT_TRAIT_ACCESS,
518 derive::DERIVE_HASH_XOR_EQ,
519 double_comparison::DOUBLE_COMPARISONS,
520 double_parens::DOUBLE_PARENS,
521 drop_forget_ref::DROP_COPY,
522 drop_forget_ref::DROP_REF,
523 drop_forget_ref::FORGET_COPY,
524 drop_forget_ref::FORGET_REF,
525 duration_subsec::DURATION_SUBSEC,
527 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
528 enum_variants::ENUM_VARIANT_NAMES,
529 enum_variants::MODULE_INCEPTION,
532 erasing_op::ERASING_OP,
534 eta_reduction::REDUNDANT_CLOSURE,
535 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
536 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
537 excessive_precision::EXCESSIVE_PRECISION,
538 explicit_write::EXPLICIT_WRITE,
539 format::USELESS_FORMAT,
540 formatting::POSSIBLE_MISSING_COMMA,
541 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
542 formatting::SUSPICIOUS_ELSE_FORMATTING,
543 functions::NOT_UNSAFE_PTR_ARG_DEREF,
544 functions::TOO_MANY_ARGUMENTS,
545 identity_conversion::IDENTITY_CONVERSION,
546 identity_op::IDENTITY_OP,
547 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
548 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
549 infinite_iter::INFINITE_ITER,
550 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
551 int_plus_one::INT_PLUS_ONE,
552 invalid_ref::INVALID_REF,
553 large_enum_variant::LARGE_ENUM_VARIANT,
554 len_zero::LEN_WITHOUT_IS_EMPTY,
556 let_if_seq::USELESS_LET_IF_SEQ,
557 lifetimes::EXTRA_UNUSED_LIFETIMES,
558 lifetimes::NEEDLESS_LIFETIMES,
559 literal_representation::INCONSISTENT_DIGIT_GROUPING,
560 literal_representation::LARGE_DIGIT_GROUPS,
561 literal_representation::UNREADABLE_LITERAL,
563 loops::EXPLICIT_COUNTER_LOOP,
564 loops::EXPLICIT_INTO_ITER_LOOP,
565 loops::EXPLICIT_ITER_LOOP,
567 loops::FOR_LOOP_OVER_OPTION,
568 loops::FOR_LOOP_OVER_RESULT,
569 loops::ITER_NEXT_LOOP,
570 loops::MANUAL_MEMCPY,
571 loops::MUT_RANGE_BOUND,
572 loops::NEEDLESS_RANGE_LOOP,
574 loops::REVERSE_RANGE_LOOP,
575 loops::UNUSED_COLLECT,
576 loops::WHILE_IMMUTABLE_CONDITION,
577 loops::WHILE_LET_LOOP,
578 loops::WHILE_LET_ON_ITERATOR,
579 map_clone::MAP_CLONE,
580 map_unit_fn::OPTION_MAP_UNIT_FN,
581 map_unit_fn::RESULT_MAP_UNIT_FN,
582 matches::MATCH_AS_REF,
584 matches::MATCH_OVERLAPPING_ARM,
585 matches::MATCH_REF_PATS,
586 matches::MATCH_WILD_ERR_ARM,
587 matches::SINGLE_MATCH,
588 methods::CHARS_LAST_CMP,
589 methods::CHARS_NEXT_CMP,
590 methods::CLONE_DOUBLE_REF,
591 methods::CLONE_ON_COPY,
592 methods::FILTER_NEXT,
594 methods::ITER_CLONED_COLLECT,
596 methods::ITER_SKIP_NEXT,
597 methods::NEW_RET_NO_SELF,
599 methods::OPTION_MAP_OR_NONE,
600 methods::OR_FUN_CALL,
601 methods::EXPECT_FUN_CALL,
602 methods::SEARCH_IS_SOME,
603 methods::SHOULD_IMPLEMENT_TRAIT,
604 methods::SINGLE_CHAR_PATTERN,
605 methods::STRING_EXTEND_CHARS,
606 methods::TEMPORARY_CSTRING_AS_PTR,
607 methods::UNNECESSARY_FOLD,
608 methods::USELESS_ASREF,
609 methods::WRONG_SELF_CONVENTION,
615 misc::REDUNDANT_PATTERN,
616 misc::SHORT_CIRCUIT_STATEMENT,
617 misc::TOPLEVEL_REF_ARG,
619 misc_early::BUILTIN_TYPE_SHADOW,
620 misc_early::DOUBLE_NEG,
621 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
622 misc_early::MIXED_CASE_HEX_LITERALS,
623 misc_early::REDUNDANT_CLOSURE_CALL,
624 misc_early::UNNEEDED_FIELD_PATTERN,
625 misc_early::ZERO_PREFIXED_LITERAL,
626 mut_reference::UNNECESSARY_MUT_PASSED,
627 mutex_atomic::MUTEX_ATOMIC,
628 needless_bool::BOOL_COMPARISON,
629 needless_bool::NEEDLESS_BOOL,
630 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
631 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
632 needless_update::NEEDLESS_UPDATE,
633 neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
634 neg_multiply::NEG_MULTIPLY,
635 new_without_default::NEW_WITHOUT_DEFAULT,
636 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
637 no_effect::NO_EFFECT,
638 no_effect::UNNECESSARY_OPERATION,
639 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
640 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
641 ok_if_let::IF_LET_SOME_RESULT,
642 open_options::NONSENSICAL_OPEN_OPTIONS,
643 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
644 panic_unimplemented::PANIC_PARAMS,
645 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
646 precedence::PRECEDENCE,
650 question_mark::QUESTION_MARK,
651 ranges::ITERATOR_STEP_BY_ZERO,
652 ranges::RANGE_MINUS_ONE,
653 ranges::RANGE_ZIP_WITH_LEN,
654 redundant_field_names::REDUNDANT_FIELD_NAMES,
655 reference::DEREF_ADDROF,
656 reference::REF_IN_DEREF,
657 regex::INVALID_REGEX,
659 regex::TRIVIAL_REGEX,
660 returns::LET_AND_RETURN,
661 returns::NEEDLESS_RETURN,
662 serde_api::SERDE_API_MISUSE,
663 strings::STRING_LIT_AS_BYTES,
664 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
665 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
666 swap::ALMOST_SWAPPED,
668 temporary_assignment::TEMPORARY_ASSIGNMENT,
669 transmute::CROSSPOINTER_TRANSMUTE,
670 transmute::TRANSMUTE_BYTES_TO_STR,
671 transmute::TRANSMUTE_INT_TO_BOOL,
672 transmute::TRANSMUTE_INT_TO_CHAR,
673 transmute::TRANSMUTE_INT_TO_FLOAT,
674 transmute::TRANSMUTE_PTR_TO_PTR,
675 transmute::TRANSMUTE_PTR_TO_REF,
676 transmute::USELESS_TRANSMUTE,
677 transmute::WRONG_TRANSMUTE,
678 types::ABSURD_EXTREME_COMPARISONS,
681 types::CAST_LOSSLESS,
682 types::CAST_PTR_ALIGNMENT,
683 types::CHAR_LIT_AS_U8,
684 types::FN_TO_NUMERIC_CAST,
685 types::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
686 types::IMPLICIT_HASHER,
687 types::LET_UNIT_VALUE,
688 types::OPTION_OPTION,
689 types::TYPE_COMPLEXITY,
692 types::UNNECESSARY_CAST,
693 unicode::ZERO_WIDTH_SPACE,
694 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
695 unused_io_amount::UNUSED_IO_AMOUNT,
696 unused_label::UNUSED_LABEL,
698 write::PRINT_LITERAL,
699 write::PRINT_WITH_NEWLINE,
700 write::PRINTLN_EMPTY_STRING,
701 write::WRITE_LITERAL,
702 write::WRITE_WITH_NEWLINE,
703 write::WRITELN_EMPTY_STRING,
704 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
707 reg.register_lint_group("clippy_style", vec![
708 assign_ops::ASSIGN_OP_PATTERN,
709 bit_mask::VERBOSE_BIT_MASK,
710 blacklisted_name::BLACKLISTED_NAME,
711 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
712 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
713 collapsible_if::COLLAPSIBLE_IF,
714 const_static_lifetime::CONST_STATIC_LIFETIME,
715 default_trait_access::DEFAULT_TRAIT_ACCESS,
716 enum_variants::ENUM_VARIANT_NAMES,
717 enum_variants::MODULE_INCEPTION,
719 eta_reduction::REDUNDANT_CLOSURE,
720 excessive_precision::EXCESSIVE_PRECISION,
721 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
722 formatting::SUSPICIOUS_ELSE_FORMATTING,
723 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
724 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
725 len_zero::LEN_WITHOUT_IS_EMPTY,
727 let_if_seq::USELESS_LET_IF_SEQ,
728 literal_representation::INCONSISTENT_DIGIT_GROUPING,
729 literal_representation::LARGE_DIGIT_GROUPS,
730 literal_representation::UNREADABLE_LITERAL,
732 loops::EXPLICIT_INTO_ITER_LOOP,
733 loops::EXPLICIT_ITER_LOOP,
735 loops::NEEDLESS_RANGE_LOOP,
736 loops::WHILE_LET_ON_ITERATOR,
737 map_clone::MAP_CLONE,
739 matches::MATCH_OVERLAPPING_ARM,
740 matches::MATCH_REF_PATS,
741 matches::MATCH_WILD_ERR_ARM,
742 matches::SINGLE_MATCH,
743 methods::CHARS_LAST_CMP,
745 methods::ITER_CLONED_COLLECT,
746 methods::ITER_SKIP_NEXT,
747 methods::NEW_RET_NO_SELF,
749 methods::OPTION_MAP_OR_NONE,
750 methods::SHOULD_IMPLEMENT_TRAIT,
751 methods::STRING_EXTEND_CHARS,
752 methods::UNNECESSARY_FOLD,
753 methods::WRONG_SELF_CONVENTION,
754 misc::REDUNDANT_PATTERN,
755 misc::TOPLEVEL_REF_ARG,
757 misc_early::BUILTIN_TYPE_SHADOW,
758 misc_early::DOUBLE_NEG,
759 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
760 misc_early::MIXED_CASE_HEX_LITERALS,
761 misc_early::UNNEEDED_FIELD_PATTERN,
762 mut_reference::UNNECESSARY_MUT_PASSED,
763 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
764 neg_multiply::NEG_MULTIPLY,
765 new_without_default::NEW_WITHOUT_DEFAULT,
766 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
767 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
768 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
769 ok_if_let::IF_LET_SOME_RESULT,
770 panic_unimplemented::PANIC_PARAMS,
773 question_mark::QUESTION_MARK,
774 ranges::RANGE_MINUS_ONE,
775 redundant_field_names::REDUNDANT_FIELD_NAMES,
777 regex::TRIVIAL_REGEX,
778 returns::LET_AND_RETURN,
779 returns::NEEDLESS_RETURN,
780 strings::STRING_LIT_AS_BYTES,
781 types::FN_TO_NUMERIC_CAST,
782 types::IMPLICIT_HASHER,
783 types::LET_UNIT_VALUE,
784 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
785 write::PRINT_LITERAL,
786 write::PRINT_WITH_NEWLINE,
787 write::PRINTLN_EMPTY_STRING,
788 write::WRITE_LITERAL,
789 write::WRITE_WITH_NEWLINE,
790 write::WRITELN_EMPTY_STRING,
793 reg.register_lint_group("clippy_complexity", vec![
794 assign_ops::MISREFACTORED_ASSIGN_OP,
795 booleans::NONMINIMAL_BOOL,
796 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
797 double_comparison::DOUBLE_COMPARISONS,
798 double_parens::DOUBLE_PARENS,
799 duration_subsec::DURATION_SUBSEC,
800 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
801 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
802 explicit_write::EXPLICIT_WRITE,
803 format::USELESS_FORMAT,
804 functions::TOO_MANY_ARGUMENTS,
805 identity_conversion::IDENTITY_CONVERSION,
806 identity_op::IDENTITY_OP,
807 int_plus_one::INT_PLUS_ONE,
808 lifetimes::EXTRA_UNUSED_LIFETIMES,
809 lifetimes::NEEDLESS_LIFETIMES,
810 loops::EXPLICIT_COUNTER_LOOP,
811 loops::MUT_RANGE_BOUND,
812 loops::WHILE_LET_LOOP,
813 map_unit_fn::OPTION_MAP_UNIT_FN,
814 map_unit_fn::RESULT_MAP_UNIT_FN,
815 matches::MATCH_AS_REF,
816 methods::CHARS_NEXT_CMP,
817 methods::CLONE_ON_COPY,
818 methods::FILTER_NEXT,
819 methods::SEARCH_IS_SOME,
820 methods::USELESS_ASREF,
821 misc::SHORT_CIRCUIT_STATEMENT,
822 misc_early::REDUNDANT_CLOSURE_CALL,
823 misc_early::ZERO_PREFIXED_LITERAL,
824 needless_bool::BOOL_COMPARISON,
825 needless_bool::NEEDLESS_BOOL,
826 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
827 needless_update::NEEDLESS_UPDATE,
828 neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
829 no_effect::NO_EFFECT,
830 no_effect::UNNECESSARY_OPERATION,
831 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
832 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
833 precedence::PRECEDENCE,
834 ranges::RANGE_ZIP_WITH_LEN,
835 reference::DEREF_ADDROF,
836 reference::REF_IN_DEREF,
838 temporary_assignment::TEMPORARY_ASSIGNMENT,
839 transmute::CROSSPOINTER_TRANSMUTE,
840 transmute::TRANSMUTE_BYTES_TO_STR,
841 transmute::TRANSMUTE_INT_TO_BOOL,
842 transmute::TRANSMUTE_INT_TO_CHAR,
843 transmute::TRANSMUTE_INT_TO_FLOAT,
844 transmute::TRANSMUTE_PTR_TO_PTR,
845 transmute::TRANSMUTE_PTR_TO_REF,
846 transmute::USELESS_TRANSMUTE,
848 types::CAST_LOSSLESS,
849 types::CHAR_LIT_AS_U8,
850 types::OPTION_OPTION,
851 types::TYPE_COMPLEXITY,
853 types::UNNECESSARY_CAST,
854 unused_label::UNUSED_LABEL,
855 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
858 reg.register_lint_group("clippy_correctness", vec![
859 approx_const::APPROX_CONSTANT,
860 array_indexing::OUT_OF_BOUNDS_INDEXING,
861 attrs::DEPRECATED_SEMVER,
862 attrs::USELESS_ATTRIBUTE,
863 bit_mask::BAD_BIT_MASK,
864 bit_mask::INEFFECTIVE_BIT_MASK,
866 copies::IF_SAME_THEN_ELSE,
867 copies::IFS_SAME_COND,
868 derive::DERIVE_HASH_XOR_EQ,
869 drop_forget_ref::DROP_COPY,
870 drop_forget_ref::DROP_REF,
871 drop_forget_ref::FORGET_COPY,
872 drop_forget_ref::FORGET_REF,
873 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
875 erasing_op::ERASING_OP,
876 formatting::POSSIBLE_MISSING_COMMA,
877 functions::NOT_UNSAFE_PTR_ARG_DEREF,
878 infinite_iter::INFINITE_ITER,
879 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
880 invalid_ref::INVALID_REF,
881 loops::FOR_LOOP_OVER_OPTION,
882 loops::FOR_LOOP_OVER_RESULT,
883 loops::ITER_NEXT_LOOP,
885 loops::REVERSE_RANGE_LOOP,
886 loops::WHILE_IMMUTABLE_CONDITION,
887 methods::CLONE_DOUBLE_REF,
888 methods::TEMPORARY_CSTRING_AS_PTR,
893 open_options::NONSENSICAL_OPEN_OPTIONS,
895 ranges::ITERATOR_STEP_BY_ZERO,
896 regex::INVALID_REGEX,
897 serde_api::SERDE_API_MISUSE,
898 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
899 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
900 swap::ALMOST_SWAPPED,
901 transmute::WRONG_TRANSMUTE,
902 types::ABSURD_EXTREME_COMPARISONS,
903 types::CAST_PTR_ALIGNMENT,
904 types::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
906 unicode::ZERO_WIDTH_SPACE,
907 unused_io_amount::UNUSED_IO_AMOUNT,
910 reg.register_lint_group("clippy_perf", vec![
911 bytecount::NAIVE_BYTECOUNT,
914 large_enum_variant::LARGE_ENUM_VARIANT,
915 loops::MANUAL_MEMCPY,
916 loops::UNUSED_COLLECT,
918 methods::OR_FUN_CALL,
919 methods::EXPECT_FUN_CALL,
920 methods::SINGLE_CHAR_PATTERN,
922 mutex_atomic::MUTEX_ATOMIC,
927 reg.register_lint_group("clippy_cargo", vec![
928 multiple_crate_versions::MULTIPLE_CRATE_VERSIONS,
931 reg.register_lint_group("clippy_nursery", vec![
932 attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
933 fallible_impl_from::FALLIBLE_IMPL_FROM,
934 mutex_atomic::MUTEX_INTEGER,
935 needless_borrow::NEEDLESS_BORROW,
936 ranges::RANGE_PLUS_ONE,
937 unwrap::UNNECESSARY_UNWRAP,
941 // only exists to let the dogfood integration test works.
942 // Don't run clippy as an executable directly
943 #[allow(dead_code, print_stdout)]
945 panic!("Please use the cargo-clippy executable");