1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(rustc_private)]
5 #![feature(slice_patterns)]
6 #![feature(stmt_expr_attributes)]
7 #![feature(range_contains)]
8 #![feature(macro_vis_matcher)]
9 #![allow(unknown_lints, shadow_reuse, missing_docs_in_private_items)]
10 #![recursion_limit = "256"]
11 #![allow(stable_features)]
12 #![feature(iterator_find_map)]
13 #![feature(macro_at_most_once_rep)]
14 #![feature(rust_2018_preview)]
16 extern crate cargo_metadata;
19 extern crate rustc_target;
20 extern crate rustc_typeck;
22 extern crate syntax_pos;
26 // for unicode nfc normalization
28 extern crate unicode_normalization;
30 // for semver check in attrs.rs
36 extern crate regex_syntax;
38 // for finding minimal boolean expressions
40 extern crate quine_mc_cluskey;
42 extern crate rustc_errors;
43 extern crate rustc_plugin;
46 extern crate matches as matches_macro;
50 extern crate serde_derive;
53 extern crate lazy_static;
55 extern crate itertools;
56 extern crate pulldown_cmark;
60 extern crate if_chain;
62 macro_rules! declare_clippy_lint {
63 { pub $name:tt, style, $description:tt } => {
64 declare_lint! { pub $name, Warn, $description }
66 { pub $name:tt, correctness, $description:tt } => {
67 declare_lint! { pub $name, Deny, $description }
69 { pub $name:tt, complexity, $description:tt } => {
70 declare_lint! { pub $name, Warn, $description }
72 { pub $name:tt, perf, $description:tt } => {
73 declare_lint! { pub $name, Warn, $description }
75 { pub $name:tt, pedantic, $description:tt } => {
76 declare_lint! { pub $name, Allow, $description }
78 { pub $name:tt, restriction, $description:tt } => {
79 declare_lint! { pub $name, Allow, $description }
81 { pub $name:tt, cargo, $description:tt } => {
82 declare_lint! { pub $name, Allow, $description }
84 { pub $name:tt, nursery, $description:tt } => {
85 declare_lint! { pub $name, Allow, $description }
87 { pub $name:tt, internal, $description:tt } => {
88 declare_lint! { pub $name, Allow, $description }
90 { pub $name:tt, internal_warn, $description:tt } => {
91 declare_lint! { pub $name, Warn, $description }
99 // begin lints modules, do not remove this comment, it’s used in `update_lints`
100 pub mod approx_const;
105 pub mod blacklisted_name;
106 pub mod block_in_if_condition;
109 pub mod collapsible_if;
110 pub mod const_static_lifetime;
112 pub mod cyclomatic_complexity;
113 pub mod default_trait_access;
116 pub mod double_comparison;
117 pub mod double_parens;
118 pub mod drop_forget_ref;
119 pub mod duration_subsec;
120 pub mod else_if_without_else;
124 pub mod enum_glob_use;
125 pub mod enum_variants;
129 pub mod eta_reduction;
130 pub mod eval_order_dependence;
131 pub mod excessive_precision;
132 pub mod explicit_write;
133 pub mod fallible_impl_from;
137 pub mod identity_conversion;
139 pub mod if_let_redundant_pattern_matching;
141 pub mod indexing_slicing;
142 pub mod infallible_destructuring_match;
143 pub mod infinite_iter;
144 pub mod inherent_impl;
145 pub mod inline_fn_without_body;
146 pub mod int_plus_one;
148 pub mod items_after_statements;
149 pub mod large_enum_variant;
153 pub mod literal_representation;
164 pub mod multiple_crate_versions;
166 pub mod mut_reference;
167 pub mod mutex_atomic;
168 pub mod needless_bool;
169 pub mod needless_borrow;
170 pub mod needless_borrowed_ref;
171 pub mod needless_continue;
172 pub mod needless_pass_by_value;
173 pub mod needless_update;
174 pub mod neg_cmp_op_on_partial_ord;
175 pub mod neg_multiply;
176 pub mod new_without_default;
178 pub mod non_expressive_names;
180 pub mod open_options;
181 pub mod overflow_check_conditional;
182 pub mod panic_unimplemented;
183 pub mod partialeq_ne_impl;
186 pub mod question_mark;
188 pub mod redundant_field_names;
191 pub mod replace_consts;
196 pub mod suspicious_trait_impl;
198 pub mod temporary_assignment;
200 pub mod trivially_copy_pass_by_ref;
203 pub mod unsafe_removed_from_name;
204 pub mod unused_io_amount;
205 pub mod unused_label;
210 pub mod zero_div_zero;
211 // end lints modules, do not remove this comment, it’s used in `update_lints`
214 pub use syntax::ast::{Name, NodeId};
217 #[cfg_attr(rustfmt, rustfmt_skip)]
218 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
219 let conf = match utils::conf::file_from_args(reg.args()) {
221 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
222 // do not require the file to exist
223 let file_name = if let Some(file_name) = file_name {
226 match utils::conf::lookup_conf_file() {
229 reg.sess.struct_err(&format!("error finding Clippy's configuration file: {}", error)).emit();
235 let file_name = file_name.map(|file_name| if file_name.is_relative() {
237 .local_crate_source_file
239 .and_then(|file| std::path::Path::new(&file).parent().map(std::path::Path::to_path_buf))
246 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
248 // all conf errors are non-fatal, we just use the default conf in case of error
249 for error in errors {
250 reg.sess.struct_err(&format!("error reading Clippy's configuration file `{}`: {}", file_name.as_ref().and_then(|p| p.to_str()).unwrap_or(""), error)).emit();
255 Err((err, span)) => {
256 reg.sess.struct_span_err(span, err)
257 .span_note(span, "Clippy will use default configuration")
259 toml::from_str("").expect("we never error on empty config files")
263 let mut store = reg.sess.lint_store.borrow_mut();
264 store.register_removed(
266 "`assert!()` will be more flexible with RFC 2011",
268 store.register_removed(
270 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
272 store.register_removed(
273 "range_step_by_zero",
274 "`iterator.step_by(0)` panics nowadays",
276 store.register_removed(
278 "`Vec::as_slice` has been stabilized in 1.7",
280 store.register_removed(
281 "unstable_as_mut_slice",
282 "`Vec::as_mut_slice` has been stabilized in 1.7",
284 store.register_removed(
286 "using `str::to_string` is common even today and specialization will likely happen soon",
288 store.register_removed(
290 "using `string::to_string` is common even today and specialization will likely happen soon",
292 store.register_removed(
293 "misaligned_transmute",
294 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
296 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
298 reg.register_late_lint_pass(box serde_api::Serde);
299 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
300 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
301 reg.register_late_lint_pass(box utils::inspector::Pass);
302 reg.register_late_lint_pass(box utils::author::Pass);
303 reg.register_late_lint_pass(box types::TypePass);
304 reg.register_late_lint_pass(box booleans::NonminimalBool);
305 reg.register_late_lint_pass(box eq_op::EqOp);
306 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
307 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
308 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
309 reg.register_late_lint_pass(box excessive_precision::ExcessivePrecision);
310 reg.register_late_lint_pass(box bit_mask::BitMask::new(conf.verbose_bit_mask_threshold));
311 reg.register_late_lint_pass(box ptr::PointerPass);
312 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
313 reg.register_late_lint_pass(box needless_bool::BoolComparison);
314 reg.register_late_lint_pass(box approx_const::Pass);
315 reg.register_late_lint_pass(box misc::Pass);
316 reg.register_early_lint_pass(box precedence::Precedence);
317 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
318 reg.register_late_lint_pass(box eta_reduction::EtaPass);
319 reg.register_late_lint_pass(box identity_op::IdentityOp);
320 reg.register_late_lint_pass(box erasing_op::ErasingOp);
321 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
322 reg.register_late_lint_pass(box mut_mut::MutMut);
323 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
324 reg.register_late_lint_pass(box len_zero::LenZero);
325 reg.register_late_lint_pass(box attrs::AttrPass);
326 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
327 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
328 reg.register_late_lint_pass(box unicode::Unicode);
329 reg.register_late_lint_pass(box strings::StringAdd);
330 reg.register_early_lint_pass(box returns::ReturnPass);
331 reg.register_late_lint_pass(box methods::Pass);
332 reg.register_late_lint_pass(box shadow::Pass);
333 reg.register_late_lint_pass(box types::LetPass);
334 reg.register_late_lint_pass(box types::UnitCmp);
335 reg.register_late_lint_pass(box loops::Pass);
336 reg.register_late_lint_pass(box lifetimes::LifetimePass);
337 reg.register_late_lint_pass(box entry::HashMapLint);
338 reg.register_late_lint_pass(box ranges::Pass);
339 reg.register_late_lint_pass(box types::CastPass);
340 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
341 reg.register_late_lint_pass(box matches::MatchPass);
342 reg.register_late_lint_pass(box minmax::MinMaxPass);
343 reg.register_late_lint_pass(box open_options::NonSensical);
344 reg.register_late_lint_pass(box zero_div_zero::Pass);
345 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
346 reg.register_late_lint_pass(box needless_update::Pass);
347 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
348 reg.register_late_lint_pass(box needless_borrowed_ref::NeedlessBorrowedRef);
349 reg.register_late_lint_pass(box no_effect::Pass);
350 reg.register_late_lint_pass(box map_clone::Pass);
351 reg.register_late_lint_pass(box temporary_assignment::Pass);
352 reg.register_late_lint_pass(box transmute::Transmute);
353 reg.register_late_lint_pass(
354 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
356 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
357 reg.register_early_lint_pass(box misc_early::MiscEarly);
358 reg.register_late_lint_pass(box panic_unimplemented::Pass);
359 reg.register_late_lint_pass(box strings::StringLitAsBytes);
360 reg.register_late_lint_pass(box derive::Derive);
361 reg.register_late_lint_pass(box types::CharLitAsU8);
362 reg.register_late_lint_pass(box write::Pass);
363 reg.register_late_lint_pass(box vec::Pass);
364 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
365 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
367 reg.register_late_lint_pass(box drop_forget_ref::Pass);
368 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
369 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
370 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
371 reg.register_late_lint_pass(box regex::Pass::default());
372 reg.register_late_lint_pass(box copies::CopyAndPaste);
373 reg.register_late_lint_pass(box format::Pass);
374 reg.register_early_lint_pass(box formatting::Formatting);
375 reg.register_late_lint_pass(box swap::Swap);
376 reg.register_early_lint_pass(box if_not_else::IfNotElse);
377 reg.register_early_lint_pass(box else_if_without_else::ElseIfWithoutElse);
378 reg.register_early_lint_pass(box int_plus_one::IntPlusOne);
379 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
380 reg.register_late_lint_pass(box unused_label::UnusedLabel);
381 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
382 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
383 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
384 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
385 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
386 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
387 reg.register_late_lint_pass(box mem_forget::MemForget);
388 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
389 reg.register_late_lint_pass(box assign_ops::AssignOps);
390 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
391 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
392 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
393 reg.register_late_lint_pass(box ok_if_let::Pass);
394 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
395 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
396 reg.register_early_lint_pass(box reference::Pass);
397 reg.register_early_lint_pass(box reference::DerefPass);
398 reg.register_early_lint_pass(box double_parens::DoubleParens);
399 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
400 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
401 reg.register_late_lint_pass(box explicit_write::Pass);
402 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
403 reg.register_late_lint_pass(box trivially_copy_pass_by_ref::TriviallyCopyPassByRef::new(
404 conf.trivial_copy_size_limit,
407 reg.register_early_lint_pass(box literal_representation::LiteralDigitGrouping);
408 reg.register_early_lint_pass(box literal_representation::LiteralRepresentation::new(
409 conf.literal_representation_threshold
411 reg.register_late_lint_pass(box use_self::UseSelf);
412 reg.register_late_lint_pass(box bytecount::ByteCount);
413 reg.register_late_lint_pass(box infinite_iter::Pass);
414 reg.register_late_lint_pass(box inline_fn_without_body::Pass);
415 reg.register_late_lint_pass(box invalid_ref::InvalidRef);
416 reg.register_late_lint_pass(box identity_conversion::IdentityConversion::default());
417 reg.register_late_lint_pass(box types::ImplicitHasher);
418 reg.register_early_lint_pass(box const_static_lifetime::StaticConst);
419 reg.register_late_lint_pass(box fallible_impl_from::FallibleImplFrom);
420 reg.register_late_lint_pass(box replace_consts::ReplaceConsts);
421 reg.register_late_lint_pass(box types::UnitArg);
422 reg.register_late_lint_pass(box double_comparison::DoubleComparisonPass);
423 reg.register_late_lint_pass(box question_mark::QuestionMarkPass);
424 reg.register_late_lint_pass(box suspicious_trait_impl::SuspiciousImpl);
425 reg.register_late_lint_pass(box redundant_field_names::RedundantFieldNames);
426 reg.register_early_lint_pass(box multiple_crate_versions::Pass);
427 reg.register_late_lint_pass(box map_unit_fn::Pass);
428 reg.register_late_lint_pass(box infallible_destructuring_match::Pass);
429 reg.register_late_lint_pass(box inherent_impl::Pass::default());
430 reg.register_late_lint_pass(box neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd);
431 reg.register_late_lint_pass(box unwrap::Pass);
432 reg.register_late_lint_pass(box duration_subsec::DurationSubsec);
433 reg.register_late_lint_pass(box default_trait_access::DefaultTraitAccess);
434 reg.register_late_lint_pass(box indexing_slicing::IndexingSlicing);
436 reg.register_lint_group("clippy_restriction", vec![
437 arithmetic::FLOAT_ARITHMETIC,
438 arithmetic::INTEGER_ARITHMETIC,
439 assign_ops::ASSIGN_OPS,
440 else_if_without_else::ELSE_IF_WITHOUT_ELSE,
441 inherent_impl::MULTIPLE_INHERENT_IMPL,
442 literal_representation::DECIMAL_LITERAL_REPRESENTATION,
443 mem_forget::MEM_FORGET,
444 methods::CLONE_ON_REF_PTR,
445 methods::OPTION_UNWRAP_USED,
446 methods::RESULT_UNWRAP_USED,
447 methods::WRONG_PUB_SELF_CONVENTION,
448 misc::FLOAT_CMP_CONST,
449 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
450 panic_unimplemented::UNIMPLEMENTED,
451 shadow::SHADOW_REUSE,
453 shadow::SHADOW_UNRELATED,
459 reg.register_lint_group("clippy_pedantic", vec![
460 attrs::INLINE_ALWAYS,
461 copies::MATCH_SAME_ARMS,
462 derive::EXPL_IMPL_CLONE_ON_COPY,
464 empty_enum::EMPTY_ENUM,
465 enum_glob_use::ENUM_GLOB_USE,
466 enum_variants::PUB_ENUM_VARIANT_NAMES,
467 enum_variants::STUTTER,
468 if_not_else::IF_NOT_ELSE,
469 indexing_slicing::INDEXING_SLICING,
470 infinite_iter::MAYBE_INFINITE_ITER,
471 items_after_statements::ITEMS_AFTER_STATEMENTS,
472 matches::SINGLE_MATCH_ELSE,
474 methods::OPTION_MAP_UNWRAP_OR,
475 methods::OPTION_MAP_UNWRAP_OR_ELSE,
476 methods::RESULT_MAP_UNWRAP_OR_ELSE,
477 misc::USED_UNDERSCORE_BINDING,
478 misc_early::UNSEPARATED_LITERAL_SUFFIX,
480 needless_continue::NEEDLESS_CONTINUE,
481 non_expressive_names::SIMILAR_NAMES,
482 replace_consts::REPLACE_CONSTS,
483 strings::STRING_ADD_ASSIGN,
484 types::CAST_POSSIBLE_TRUNCATION,
485 types::CAST_POSSIBLE_WRAP,
486 types::CAST_PRECISION_LOSS,
487 types::CAST_SIGN_LOSS,
488 types::INVALID_UPCAST_COMPARISONS,
490 unicode::NON_ASCII_LITERAL,
491 unicode::UNICODE_NOT_NFC,
495 reg.register_lint_group("clippy_internal", vec![
496 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
497 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
500 reg.register_lint_group("clippy", vec![
501 approx_const::APPROX_CONSTANT,
502 assign_ops::ASSIGN_OP_PATTERN,
503 assign_ops::MISREFACTORED_ASSIGN_OP,
504 attrs::DEPRECATED_SEMVER,
505 attrs::USELESS_ATTRIBUTE,
506 bit_mask::BAD_BIT_MASK,
507 bit_mask::INEFFECTIVE_BIT_MASK,
508 bit_mask::VERBOSE_BIT_MASK,
509 blacklisted_name::BLACKLISTED_NAME,
510 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
511 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
513 booleans::NONMINIMAL_BOOL,
514 bytecount::NAIVE_BYTECOUNT,
515 collapsible_if::COLLAPSIBLE_IF,
516 const_static_lifetime::CONST_STATIC_LIFETIME,
517 copies::IF_SAME_THEN_ELSE,
518 copies::IFS_SAME_COND,
519 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
520 default_trait_access::DEFAULT_TRAIT_ACCESS,
521 derive::DERIVE_HASH_XOR_EQ,
522 double_comparison::DOUBLE_COMPARISONS,
523 double_parens::DOUBLE_PARENS,
524 drop_forget_ref::DROP_COPY,
525 drop_forget_ref::DROP_REF,
526 drop_forget_ref::FORGET_COPY,
527 drop_forget_ref::FORGET_REF,
528 duration_subsec::DURATION_SUBSEC,
530 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
531 enum_variants::ENUM_VARIANT_NAMES,
532 enum_variants::MODULE_INCEPTION,
535 erasing_op::ERASING_OP,
537 eta_reduction::REDUNDANT_CLOSURE,
538 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
539 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
540 excessive_precision::EXCESSIVE_PRECISION,
541 explicit_write::EXPLICIT_WRITE,
542 format::USELESS_FORMAT,
543 formatting::POSSIBLE_MISSING_COMMA,
544 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
545 formatting::SUSPICIOUS_ELSE_FORMATTING,
546 functions::NOT_UNSAFE_PTR_ARG_DEREF,
547 functions::TOO_MANY_ARGUMENTS,
548 identity_conversion::IDENTITY_CONVERSION,
549 identity_op::IDENTITY_OP,
550 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
551 indexing_slicing::OUT_OF_BOUNDS_INDEXING,
552 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
553 infinite_iter::INFINITE_ITER,
554 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
555 int_plus_one::INT_PLUS_ONE,
556 invalid_ref::INVALID_REF,
557 large_enum_variant::LARGE_ENUM_VARIANT,
558 len_zero::LEN_WITHOUT_IS_EMPTY,
560 let_if_seq::USELESS_LET_IF_SEQ,
561 lifetimes::EXTRA_UNUSED_LIFETIMES,
562 lifetimes::NEEDLESS_LIFETIMES,
563 literal_representation::INCONSISTENT_DIGIT_GROUPING,
564 literal_representation::LARGE_DIGIT_GROUPS,
565 literal_representation::UNREADABLE_LITERAL,
567 loops::EXPLICIT_COUNTER_LOOP,
568 loops::EXPLICIT_INTO_ITER_LOOP,
569 loops::EXPLICIT_ITER_LOOP,
571 loops::FOR_LOOP_OVER_OPTION,
572 loops::FOR_LOOP_OVER_RESULT,
573 loops::ITER_NEXT_LOOP,
574 loops::MANUAL_MEMCPY,
575 loops::MUT_RANGE_BOUND,
576 loops::NEEDLESS_RANGE_LOOP,
578 loops::REVERSE_RANGE_LOOP,
579 loops::UNUSED_COLLECT,
580 loops::WHILE_IMMUTABLE_CONDITION,
581 loops::WHILE_LET_LOOP,
582 loops::WHILE_LET_ON_ITERATOR,
583 map_clone::MAP_CLONE,
584 map_unit_fn::OPTION_MAP_UNIT_FN,
585 map_unit_fn::RESULT_MAP_UNIT_FN,
586 matches::MATCH_AS_REF,
588 matches::MATCH_OVERLAPPING_ARM,
589 matches::MATCH_REF_PATS,
590 matches::MATCH_WILD_ERR_ARM,
591 matches::SINGLE_MATCH,
592 methods::CHARS_LAST_CMP,
593 methods::CHARS_NEXT_CMP,
594 methods::CLONE_DOUBLE_REF,
595 methods::CLONE_ON_COPY,
596 methods::EXPECT_FUN_CALL,
597 methods::FILTER_NEXT,
599 methods::ITER_CLONED_COLLECT,
601 methods::ITER_SKIP_NEXT,
602 methods::NEW_RET_NO_SELF,
604 methods::OPTION_MAP_OR_NONE,
605 methods::OR_FUN_CALL,
606 methods::SEARCH_IS_SOME,
607 methods::SHOULD_IMPLEMENT_TRAIT,
608 methods::SINGLE_CHAR_PATTERN,
609 methods::STRING_EXTEND_CHARS,
610 methods::TEMPORARY_CSTRING_AS_PTR,
611 methods::UNNECESSARY_FOLD,
612 methods::USELESS_ASREF,
613 methods::WRONG_SELF_CONVENTION,
619 misc::REDUNDANT_PATTERN,
620 misc::SHORT_CIRCUIT_STATEMENT,
621 misc::TOPLEVEL_REF_ARG,
623 misc_early::BUILTIN_TYPE_SHADOW,
624 misc_early::DOUBLE_NEG,
625 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
626 misc_early::MIXED_CASE_HEX_LITERALS,
627 misc_early::REDUNDANT_CLOSURE_CALL,
628 misc_early::UNNEEDED_FIELD_PATTERN,
629 misc_early::ZERO_PREFIXED_LITERAL,
630 mut_reference::UNNECESSARY_MUT_PASSED,
631 mutex_atomic::MUTEX_ATOMIC,
632 needless_bool::BOOL_COMPARISON,
633 needless_bool::NEEDLESS_BOOL,
634 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
635 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
636 needless_update::NEEDLESS_UPDATE,
637 neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
638 neg_multiply::NEG_MULTIPLY,
639 new_without_default::NEW_WITHOUT_DEFAULT,
640 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
641 no_effect::NO_EFFECT,
642 no_effect::UNNECESSARY_OPERATION,
643 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
644 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
645 ok_if_let::IF_LET_SOME_RESULT,
646 open_options::NONSENSICAL_OPEN_OPTIONS,
647 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
648 panic_unimplemented::PANIC_PARAMS,
649 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
650 precedence::PRECEDENCE,
654 question_mark::QUESTION_MARK,
655 ranges::ITERATOR_STEP_BY_ZERO,
656 ranges::RANGE_MINUS_ONE,
657 ranges::RANGE_ZIP_WITH_LEN,
658 redundant_field_names::REDUNDANT_FIELD_NAMES,
659 reference::DEREF_ADDROF,
660 reference::REF_IN_DEREF,
661 regex::INVALID_REGEX,
663 regex::TRIVIAL_REGEX,
664 returns::LET_AND_RETURN,
665 returns::NEEDLESS_RETURN,
666 serde_api::SERDE_API_MISUSE,
667 strings::STRING_LIT_AS_BYTES,
668 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
669 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
670 swap::ALMOST_SWAPPED,
672 temporary_assignment::TEMPORARY_ASSIGNMENT,
673 transmute::CROSSPOINTER_TRANSMUTE,
674 transmute::TRANSMUTE_BYTES_TO_STR,
675 transmute::TRANSMUTE_INT_TO_BOOL,
676 transmute::TRANSMUTE_INT_TO_CHAR,
677 transmute::TRANSMUTE_INT_TO_FLOAT,
678 transmute::TRANSMUTE_PTR_TO_PTR,
679 transmute::TRANSMUTE_PTR_TO_REF,
680 transmute::USELESS_TRANSMUTE,
681 transmute::WRONG_TRANSMUTE,
682 trivially_copy_pass_by_ref::TRIVIALLY_COPY_PASS_BY_REF,
683 types::ABSURD_EXTREME_COMPARISONS,
686 types::CAST_LOSSLESS,
687 types::CAST_PTR_ALIGNMENT,
688 types::CHAR_LIT_AS_U8,
689 types::FN_TO_NUMERIC_CAST,
690 types::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
691 types::IMPLICIT_HASHER,
692 types::LET_UNIT_VALUE,
693 types::OPTION_OPTION,
694 types::TYPE_COMPLEXITY,
697 types::UNNECESSARY_CAST,
698 unicode::ZERO_WIDTH_SPACE,
699 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
700 unused_io_amount::UNUSED_IO_AMOUNT,
701 unused_label::UNUSED_LABEL,
703 write::PRINT_LITERAL,
704 write::PRINT_WITH_NEWLINE,
705 write::PRINTLN_EMPTY_STRING,
706 write::WRITE_LITERAL,
707 write::WRITE_WITH_NEWLINE,
708 write::WRITELN_EMPTY_STRING,
709 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
712 reg.register_lint_group("clippy_style", vec![
713 assign_ops::ASSIGN_OP_PATTERN,
714 bit_mask::VERBOSE_BIT_MASK,
715 blacklisted_name::BLACKLISTED_NAME,
716 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
717 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
718 collapsible_if::COLLAPSIBLE_IF,
719 const_static_lifetime::CONST_STATIC_LIFETIME,
720 default_trait_access::DEFAULT_TRAIT_ACCESS,
721 enum_variants::ENUM_VARIANT_NAMES,
722 enum_variants::MODULE_INCEPTION,
724 eta_reduction::REDUNDANT_CLOSURE,
725 excessive_precision::EXCESSIVE_PRECISION,
726 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
727 formatting::SUSPICIOUS_ELSE_FORMATTING,
728 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
729 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
730 len_zero::LEN_WITHOUT_IS_EMPTY,
732 let_if_seq::USELESS_LET_IF_SEQ,
733 literal_representation::INCONSISTENT_DIGIT_GROUPING,
734 literal_representation::LARGE_DIGIT_GROUPS,
735 literal_representation::UNREADABLE_LITERAL,
737 loops::EXPLICIT_INTO_ITER_LOOP,
738 loops::EXPLICIT_ITER_LOOP,
740 loops::NEEDLESS_RANGE_LOOP,
741 loops::WHILE_LET_ON_ITERATOR,
742 map_clone::MAP_CLONE,
744 matches::MATCH_OVERLAPPING_ARM,
745 matches::MATCH_REF_PATS,
746 matches::MATCH_WILD_ERR_ARM,
747 matches::SINGLE_MATCH,
748 methods::CHARS_LAST_CMP,
750 methods::ITER_CLONED_COLLECT,
751 methods::ITER_SKIP_NEXT,
752 methods::NEW_RET_NO_SELF,
754 methods::OPTION_MAP_OR_NONE,
755 methods::SHOULD_IMPLEMENT_TRAIT,
756 methods::STRING_EXTEND_CHARS,
757 methods::UNNECESSARY_FOLD,
758 methods::WRONG_SELF_CONVENTION,
759 misc::REDUNDANT_PATTERN,
760 misc::TOPLEVEL_REF_ARG,
762 misc_early::BUILTIN_TYPE_SHADOW,
763 misc_early::DOUBLE_NEG,
764 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
765 misc_early::MIXED_CASE_HEX_LITERALS,
766 misc_early::UNNEEDED_FIELD_PATTERN,
767 mut_reference::UNNECESSARY_MUT_PASSED,
768 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
769 neg_multiply::NEG_MULTIPLY,
770 new_without_default::NEW_WITHOUT_DEFAULT,
771 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
772 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
773 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
774 ok_if_let::IF_LET_SOME_RESULT,
775 panic_unimplemented::PANIC_PARAMS,
778 question_mark::QUESTION_MARK,
779 ranges::RANGE_MINUS_ONE,
780 redundant_field_names::REDUNDANT_FIELD_NAMES,
782 regex::TRIVIAL_REGEX,
783 returns::LET_AND_RETURN,
784 returns::NEEDLESS_RETURN,
785 strings::STRING_LIT_AS_BYTES,
786 types::FN_TO_NUMERIC_CAST,
787 types::IMPLICIT_HASHER,
788 types::LET_UNIT_VALUE,
789 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
790 write::PRINT_LITERAL,
791 write::PRINT_WITH_NEWLINE,
792 write::PRINTLN_EMPTY_STRING,
793 write::WRITE_LITERAL,
794 write::WRITE_WITH_NEWLINE,
795 write::WRITELN_EMPTY_STRING,
798 reg.register_lint_group("clippy_complexity", vec![
799 assign_ops::MISREFACTORED_ASSIGN_OP,
800 booleans::NONMINIMAL_BOOL,
801 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
802 double_comparison::DOUBLE_COMPARISONS,
803 double_parens::DOUBLE_PARENS,
804 duration_subsec::DURATION_SUBSEC,
805 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
806 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
807 explicit_write::EXPLICIT_WRITE,
808 format::USELESS_FORMAT,
809 functions::TOO_MANY_ARGUMENTS,
810 identity_conversion::IDENTITY_CONVERSION,
811 identity_op::IDENTITY_OP,
812 int_plus_one::INT_PLUS_ONE,
813 lifetimes::EXTRA_UNUSED_LIFETIMES,
814 lifetimes::NEEDLESS_LIFETIMES,
815 loops::EXPLICIT_COUNTER_LOOP,
816 loops::MUT_RANGE_BOUND,
817 loops::WHILE_LET_LOOP,
818 map_unit_fn::OPTION_MAP_UNIT_FN,
819 map_unit_fn::RESULT_MAP_UNIT_FN,
820 matches::MATCH_AS_REF,
821 methods::CHARS_NEXT_CMP,
822 methods::CLONE_ON_COPY,
823 methods::FILTER_NEXT,
824 methods::SEARCH_IS_SOME,
825 methods::USELESS_ASREF,
826 misc::SHORT_CIRCUIT_STATEMENT,
827 misc_early::REDUNDANT_CLOSURE_CALL,
828 misc_early::ZERO_PREFIXED_LITERAL,
829 needless_bool::BOOL_COMPARISON,
830 needless_bool::NEEDLESS_BOOL,
831 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
832 needless_update::NEEDLESS_UPDATE,
833 neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
834 no_effect::NO_EFFECT,
835 no_effect::UNNECESSARY_OPERATION,
836 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
837 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
838 precedence::PRECEDENCE,
839 ranges::RANGE_ZIP_WITH_LEN,
840 reference::DEREF_ADDROF,
841 reference::REF_IN_DEREF,
843 temporary_assignment::TEMPORARY_ASSIGNMENT,
844 transmute::CROSSPOINTER_TRANSMUTE,
845 transmute::TRANSMUTE_BYTES_TO_STR,
846 transmute::TRANSMUTE_INT_TO_BOOL,
847 transmute::TRANSMUTE_INT_TO_CHAR,
848 transmute::TRANSMUTE_INT_TO_FLOAT,
849 transmute::TRANSMUTE_PTR_TO_PTR,
850 transmute::TRANSMUTE_PTR_TO_REF,
851 transmute::USELESS_TRANSMUTE,
853 types::CAST_LOSSLESS,
854 types::CHAR_LIT_AS_U8,
855 types::OPTION_OPTION,
856 types::TYPE_COMPLEXITY,
858 types::UNNECESSARY_CAST,
859 unused_label::UNUSED_LABEL,
860 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
863 reg.register_lint_group("clippy_correctness", vec![
864 approx_const::APPROX_CONSTANT,
865 attrs::DEPRECATED_SEMVER,
866 attrs::USELESS_ATTRIBUTE,
867 bit_mask::BAD_BIT_MASK,
868 bit_mask::INEFFECTIVE_BIT_MASK,
870 copies::IF_SAME_THEN_ELSE,
871 copies::IFS_SAME_COND,
872 derive::DERIVE_HASH_XOR_EQ,
873 drop_forget_ref::DROP_COPY,
874 drop_forget_ref::DROP_REF,
875 drop_forget_ref::FORGET_COPY,
876 drop_forget_ref::FORGET_REF,
877 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
879 erasing_op::ERASING_OP,
880 formatting::POSSIBLE_MISSING_COMMA,
881 functions::NOT_UNSAFE_PTR_ARG_DEREF,
882 indexing_slicing::OUT_OF_BOUNDS_INDEXING,
883 infinite_iter::INFINITE_ITER,
884 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
885 invalid_ref::INVALID_REF,
886 loops::FOR_LOOP_OVER_OPTION,
887 loops::FOR_LOOP_OVER_RESULT,
888 loops::ITER_NEXT_LOOP,
890 loops::REVERSE_RANGE_LOOP,
891 loops::WHILE_IMMUTABLE_CONDITION,
892 methods::CLONE_DOUBLE_REF,
893 methods::TEMPORARY_CSTRING_AS_PTR,
898 open_options::NONSENSICAL_OPEN_OPTIONS,
900 ranges::ITERATOR_STEP_BY_ZERO,
901 regex::INVALID_REGEX,
902 serde_api::SERDE_API_MISUSE,
903 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
904 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
905 swap::ALMOST_SWAPPED,
906 transmute::WRONG_TRANSMUTE,
907 types::ABSURD_EXTREME_COMPARISONS,
908 types::CAST_PTR_ALIGNMENT,
909 types::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
911 unicode::ZERO_WIDTH_SPACE,
912 unused_io_amount::UNUSED_IO_AMOUNT,
915 reg.register_lint_group("clippy_perf", vec![
916 bytecount::NAIVE_BYTECOUNT,
919 large_enum_variant::LARGE_ENUM_VARIANT,
920 loops::MANUAL_MEMCPY,
921 loops::UNUSED_COLLECT,
922 methods::EXPECT_FUN_CALL,
924 methods::OR_FUN_CALL,
925 methods::SINGLE_CHAR_PATTERN,
927 mutex_atomic::MUTEX_ATOMIC,
928 trivially_copy_pass_by_ref::TRIVIALLY_COPY_PASS_BY_REF,
933 reg.register_lint_group("clippy_cargo", vec![
934 multiple_crate_versions::MULTIPLE_CRATE_VERSIONS,
937 reg.register_lint_group("clippy_nursery", vec![
938 attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
939 fallible_impl_from::FALLIBLE_IMPL_FROM,
940 mutex_atomic::MUTEX_INTEGER,
941 needless_borrow::NEEDLESS_BORROW,
942 ranges::RANGE_PLUS_ONE,
943 unwrap::PANICKING_UNWRAP,
944 unwrap::UNNECESSARY_UNWRAP,
948 // only exists to let the dogfood integration test works.
949 // Don't run clippy as an executable directly
950 #[allow(dead_code, print_stdout)]
952 panic!("Please use the cargo-clippy executable");