1 // error-pattern:cargo-clippy
3 #![feature(binary_heap_into_iter_sorted)]
4 #![feature(box_patterns)]
5 #![feature(control_flow_enum)]
6 #![feature(drain_filter)]
7 #![feature(iter_intersperse)]
8 #![feature(let_chains)]
10 #![feature(once_cell)]
11 #![feature(rustc_private)]
12 #![feature(stmt_expr_attributes)]
13 #![recursion_limit = "512"]
14 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
15 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
16 #![warn(trivial_casts, trivial_numeric_casts)]
17 // warn on lints, that are included in `rust-lang/rust`s bootstrap
18 #![warn(rust_2018_idioms, unused_lifetimes)]
19 // warn on rustc internal lints
20 #![warn(rustc::internal)]
21 // Disable this rustc lint for now, as it was also done in rustc
22 #![allow(rustc::potential_query_instability)]
24 // FIXME: switch to something more ergonomic here, once available.
25 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
26 extern crate rustc_ast;
27 extern crate rustc_ast_pretty;
28 extern crate rustc_attr;
29 extern crate rustc_data_structures;
30 extern crate rustc_driver;
31 extern crate rustc_errors;
32 extern crate rustc_hir;
33 extern crate rustc_hir_pretty;
34 extern crate rustc_index;
35 extern crate rustc_infer;
36 extern crate rustc_lexer;
37 extern crate rustc_lint;
38 extern crate rustc_middle;
39 extern crate rustc_mir_dataflow;
40 extern crate rustc_parse;
41 extern crate rustc_parse_format;
42 extern crate rustc_session;
43 extern crate rustc_span;
44 extern crate rustc_target;
45 extern crate rustc_trait_selection;
46 extern crate rustc_typeck;
49 extern crate clippy_utils;
51 use clippy_utils::parse_msrv;
52 use rustc_data_structures::fx::FxHashSet;
53 use rustc_lint::LintId;
54 use rustc_session::Session;
56 /// Macro used to declare a Clippy lint.
58 /// Every lint declaration consists of 4 parts:
60 /// 1. The documentation, which is used for the website
61 /// 2. The `LINT_NAME`. See [lint naming][lint_naming] on lint naming conventions.
62 /// 3. The `lint_level`, which is a mapping from *one* of our lint groups to `Allow`, `Warn` or
63 /// `Deny`. The lint level here has nothing to do with what lint groups the lint is a part of.
64 /// 4. The `description` that contains a short explanation on what's wrong with code where the
65 /// lint is triggered.
67 /// Currently the categories `style`, `correctness`, `suspicious`, `complexity` and `perf` are
68 /// enabled by default. As said in the README.md of this repository, if the lint level mapping
69 /// changes, please update README.md.
74 /// #![feature(rustc_private)]
75 /// extern crate rustc_session;
76 /// use rustc_session::declare_tool_lint;
77 /// use clippy_lints::declare_clippy_lint;
79 /// declare_clippy_lint! {
80 /// /// ### What it does
81 /// /// Checks for ... (describe what the lint matches).
83 /// /// ### Why is this bad?
84 /// /// Supply the reason for linting the code.
89 /// /// Insert a short example of code that triggers the lint
92 /// /// Insert a short example of improved code that doesn't trigger the lint
99 /// [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
101 macro_rules! declare_clippy_lint {
102 { $(#[$attr:meta])* pub $name:tt, style, $description:tt } => {
104 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
107 { $(#[$attr:meta])* pub $name:tt, correctness, $description:tt } => {
109 $(#[$attr])* pub clippy::$name, Deny, $description, report_in_external_macro: true
112 { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
114 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
117 { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
119 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
122 { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
124 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
127 { $(#[$attr:meta])* pub $name:tt, pedantic, $description:tt } => {
129 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
132 { $(#[$attr:meta])* pub $name:tt, restriction, $description:tt } => {
134 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
137 { $(#[$attr:meta])* pub $name:tt, cargo, $description:tt } => {
139 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
142 { $(#[$attr:meta])* pub $name:tt, nursery, $description:tt } => {
144 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
147 { $(#[$attr:meta])* pub $name:tt, internal, $description:tt } => {
149 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
152 { $(#[$attr:meta])* pub $name:tt, internal_warn, $description:tt } => {
154 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
159 #[cfg(feature = "internal")]
160 mod deprecated_lints;
161 #[cfg_attr(feature = "internal", allow(clippy::missing_clippy_version_attribute))]
164 // begin lints modules, do not remove this comment, it’s used in `update_lints`
165 mod absurd_extreme_comparisons;
170 mod assertions_on_constants;
172 mod async_yields_async;
174 mod await_holding_invalid;
176 mod blacklisted_name;
177 mod blocks_in_if_conditions;
178 mod bool_assert_comparison;
183 mod case_sensitive_file_extension_comparisons;
185 mod checked_conversions;
186 mod cognitive_complexity;
188 mod collapsible_match;
189 mod comparison_chain;
195 mod default_numeric_fallback;
196 mod default_union_representation;
200 mod disallowed_methods;
201 mod disallowed_script_idents;
202 mod disallowed_types;
204 mod double_comparison;
208 mod else_if_without_else;
214 mod equatable_if_let;
218 mod eval_order_dependence;
220 mod exhaustive_items;
223 mod fallible_impl_from;
224 mod float_equality_without_abs;
226 mod floating_point_arithmetic;
232 mod from_str_radix_10;
235 mod get_last_with_len;
239 mod if_then_some_else_none;
242 mod implicit_saturating_sub;
243 mod inconsistent_struct_constructor;
244 mod index_refutable_slice;
245 mod indexing_slicing;
248 mod inherent_to_string;
249 mod init_numbered_fields;
250 mod inline_fn_without_body;
252 mod integer_division;
253 mod invalid_upcast_comparisons;
254 mod items_after_statements;
255 mod iter_not_returning_iterator;
256 mod large_const_arrays;
257 mod large_enum_variant;
258 mod large_stack_arrays;
263 mod literal_representation;
271 mod manual_non_exhaustive;
274 mod manual_unwrap_or;
278 mod match_on_vec_items;
280 mod match_str_case_mismatch;
288 mod missing_const_for_fn;
290 mod missing_enforced_import_rename;
293 mod modulo_arithmetic;
298 mod mutable_debug_assertion;
300 mod needless_arbitrary_self_type;
301 mod needless_bitwise_bool;
303 mod needless_borrowed_ref;
304 mod needless_continue;
305 mod needless_for_each;
306 mod needless_late_init;
307 mod needless_option_as_deref;
308 mod needless_pass_by_value;
309 mod needless_question_mark;
311 mod neg_cmp_op_on_partial_ord;
313 mod new_without_default;
316 mod non_expressive_names;
317 mod non_octal_unix_permissions;
318 mod non_send_fields_in_send_ty;
319 mod nonstandard_macro_braces;
322 mod option_env_unwrap;
323 mod option_if_let_else;
324 mod overflow_check_conditional;
325 mod panic_in_result_fn;
326 mod panic_unimplemented;
327 mod partialeq_ne_impl;
328 mod pass_by_ref_or_value;
329 mod path_buf_push_overwrite;
330 mod pattern_type_mismatch;
334 mod ptr_offset_with_cast;
338 mod redundant_closure_call;
340 mod redundant_field_names;
341 mod redundant_pub_crate;
342 mod redundant_slicing;
343 mod redundant_static_lifetimes;
348 mod return_self_not_must_use;
350 mod same_name_method;
352 mod self_named_constructors;
353 mod semicolon_if_nothing_returned;
356 mod single_char_lifetime_names;
357 mod single_component_path_imports;
358 mod size_of_in_element_count;
359 mod slow_vector_initialization;
360 mod stable_sort_primitive;
362 mod strlen_on_c_strings;
363 mod suspicious_operation_groupings;
364 mod suspicious_trait_impl;
366 mod tabs_in_doc_comments;
367 mod temporary_assignment;
368 mod to_digit_is_some;
369 mod trailing_empty_array;
372 mod transmuting_null;
375 mod undocumented_unsafe_blocks;
376 mod undropped_manually_drops;
380 mod unit_return_expecting_ord;
383 mod unnecessary_self_imports;
384 mod unnecessary_sort_by;
385 mod unnecessary_wraps;
386 mod unnested_or_patterns;
387 mod unsafe_removed_from_name;
389 mod unused_io_amount;
393 mod unwrap_in_result;
394 mod upper_case_acronyms;
396 mod useless_conversion;
398 mod vec_init_then_push;
399 mod vec_resize_to_zero;
400 mod verbose_file_reads;
401 mod wildcard_imports;
404 mod zero_sized_map_values;
405 // end lints modules, do not remove this comment, it’s used in `update_lints`
407 pub use crate::utils::conf::Conf;
408 use crate::utils::conf::TryConf;
410 /// Register all pre expansion lints
412 /// Pre-expansion lints run before any macro expansion has happened.
414 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
415 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
417 /// Used in `./src/driver.rs`.
418 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
419 // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
421 let msrv = conf.msrv.as_ref().and_then(|s| {
422 parse_msrv(s, None, None).or_else(|| {
424 "error reading Clippy's configuration file. `{}` is not a valid Rust version",
431 store.register_pre_expansion_pass(|| Box::new(write::Write::default()));
432 store.register_pre_expansion_pass(move || Box::new(attrs::EarlyAttributes { msrv }));
436 pub fn read_conf(sess: &Session) -> Conf {
437 let file_name = match utils::conf::lookup_conf_file() {
438 Ok(Some(path)) => path,
439 Ok(None) => return Conf::default(),
441 sess.struct_err(&format!("error finding Clippy's configuration file: {}", error))
443 return Conf::default();
447 let TryConf { conf, errors } = utils::conf::read(&file_name);
448 // all conf errors are non-fatal, we just use the default conf in case of error
449 for error in errors {
450 sess.struct_err(&format!(
451 "error reading Clippy's configuration file `{}`: {}",
461 /// Register all lints and lint groups with the rustc plugin registry
463 /// Used in `./src/driver.rs`.
464 #[allow(clippy::too_many_lines)]
465 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
466 register_removed_non_tool_lints(store);
468 include!("lib.deprecated.rs");
470 include!("lib.register_lints.rs");
471 include!("lib.register_restriction.rs");
472 include!("lib.register_pedantic.rs");
474 #[cfg(feature = "internal")]
475 include!("lib.register_internal.rs");
477 include!("lib.register_all.rs");
478 include!("lib.register_style.rs");
479 include!("lib.register_complexity.rs");
480 include!("lib.register_correctness.rs");
481 include!("lib.register_suspicious.rs");
482 include!("lib.register_perf.rs");
483 include!("lib.register_cargo.rs");
484 include!("lib.register_nursery.rs");
486 #[cfg(feature = "internal")]
488 if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
489 store.register_late_pass(|| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
494 // all the internal lints
495 #[cfg(feature = "internal")]
497 store.register_early_pass(|| Box::new(utils::internal_lints::ClippyLintsInternal));
498 store.register_early_pass(|| Box::new(utils::internal_lints::ProduceIce));
499 store.register_late_pass(|| Box::new(utils::inspector::DeepCodeInspector));
500 store.register_late_pass(|| Box::new(utils::internal_lints::CollapsibleCalls));
501 store.register_late_pass(|| Box::new(utils::internal_lints::CompilerLintFunctions::new()));
502 store.register_late_pass(|| Box::new(utils::internal_lints::IfChainStyle));
503 store.register_late_pass(|| Box::new(utils::internal_lints::InvalidPaths));
504 store.register_late_pass(|| Box::new(utils::internal_lints::InterningDefinedSymbol::default()));
505 store.register_late_pass(|| Box::new(utils::internal_lints::LintWithoutLintPass::default()));
506 store.register_late_pass(|| Box::new(utils::internal_lints::MatchTypeOnDiagItem));
507 store.register_late_pass(|| Box::new(utils::internal_lints::OuterExpnDataPass));
510 store.register_late_pass(|| Box::new(utils::author::Author));
511 store.register_late_pass(|| Box::new(await_holding_invalid::AwaitHolding));
512 store.register_late_pass(|| Box::new(serde_api::SerdeApi));
513 let vec_box_size_threshold = conf.vec_box_size_threshold;
514 let type_complexity_threshold = conf.type_complexity_threshold;
515 let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
516 store.register_late_pass(move || {
517 Box::new(types::Types::new(
518 vec_box_size_threshold,
519 type_complexity_threshold,
520 avoid_breaking_exported_api,
523 store.register_late_pass(|| Box::new(booleans::NonminimalBool));
524 store.register_late_pass(|| Box::new(needless_bitwise_bool::NeedlessBitwiseBool));
525 store.register_late_pass(|| Box::new(eq_op::EqOp));
526 store.register_late_pass(|| Box::new(enum_clike::UnportableVariant));
527 store.register_late_pass(|| Box::new(float_literal::FloatLiteral));
528 let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
529 store.register_late_pass(move || Box::new(bit_mask::BitMask::new(verbose_bit_mask_threshold)));
530 store.register_late_pass(|| Box::new(ptr::Ptr));
531 store.register_late_pass(|| Box::new(ptr_eq::PtrEq));
532 store.register_late_pass(|| Box::new(needless_bool::NeedlessBool));
533 store.register_late_pass(|| Box::new(needless_option_as_deref::OptionNeedlessDeref));
534 store.register_late_pass(|| Box::new(needless_bool::BoolComparison));
535 store.register_late_pass(|| Box::new(needless_for_each::NeedlessForEach));
536 store.register_late_pass(|| Box::new(misc::MiscLints));
537 store.register_late_pass(|| Box::new(eta_reduction::EtaReduction));
538 store.register_late_pass(|| Box::new(identity_op::IdentityOp));
539 store.register_late_pass(|| Box::new(erasing_op::ErasingOp));
540 store.register_late_pass(|| Box::new(mut_mut::MutMut));
541 store.register_late_pass(|| Box::new(mut_reference::UnnecessaryMutPassed));
542 store.register_late_pass(|| Box::new(len_zero::LenZero));
543 store.register_late_pass(|| Box::new(attrs::Attributes));
544 store.register_late_pass(|| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
545 store.register_late_pass(|| Box::new(collapsible_match::CollapsibleMatch));
546 store.register_late_pass(|| Box::new(unicode::Unicode));
547 store.register_late_pass(|| Box::new(uninit_vec::UninitVec));
548 store.register_late_pass(|| Box::new(unit_hash::UnitHash));
549 store.register_late_pass(|| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
550 store.register_late_pass(|| Box::new(strings::StringAdd));
551 store.register_late_pass(|| Box::new(implicit_return::ImplicitReturn));
552 store.register_late_pass(|| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
553 store.register_late_pass(|| Box::new(default_numeric_fallback::DefaultNumericFallback));
554 store.register_late_pass(|| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
555 store.register_late_pass(|| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
556 store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
558 let msrv = conf.msrv.as_ref().and_then(|s| {
559 parse_msrv(s, None, None).or_else(|| {
561 "error reading Clippy's configuration file. `{}` is not a valid Rust version",
568 let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
569 store.register_late_pass(move || Box::new(approx_const::ApproxConstant::new(msrv)));
570 store.register_late_pass(move || Box::new(methods::Methods::new(avoid_breaking_exported_api, msrv)));
571 store.register_late_pass(move || Box::new(matches::Matches::new(msrv)));
572 store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustive::new(msrv)));
573 store.register_late_pass(move || Box::new(manual_strip::ManualStrip::new(msrv)));
574 store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv)));
575 store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv)));
576 store.register_late_pass(move || Box::new(checked_conversions::CheckedConversions::new(msrv)));
577 store.register_late_pass(move || Box::new(mem_replace::MemReplace::new(msrv)));
578 store.register_late_pass(move || Box::new(ranges::Ranges::new(msrv)));
579 store.register_late_pass(move || Box::new(from_over_into::FromOverInto::new(msrv)));
580 store.register_late_pass(move || Box::new(use_self::UseSelf::new(msrv)));
581 store.register_late_pass(move || Box::new(missing_const_for_fn::MissingConstForFn::new(msrv)));
582 store.register_late_pass(move || Box::new(needless_question_mark::NeedlessQuestionMark));
583 store.register_late_pass(move || Box::new(casts::Casts::new(msrv)));
584 store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv)));
585 store.register_late_pass(move || Box::new(map_clone::MapClone::new(msrv)));
587 store.register_late_pass(|| Box::new(size_of_in_element_count::SizeOfInElementCount));
588 store.register_late_pass(|| Box::new(same_name_method::SameNameMethod));
589 let max_suggested_slice_pattern_length = conf.max_suggested_slice_pattern_length;
590 store.register_late_pass(move || {
591 Box::new(index_refutable_slice::IndexRefutableSlice::new(
592 max_suggested_slice_pattern_length,
596 store.register_late_pass(|| Box::new(map_err_ignore::MapErrIgnore));
597 store.register_late_pass(|| Box::new(shadow::Shadow::default()));
598 store.register_late_pass(|| Box::new(unit_types::UnitTypes));
599 store.register_late_pass(|| Box::new(loops::Loops));
600 store.register_late_pass(|| Box::new(main_recursion::MainRecursion::default()));
601 store.register_late_pass(|| Box::new(lifetimes::Lifetimes));
602 store.register_late_pass(|| Box::new(entry::HashMapPass));
603 store.register_late_pass(|| Box::new(minmax::MinMaxPass));
604 store.register_late_pass(|| Box::new(open_options::OpenOptions));
605 store.register_late_pass(|| Box::new(zero_div_zero::ZeroDiv));
606 store.register_late_pass(|| Box::new(mutex_atomic::Mutex));
607 store.register_late_pass(|| Box::new(needless_update::NeedlessUpdate));
608 store.register_late_pass(|| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
609 store.register_late_pass(|| Box::new(no_effect::NoEffect));
610 store.register_late_pass(|| Box::new(temporary_assignment::TemporaryAssignment));
611 store.register_late_pass(|| Box::new(transmute::Transmute));
612 let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
613 store.register_late_pass(move || {
614 Box::new(cognitive_complexity::CognitiveComplexity::new(
615 cognitive_complexity_threshold,
618 let too_large_for_stack = conf.too_large_for_stack;
619 store.register_late_pass(move || Box::new(escape::BoxedLocal { too_large_for_stack }));
620 store.register_late_pass(move || Box::new(vec::UselessVec { too_large_for_stack }));
621 store.register_late_pass(|| Box::new(panic_unimplemented::PanicUnimplemented));
622 store.register_late_pass(|| Box::new(strings::StringLitAsBytes));
623 store.register_late_pass(|| Box::new(derive::Derive));
624 store.register_late_pass(|| Box::new(derivable_impls::DerivableImpls));
625 store.register_late_pass(|| Box::new(get_last_with_len::GetLastWithLen));
626 store.register_late_pass(|| Box::new(drop_forget_ref::DropForgetRef));
627 store.register_late_pass(|| Box::new(empty_enum::EmptyEnum));
628 store.register_late_pass(|| Box::new(absurd_extreme_comparisons::AbsurdExtremeComparisons));
629 store.register_late_pass(|| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
630 store.register_late_pass(|| Box::new(regex::Regex));
631 store.register_late_pass(|| Box::new(copies::CopyAndPaste));
632 store.register_late_pass(|| Box::new(copy_iterator::CopyIterator));
633 store.register_late_pass(|| Box::new(format::UselessFormat));
634 store.register_late_pass(|| Box::new(swap::Swap));
635 store.register_late_pass(|| Box::new(overflow_check_conditional::OverflowCheckConditional));
636 store.register_late_pass(|| Box::new(new_without_default::NewWithoutDefault::default()));
637 let blacklisted_names = conf.blacklisted_names.iter().cloned().collect::<FxHashSet<_>>();
638 store.register_late_pass(move || Box::new(blacklisted_name::BlacklistedName::new(blacklisted_names.clone())));
639 let too_many_arguments_threshold = conf.too_many_arguments_threshold;
640 let too_many_lines_threshold = conf.too_many_lines_threshold;
641 store.register_late_pass(move || {
642 Box::new(functions::Functions::new(
643 too_many_arguments_threshold,
644 too_many_lines_threshold,
647 let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
648 store.register_late_pass(move || Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
649 store.register_late_pass(|| Box::new(neg_multiply::NegMultiply));
650 store.register_late_pass(|| Box::new(mem_forget::MemForget));
651 store.register_late_pass(|| Box::new(arithmetic::Arithmetic::default()));
652 store.register_late_pass(|| Box::new(assign_ops::AssignOps));
653 store.register_late_pass(|| Box::new(let_if_seq::LetIfSeq));
654 store.register_late_pass(|| Box::new(eval_order_dependence::EvalOrderDependence));
655 store.register_late_pass(|| Box::new(missing_doc::MissingDoc::new()));
656 store.register_late_pass(|| Box::new(missing_inline::MissingInline));
657 store.register_late_pass(move || Box::new(exhaustive_items::ExhaustiveItems));
658 store.register_late_pass(|| Box::new(match_result_ok::MatchResultOk));
659 store.register_late_pass(|| Box::new(partialeq_ne_impl::PartialEqNeImpl));
660 store.register_late_pass(|| Box::new(unused_io_amount::UnusedIoAmount));
661 let enum_variant_size_threshold = conf.enum_variant_size_threshold;
662 store.register_late_pass(move || Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
663 store.register_late_pass(|| Box::new(explicit_write::ExplicitWrite));
664 store.register_late_pass(|| Box::new(needless_pass_by_value::NeedlessPassByValue));
665 let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
666 conf.trivial_copy_size_limit,
667 conf.pass_by_value_size_limit,
668 conf.avoid_breaking_exported_api,
671 store.register_late_pass(move || Box::new(pass_by_ref_or_value));
672 store.register_late_pass(|| Box::new(ref_option_ref::RefOptionRef));
673 store.register_late_pass(|| Box::new(try_err::TryErr));
674 store.register_late_pass(|| Box::new(bytecount::ByteCount));
675 store.register_late_pass(|| Box::new(infinite_iter::InfiniteIter));
676 store.register_late_pass(|| Box::new(inline_fn_without_body::InlineFnWithoutBody));
677 store.register_late_pass(|| Box::new(useless_conversion::UselessConversion::default()));
678 store.register_late_pass(|| Box::new(implicit_hasher::ImplicitHasher));
679 store.register_late_pass(|| Box::new(fallible_impl_from::FallibleImplFrom));
680 store.register_late_pass(|| Box::new(double_comparison::DoubleComparisons));
681 store.register_late_pass(|| Box::new(question_mark::QuestionMark));
682 store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
683 store.register_late_pass(|| Box::new(suspicious_trait_impl::SuspiciousImpl));
684 store.register_late_pass(|| Box::new(map_unit_fn::MapUnit));
685 store.register_late_pass(|| Box::new(inherent_impl::MultipleInherentImpl));
686 store.register_late_pass(|| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
687 store.register_late_pass(|| Box::new(unwrap::Unwrap));
688 store.register_late_pass(|| Box::new(duration_subsec::DurationSubsec));
689 store.register_late_pass(|| Box::new(indexing_slicing::IndexingSlicing));
690 store.register_late_pass(|| Box::new(non_copy_const::NonCopyConst));
691 store.register_late_pass(|| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
692 store.register_late_pass(|| Box::new(redundant_clone::RedundantClone));
693 store.register_late_pass(|| Box::new(slow_vector_initialization::SlowVectorInit));
694 store.register_late_pass(|| Box::new(unnecessary_sort_by::UnnecessarySortBy));
695 store.register_late_pass(move || Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
696 store.register_late_pass(|| Box::new(assertions_on_constants::AssertionsOnConstants));
697 store.register_late_pass(|| Box::new(transmuting_null::TransmutingNull));
698 store.register_late_pass(|| Box::new(path_buf_push_overwrite::PathBufPushOverwrite));
699 store.register_late_pass(|| Box::new(integer_division::IntegerDivision));
700 store.register_late_pass(|| Box::new(inherent_to_string::InherentToString));
701 let max_trait_bounds = conf.max_trait_bounds;
702 store.register_late_pass(move || Box::new(trait_bounds::TraitBounds::new(max_trait_bounds)));
703 store.register_late_pass(|| Box::new(comparison_chain::ComparisonChain));
704 store.register_late_pass(|| Box::new(mut_key::MutableKeyType));
705 store.register_late_pass(|| Box::new(modulo_arithmetic::ModuloArithmetic));
706 store.register_early_pass(|| Box::new(reference::DerefAddrOf));
707 store.register_early_pass(|| Box::new(double_parens::DoubleParens));
708 store.register_late_pass(|| Box::new(format_impl::FormatImpl::new()));
709 store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
710 store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
711 store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
712 store.register_early_pass(|| Box::new(formatting::Formatting));
713 store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
714 store.register_early_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
715 store.register_late_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
716 store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
717 store.register_late_pass(|| Box::new(returns::Return));
718 store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
719 store.register_early_pass(|| Box::new(items_after_statements::ItemsAfterStatements));
720 store.register_early_pass(|| Box::new(precedence::Precedence));
721 store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
722 store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
723 store.register_late_pass(|| Box::new(create_dir::CreateDir));
724 store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
725 let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
726 store.register_early_pass(move || {
727 Box::new(literal_representation::LiteralDigitGrouping::new(
728 literal_representation_lint_fraction_readability,
731 let literal_representation_threshold = conf.literal_representation_threshold;
732 store.register_early_pass(move || {
733 Box::new(literal_representation::DecimalLiteralRepresentation::new(
734 literal_representation_threshold,
737 let enum_variant_name_threshold = conf.enum_variant_name_threshold;
738 store.register_late_pass(move || {
739 Box::new(enum_variants::EnumVariantNames::new(
740 enum_variant_name_threshold,
741 avoid_breaking_exported_api,
744 store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
745 let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
746 store.register_late_pass(move || {
747 Box::new(upper_case_acronyms::UpperCaseAcronyms::new(
748 avoid_breaking_exported_api,
749 upper_case_acronyms_aggressive,
752 store.register_late_pass(|| Box::new(default::Default::default()));
753 store.register_late_pass(|| Box::new(unused_self::UnusedSelf));
754 store.register_late_pass(|| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
755 store.register_late_pass(|| Box::new(exit::Exit));
756 store.register_late_pass(|| Box::new(to_digit_is_some::ToDigitIsSome));
757 let array_size_threshold = conf.array_size_threshold;
758 store.register_late_pass(move || Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
759 store.register_late_pass(move || Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
760 store.register_late_pass(|| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
761 store.register_early_pass(|| Box::new(as_conversions::AsConversions));
762 store.register_late_pass(|| Box::new(let_underscore::LetUnderscore));
763 store.register_early_pass(|| Box::new(single_component_path_imports::SingleComponentPathImports));
764 let max_fn_params_bools = conf.max_fn_params_bools;
765 let max_struct_bools = conf.max_struct_bools;
766 store.register_early_pass(move || {
767 Box::new(excessive_bools::ExcessiveBools::new(
772 store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
773 let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
774 store.register_late_pass(move || Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
775 store.register_late_pass(|| Box::new(verbose_file_reads::VerboseFileReads));
776 store.register_late_pass(|| Box::new(redundant_pub_crate::RedundantPubCrate::default()));
777 store.register_late_pass(|| Box::new(unnamed_address::UnnamedAddress));
778 store.register_late_pass(|| Box::new(dereference::Dereferencing::default()));
779 store.register_late_pass(|| Box::new(option_if_let_else::OptionIfLetElse));
780 store.register_late_pass(|| Box::new(future_not_send::FutureNotSend));
781 store.register_late_pass(|| Box::new(if_let_mutex::IfLetMutex));
782 store.register_late_pass(|| Box::new(if_not_else::IfNotElse));
783 store.register_late_pass(|| Box::new(equatable_if_let::PatternEquality));
784 store.register_late_pass(|| Box::new(mut_mutex_lock::MutMutexLock));
785 store.register_late_pass(|| Box::new(match_on_vec_items::MatchOnVecItems));
786 store.register_late_pass(|| Box::new(manual_async_fn::ManualAsyncFn));
787 store.register_late_pass(|| Box::new(vec_resize_to_zero::VecResizeToZero));
788 store.register_late_pass(|| Box::new(panic_in_result_fn::PanicInResultFn));
789 let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
790 store.register_early_pass(move || {
791 Box::new(non_expressive_names::NonExpressiveNames {
792 single_char_binding_names_threshold,
795 let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
796 store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(¯o_matcher)));
797 store.register_late_pass(|| Box::new(macro_use::MacroUseImports::default()));
798 store.register_late_pass(|| Box::new(pattern_type_mismatch::PatternTypeMismatch));
799 store.register_late_pass(|| Box::new(stable_sort_primitive::StableSortPrimitive));
800 store.register_late_pass(|| Box::new(repeat_once::RepeatOnce));
801 store.register_late_pass(|| Box::new(unwrap_in_result::UnwrapInResult));
802 store.register_late_pass(|| Box::new(self_assignment::SelfAssignment));
803 store.register_late_pass(|| Box::new(manual_unwrap_or::ManualUnwrapOr));
804 store.register_late_pass(|| Box::new(manual_ok_or::ManualOkOr));
805 store.register_late_pass(|| Box::new(float_equality_without_abs::FloatEqualityWithoutAbs));
806 store.register_late_pass(|| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
807 store.register_late_pass(|| Box::new(async_yields_async::AsyncYieldsAsync));
808 let disallowed_methods = conf.disallowed_methods.clone();
809 store.register_late_pass(move || Box::new(disallowed_methods::DisallowedMethods::new(disallowed_methods.clone())));
810 store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
811 store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
812 store.register_late_pass(|| Box::new(undropped_manually_drops::UndroppedManuallyDrops));
813 store.register_late_pass(|| Box::new(strings::StrToString));
814 store.register_late_pass(|| Box::new(strings::StringToString));
815 store.register_late_pass(|| Box::new(zero_sized_map_values::ZeroSizedMapValues));
816 store.register_late_pass(|| Box::new(vec_init_then_push::VecInitThenPush::default()));
817 store.register_late_pass(|| {
818 Box::new(case_sensitive_file_extension_comparisons::CaseSensitiveFileExtensionComparisons)
820 store.register_late_pass(|| Box::new(redundant_slicing::RedundantSlicing));
821 store.register_late_pass(|| Box::new(from_str_radix_10::FromStrRadix10));
822 store.register_late_pass(|| Box::new(manual_map::ManualMap));
823 store.register_late_pass(move || Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv)));
824 store.register_late_pass(|| Box::new(bool_assert_comparison::BoolAssertComparison));
825 store.register_early_pass(move || Box::new(module_style::ModStyle));
826 store.register_late_pass(|| Box::new(unused_async::UnusedAsync));
827 let disallowed_types = conf.disallowed_types.clone();
828 store.register_late_pass(move || Box::new(disallowed_types::DisallowedTypes::new(disallowed_types.clone())));
829 let import_renames = conf.enforced_import_renames.clone();
830 store.register_late_pass(move || {
831 Box::new(missing_enforced_import_rename::ImportRename::new(
832 import_renames.clone(),
835 let scripts = conf.allowed_scripts.clone();
836 store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
837 store.register_late_pass(|| Box::new(strlen_on_c_strings::StrlenOnCStrings));
838 store.register_late_pass(move || Box::new(self_named_constructors::SelfNamedConstructors));
839 store.register_late_pass(move || Box::new(iter_not_returning_iterator::IterNotReturningIterator));
840 store.register_late_pass(move || Box::new(manual_assert::ManualAssert));
841 let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
842 store.register_late_pass(move || {
843 Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(
844 enable_raw_pointer_heuristic_for_send,
847 store.register_late_pass(move || Box::new(undocumented_unsafe_blocks::UndocumentedUnsafeBlocks::default()));
848 store.register_late_pass(|| Box::new(match_str_case_mismatch::MatchStrCaseMismatch));
849 store.register_late_pass(move || Box::new(format_args::FormatArgs));
850 store.register_late_pass(|| Box::new(trailing_empty_array::TrailingEmptyArray));
851 store.register_early_pass(|| Box::new(octal_escapes::OctalEscapes));
852 store.register_late_pass(|| Box::new(needless_late_init::NeedlessLateInit));
853 store.register_late_pass(|| Box::new(return_self_not_must_use::ReturnSelfNotMustUse));
854 store.register_late_pass(|| Box::new(init_numbered_fields::NumberedFields));
855 store.register_early_pass(|| Box::new(single_char_lifetime_names::SingleCharLifetimeNames));
856 store.register_late_pass(move || Box::new(borrow_as_ptr::BorrowAsPtr::new(msrv)));
857 store.register_late_pass(move || Box::new(manual_bits::ManualBits::new(msrv)));
858 store.register_late_pass(|| Box::new(default_union_representation::DefaultUnionRepresentation));
859 store.register_late_pass(|| Box::new(dbg_macro::DbgMacro));
860 let cargo_ignore_publish = conf.cargo_ignore_publish;
861 store.register_late_pass(move || {
862 Box::new(cargo::Cargo {
863 ignore_publish: cargo_ignore_publish,
866 // add lints here, do not remove this comment, it's used in `new_lint`
870 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
871 store.register_removed(
873 "`assert!()` will be more flexible with RFC 2011",
875 store.register_removed(
877 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
879 store.register_removed(
880 "range_step_by_zero",
881 "`iterator.step_by(0)` panics nowadays",
883 store.register_removed(
885 "`Vec::as_slice` has been stabilized in 1.7",
887 store.register_removed(
888 "unstable_as_mut_slice",
889 "`Vec::as_mut_slice` has been stabilized in 1.7",
891 store.register_removed(
892 "misaligned_transmute",
893 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
895 store.register_removed(
897 "using compound assignment operators (e.g., `+=`) is harmless",
899 store.register_removed(
900 "if_let_redundant_pattern_matching",
901 "this lint has been changed to redundant_pattern_matching",
903 store.register_removed(
904 "unsafe_vector_initialization",
905 "the replacement suggested by this lint had substantially different behavior",
907 store.register_removed(
908 "reverse_range_loop",
909 "this lint is now included in reversed_empty_ranges",
913 /// Register renamed lints.
915 /// Used in `./src/driver.rs`.
916 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
917 // NOTE: when renaming a lint, add a corresponding test to tests/ui/rename.rs
918 ls.register_renamed("clippy::stutter", "clippy::module_name_repetitions");
919 ls.register_renamed("clippy::new_without_default_derive", "clippy::new_without_default");
920 ls.register_renamed("clippy::cyclomatic_complexity", "clippy::cognitive_complexity");
921 ls.register_renamed("clippy::const_static_lifetime", "clippy::redundant_static_lifetimes");
922 ls.register_renamed("clippy::option_and_then_some", "clippy::bind_instead_of_map");
923 ls.register_renamed("clippy::box_vec", "clippy::box_collection");
924 ls.register_renamed("clippy::block_in_if_condition_expr", "clippy::blocks_in_if_conditions");
925 ls.register_renamed("clippy::block_in_if_condition_stmt", "clippy::blocks_in_if_conditions");
926 ls.register_renamed("clippy::option_map_unwrap_or", "clippy::map_unwrap_or");
927 ls.register_renamed("clippy::option_map_unwrap_or_else", "clippy::map_unwrap_or");
928 ls.register_renamed("clippy::result_map_unwrap_or_else", "clippy::map_unwrap_or");
929 ls.register_renamed("clippy::option_unwrap_used", "clippy::unwrap_used");
930 ls.register_renamed("clippy::result_unwrap_used", "clippy::unwrap_used");
931 ls.register_renamed("clippy::option_expect_used", "clippy::expect_used");
932 ls.register_renamed("clippy::result_expect_used", "clippy::expect_used");
933 ls.register_renamed("clippy::for_loop_over_option", "clippy::for_loops_over_fallibles");
934 ls.register_renamed("clippy::for_loop_over_result", "clippy::for_loops_over_fallibles");
935 ls.register_renamed("clippy::identity_conversion", "clippy::useless_conversion");
936 ls.register_renamed("clippy::zero_width_space", "clippy::invisible_characters");
937 ls.register_renamed("clippy::single_char_push_str", "clippy::single_char_add_str");
938 ls.register_renamed("clippy::if_let_some_result", "clippy::match_result_ok");
939 ls.register_renamed("clippy::disallowed_type", "clippy::disallowed_types");
940 ls.register_renamed("clippy::disallowed_method", "clippy::disallowed_methods");
941 ls.register_renamed("clippy::ref_in_deref", "clippy::needless_borrow");
942 ls.register_renamed("clippy::to_string_in_display", "clippy::recursive_format_impl");
945 ls.register_renamed("clippy::invalid_ref", "invalid_value");
946 ls.register_renamed("clippy::into_iter_on_array", "array_into_iter");
947 ls.register_renamed("clippy::unused_label", "unused_labels");
948 ls.register_renamed("clippy::drop_bounds", "drop_bounds");
949 ls.register_renamed("clippy::temporary_cstring_as_ptr", "temporary_cstring_as_ptr");
950 ls.register_renamed("clippy::panic_params", "non_fmt_panics");
951 ls.register_renamed("clippy::unknown_clippy_lints", "unknown_lints");
952 ls.register_renamed("clippy::invalid_atomic_ordering", "invalid_atomic_ordering");
953 ls.register_renamed("clippy::mem_discriminant_non_enum", "enum_intrinsics_non_enums");
956 // only exists to let the dogfood integration test works.
957 // Don't run clippy as an executable directly
960 panic!("Please use the cargo-clippy executable");