]> git.lizzy.rs Git - rust.git/blob - clippy_lints/src/lib.rs
Auto merge of #92252 - GuillaumeGomez:update-pulldown, r=camelid,xFrednet
[rust.git] / clippy_lints / src / lib.rs
1 // error-pattern:cargo-clippy
2
3 #![feature(binary_heap_into_iter_sorted)]
4 #![feature(box_patterns)]
5 #![feature(control_flow_enum)]
6 #![feature(drain_filter)]
7 #![feature(in_band_lifetimes)]
8 #![feature(iter_intersperse)]
9 #![feature(let_else)]
10 #![feature(once_cell)]
11 #![feature(rustc_private)]
12 #![feature(stmt_expr_attributes)]
13 #![recursion_limit = "512"]
14 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
15 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
16 #![warn(trivial_casts, trivial_numeric_casts)]
17 // warn on lints, that are included in `rust-lang/rust`s bootstrap
18 #![warn(rust_2018_idioms, unused_lifetimes)]
19 // warn on rustc internal lints
20 #![warn(rustc::internal)]
21
22 // FIXME: switch to something more ergonomic here, once available.
23 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
24 extern crate rustc_ast;
25 extern crate rustc_ast_pretty;
26 extern crate rustc_data_structures;
27 extern crate rustc_driver;
28 extern crate rustc_errors;
29 extern crate rustc_hir;
30 extern crate rustc_hir_pretty;
31 extern crate rustc_index;
32 extern crate rustc_infer;
33 extern crate rustc_lexer;
34 extern crate rustc_lint;
35 extern crate rustc_middle;
36 extern crate rustc_mir_dataflow;
37 extern crate rustc_parse;
38 extern crate rustc_parse_format;
39 extern crate rustc_session;
40 extern crate rustc_span;
41 extern crate rustc_target;
42 extern crate rustc_trait_selection;
43 extern crate rustc_typeck;
44
45 #[macro_use]
46 extern crate clippy_utils;
47
48 use clippy_utils::parse_msrv;
49 use rustc_data_structures::fx::FxHashSet;
50 use rustc_lint::LintId;
51 use rustc_session::Session;
52
53 /// Macro used to declare a Clippy lint.
54 ///
55 /// Every lint declaration consists of 4 parts:
56 ///
57 /// 1. The documentation, which is used for the website
58 /// 2. The `LINT_NAME`. See [lint naming][lint_naming] on lint naming conventions.
59 /// 3. The `lint_level`, which is a mapping from *one* of our lint groups to `Allow`, `Warn` or
60 ///    `Deny`. The lint level here has nothing to do with what lint groups the lint is a part of.
61 /// 4. The `description` that contains a short explanation on what's wrong with code where the
62 ///    lint is triggered.
63 ///
64 /// Currently the categories `style`, `correctness`, `suspicious`, `complexity` and `perf` are
65 /// enabled by default. As said in the README.md of this repository, if the lint level mapping
66 /// changes, please update README.md.
67 ///
68 /// # Example
69 ///
70 /// ```
71 /// #![feature(rustc_private)]
72 /// extern crate rustc_session;
73 /// use rustc_session::declare_tool_lint;
74 /// use clippy_lints::declare_clippy_lint;
75 ///
76 /// declare_clippy_lint! {
77 ///     /// ### What it does
78 ///     /// Checks for ... (describe what the lint matches).
79 ///     ///
80 ///     /// ### Why is this bad?
81 ///     /// Supply the reason for linting the code.
82 ///     ///
83 ///     /// ### Example
84 ///     /// ```rust
85 ///     /// // Bad
86 ///     /// Insert a short example of code that triggers the lint
87 ///     ///
88 ///     /// // Good
89 ///     /// Insert a short example of improved code that doesn't trigger the lint
90 ///     /// ```
91 ///     pub LINT_NAME,
92 ///     pedantic,
93 ///     "description"
94 /// }
95 /// ```
96 /// [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
97 #[macro_export]
98 macro_rules! declare_clippy_lint {
99     { $(#[$attr:meta])* pub $name:tt, style, $description:tt } => {
100         declare_tool_lint! {
101             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
102         }
103     };
104     { $(#[$attr:meta])* pub $name:tt, correctness, $description:tt } => {
105         declare_tool_lint! {
106             $(#[$attr])* pub clippy::$name, Deny, $description, report_in_external_macro: true
107         }
108     };
109     { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
110         declare_tool_lint! {
111             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
112         }
113     };
114     { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
115         declare_tool_lint! {
116             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
117         }
118     };
119     { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
120         declare_tool_lint! {
121             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
122         }
123     };
124     { $(#[$attr:meta])* pub $name:tt, pedantic, $description:tt } => {
125         declare_tool_lint! {
126             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
127         }
128     };
129     { $(#[$attr:meta])* pub $name:tt, restriction, $description:tt } => {
130         declare_tool_lint! {
131             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
132         }
133     };
134     { $(#[$attr:meta])* pub $name:tt, cargo, $description:tt } => {
135         declare_tool_lint! {
136             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
137         }
138     };
139     { $(#[$attr:meta])* pub $name:tt, nursery, $description:tt } => {
140         declare_tool_lint! {
141             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
142         }
143     };
144     { $(#[$attr:meta])* pub $name:tt, internal, $description:tt } => {
145         declare_tool_lint! {
146             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
147         }
148     };
149     { $(#[$attr:meta])* pub $name:tt, internal_warn, $description:tt } => {
150         declare_tool_lint! {
151             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
152         }
153     };
154 }
155
156 #[cfg(feature = "metadata-collector-lint")]
157 mod deprecated_lints;
158 #[cfg_attr(
159     any(feature = "internal-lints", feature = "metadata-collector-lint"),
160     allow(clippy::missing_clippy_version_attribute)
161 )]
162 mod utils;
163
164 // begin lints modules, do not remove this comment, it’s used in `update_lints`
165 mod absurd_extreme_comparisons;
166 mod approx_const;
167 mod arithmetic;
168 mod as_conversions;
169 mod asm_syntax;
170 mod assertions_on_constants;
171 mod assign_ops;
172 mod async_yields_async;
173 mod attrs;
174 mod await_holding_invalid;
175 mod bit_mask;
176 mod blacklisted_name;
177 mod blocks_in_if_conditions;
178 mod bool_assert_comparison;
179 mod booleans;
180 mod bytecount;
181 mod cargo_common_metadata;
182 mod case_sensitive_file_extension_comparisons;
183 mod casts;
184 mod checked_conversions;
185 mod cognitive_complexity;
186 mod collapsible_if;
187 mod collapsible_match;
188 mod comparison_chain;
189 mod copies;
190 mod copy_iterator;
191 mod create_dir;
192 mod dbg_macro;
193 mod default;
194 mod default_numeric_fallback;
195 mod dereference;
196 mod derivable_impls;
197 mod derive;
198 mod disallowed_methods;
199 mod disallowed_script_idents;
200 mod disallowed_types;
201 mod doc;
202 mod double_comparison;
203 mod double_parens;
204 mod drop_forget_ref;
205 mod duration_subsec;
206 mod else_if_without_else;
207 mod empty_enum;
208 mod entry;
209 mod enum_clike;
210 mod enum_variants;
211 mod eq_op;
212 mod equatable_if_let;
213 mod erasing_op;
214 mod escape;
215 mod eta_reduction;
216 mod eval_order_dependence;
217 mod excessive_bools;
218 mod exhaustive_items;
219 mod exit;
220 mod explicit_write;
221 mod fallible_impl_from;
222 mod feature_name;
223 mod float_equality_without_abs;
224 mod float_literal;
225 mod floating_point_arithmetic;
226 mod format;
227 mod format_args;
228 mod formatting;
229 mod from_over_into;
230 mod from_str_radix_10;
231 mod functions;
232 mod future_not_send;
233 mod get_last_with_len;
234 mod identity_op;
235 mod if_let_mutex;
236 mod if_not_else;
237 mod if_then_some_else_none;
238 mod implicit_hasher;
239 mod implicit_return;
240 mod implicit_saturating_sub;
241 mod inconsistent_struct_constructor;
242 mod index_refutable_slice;
243 mod indexing_slicing;
244 mod infinite_iter;
245 mod inherent_impl;
246 mod inherent_to_string;
247 mod init_numbered_fields;
248 mod inline_fn_without_body;
249 mod int_plus_one;
250 mod integer_division;
251 mod invalid_upcast_comparisons;
252 mod items_after_statements;
253 mod iter_not_returning_iterator;
254 mod large_const_arrays;
255 mod large_enum_variant;
256 mod large_stack_arrays;
257 mod len_zero;
258 mod let_if_seq;
259 mod let_underscore;
260 mod lifetimes;
261 mod literal_representation;
262 mod loops;
263 mod macro_use;
264 mod main_recursion;
265 mod manual_assert;
266 mod manual_async_fn;
267 mod manual_map;
268 mod manual_non_exhaustive;
269 mod manual_ok_or;
270 mod manual_strip;
271 mod manual_unwrap_or;
272 mod map_clone;
273 mod map_err_ignore;
274 mod map_unit_fn;
275 mod match_on_vec_items;
276 mod match_result_ok;
277 mod match_str_case_mismatch;
278 mod matches;
279 mod mem_forget;
280 mod mem_replace;
281 mod methods;
282 mod minmax;
283 mod misc;
284 mod misc_early;
285 mod missing_const_for_fn;
286 mod missing_doc;
287 mod missing_enforced_import_rename;
288 mod missing_inline;
289 mod module_style;
290 mod modulo_arithmetic;
291 mod multiple_crate_versions;
292 mod mut_key;
293 mod mut_mut;
294 mod mut_mutex_lock;
295 mod mut_reference;
296 mod mutable_debug_assertion;
297 mod mutex_atomic;
298 mod needless_arbitrary_self_type;
299 mod needless_bitwise_bool;
300 mod needless_bool;
301 mod needless_borrowed_ref;
302 mod needless_continue;
303 mod needless_for_each;
304 mod needless_late_init;
305 mod needless_option_as_deref;
306 mod needless_pass_by_value;
307 mod needless_question_mark;
308 mod needless_update;
309 mod neg_cmp_op_on_partial_ord;
310 mod neg_multiply;
311 mod new_without_default;
312 mod no_effect;
313 mod non_copy_const;
314 mod non_expressive_names;
315 mod non_octal_unix_permissions;
316 mod non_send_fields_in_send_ty;
317 mod nonstandard_macro_braces;
318 mod octal_escapes;
319 mod open_options;
320 mod option_env_unwrap;
321 mod option_if_let_else;
322 mod overflow_check_conditional;
323 mod panic_in_result_fn;
324 mod panic_unimplemented;
325 mod partialeq_ne_impl;
326 mod pass_by_ref_or_value;
327 mod path_buf_push_overwrite;
328 mod pattern_type_mismatch;
329 mod precedence;
330 mod ptr;
331 mod ptr_eq;
332 mod ptr_offset_with_cast;
333 mod question_mark;
334 mod ranges;
335 mod redundant_clone;
336 mod redundant_closure_call;
337 mod redundant_else;
338 mod redundant_field_names;
339 mod redundant_pub_crate;
340 mod redundant_slicing;
341 mod redundant_static_lifetimes;
342 mod ref_option_ref;
343 mod reference;
344 mod regex;
345 mod repeat_once;
346 mod return_self_not_must_use;
347 mod returns;
348 mod same_name_method;
349 mod self_assignment;
350 mod self_named_constructors;
351 mod semicolon_if_nothing_returned;
352 mod serde_api;
353 mod shadow;
354 mod single_component_path_imports;
355 mod size_of_in_element_count;
356 mod slow_vector_initialization;
357 mod stable_sort_primitive;
358 mod strings;
359 mod strlen_on_c_strings;
360 mod suspicious_operation_groupings;
361 mod suspicious_trait_impl;
362 mod swap;
363 mod tabs_in_doc_comments;
364 mod temporary_assignment;
365 mod to_digit_is_some;
366 mod to_string_in_display;
367 mod trailing_empty_array;
368 mod trait_bounds;
369 mod transmute;
370 mod transmuting_null;
371 mod try_err;
372 mod types;
373 mod undocumented_unsafe_blocks;
374 mod undropped_manually_drops;
375 mod unicode;
376 mod uninit_vec;
377 mod unit_hash;
378 mod unit_return_expecting_ord;
379 mod unit_types;
380 mod unnamed_address;
381 mod unnecessary_self_imports;
382 mod unnecessary_sort_by;
383 mod unnecessary_wraps;
384 mod unnested_or_patterns;
385 mod unsafe_removed_from_name;
386 mod unused_async;
387 mod unused_io_amount;
388 mod unused_self;
389 mod unused_unit;
390 mod unwrap;
391 mod unwrap_in_result;
392 mod upper_case_acronyms;
393 mod use_self;
394 mod useless_conversion;
395 mod vec;
396 mod vec_init_then_push;
397 mod vec_resize_to_zero;
398 mod verbose_file_reads;
399 mod wildcard_dependencies;
400 mod wildcard_imports;
401 mod write;
402 mod zero_div_zero;
403 mod zero_sized_map_values;
404 // end lints modules, do not remove this comment, it’s used in `update_lints`
405
406 pub use crate::utils::conf::Conf;
407 use crate::utils::conf::TryConf;
408
409 /// Register all pre expansion lints
410 ///
411 /// Pre-expansion lints run before any macro expansion has happened.
412 ///
413 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
414 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
415 ///
416 /// Used in `./src/driver.rs`.
417 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
418     // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
419
420     let msrv = conf.msrv.as_ref().and_then(|s| {
421         parse_msrv(s, None, None).or_else(|| {
422             sess.err(&format!(
423                 "error reading Clippy's configuration file. `{}` is not a valid Rust version",
424                 s
425             ));
426             None
427         })
428     });
429
430     store.register_pre_expansion_pass(|| Box::new(write::Write::default()));
431     store.register_pre_expansion_pass(move || Box::new(attrs::EarlyAttributes { msrv }));
432     store.register_pre_expansion_pass(|| Box::new(dbg_macro::DbgMacro));
433 }
434
435 #[doc(hidden)]
436 pub fn read_conf(sess: &Session) -> Conf {
437     let file_name = match utils::conf::lookup_conf_file() {
438         Ok(Some(path)) => path,
439         Ok(None) => return Conf::default(),
440         Err(error) => {
441             sess.struct_err(&format!("error finding Clippy's configuration file: {}", error))
442                 .emit();
443             return Conf::default();
444         },
445     };
446
447     let TryConf { conf, errors } = utils::conf::read(&file_name);
448     // all conf errors are non-fatal, we just use the default conf in case of error
449     for error in errors {
450         sess.struct_err(&format!(
451             "error reading Clippy's configuration file `{}`: {}",
452             file_name.display(),
453             error
454         ))
455         .emit();
456     }
457
458     conf
459 }
460
461 /// Register all lints and lint groups with the rustc plugin registry
462 ///
463 /// Used in `./src/driver.rs`.
464 #[allow(clippy::too_many_lines)]
465 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
466     register_removed_non_tool_lints(store);
467
468     include!("lib.deprecated.rs");
469
470     include!("lib.register_lints.rs");
471     include!("lib.register_restriction.rs");
472     include!("lib.register_pedantic.rs");
473
474     #[cfg(feature = "internal-lints")]
475     include!("lib.register_internal.rs");
476
477     include!("lib.register_all.rs");
478     include!("lib.register_style.rs");
479     include!("lib.register_complexity.rs");
480     include!("lib.register_correctness.rs");
481     include!("lib.register_suspicious.rs");
482     include!("lib.register_perf.rs");
483     include!("lib.register_cargo.rs");
484     include!("lib.register_nursery.rs");
485
486     #[cfg(feature = "metadata-collector-lint")]
487     {
488         if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
489             store.register_late_pass(|| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
490             return;
491         }
492     }
493
494     // all the internal lints
495     #[cfg(feature = "internal-lints")]
496     {
497         store.register_early_pass(|| Box::new(utils::internal_lints::ClippyLintsInternal));
498         store.register_early_pass(|| Box::new(utils::internal_lints::ProduceIce));
499         store.register_late_pass(|| Box::new(utils::inspector::DeepCodeInspector));
500         store.register_late_pass(|| Box::new(utils::internal_lints::CollapsibleCalls));
501         store.register_late_pass(|| Box::new(utils::internal_lints::CompilerLintFunctions::new()));
502         store.register_late_pass(|| Box::new(utils::internal_lints::IfChainStyle));
503         store.register_late_pass(|| Box::new(utils::internal_lints::InvalidPaths));
504         store.register_late_pass(|| Box::new(utils::internal_lints::InterningDefinedSymbol::default()));
505         store.register_late_pass(|| Box::new(utils::internal_lints::LintWithoutLintPass::default()));
506         store.register_late_pass(|| Box::new(utils::internal_lints::MatchTypeOnDiagItem));
507         store.register_late_pass(|| Box::new(utils::internal_lints::OuterExpnDataPass));
508     }
509
510     store.register_late_pass(|| Box::new(utils::author::Author));
511     store.register_late_pass(|| Box::new(await_holding_invalid::AwaitHolding));
512     store.register_late_pass(|| Box::new(serde_api::SerdeApi));
513     let vec_box_size_threshold = conf.vec_box_size_threshold;
514     let type_complexity_threshold = conf.type_complexity_threshold;
515     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
516     store.register_late_pass(move || {
517         Box::new(types::Types::new(
518             vec_box_size_threshold,
519             type_complexity_threshold,
520             avoid_breaking_exported_api,
521         ))
522     });
523     store.register_late_pass(|| Box::new(booleans::NonminimalBool));
524     store.register_late_pass(|| Box::new(needless_bitwise_bool::NeedlessBitwiseBool));
525     store.register_late_pass(|| Box::new(eq_op::EqOp));
526     store.register_late_pass(|| Box::new(enum_clike::UnportableVariant));
527     store.register_late_pass(|| Box::new(float_literal::FloatLiteral));
528     let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
529     store.register_late_pass(move || Box::new(bit_mask::BitMask::new(verbose_bit_mask_threshold)));
530     store.register_late_pass(|| Box::new(ptr::Ptr));
531     store.register_late_pass(|| Box::new(ptr_eq::PtrEq));
532     store.register_late_pass(|| Box::new(needless_bool::NeedlessBool));
533     store.register_late_pass(|| Box::new(needless_option_as_deref::OptionNeedlessDeref));
534     store.register_late_pass(|| Box::new(needless_bool::BoolComparison));
535     store.register_late_pass(|| Box::new(needless_for_each::NeedlessForEach));
536     store.register_late_pass(|| Box::new(misc::MiscLints));
537     store.register_late_pass(|| Box::new(eta_reduction::EtaReduction));
538     store.register_late_pass(|| Box::new(identity_op::IdentityOp));
539     store.register_late_pass(|| Box::new(erasing_op::ErasingOp));
540     store.register_late_pass(|| Box::new(mut_mut::MutMut));
541     store.register_late_pass(|| Box::new(mut_reference::UnnecessaryMutPassed));
542     store.register_late_pass(|| Box::new(len_zero::LenZero));
543     store.register_late_pass(|| Box::new(attrs::Attributes));
544     store.register_late_pass(|| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
545     store.register_late_pass(|| Box::new(collapsible_match::CollapsibleMatch));
546     store.register_late_pass(|| Box::new(unicode::Unicode));
547     store.register_late_pass(|| Box::new(uninit_vec::UninitVec));
548     store.register_late_pass(|| Box::new(unit_hash::UnitHash));
549     store.register_late_pass(|| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
550     store.register_late_pass(|| Box::new(strings::StringAdd));
551     store.register_late_pass(|| Box::new(implicit_return::ImplicitReturn));
552     store.register_late_pass(|| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
553     store.register_late_pass(|| Box::new(default_numeric_fallback::DefaultNumericFallback));
554     store.register_late_pass(|| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
555     store.register_late_pass(|| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
556     store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
557
558     let msrv = conf.msrv.as_ref().and_then(|s| {
559         parse_msrv(s, None, None).or_else(|| {
560             sess.err(&format!(
561                 "error reading Clippy's configuration file. `{}` is not a valid Rust version",
562                 s
563             ));
564             None
565         })
566     });
567
568     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
569     store.register_late_pass(move || Box::new(approx_const::ApproxConstant::new(msrv)));
570     store.register_late_pass(move || Box::new(methods::Methods::new(avoid_breaking_exported_api, msrv)));
571     store.register_late_pass(move || Box::new(matches::Matches::new(msrv)));
572     store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustive::new(msrv)));
573     store.register_late_pass(move || Box::new(manual_strip::ManualStrip::new(msrv)));
574     store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv)));
575     store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv)));
576     store.register_late_pass(move || Box::new(checked_conversions::CheckedConversions::new(msrv)));
577     store.register_late_pass(move || Box::new(mem_replace::MemReplace::new(msrv)));
578     store.register_late_pass(move || Box::new(ranges::Ranges::new(msrv)));
579     store.register_late_pass(move || Box::new(from_over_into::FromOverInto::new(msrv)));
580     store.register_late_pass(move || Box::new(use_self::UseSelf::new(msrv)));
581     store.register_late_pass(move || Box::new(missing_const_for_fn::MissingConstForFn::new(msrv)));
582     store.register_late_pass(move || Box::new(needless_question_mark::NeedlessQuestionMark));
583     store.register_late_pass(move || Box::new(casts::Casts::new(msrv)));
584     store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv)));
585
586     store.register_late_pass(|| Box::new(size_of_in_element_count::SizeOfInElementCount));
587     store.register_late_pass(|| Box::new(same_name_method::SameNameMethod));
588     let max_suggested_slice_pattern_length = conf.max_suggested_slice_pattern_length;
589     store.register_late_pass(move || {
590         Box::new(index_refutable_slice::IndexRefutableSlice::new(
591             max_suggested_slice_pattern_length,
592             msrv,
593         ))
594     });
595     store.register_late_pass(|| Box::new(map_clone::MapClone));
596     store.register_late_pass(|| Box::new(map_err_ignore::MapErrIgnore));
597     store.register_late_pass(|| Box::new(shadow::Shadow::default()));
598     store.register_late_pass(|| Box::new(unit_types::UnitTypes));
599     store.register_late_pass(|| Box::new(loops::Loops));
600     store.register_late_pass(|| Box::new(main_recursion::MainRecursion::default()));
601     store.register_late_pass(|| Box::new(lifetimes::Lifetimes));
602     store.register_late_pass(|| Box::new(entry::HashMapPass));
603     store.register_late_pass(|| Box::new(minmax::MinMaxPass));
604     store.register_late_pass(|| Box::new(open_options::OpenOptions));
605     store.register_late_pass(|| Box::new(zero_div_zero::ZeroDiv));
606     store.register_late_pass(|| Box::new(mutex_atomic::Mutex));
607     store.register_late_pass(|| Box::new(needless_update::NeedlessUpdate));
608     store.register_late_pass(|| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
609     store.register_late_pass(|| Box::new(no_effect::NoEffect));
610     store.register_late_pass(|| Box::new(temporary_assignment::TemporaryAssignment));
611     store.register_late_pass(|| Box::new(transmute::Transmute));
612     let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
613     store.register_late_pass(move || {
614         Box::new(cognitive_complexity::CognitiveComplexity::new(
615             cognitive_complexity_threshold,
616         ))
617     });
618     let too_large_for_stack = conf.too_large_for_stack;
619     store.register_late_pass(move || Box::new(escape::BoxedLocal { too_large_for_stack }));
620     store.register_late_pass(move || Box::new(vec::UselessVec { too_large_for_stack }));
621     store.register_late_pass(|| Box::new(panic_unimplemented::PanicUnimplemented));
622     store.register_late_pass(|| Box::new(strings::StringLitAsBytes));
623     store.register_late_pass(|| Box::new(derive::Derive));
624     store.register_late_pass(|| Box::new(derivable_impls::DerivableImpls));
625     store.register_late_pass(|| Box::new(get_last_with_len::GetLastWithLen));
626     store.register_late_pass(|| Box::new(drop_forget_ref::DropForgetRef));
627     store.register_late_pass(|| Box::new(empty_enum::EmptyEnum));
628     store.register_late_pass(|| Box::new(absurd_extreme_comparisons::AbsurdExtremeComparisons));
629     store.register_late_pass(|| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
630     store.register_late_pass(|| Box::new(regex::Regex));
631     store.register_late_pass(|| Box::new(copies::CopyAndPaste));
632     store.register_late_pass(|| Box::new(copy_iterator::CopyIterator));
633     store.register_late_pass(|| Box::new(format::UselessFormat));
634     store.register_late_pass(|| Box::new(swap::Swap));
635     store.register_late_pass(|| Box::new(overflow_check_conditional::OverflowCheckConditional));
636     store.register_late_pass(|| Box::new(new_without_default::NewWithoutDefault::default()));
637     let blacklisted_names = conf.blacklisted_names.iter().cloned().collect::<FxHashSet<_>>();
638     store.register_late_pass(move || Box::new(blacklisted_name::BlacklistedName::new(blacklisted_names.clone())));
639     let too_many_arguments_threshold = conf.too_many_arguments_threshold;
640     let too_many_lines_threshold = conf.too_many_lines_threshold;
641     store.register_late_pass(move || {
642         Box::new(functions::Functions::new(
643             too_many_arguments_threshold,
644             too_many_lines_threshold,
645         ))
646     });
647     let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
648     store.register_late_pass(move || Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
649     store.register_late_pass(|| Box::new(neg_multiply::NegMultiply));
650     store.register_late_pass(|| Box::new(mem_forget::MemForget));
651     store.register_late_pass(|| Box::new(arithmetic::Arithmetic::default()));
652     store.register_late_pass(|| Box::new(assign_ops::AssignOps));
653     store.register_late_pass(|| Box::new(let_if_seq::LetIfSeq));
654     store.register_late_pass(|| Box::new(eval_order_dependence::EvalOrderDependence));
655     store.register_late_pass(|| Box::new(missing_doc::MissingDoc::new()));
656     store.register_late_pass(|| Box::new(missing_inline::MissingInline));
657     store.register_late_pass(move || Box::new(exhaustive_items::ExhaustiveItems));
658     store.register_late_pass(|| Box::new(match_result_ok::MatchResultOk));
659     store.register_late_pass(|| Box::new(partialeq_ne_impl::PartialEqNeImpl));
660     store.register_late_pass(|| Box::new(unused_io_amount::UnusedIoAmount));
661     let enum_variant_size_threshold = conf.enum_variant_size_threshold;
662     store.register_late_pass(move || Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
663     store.register_late_pass(|| Box::new(explicit_write::ExplicitWrite));
664     store.register_late_pass(|| Box::new(needless_pass_by_value::NeedlessPassByValue));
665     let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
666         conf.trivial_copy_size_limit,
667         conf.pass_by_value_size_limit,
668         conf.avoid_breaking_exported_api,
669         &sess.target,
670     );
671     store.register_late_pass(move || Box::new(pass_by_ref_or_value));
672     store.register_late_pass(|| Box::new(ref_option_ref::RefOptionRef));
673     store.register_late_pass(|| Box::new(try_err::TryErr));
674     store.register_late_pass(|| Box::new(bytecount::ByteCount));
675     store.register_late_pass(|| Box::new(infinite_iter::InfiniteIter));
676     store.register_late_pass(|| Box::new(inline_fn_without_body::InlineFnWithoutBody));
677     store.register_late_pass(|| Box::new(useless_conversion::UselessConversion::default()));
678     store.register_late_pass(|| Box::new(implicit_hasher::ImplicitHasher));
679     store.register_late_pass(|| Box::new(fallible_impl_from::FallibleImplFrom));
680     store.register_late_pass(|| Box::new(double_comparison::DoubleComparisons));
681     store.register_late_pass(|| Box::new(question_mark::QuestionMark));
682     store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
683     store.register_late_pass(|| Box::new(suspicious_trait_impl::SuspiciousImpl));
684     store.register_late_pass(|| Box::new(map_unit_fn::MapUnit));
685     store.register_late_pass(|| Box::new(inherent_impl::MultipleInherentImpl));
686     store.register_late_pass(|| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
687     store.register_late_pass(|| Box::new(unwrap::Unwrap));
688     store.register_late_pass(|| Box::new(duration_subsec::DurationSubsec));
689     store.register_late_pass(|| Box::new(indexing_slicing::IndexingSlicing));
690     store.register_late_pass(|| Box::new(non_copy_const::NonCopyConst));
691     store.register_late_pass(|| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
692     store.register_late_pass(|| Box::new(redundant_clone::RedundantClone));
693     store.register_late_pass(|| Box::new(slow_vector_initialization::SlowVectorInit));
694     store.register_late_pass(|| Box::new(unnecessary_sort_by::UnnecessarySortBy));
695     store.register_late_pass(move || Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
696     store.register_late_pass(|| Box::new(assertions_on_constants::AssertionsOnConstants));
697     store.register_late_pass(|| Box::new(transmuting_null::TransmutingNull));
698     store.register_late_pass(|| Box::new(path_buf_push_overwrite::PathBufPushOverwrite));
699     store.register_late_pass(|| Box::new(integer_division::IntegerDivision));
700     store.register_late_pass(|| Box::new(inherent_to_string::InherentToString));
701     let max_trait_bounds = conf.max_trait_bounds;
702     store.register_late_pass(move || Box::new(trait_bounds::TraitBounds::new(max_trait_bounds)));
703     store.register_late_pass(|| Box::new(comparison_chain::ComparisonChain));
704     store.register_late_pass(|| Box::new(mut_key::MutableKeyType));
705     store.register_late_pass(|| Box::new(modulo_arithmetic::ModuloArithmetic));
706     store.register_early_pass(|| Box::new(reference::DerefAddrOf));
707     store.register_early_pass(|| Box::new(reference::RefInDeref));
708     store.register_early_pass(|| Box::new(double_parens::DoubleParens));
709     store.register_late_pass(|| Box::new(to_string_in_display::ToStringInDisplay::new()));
710     store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
711     store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
712     store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
713     store.register_early_pass(|| Box::new(formatting::Formatting));
714     store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
715     store.register_early_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
716     store.register_late_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
717     store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
718     store.register_late_pass(|| Box::new(returns::Return));
719     store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
720     store.register_early_pass(|| Box::new(items_after_statements::ItemsAfterStatements));
721     store.register_early_pass(|| Box::new(precedence::Precedence));
722     store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
723     store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
724     store.register_late_pass(|| Box::new(create_dir::CreateDir));
725     store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
726     let cargo_ignore_publish = conf.cargo_ignore_publish;
727     store.register_late_pass(move || Box::new(cargo_common_metadata::CargoCommonMetadata::new(cargo_ignore_publish)));
728     store.register_late_pass(|| Box::new(multiple_crate_versions::MultipleCrateVersions));
729     store.register_late_pass(|| Box::new(wildcard_dependencies::WildcardDependencies));
730     let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
731     store.register_early_pass(move || {
732         Box::new(literal_representation::LiteralDigitGrouping::new(
733             literal_representation_lint_fraction_readability,
734         ))
735     });
736     let literal_representation_threshold = conf.literal_representation_threshold;
737     store.register_early_pass(move || {
738         Box::new(literal_representation::DecimalLiteralRepresentation::new(
739             literal_representation_threshold,
740         ))
741     });
742     let enum_variant_name_threshold = conf.enum_variant_name_threshold;
743     store.register_late_pass(move || {
744         Box::new(enum_variants::EnumVariantNames::new(
745             enum_variant_name_threshold,
746             avoid_breaking_exported_api,
747         ))
748     });
749     store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
750     let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
751     store.register_late_pass(move || {
752         Box::new(upper_case_acronyms::UpperCaseAcronyms::new(
753             avoid_breaking_exported_api,
754             upper_case_acronyms_aggressive,
755         ))
756     });
757     store.register_late_pass(|| Box::new(default::Default::default()));
758     store.register_late_pass(|| Box::new(unused_self::UnusedSelf));
759     store.register_late_pass(|| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
760     store.register_late_pass(|| Box::new(exit::Exit));
761     store.register_late_pass(|| Box::new(to_digit_is_some::ToDigitIsSome));
762     let array_size_threshold = conf.array_size_threshold;
763     store.register_late_pass(move || Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
764     store.register_late_pass(move || Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
765     store.register_late_pass(|| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
766     store.register_early_pass(|| Box::new(as_conversions::AsConversions));
767     store.register_late_pass(|| Box::new(let_underscore::LetUnderscore));
768     store.register_early_pass(|| Box::new(single_component_path_imports::SingleComponentPathImports));
769     let max_fn_params_bools = conf.max_fn_params_bools;
770     let max_struct_bools = conf.max_struct_bools;
771     store.register_early_pass(move || {
772         Box::new(excessive_bools::ExcessiveBools::new(
773             max_struct_bools,
774             max_fn_params_bools,
775         ))
776     });
777     store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
778     let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
779     store.register_late_pass(move || Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
780     store.register_late_pass(|| Box::new(verbose_file_reads::VerboseFileReads));
781     store.register_late_pass(|| Box::new(redundant_pub_crate::RedundantPubCrate::default()));
782     store.register_late_pass(|| Box::new(unnamed_address::UnnamedAddress));
783     store.register_late_pass(|| Box::new(dereference::Dereferencing::default()));
784     store.register_late_pass(|| Box::new(option_if_let_else::OptionIfLetElse));
785     store.register_late_pass(|| Box::new(future_not_send::FutureNotSend));
786     store.register_late_pass(|| Box::new(if_let_mutex::IfLetMutex));
787     store.register_late_pass(|| Box::new(if_not_else::IfNotElse));
788     store.register_late_pass(|| Box::new(equatable_if_let::PatternEquality));
789     store.register_late_pass(|| Box::new(mut_mutex_lock::MutMutexLock));
790     store.register_late_pass(|| Box::new(match_on_vec_items::MatchOnVecItems));
791     store.register_late_pass(|| Box::new(manual_async_fn::ManualAsyncFn));
792     store.register_late_pass(|| Box::new(vec_resize_to_zero::VecResizeToZero));
793     store.register_late_pass(|| Box::new(panic_in_result_fn::PanicInResultFn));
794     let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
795     store.register_early_pass(move || {
796         Box::new(non_expressive_names::NonExpressiveNames {
797             single_char_binding_names_threshold,
798         })
799     });
800     let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
801     store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(&macro_matcher)));
802     store.register_late_pass(|| Box::new(macro_use::MacroUseImports::default()));
803     store.register_late_pass(|| Box::new(pattern_type_mismatch::PatternTypeMismatch));
804     store.register_late_pass(|| Box::new(stable_sort_primitive::StableSortPrimitive));
805     store.register_late_pass(|| Box::new(repeat_once::RepeatOnce));
806     store.register_late_pass(|| Box::new(unwrap_in_result::UnwrapInResult));
807     store.register_late_pass(|| Box::new(self_assignment::SelfAssignment));
808     store.register_late_pass(|| Box::new(manual_unwrap_or::ManualUnwrapOr));
809     store.register_late_pass(|| Box::new(manual_ok_or::ManualOkOr));
810     store.register_late_pass(|| Box::new(float_equality_without_abs::FloatEqualityWithoutAbs));
811     store.register_late_pass(|| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
812     store.register_late_pass(|| Box::new(async_yields_async::AsyncYieldsAsync));
813     let disallowed_methods = conf.disallowed_methods.clone();
814     store.register_late_pass(move || Box::new(disallowed_methods::DisallowedMethods::new(disallowed_methods.clone())));
815     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
816     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
817     store.register_late_pass(|| Box::new(undropped_manually_drops::UndroppedManuallyDrops));
818     store.register_late_pass(|| Box::new(strings::StrToString));
819     store.register_late_pass(|| Box::new(strings::StringToString));
820     store.register_late_pass(|| Box::new(zero_sized_map_values::ZeroSizedMapValues));
821     store.register_late_pass(|| Box::new(vec_init_then_push::VecInitThenPush::default()));
822     store.register_late_pass(|| {
823         Box::new(case_sensitive_file_extension_comparisons::CaseSensitiveFileExtensionComparisons)
824     });
825     store.register_late_pass(|| Box::new(redundant_slicing::RedundantSlicing));
826     store.register_late_pass(|| Box::new(from_str_radix_10::FromStrRadix10));
827     store.register_late_pass(|| Box::new(manual_map::ManualMap));
828     store.register_late_pass(move || Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv)));
829     store.register_late_pass(|| Box::new(bool_assert_comparison::BoolAssertComparison));
830     store.register_early_pass(move || Box::new(module_style::ModStyle));
831     store.register_late_pass(|| Box::new(unused_async::UnusedAsync));
832     let disallowed_types = conf.disallowed_types.clone();
833     store.register_late_pass(move || Box::new(disallowed_types::DisallowedTypes::new(disallowed_types.clone())));
834     let import_renames = conf.enforced_import_renames.clone();
835     store.register_late_pass(move || {
836         Box::new(missing_enforced_import_rename::ImportRename::new(
837             import_renames.clone(),
838         ))
839     });
840     let scripts = conf.allowed_scripts.clone();
841     store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
842     store.register_late_pass(|| Box::new(strlen_on_c_strings::StrlenOnCStrings));
843     store.register_late_pass(move || Box::new(self_named_constructors::SelfNamedConstructors));
844     store.register_late_pass(move || Box::new(feature_name::FeatureName));
845     store.register_late_pass(move || Box::new(iter_not_returning_iterator::IterNotReturningIterator));
846     store.register_late_pass(move || Box::new(manual_assert::ManualAssert));
847     let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
848     store.register_late_pass(move || {
849         Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(
850             enable_raw_pointer_heuristic_for_send,
851         ))
852     });
853     store.register_late_pass(move || Box::new(undocumented_unsafe_blocks::UndocumentedUnsafeBlocks::default()));
854     store.register_late_pass(|| Box::new(match_str_case_mismatch::MatchStrCaseMismatch));
855     store.register_late_pass(move || Box::new(format_args::FormatArgs));
856     store.register_late_pass(|| Box::new(trailing_empty_array::TrailingEmptyArray));
857     store.register_early_pass(|| Box::new(octal_escapes::OctalEscapes));
858     store.register_late_pass(|| Box::new(needless_late_init::NeedlessLateInit));
859     store.register_late_pass(|| Box::new(return_self_not_must_use::ReturnSelfNotMustUse));
860     store.register_late_pass(|| Box::new(init_numbered_fields::NumberedFields));
861     // add lints here, do not remove this comment, it's used in `new_lint`
862 }
863
864 #[rustfmt::skip]
865 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
866     store.register_removed(
867         "should_assert_eq",
868         "`assert!()` will be more flexible with RFC 2011",
869     );
870     store.register_removed(
871         "extend_from_slice",
872         "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
873     );
874     store.register_removed(
875         "range_step_by_zero",
876         "`iterator.step_by(0)` panics nowadays",
877     );
878     store.register_removed(
879         "unstable_as_slice",
880         "`Vec::as_slice` has been stabilized in 1.7",
881     );
882     store.register_removed(
883         "unstable_as_mut_slice",
884         "`Vec::as_mut_slice` has been stabilized in 1.7",
885     );
886     store.register_removed(
887         "misaligned_transmute",
888         "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
889     );
890     store.register_removed(
891         "assign_ops",
892         "using compound assignment operators (e.g., `+=`) is harmless",
893     );
894     store.register_removed(
895         "if_let_redundant_pattern_matching",
896         "this lint has been changed to redundant_pattern_matching",
897     );
898     store.register_removed(
899         "unsafe_vector_initialization",
900         "the replacement suggested by this lint had substantially different behavior",
901     );
902     store.register_removed(
903         "reverse_range_loop",
904         "this lint is now included in reversed_empty_ranges",
905     );
906 }
907
908 /// Register renamed lints.
909 ///
910 /// Used in `./src/driver.rs`.
911 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
912     // NOTE: when renaming a lint, add a corresponding test to tests/ui/rename.rs
913     ls.register_renamed("clippy::stutter", "clippy::module_name_repetitions");
914     ls.register_renamed("clippy::new_without_default_derive", "clippy::new_without_default");
915     ls.register_renamed("clippy::cyclomatic_complexity", "clippy::cognitive_complexity");
916     ls.register_renamed("clippy::const_static_lifetime", "clippy::redundant_static_lifetimes");
917     ls.register_renamed("clippy::option_and_then_some", "clippy::bind_instead_of_map");
918     ls.register_renamed("clippy::box_vec", "clippy::box_collection");
919     ls.register_renamed("clippy::block_in_if_condition_expr", "clippy::blocks_in_if_conditions");
920     ls.register_renamed("clippy::block_in_if_condition_stmt", "clippy::blocks_in_if_conditions");
921     ls.register_renamed("clippy::option_map_unwrap_or", "clippy::map_unwrap_or");
922     ls.register_renamed("clippy::option_map_unwrap_or_else", "clippy::map_unwrap_or");
923     ls.register_renamed("clippy::result_map_unwrap_or_else", "clippy::map_unwrap_or");
924     ls.register_renamed("clippy::option_unwrap_used", "clippy::unwrap_used");
925     ls.register_renamed("clippy::result_unwrap_used", "clippy::unwrap_used");
926     ls.register_renamed("clippy::option_expect_used", "clippy::expect_used");
927     ls.register_renamed("clippy::result_expect_used", "clippy::expect_used");
928     ls.register_renamed("clippy::for_loop_over_option", "clippy::for_loops_over_fallibles");
929     ls.register_renamed("clippy::for_loop_over_result", "clippy::for_loops_over_fallibles");
930     ls.register_renamed("clippy::identity_conversion", "clippy::useless_conversion");
931     ls.register_renamed("clippy::zero_width_space", "clippy::invisible_characters");
932     ls.register_renamed("clippy::single_char_push_str", "clippy::single_char_add_str");
933     ls.register_renamed("clippy::if_let_some_result", "clippy::match_result_ok");
934     ls.register_renamed("clippy::disallowed_type", "clippy::disallowed_types");
935     ls.register_renamed("clippy::disallowed_method", "clippy::disallowed_methods");
936
937     // uplifted lints
938     ls.register_renamed("clippy::invalid_ref", "invalid_value");
939     ls.register_renamed("clippy::into_iter_on_array", "array_into_iter");
940     ls.register_renamed("clippy::unused_label", "unused_labels");
941     ls.register_renamed("clippy::drop_bounds", "drop_bounds");
942     ls.register_renamed("clippy::temporary_cstring_as_ptr", "temporary_cstring_as_ptr");
943     ls.register_renamed("clippy::panic_params", "non_fmt_panics");
944     ls.register_renamed("clippy::unknown_clippy_lints", "unknown_lints");
945     ls.register_renamed("clippy::invalid_atomic_ordering", "invalid_atomic_ordering");
946     ls.register_renamed("clippy::mem_discriminant_non_enum", "enum_intrinsics_non_enums");
947 }
948
949 // only exists to let the dogfood integration test works.
950 // Don't run clippy as an executable directly
951 #[allow(dead_code)]
952 fn main() {
953     panic!("Please use the cargo-clippy executable");
954 }