]> git.lizzy.rs Git - rust.git/blob - clippy_lints/src/lib.rs
[`excessive_bools`] lint trait functions even without bodies
[rust.git] / clippy_lints / src / lib.rs
1 #![feature(array_windows)]
2 #![feature(binary_heap_into_iter_sorted)]
3 #![feature(box_patterns)]
4 #![feature(control_flow_enum)]
5 #![feature(drain_filter)]
6 #![feature(iter_intersperse)]
7 #![feature(let_chains)]
8 #![feature(lint_reasons)]
9 #![feature(never_type)]
10 #![feature(once_cell)]
11 #![feature(rustc_private)]
12 #![feature(stmt_expr_attributes)]
13 #![recursion_limit = "512"]
14 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
15 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
16 #![warn(trivial_casts, trivial_numeric_casts)]
17 // warn on lints, that are included in `rust-lang/rust`s bootstrap
18 #![warn(rust_2018_idioms, unused_lifetimes)]
19 // warn on rustc internal lints
20 #![warn(rustc::internal)]
21 // Disable this rustc lint for now, as it was also done in rustc
22 #![allow(rustc::potential_query_instability)]
23
24 // FIXME: switch to something more ergonomic here, once available.
25 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
26 extern crate rustc_arena;
27 extern crate rustc_ast;
28 extern crate rustc_ast_pretty;
29 extern crate rustc_attr;
30 extern crate rustc_data_structures;
31 extern crate rustc_driver;
32 extern crate rustc_errors;
33 extern crate rustc_hir;
34 extern crate rustc_hir_analysis;
35 extern crate rustc_hir_pretty;
36 extern crate rustc_index;
37 extern crate rustc_infer;
38 extern crate rustc_lexer;
39 extern crate rustc_lint;
40 extern crate rustc_middle;
41 extern crate rustc_parse;
42 extern crate rustc_session;
43 extern crate rustc_span;
44 extern crate rustc_target;
45 extern crate rustc_trait_selection;
46
47 #[macro_use]
48 extern crate clippy_utils;
49 #[macro_use]
50 extern crate declare_clippy_lint;
51
52 use std::io;
53 use std::path::PathBuf;
54
55 use clippy_utils::parse_msrv;
56 use rustc_data_structures::fx::FxHashSet;
57 use rustc_lint::{Lint, LintId};
58 use rustc_semver::RustcVersion;
59 use rustc_session::Session;
60
61 #[cfg(feature = "internal")]
62 pub mod deprecated_lints;
63 #[cfg_attr(feature = "internal", allow(clippy::missing_clippy_version_attribute))]
64 mod utils;
65
66 mod declared_lints;
67 mod renamed_lints;
68
69 // begin lints modules, do not remove this comment, it’s used in `update_lints`
70 mod almost_complete_letter_range;
71 mod approx_const;
72 mod as_conversions;
73 mod asm_syntax;
74 mod assertions_on_constants;
75 mod assertions_on_result_states;
76 mod async_yields_async;
77 mod attrs;
78 mod await_holding_invalid;
79 mod blocks_in_if_conditions;
80 mod bool_assert_comparison;
81 mod bool_to_int_with_if;
82 mod booleans;
83 mod borrow_deref_ref;
84 mod box_default;
85 mod cargo;
86 mod casts;
87 mod checked_conversions;
88 mod cognitive_complexity;
89 mod collapsible_if;
90 mod comparison_chain;
91 mod copies;
92 mod copy_iterator;
93 mod crate_in_macro_def;
94 mod create_dir;
95 mod dbg_macro;
96 mod default;
97 mod default_instead_of_iter_empty;
98 mod default_numeric_fallback;
99 mod default_union_representation;
100 mod dereference;
101 mod derivable_impls;
102 mod derive;
103 mod disallowed_macros;
104 mod disallowed_methods;
105 mod disallowed_names;
106 mod disallowed_script_idents;
107 mod disallowed_types;
108 mod doc;
109 mod double_parens;
110 mod drop_forget_ref;
111 mod duplicate_mod;
112 mod else_if_without_else;
113 mod empty_drop;
114 mod empty_enum;
115 mod empty_structs_with_brackets;
116 mod entry;
117 mod enum_clike;
118 mod enum_variants;
119 mod equatable_if_let;
120 mod escape;
121 mod eta_reduction;
122 mod excessive_bools;
123 mod exhaustive_items;
124 mod exit;
125 mod explicit_write;
126 mod fallible_impl_from;
127 mod float_literal;
128 mod floating_point_arithmetic;
129 mod format;
130 mod format_args;
131 mod format_impl;
132 mod format_push_string;
133 mod formatting;
134 mod from_over_into;
135 mod from_raw_with_void_ptr;
136 mod from_str_radix_10;
137 mod functions;
138 mod future_not_send;
139 mod if_let_mutex;
140 mod if_not_else;
141 mod if_then_some_else_none;
142 mod implicit_hasher;
143 mod implicit_return;
144 mod implicit_saturating_add;
145 mod implicit_saturating_sub;
146 mod inconsistent_struct_constructor;
147 mod index_refutable_slice;
148 mod indexing_slicing;
149 mod infinite_iter;
150 mod inherent_impl;
151 mod inherent_to_string;
152 mod init_numbered_fields;
153 mod inline_fn_without_body;
154 mod int_plus_one;
155 mod invalid_upcast_comparisons;
156 mod invalid_utf8_in_unchecked;
157 mod items_after_statements;
158 mod iter_not_returning_iterator;
159 mod large_const_arrays;
160 mod large_enum_variant;
161 mod large_include_file;
162 mod large_stack_arrays;
163 mod len_zero;
164 mod let_if_seq;
165 mod let_underscore;
166 mod lifetimes;
167 mod literal_representation;
168 mod loops;
169 mod macro_use;
170 mod main_recursion;
171 mod manual_assert;
172 mod manual_async_fn;
173 mod manual_bits;
174 mod manual_clamp;
175 mod manual_instant_elapsed;
176 mod manual_let_else;
177 mod manual_non_exhaustive;
178 mod manual_rem_euclid;
179 mod manual_retain;
180 mod manual_string_new;
181 mod manual_strip;
182 mod map_unit_fn;
183 mod match_result_ok;
184 mod matches;
185 mod mem_forget;
186 mod mem_replace;
187 mod methods;
188 mod minmax;
189 mod misc;
190 mod misc_early;
191 mod mismatching_type_param_order;
192 mod missing_const_for_fn;
193 mod missing_doc;
194 mod missing_enforced_import_rename;
195 mod missing_inline;
196 mod missing_trait_methods;
197 mod mixed_read_write_in_expression;
198 mod module_style;
199 mod multi_assignments;
200 mod mut_key;
201 mod mut_mut;
202 mod mut_reference;
203 mod mutable_debug_assertion;
204 mod mutex_atomic;
205 mod needless_arbitrary_self_type;
206 mod needless_bool;
207 mod needless_borrowed_ref;
208 mod needless_continue;
209 mod needless_for_each;
210 mod needless_late_init;
211 mod needless_parens_on_range_literals;
212 mod needless_pass_by_value;
213 mod needless_question_mark;
214 mod needless_update;
215 mod neg_cmp_op_on_partial_ord;
216 mod neg_multiply;
217 mod new_without_default;
218 mod no_effect;
219 mod non_copy_const;
220 mod non_expressive_names;
221 mod non_octal_unix_permissions;
222 mod non_send_fields_in_send_ty;
223 mod nonstandard_macro_braces;
224 mod octal_escapes;
225 mod only_used_in_recursion;
226 mod operators;
227 mod option_env_unwrap;
228 mod option_if_let_else;
229 mod overflow_check_conditional;
230 mod panic_in_result_fn;
231 mod panic_unimplemented;
232 mod partial_pub_fields;
233 mod partialeq_ne_impl;
234 mod partialeq_to_none;
235 mod pass_by_ref_or_value;
236 mod pattern_type_mismatch;
237 mod precedence;
238 mod ptr;
239 mod ptr_offset_with_cast;
240 mod pub_use;
241 mod question_mark;
242 mod ranges;
243 mod rc_clone_in_vec_init;
244 mod read_zero_byte_vec;
245 mod redundant_clone;
246 mod redundant_closure_call;
247 mod redundant_else;
248 mod redundant_field_names;
249 mod redundant_pub_crate;
250 mod redundant_slicing;
251 mod redundant_static_lifetimes;
252 mod ref_option_ref;
253 mod reference;
254 mod regex;
255 mod return_self_not_must_use;
256 mod returns;
257 mod same_name_method;
258 mod self_named_constructors;
259 mod semicolon_if_nothing_returned;
260 mod serde_api;
261 mod shadow;
262 mod single_char_lifetime_names;
263 mod single_component_path_imports;
264 mod size_of_in_element_count;
265 mod slow_vector_initialization;
266 mod std_instead_of_core;
267 mod strings;
268 mod strlen_on_c_strings;
269 mod suspicious_operation_groupings;
270 mod suspicious_trait_impl;
271 mod swap;
272 mod swap_ptr_to_ref;
273 mod tabs_in_doc_comments;
274 mod temporary_assignment;
275 mod to_digit_is_some;
276 mod trailing_empty_array;
277 mod trait_bounds;
278 mod transmute;
279 mod types;
280 mod undocumented_unsafe_blocks;
281 mod unicode;
282 mod uninit_vec;
283 mod unit_return_expecting_ord;
284 mod unit_types;
285 mod unnamed_address;
286 mod unnecessary_owned_empty_strings;
287 mod unnecessary_self_imports;
288 mod unnecessary_wraps;
289 mod unnested_or_patterns;
290 mod unsafe_removed_from_name;
291 mod unused_async;
292 mod unused_io_amount;
293 mod unused_peekable;
294 mod unused_rounding;
295 mod unused_self;
296 mod unused_unit;
297 mod unwrap;
298 mod unwrap_in_result;
299 mod upper_case_acronyms;
300 mod use_self;
301 mod useless_conversion;
302 mod vec;
303 mod vec_init_then_push;
304 mod wildcard_imports;
305 mod write;
306 mod zero_div_zero;
307 mod zero_sized_map_values;
308 // end lints modules, do not remove this comment, it’s used in `update_lints`
309
310 use crate::utils::conf::{format_error, TryConf};
311 pub use crate::utils::conf::{lookup_conf_file, Conf};
312
313 /// Register all pre expansion lints
314 ///
315 /// Pre-expansion lints run before any macro expansion has happened.
316 ///
317 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
318 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
319 ///
320 /// Used in `./src/driver.rs`.
321 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
322     // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
323
324     let msrv = conf.msrv.as_ref().and_then(|s| {
325         parse_msrv(s, None, None).or_else(|| {
326             sess.err(format!(
327                 "error reading Clippy's configuration file. `{s}` is not a valid Rust version"
328             ));
329             None
330         })
331     });
332
333     store.register_pre_expansion_pass(move || Box::new(attrs::EarlyAttributes { msrv }));
334 }
335
336 fn read_msrv(conf: &Conf, sess: &Session) -> Option<RustcVersion> {
337     let cargo_msrv = std::env::var("CARGO_PKG_RUST_VERSION")
338         .ok()
339         .and_then(|v| parse_msrv(&v, None, None));
340     let clippy_msrv = conf.msrv.as_ref().and_then(|s| {
341         parse_msrv(s, None, None).or_else(|| {
342             sess.err(format!(
343                 "error reading Clippy's configuration file. `{s}` is not a valid Rust version"
344             ));
345             None
346         })
347     });
348
349     if let Some(cargo_msrv) = cargo_msrv {
350         if let Some(clippy_msrv) = clippy_msrv {
351             // if both files have an msrv, let's compare them and emit a warning if they differ
352             if clippy_msrv != cargo_msrv {
353                 sess.warn(format!(
354                     "the MSRV in `clippy.toml` and `Cargo.toml` differ; using `{clippy_msrv}` from `clippy.toml`"
355                 ));
356             }
357
358             Some(clippy_msrv)
359         } else {
360             Some(cargo_msrv)
361         }
362     } else {
363         clippy_msrv
364     }
365 }
366
367 #[doc(hidden)]
368 pub fn read_conf(sess: &Session, path: &io::Result<Option<PathBuf>>) -> Conf {
369     let file_name = match path {
370         Ok(Some(path)) => path,
371         Ok(None) => return Conf::default(),
372         Err(error) => {
373             sess.struct_err(&format!("error finding Clippy's configuration file: {error}"))
374                 .emit();
375             return Conf::default();
376         },
377     };
378
379     let TryConf { conf, errors, warnings } = utils::conf::read(file_name);
380     // all conf errors are non-fatal, we just use the default conf in case of error
381     for error in errors {
382         sess.err(format!(
383             "error reading Clippy's configuration file `{}`: {}",
384             file_name.display(),
385             format_error(error)
386         ));
387     }
388
389     for warning in warnings {
390         sess.struct_warn(format!(
391             "error reading Clippy's configuration file `{}`: {}",
392             file_name.display(),
393             format_error(warning)
394         ))
395         .emit();
396     }
397
398     conf
399 }
400
401 #[derive(Default)]
402 struct RegistrationGroups {
403     all: Vec<LintId>,
404     cargo: Vec<LintId>,
405     complexity: Vec<LintId>,
406     correctness: Vec<LintId>,
407     nursery: Vec<LintId>,
408     pedantic: Vec<LintId>,
409     perf: Vec<LintId>,
410     restriction: Vec<LintId>,
411     style: Vec<LintId>,
412     suspicious: Vec<LintId>,
413     #[cfg(feature = "internal")]
414     internal: Vec<LintId>,
415 }
416
417 impl RegistrationGroups {
418     #[rustfmt::skip]
419     fn register(self, store: &mut rustc_lint::LintStore) {
420         store.register_group(true, "clippy::all", Some("clippy_all"), self.all);
421         store.register_group(true, "clippy::cargo", Some("clippy_cargo"), self.cargo);
422         store.register_group(true, "clippy::complexity", Some("clippy_complexity"), self.complexity);
423         store.register_group(true, "clippy::correctness", Some("clippy_correctness"), self.correctness);
424         store.register_group(true, "clippy::nursery", Some("clippy_nursery"), self.nursery);
425         store.register_group(true, "clippy::pedantic", Some("clippy_pedantic"), self.pedantic);
426         store.register_group(true, "clippy::perf", Some("clippy_perf"), self.perf);
427         store.register_group(true, "clippy::restriction", Some("clippy_restriction"), self.restriction);
428         store.register_group(true, "clippy::style", Some("clippy_style"), self.style);
429         store.register_group(true, "clippy::suspicious", Some("clippy_suspicious"), self.suspicious);
430         #[cfg(feature = "internal")]
431         store.register_group(true, "clippy::internal", Some("clippy_internal"), self.internal);
432     }
433 }
434
435 #[derive(Copy, Clone)]
436 pub(crate) enum LintCategory {
437     Cargo,
438     Complexity,
439     Correctness,
440     Nursery,
441     Pedantic,
442     Perf,
443     Restriction,
444     Style,
445     Suspicious,
446     #[cfg(feature = "internal")]
447     Internal,
448 }
449 #[allow(clippy::enum_glob_use)]
450 use LintCategory::*;
451
452 impl LintCategory {
453     fn is_all(self) -> bool {
454         matches!(self, Correctness | Suspicious | Style | Complexity | Perf)
455     }
456
457     fn group(self, groups: &mut RegistrationGroups) -> &mut Vec<LintId> {
458         match self {
459             Cargo => &mut groups.cargo,
460             Complexity => &mut groups.complexity,
461             Correctness => &mut groups.correctness,
462             Nursery => &mut groups.nursery,
463             Pedantic => &mut groups.pedantic,
464             Perf => &mut groups.perf,
465             Restriction => &mut groups.restriction,
466             Style => &mut groups.style,
467             Suspicious => &mut groups.suspicious,
468             #[cfg(feature = "internal")]
469             Internal => &mut groups.internal,
470         }
471     }
472 }
473
474 pub(crate) struct LintInfo {
475     /// Double reference to maintain pointer equality
476     lint: &'static &'static Lint,
477     category: LintCategory,
478     explanation: &'static str,
479 }
480
481 pub fn explain(name: &str) {
482     let target = format!("clippy::{}", name.to_ascii_uppercase());
483     match declared_lints::LINTS.iter().find(|info| info.lint.name == target) {
484         Some(info) => print!("{}", info.explanation),
485         None => println!("unknown lint: {name}"),
486     }
487 }
488
489 fn register_categories(store: &mut rustc_lint::LintStore) {
490     let mut groups = RegistrationGroups::default();
491
492     for LintInfo { lint, category, .. } in declared_lints::LINTS {
493         if category.is_all() {
494             groups.all.push(LintId::of(lint));
495         }
496
497         category.group(&mut groups).push(LintId::of(lint));
498     }
499
500     let lints: Vec<&'static Lint> = declared_lints::LINTS.iter().map(|info| *info.lint).collect();
501
502     store.register_lints(&lints);
503     groups.register(store);
504 }
505
506 /// Register all lints and lint groups with the rustc plugin registry
507 ///
508 /// Used in `./src/driver.rs`.
509 #[expect(clippy::too_many_lines)]
510 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
511     register_removed_non_tool_lints(store);
512     register_categories(store);
513
514     include!("lib.deprecated.rs");
515
516     #[cfg(feature = "internal")]
517     {
518         if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
519             store.register_late_pass(|_| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
520             return;
521         }
522     }
523
524     // all the internal lints
525     #[cfg(feature = "internal")]
526     {
527         store.register_early_pass(|| Box::new(utils::internal_lints::clippy_lints_internal::ClippyLintsInternal));
528         store.register_early_pass(|| Box::new(utils::internal_lints::produce_ice::ProduceIce));
529         store.register_late_pass(|_| Box::new(utils::internal_lints::collapsible_calls::CollapsibleCalls));
530         store.register_late_pass(|_| {
531             Box::new(utils::internal_lints::compiler_lint_functions::CompilerLintFunctions::new())
532         });
533         store.register_late_pass(|_| Box::new(utils::internal_lints::if_chain_style::IfChainStyle));
534         store.register_late_pass(|_| Box::new(utils::internal_lints::invalid_paths::InvalidPaths));
535         store.register_late_pass(|_| {
536             Box::<utils::internal_lints::interning_defined_symbol::InterningDefinedSymbol>::default()
537         });
538         store.register_late_pass(|_| {
539             Box::<utils::internal_lints::lint_without_lint_pass::LintWithoutLintPass>::default()
540         });
541         store.register_late_pass(|_| Box::<utils::internal_lints::unnecessary_def_path::UnnecessaryDefPath>::default());
542         store.register_late_pass(|_| Box::new(utils::internal_lints::outer_expn_data_pass::OuterExpnDataPass));
543         store.register_late_pass(|_| Box::new(utils::internal_lints::msrv_attr_impl::MsrvAttrImpl));
544     }
545
546     let arithmetic_side_effects_allowed = conf.arithmetic_side_effects_allowed.clone();
547     store.register_late_pass(move |_| {
548         Box::new(operators::arithmetic_side_effects::ArithmeticSideEffects::new(
549             arithmetic_side_effects_allowed.clone(),
550         ))
551     });
552     store.register_late_pass(|_| Box::new(utils::dump_hir::DumpHir));
553     store.register_late_pass(|_| Box::new(utils::author::Author));
554     let await_holding_invalid_types = conf.await_holding_invalid_types.clone();
555     store.register_late_pass(move |_| {
556         Box::new(await_holding_invalid::AwaitHolding::new(
557             await_holding_invalid_types.clone(),
558         ))
559     });
560     store.register_late_pass(|_| Box::new(serde_api::SerdeApi));
561     let vec_box_size_threshold = conf.vec_box_size_threshold;
562     let type_complexity_threshold = conf.type_complexity_threshold;
563     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
564     store.register_late_pass(move |_| {
565         Box::new(types::Types::new(
566             vec_box_size_threshold,
567             type_complexity_threshold,
568             avoid_breaking_exported_api,
569         ))
570     });
571     store.register_late_pass(|_| Box::new(booleans::NonminimalBool));
572     store.register_late_pass(|_| Box::new(enum_clike::UnportableVariant));
573     store.register_late_pass(|_| Box::new(float_literal::FloatLiteral));
574     store.register_late_pass(|_| Box::new(ptr::Ptr));
575     store.register_late_pass(|_| Box::new(needless_bool::NeedlessBool));
576     store.register_late_pass(|_| Box::new(needless_bool::BoolComparison));
577     store.register_late_pass(|_| Box::new(needless_for_each::NeedlessForEach));
578     store.register_late_pass(|_| Box::new(misc::MiscLints));
579     store.register_late_pass(|_| Box::new(eta_reduction::EtaReduction));
580     store.register_late_pass(|_| Box::new(mut_mut::MutMut));
581     store.register_late_pass(|_| Box::new(mut_reference::UnnecessaryMutPassed));
582     store.register_late_pass(|_| Box::new(len_zero::LenZero));
583     store.register_late_pass(|_| Box::new(attrs::Attributes));
584     store.register_late_pass(|_| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
585     store.register_late_pass(|_| Box::new(unicode::Unicode));
586     store.register_late_pass(|_| Box::new(uninit_vec::UninitVec));
587     store.register_late_pass(|_| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
588     store.register_late_pass(|_| Box::new(strings::StringAdd));
589     store.register_late_pass(|_| Box::new(implicit_return::ImplicitReturn));
590     store.register_late_pass(|_| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
591     store.register_late_pass(|_| Box::new(default_numeric_fallback::DefaultNumericFallback));
592     store.register_late_pass(|_| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
593     store.register_late_pass(|_| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
594     store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
595
596     let msrv = read_msrv(conf, sess);
597     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
598     let allow_expect_in_tests = conf.allow_expect_in_tests;
599     let allow_unwrap_in_tests = conf.allow_unwrap_in_tests;
600     store.register_late_pass(move |_| Box::new(approx_const::ApproxConstant::new(msrv)));
601     store.register_late_pass(move |_| {
602         Box::new(methods::Methods::new(
603             avoid_breaking_exported_api,
604             msrv,
605             allow_expect_in_tests,
606             allow_unwrap_in_tests,
607         ))
608     });
609     store.register_late_pass(move |_| Box::new(matches::Matches::new(msrv)));
610     let matches_for_let_else = conf.matches_for_let_else;
611     store.register_late_pass(move |_| Box::new(manual_let_else::ManualLetElse::new(msrv, matches_for_let_else)));
612     store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustiveStruct::new(msrv)));
613     store.register_late_pass(move |_| Box::new(manual_non_exhaustive::ManualNonExhaustiveEnum::new(msrv)));
614     store.register_late_pass(move |_| Box::new(manual_strip::ManualStrip::new(msrv)));
615     store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv)));
616     store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv)));
617     store.register_late_pass(move |_| Box::new(checked_conversions::CheckedConversions::new(msrv)));
618     store.register_late_pass(move |_| Box::new(mem_replace::MemReplace::new(msrv)));
619     store.register_late_pass(move |_| Box::new(ranges::Ranges::new(msrv)));
620     store.register_late_pass(move |_| Box::new(from_over_into::FromOverInto::new(msrv)));
621     store.register_late_pass(move |_| Box::new(use_self::UseSelf::new(msrv)));
622     store.register_late_pass(move |_| Box::new(missing_const_for_fn::MissingConstForFn::new(msrv)));
623     store.register_late_pass(move |_| Box::new(needless_question_mark::NeedlessQuestionMark));
624     store.register_late_pass(move |_| Box::new(casts::Casts::new(msrv)));
625     store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv)));
626     store.register_late_pass(|_| Box::new(size_of_in_element_count::SizeOfInElementCount));
627     store.register_late_pass(|_| Box::new(same_name_method::SameNameMethod));
628     let max_suggested_slice_pattern_length = conf.max_suggested_slice_pattern_length;
629     store.register_late_pass(move |_| {
630         Box::new(index_refutable_slice::IndexRefutableSlice::new(
631             max_suggested_slice_pattern_length,
632             msrv,
633         ))
634     });
635     store.register_late_pass(|_| Box::<shadow::Shadow>::default());
636     store.register_late_pass(|_| Box::new(unit_types::UnitTypes));
637     store.register_late_pass(|_| Box::new(loops::Loops));
638     store.register_late_pass(|_| Box::<main_recursion::MainRecursion>::default());
639     store.register_late_pass(|_| Box::new(lifetimes::Lifetimes));
640     store.register_late_pass(|_| Box::new(entry::HashMapPass));
641     store.register_late_pass(|_| Box::new(minmax::MinMaxPass));
642     store.register_late_pass(|_| Box::new(zero_div_zero::ZeroDiv));
643     store.register_late_pass(|_| Box::new(mutex_atomic::Mutex));
644     store.register_late_pass(|_| Box::new(needless_update::NeedlessUpdate));
645     store.register_late_pass(|_| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
646     store.register_late_pass(|_| Box::new(borrow_deref_ref::BorrowDerefRef));
647     store.register_late_pass(|_| Box::new(no_effect::NoEffect));
648     store.register_late_pass(|_| Box::new(temporary_assignment::TemporaryAssignment));
649     store.register_late_pass(move |_| Box::new(transmute::Transmute::new(msrv)));
650     let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
651     store.register_late_pass(move |_| {
652         Box::new(cognitive_complexity::CognitiveComplexity::new(
653             cognitive_complexity_threshold,
654         ))
655     });
656     let too_large_for_stack = conf.too_large_for_stack;
657     store.register_late_pass(move |_| Box::new(escape::BoxedLocal { too_large_for_stack }));
658     store.register_late_pass(move |_| Box::new(vec::UselessVec { too_large_for_stack }));
659     store.register_late_pass(|_| Box::new(panic_unimplemented::PanicUnimplemented));
660     store.register_late_pass(|_| Box::new(strings::StringLitAsBytes));
661     store.register_late_pass(|_| Box::new(derive::Derive));
662     store.register_late_pass(|_| Box::new(derivable_impls::DerivableImpls));
663     store.register_late_pass(|_| Box::new(drop_forget_ref::DropForgetRef));
664     store.register_late_pass(|_| Box::new(empty_enum::EmptyEnum));
665     store.register_late_pass(|_| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
666     store.register_late_pass(|_| Box::new(regex::Regex));
667     store.register_late_pass(|_| Box::new(copies::CopyAndPaste));
668     store.register_late_pass(|_| Box::new(copy_iterator::CopyIterator));
669     store.register_late_pass(|_| Box::new(format::UselessFormat));
670     store.register_late_pass(|_| Box::new(swap::Swap));
671     store.register_late_pass(|_| Box::new(overflow_check_conditional::OverflowCheckConditional));
672     store.register_late_pass(|_| Box::<new_without_default::NewWithoutDefault>::default());
673     let disallowed_names = conf.disallowed_names.iter().cloned().collect::<FxHashSet<_>>();
674     store.register_late_pass(move |_| Box::new(disallowed_names::DisallowedNames::new(disallowed_names.clone())));
675     let too_many_arguments_threshold = conf.too_many_arguments_threshold;
676     let too_many_lines_threshold = conf.too_many_lines_threshold;
677     let large_error_threshold = conf.large_error_threshold;
678     store.register_late_pass(move |_| {
679         Box::new(functions::Functions::new(
680             too_many_arguments_threshold,
681             too_many_lines_threshold,
682             large_error_threshold,
683         ))
684     });
685     let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
686     store.register_late_pass(move |_| Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
687     store.register_late_pass(|_| Box::new(neg_multiply::NegMultiply));
688     store.register_late_pass(|_| Box::new(mem_forget::MemForget));
689     store.register_late_pass(|_| Box::new(let_if_seq::LetIfSeq));
690     store.register_late_pass(|_| Box::new(mixed_read_write_in_expression::EvalOrderDependence));
691     store.register_late_pass(|_| Box::new(missing_doc::MissingDoc::new()));
692     store.register_late_pass(|_| Box::new(missing_inline::MissingInline));
693     store.register_late_pass(move |_| Box::new(exhaustive_items::ExhaustiveItems));
694     store.register_late_pass(|_| Box::new(match_result_ok::MatchResultOk));
695     store.register_late_pass(|_| Box::new(partialeq_ne_impl::PartialEqNeImpl));
696     store.register_late_pass(|_| Box::new(unused_io_amount::UnusedIoAmount));
697     let enum_variant_size_threshold = conf.enum_variant_size_threshold;
698     store.register_late_pass(move |_| Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
699     store.register_late_pass(|_| Box::new(explicit_write::ExplicitWrite));
700     store.register_late_pass(|_| Box::new(needless_pass_by_value::NeedlessPassByValue));
701     let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
702         conf.trivial_copy_size_limit,
703         conf.pass_by_value_size_limit,
704         conf.avoid_breaking_exported_api,
705         &sess.target,
706     );
707     store.register_late_pass(move |_| Box::new(pass_by_ref_or_value));
708     store.register_late_pass(|_| Box::new(ref_option_ref::RefOptionRef));
709     store.register_late_pass(|_| Box::new(infinite_iter::InfiniteIter));
710     store.register_late_pass(|_| Box::new(inline_fn_without_body::InlineFnWithoutBody));
711     store.register_late_pass(|_| Box::<useless_conversion::UselessConversion>::default());
712     store.register_late_pass(|_| Box::new(implicit_hasher::ImplicitHasher));
713     store.register_late_pass(|_| Box::new(fallible_impl_from::FallibleImplFrom));
714     store.register_late_pass(|_| Box::new(question_mark::QuestionMark));
715     store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
716     store.register_late_pass(|_| Box::new(suspicious_trait_impl::SuspiciousImpl));
717     store.register_late_pass(|_| Box::new(map_unit_fn::MapUnit));
718     store.register_late_pass(|_| Box::new(inherent_impl::MultipleInherentImpl));
719     store.register_late_pass(|_| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
720     store.register_late_pass(|_| Box::new(unwrap::Unwrap));
721     store.register_late_pass(|_| Box::new(indexing_slicing::IndexingSlicing));
722     store.register_late_pass(|_| Box::new(non_copy_const::NonCopyConst));
723     store.register_late_pass(|_| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
724     store.register_late_pass(|_| Box::new(redundant_clone::RedundantClone));
725     store.register_late_pass(|_| Box::new(slow_vector_initialization::SlowVectorInit));
726     store.register_late_pass(move |_| Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
727     store.register_late_pass(|_| Box::new(assertions_on_constants::AssertionsOnConstants));
728     store.register_late_pass(|_| Box::new(assertions_on_result_states::AssertionsOnResultStates));
729     store.register_late_pass(|_| Box::new(inherent_to_string::InherentToString));
730     let max_trait_bounds = conf.max_trait_bounds;
731     store.register_late_pass(move |_| Box::new(trait_bounds::TraitBounds::new(max_trait_bounds)));
732     store.register_late_pass(|_| Box::new(comparison_chain::ComparisonChain));
733     let ignore_interior_mutability = conf.ignore_interior_mutability.clone();
734     store.register_late_pass(move |_| Box::new(mut_key::MutableKeyType::new(ignore_interior_mutability.clone())));
735     store.register_early_pass(|| Box::new(reference::DerefAddrOf));
736     store.register_early_pass(|| Box::new(double_parens::DoubleParens));
737     store.register_late_pass(|_| Box::new(format_impl::FormatImpl::new()));
738     store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
739     store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
740     store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
741     store.register_early_pass(|| Box::new(formatting::Formatting));
742     store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
743     store.register_early_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
744     store.register_late_pass(|_| Box::new(redundant_closure_call::RedundantClosureCall));
745     store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
746     store.register_late_pass(|_| Box::new(returns::Return));
747     store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
748     store.register_early_pass(|| Box::new(items_after_statements::ItemsAfterStatements));
749     store.register_early_pass(|| Box::new(precedence::Precedence));
750     store.register_late_pass(|_| Box::new(needless_parens_on_range_literals::NeedlessParensOnRangeLiterals));
751     store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
752     store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
753     store.register_late_pass(|_| Box::new(create_dir::CreateDir));
754     store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
755     let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
756     store.register_early_pass(move || {
757         Box::new(literal_representation::LiteralDigitGrouping::new(
758             literal_representation_lint_fraction_readability,
759         ))
760     });
761     let literal_representation_threshold = conf.literal_representation_threshold;
762     store.register_early_pass(move || {
763         Box::new(literal_representation::DecimalLiteralRepresentation::new(
764             literal_representation_threshold,
765         ))
766     });
767     let enum_variant_name_threshold = conf.enum_variant_name_threshold;
768     store.register_late_pass(move |_| {
769         Box::new(enum_variants::EnumVariantNames::new(
770             enum_variant_name_threshold,
771             avoid_breaking_exported_api,
772         ))
773     });
774     store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
775     let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
776     store.register_late_pass(move |_| {
777         Box::new(upper_case_acronyms::UpperCaseAcronyms::new(
778             avoid_breaking_exported_api,
779             upper_case_acronyms_aggressive,
780         ))
781     });
782     store.register_late_pass(|_| Box::<default::Default>::default());
783     store.register_late_pass(move |_| Box::new(unused_self::UnusedSelf::new(avoid_breaking_exported_api)));
784     store.register_late_pass(|_| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
785     store.register_late_pass(|_| Box::new(exit::Exit));
786     store.register_late_pass(|_| Box::new(to_digit_is_some::ToDigitIsSome));
787     let array_size_threshold = conf.array_size_threshold;
788     store.register_late_pass(move |_| Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
789     store.register_late_pass(move |_| Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
790     store.register_late_pass(|_| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
791     store.register_early_pass(|| Box::new(as_conversions::AsConversions));
792     store.register_late_pass(|_| Box::new(let_underscore::LetUnderscore));
793     store.register_early_pass(|| Box::new(single_component_path_imports::SingleComponentPathImports));
794     let max_fn_params_bools = conf.max_fn_params_bools;
795     let max_struct_bools = conf.max_struct_bools;
796     store.register_late_pass(move |_| {
797         Box::new(excessive_bools::ExcessiveBools::new(
798             max_struct_bools,
799             max_fn_params_bools,
800         ))
801     });
802     store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
803     let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
804     store.register_late_pass(move |_| Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
805     store.register_late_pass(|_| Box::<redundant_pub_crate::RedundantPubCrate>::default());
806     store.register_late_pass(|_| Box::new(unnamed_address::UnnamedAddress));
807     store.register_late_pass(move |_| Box::new(dereference::Dereferencing::new(msrv)));
808     store.register_late_pass(|_| Box::new(option_if_let_else::OptionIfLetElse));
809     store.register_late_pass(|_| Box::new(future_not_send::FutureNotSend));
810     store.register_late_pass(|_| Box::new(if_let_mutex::IfLetMutex));
811     store.register_late_pass(|_| Box::new(if_not_else::IfNotElse));
812     store.register_late_pass(|_| Box::new(equatable_if_let::PatternEquality));
813     store.register_late_pass(|_| Box::new(manual_async_fn::ManualAsyncFn));
814     store.register_late_pass(|_| Box::new(panic_in_result_fn::PanicInResultFn));
815     let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
816     store.register_early_pass(move || {
817         Box::new(non_expressive_names::NonExpressiveNames {
818             single_char_binding_names_threshold,
819         })
820     });
821     let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
822     store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(&macro_matcher)));
823     store.register_late_pass(|_| Box::<macro_use::MacroUseImports>::default());
824     store.register_late_pass(|_| Box::new(pattern_type_mismatch::PatternTypeMismatch));
825     store.register_late_pass(|_| Box::new(unwrap_in_result::UnwrapInResult));
826     store.register_late_pass(|_| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
827     store.register_late_pass(|_| Box::new(async_yields_async::AsyncYieldsAsync));
828     let disallowed_macros = conf.disallowed_macros.clone();
829     store.register_late_pass(move |_| Box::new(disallowed_macros::DisallowedMacros::new(disallowed_macros.clone())));
830     let disallowed_methods = conf.disallowed_methods.clone();
831     store.register_late_pass(move |_| Box::new(disallowed_methods::DisallowedMethods::new(disallowed_methods.clone())));
832     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
833     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
834     store.register_late_pass(|_| Box::new(empty_drop::EmptyDrop));
835     store.register_late_pass(|_| Box::new(strings::StrToString));
836     store.register_late_pass(|_| Box::new(strings::StringToString));
837     store.register_late_pass(|_| Box::new(zero_sized_map_values::ZeroSizedMapValues));
838     store.register_late_pass(|_| Box::<vec_init_then_push::VecInitThenPush>::default());
839     store.register_late_pass(|_| Box::new(redundant_slicing::RedundantSlicing));
840     store.register_late_pass(|_| Box::new(from_str_radix_10::FromStrRadix10));
841     store.register_late_pass(move |_| Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv)));
842     store.register_late_pass(|_| Box::new(bool_assert_comparison::BoolAssertComparison));
843     store.register_early_pass(move || Box::new(module_style::ModStyle));
844     store.register_late_pass(|_| Box::new(unused_async::UnusedAsync));
845     let disallowed_types = conf.disallowed_types.clone();
846     store.register_late_pass(move |_| Box::new(disallowed_types::DisallowedTypes::new(disallowed_types.clone())));
847     let import_renames = conf.enforced_import_renames.clone();
848     store.register_late_pass(move |_| {
849         Box::new(missing_enforced_import_rename::ImportRename::new(
850             import_renames.clone(),
851         ))
852     });
853     let scripts = conf.allowed_scripts.clone();
854     store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
855     store.register_late_pass(|_| Box::new(strlen_on_c_strings::StrlenOnCStrings));
856     store.register_late_pass(move |_| Box::new(self_named_constructors::SelfNamedConstructors));
857     store.register_late_pass(move |_| Box::new(iter_not_returning_iterator::IterNotReturningIterator));
858     store.register_late_pass(move |_| Box::new(manual_assert::ManualAssert));
859     let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
860     store.register_late_pass(move |_| {
861         Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(
862             enable_raw_pointer_heuristic_for_send,
863         ))
864     });
865     store.register_late_pass(move |_| Box::new(undocumented_unsafe_blocks::UndocumentedUnsafeBlocks));
866     store.register_late_pass(move |_| Box::new(format_args::FormatArgs::new(msrv)));
867     store.register_late_pass(|_| Box::new(trailing_empty_array::TrailingEmptyArray));
868     store.register_early_pass(|| Box::new(octal_escapes::OctalEscapes));
869     store.register_late_pass(|_| Box::new(needless_late_init::NeedlessLateInit));
870     store.register_late_pass(|_| Box::new(return_self_not_must_use::ReturnSelfNotMustUse));
871     store.register_late_pass(|_| Box::new(init_numbered_fields::NumberedFields));
872     store.register_early_pass(|| Box::new(single_char_lifetime_names::SingleCharLifetimeNames));
873     store.register_late_pass(move |_| Box::new(manual_bits::ManualBits::new(msrv)));
874     store.register_late_pass(|_| Box::new(default_union_representation::DefaultUnionRepresentation));
875     store.register_late_pass(|_| Box::<only_used_in_recursion::OnlyUsedInRecursion>::default());
876     let allow_dbg_in_tests = conf.allow_dbg_in_tests;
877     store.register_late_pass(move |_| Box::new(dbg_macro::DbgMacro::new(allow_dbg_in_tests)));
878     let cargo_ignore_publish = conf.cargo_ignore_publish;
879     store.register_late_pass(move |_| {
880         Box::new(cargo::Cargo {
881             ignore_publish: cargo_ignore_publish,
882         })
883     });
884     store.register_late_pass(|_| Box::<write::Write>::default());
885     store.register_early_pass(|| Box::new(crate_in_macro_def::CrateInMacroDef));
886     store.register_early_pass(|| Box::new(empty_structs_with_brackets::EmptyStructsWithBrackets));
887     store.register_late_pass(|_| Box::new(unnecessary_owned_empty_strings::UnnecessaryOwnedEmptyStrings));
888     store.register_early_pass(|| Box::new(pub_use::PubUse));
889     store.register_late_pass(|_| Box::new(format_push_string::FormatPushString));
890     let max_include_file_size = conf.max_include_file_size;
891     store.register_late_pass(move |_| Box::new(large_include_file::LargeIncludeFile::new(max_include_file_size)));
892     store.register_late_pass(|_| Box::new(strings::TrimSplitWhitespace));
893     store.register_late_pass(|_| Box::new(rc_clone_in_vec_init::RcCloneInVecInit));
894     store.register_early_pass(|| Box::<duplicate_mod::DuplicateMod>::default());
895     store.register_early_pass(|| Box::new(unused_rounding::UnusedRounding));
896     store.register_early_pass(move || Box::new(almost_complete_letter_range::AlmostCompleteLetterRange::new(msrv)));
897     store.register_late_pass(|_| Box::new(swap_ptr_to_ref::SwapPtrToRef));
898     store.register_late_pass(|_| Box::new(mismatching_type_param_order::TypeParamMismatch));
899     store.register_late_pass(|_| Box::new(read_zero_byte_vec::ReadZeroByteVec));
900     store.register_late_pass(|_| Box::new(default_instead_of_iter_empty::DefaultIterEmpty));
901     store.register_late_pass(move |_| Box::new(manual_rem_euclid::ManualRemEuclid::new(msrv)));
902     store.register_late_pass(move |_| Box::new(manual_retain::ManualRetain::new(msrv)));
903     let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
904     store.register_late_pass(move |_| Box::new(operators::Operators::new(verbose_bit_mask_threshold)));
905     store.register_late_pass(|_| Box::new(invalid_utf8_in_unchecked::InvalidUtf8InUnchecked));
906     store.register_late_pass(|_| Box::<std_instead_of_core::StdReexports>::default());
907     store.register_late_pass(|_| Box::new(manual_instant_elapsed::ManualInstantElapsed));
908     store.register_late_pass(|_| Box::new(partialeq_to_none::PartialeqToNone));
909     store.register_late_pass(move |_| Box::new(manual_clamp::ManualClamp::new(msrv)));
910     store.register_late_pass(|_| Box::new(manual_string_new::ManualStringNew));
911     store.register_late_pass(|_| Box::new(unused_peekable::UnusedPeekable));
912     store.register_early_pass(|| Box::new(multi_assignments::MultiAssignments));
913     store.register_late_pass(|_| Box::new(bool_to_int_with_if::BoolToIntWithIf));
914     store.register_late_pass(|_| Box::new(box_default::BoxDefault));
915     store.register_late_pass(|_| Box::new(implicit_saturating_add::ImplicitSaturatingAdd));
916     store.register_early_pass(|| Box::new(partial_pub_fields::PartialPubFields));
917     store.register_late_pass(|_| Box::new(missing_trait_methods::MissingTraitMethods));
918     store.register_late_pass(|_| Box::new(from_raw_with_void_ptr::FromRawWithVoidPtr));
919     // add lints here, do not remove this comment, it's used in `new_lint`
920 }
921
922 #[rustfmt::skip]
923 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
924     store.register_removed(
925         "should_assert_eq",
926         "`assert!()` will be more flexible with RFC 2011",
927     );
928     store.register_removed(
929         "extend_from_slice",
930         "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
931     );
932     store.register_removed(
933         "range_step_by_zero",
934         "`iterator.step_by(0)` panics nowadays",
935     );
936     store.register_removed(
937         "unstable_as_slice",
938         "`Vec::as_slice` has been stabilized in 1.7",
939     );
940     store.register_removed(
941         "unstable_as_mut_slice",
942         "`Vec::as_mut_slice` has been stabilized in 1.7",
943     );
944     store.register_removed(
945         "misaligned_transmute",
946         "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
947     );
948     store.register_removed(
949         "assign_ops",
950         "using compound assignment operators (e.g., `+=`) is harmless",
951     );
952     store.register_removed(
953         "if_let_redundant_pattern_matching",
954         "this lint has been changed to redundant_pattern_matching",
955     );
956     store.register_removed(
957         "unsafe_vector_initialization",
958         "the replacement suggested by this lint had substantially different behavior",
959     );
960     store.register_removed(
961         "reverse_range_loop",
962         "this lint is now included in reversed_empty_ranges",
963     );
964 }
965
966 /// Register renamed lints.
967 ///
968 /// Used in `./src/driver.rs`.
969 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
970     for (old_name, new_name) in renamed_lints::RENAMED_LINTS {
971         ls.register_renamed(old_name, new_name);
972     }
973 }
974
975 // only exists to let the dogfood integration test works.
976 // Don't run clippy as an executable directly
977 #[allow(dead_code)]
978 fn main() {
979     panic!("Please use the cargo-clippy executable");
980 }