1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(collections)]
5 #![feature(custom_attribute)]
6 #![feature(dotdot_in_tuple_patterns)]
7 #![feature(question_mark)]
8 #![feature(rustc_private)]
9 #![feature(slice_patterns)]
10 #![feature(stmt_expr_attributes)]
11 #![feature(type_macros)]
13 #![allow(indexing_slicing, shadow_reuse, unknown_lints)]
22 // Only for the compile time checking of paths
24 extern crate collections;
26 // for unicode nfc normalization
27 extern crate unicode_normalization;
29 // for semver check in attrs.rs
33 extern crate regex_syntax;
35 // for finding minimal boolean expressions
36 extern crate quine_mc_cluskey;
38 extern crate rustc_serialize;
40 extern crate rustc_errors;
41 extern crate rustc_plugin;
42 extern crate rustc_const_eval;
43 extern crate rustc_const_math;
46 extern crate matches as matches_macro;
48 macro_rules! declare_restriction_lint {
49 { pub $name:tt, $description:tt } => {
50 declare_lint! { pub $name, Allow, $description }
58 // begin lints modules, do not remove this comment, it’s used in `update_lints`
61 pub mod array_indexing;
65 pub mod blacklisted_name;
66 pub mod block_in_if_condition;
68 pub mod collapsible_if;
70 pub mod cyclomatic_complexity;
76 pub mod enum_glob_use;
77 pub mod enum_variants;
80 pub mod eta_reduction;
81 pub mod eval_order_dependence;
87 pub mod items_after_statements;
99 pub mod module_inception;
101 pub mod mut_reference;
102 pub mod mutex_atomic;
103 pub mod needless_bool;
104 pub mod needless_borrow;
105 pub mod needless_update;
106 pub mod neg_multiply;
107 pub mod new_without_default;
109 pub mod non_expressive_names;
110 pub mod open_options;
111 pub mod overflow_check_conditional;
123 pub mod temporary_assignment;
127 pub mod unsafe_removed_from_name;
128 pub mod unused_label;
130 pub mod zero_div_zero;
131 // end lints modules, do not remove this comment, it’s used in `update_lints`
134 pub use syntax::ast::{Name, NodeId};
137 #[cfg_attr(rustfmt, rustfmt_skip)]
138 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
139 let conf = match utils::conf::file(reg.args()) {
141 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
142 // do not require the file to exist
143 let (file_name, must_exist) = if let Some(ref file_name) = file_name {
146 ("clippy.toml", false)
149 let (conf, errors) = utils::conf::read(file_name, must_exist);
151 // all conf errors are non-fatal, we just use the default conf in case of error
152 for error in errors {
153 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
158 Err((err, span)) => {
159 reg.sess.struct_span_err(span, err)
160 .span_note(span, "Clippy will use default configuration")
162 utils::conf::Conf::default()
166 let mut store = reg.sess.lint_store.borrow_mut();
167 store.register_removed("unstable_as_slice", "`Vec::as_slice` has been stabilized in 1.7");
168 store.register_removed("unstable_as_mut_slice", "`Vec::as_mut_slice` has been stabilized in 1.7");
169 store.register_removed("str_to_string", "using `str::to_string` is common even today and specialization will likely happen soon");
170 store.register_removed("string_to_string", "using `string::to_string` is common even today and specialization will likely happen soon");
171 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
173 reg.register_late_lint_pass(box serde::Serde);
174 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
175 reg.register_late_lint_pass(box types::TypePass);
176 reg.register_late_lint_pass(box booleans::NonminimalBool);
177 reg.register_early_lint_pass(box module_inception::Pass);
178 reg.register_late_lint_pass(box misc::TopLevelRefPass);
179 reg.register_late_lint_pass(box misc::CmpNan);
180 reg.register_late_lint_pass(box eq_op::EqOp);
181 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
182 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
183 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
184 reg.register_late_lint_pass(box bit_mask::BitMask);
185 reg.register_late_lint_pass(box ptr::PointerPass);
186 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
187 reg.register_late_lint_pass(box needless_bool::BoolComparison);
188 reg.register_late_lint_pass(box approx_const::Pass);
189 reg.register_late_lint_pass(box misc::FloatCmp);
190 reg.register_early_lint_pass(box precedence::Precedence);
191 reg.register_late_lint_pass(box eta_reduction::EtaPass);
192 reg.register_late_lint_pass(box identity_op::IdentityOp);
193 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
194 reg.register_late_lint_pass(box mut_mut::MutMut);
195 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
196 reg.register_late_lint_pass(box len_zero::LenZero);
197 reg.register_late_lint_pass(box misc::CmpOwned);
198 reg.register_late_lint_pass(box attrs::AttrPass);
199 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
200 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
201 reg.register_late_lint_pass(box misc::ModuloOne);
202 reg.register_late_lint_pass(box unicode::Unicode);
203 reg.register_late_lint_pass(box strings::StringAdd);
204 reg.register_early_lint_pass(box returns::ReturnPass);
205 reg.register_late_lint_pass(box methods::Pass);
206 reg.register_late_lint_pass(box shadow::Pass);
207 reg.register_late_lint_pass(box types::LetPass);
208 reg.register_late_lint_pass(box types::UnitCmp);
209 reg.register_late_lint_pass(box loops::Pass);
210 reg.register_late_lint_pass(box lifetimes::LifetimePass);
211 reg.register_late_lint_pass(box entry::HashMapLint);
212 reg.register_late_lint_pass(box ranges::StepByZero);
213 reg.register_late_lint_pass(box types::CastPass);
214 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
215 reg.register_late_lint_pass(box matches::MatchPass);
216 reg.register_late_lint_pass(box misc::PatternPass);
217 reg.register_late_lint_pass(box minmax::MinMaxPass);
218 reg.register_late_lint_pass(box open_options::NonSensical);
219 reg.register_late_lint_pass(box zero_div_zero::Pass);
220 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
221 reg.register_late_lint_pass(box needless_update::Pass);
222 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
223 reg.register_late_lint_pass(box no_effect::Pass);
224 reg.register_late_lint_pass(box map_clone::Pass);
225 reg.register_late_lint_pass(box temporary_assignment::Pass);
226 reg.register_late_lint_pass(box transmute::Transmute);
227 reg.register_late_lint_pass(box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold));
228 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
229 reg.register_early_lint_pass(box misc_early::MiscEarly);
230 reg.register_late_lint_pass(box misc::UsedUnderscoreBinding);
231 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
232 reg.register_late_lint_pass(box panic::Pass);
233 reg.register_late_lint_pass(box strings::StringLitAsBytes);
234 reg.register_late_lint_pass(box derive::Derive);
235 reg.register_late_lint_pass(box types::CharLitAsU8);
236 reg.register_late_lint_pass(box print::Pass);
237 reg.register_late_lint_pass(box vec::Pass);
238 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
239 max_single_char_names: conf.max_single_char_names,
241 reg.register_late_lint_pass(box drop_ref::Pass);
242 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
243 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
244 reg.register_late_lint_pass(box regex::Pass::default());
245 reg.register_late_lint_pass(box copies::CopyAndPaste);
246 reg.register_late_lint_pass(box format::Pass);
247 reg.register_early_lint_pass(box formatting::Formatting);
248 reg.register_late_lint_pass(box swap::Swap);
249 reg.register_early_lint_pass(box if_not_else::IfNotElse);
250 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
251 reg.register_late_lint_pass(box unused_label::UnusedLabel);
252 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
253 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
254 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
255 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
256 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
257 reg.register_late_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
258 reg.register_late_lint_pass(box mem_forget::MemForget);
259 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
260 reg.register_late_lint_pass(box assign_ops::AssignOps);
261 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
262 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
264 reg.register_lint_group("clippy_restrictions", vec![
265 arithmetic::FLOAT_ARITHMETIC,
266 arithmetic::INTEGER_ARITHMETIC,
267 array_indexing::INDEXING_SLICING,
268 assign_ops::ASSIGN_OPS,
271 reg.register_lint_group("clippy_pedantic", vec![
272 booleans::NONMINIMAL_BOOL,
273 enum_glob_use::ENUM_GLOB_USE,
274 enum_variants::STUTTER,
275 if_not_else::IF_NOT_ELSE,
276 items_after_statements::ITEMS_AFTER_STATEMENTS,
277 matches::SINGLE_MATCH_ELSE,
278 mem_forget::MEM_FORGET,
280 methods::OPTION_UNWRAP_USED,
281 methods::RESULT_UNWRAP_USED,
282 methods::WRONG_PUB_SELF_CONVENTION,
283 misc::USED_UNDERSCORE_BINDING,
284 misc_early::UNSEPARATED_LITERAL_SUFFIX,
286 mutex_atomic::MUTEX_INTEGER,
287 non_expressive_names::SIMILAR_NAMES,
290 shadow::SHADOW_REUSE,
292 shadow::SHADOW_UNRELATED,
294 strings::STRING_ADD_ASSIGN,
295 types::CAST_POSSIBLE_TRUNCATION,
296 types::CAST_POSSIBLE_WRAP,
297 types::CAST_PRECISION_LOSS,
298 types::CAST_SIGN_LOSS,
299 types::INVALID_UPCAST_COMPARISONS,
300 unicode::NON_ASCII_LITERAL,
301 unicode::UNICODE_NOT_NFC,
304 reg.register_lint_group("clippy", vec![
305 approx_const::APPROX_CONSTANT,
306 array_indexing::OUT_OF_BOUNDS_INDEXING,
307 assign_ops::ASSIGN_OP_PATTERN,
308 assign_ops::MISREFACTORED_ASSIGN_OP,
309 attrs::DEPRECATED_SEMVER,
310 attrs::INLINE_ALWAYS,
311 attrs::USELESS_ATTRIBUTE,
312 bit_mask::BAD_BIT_MASK,
313 bit_mask::INEFFECTIVE_BIT_MASK,
314 blacklisted_name::BLACKLISTED_NAME,
315 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
316 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
318 collapsible_if::COLLAPSIBLE_IF,
319 copies::IF_SAME_THEN_ELSE,
320 copies::IFS_SAME_COND,
321 copies::MATCH_SAME_ARMS,
322 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
323 derive::DERIVE_HASH_XOR_EQ,
324 derive::EXPL_IMPL_CLONE_ON_COPY,
328 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
329 enum_variants::ENUM_VARIANT_NAMES,
332 eta_reduction::REDUNDANT_CLOSURE,
333 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
334 format::USELESS_FORMAT,
335 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
336 formatting::SUSPICIOUS_ELSE_FORMATTING,
337 functions::NOT_UNSAFE_PTR_ARG_DEREF,
338 functions::TOO_MANY_ARGUMENTS,
339 identity_op::IDENTITY_OP,
340 len_zero::LEN_WITHOUT_IS_EMPTY,
342 let_if_seq::USELESS_LET_IF_SEQ,
343 lifetimes::NEEDLESS_LIFETIMES,
344 lifetimes::UNUSED_LIFETIMES,
346 loops::EXPLICIT_COUNTER_LOOP,
347 loops::EXPLICIT_ITER_LOOP,
349 loops::FOR_LOOP_OVER_OPTION,
350 loops::FOR_LOOP_OVER_RESULT,
351 loops::ITER_NEXT_LOOP,
352 loops::NEEDLESS_RANGE_LOOP,
353 loops::REVERSE_RANGE_LOOP,
354 loops::UNUSED_COLLECT,
355 loops::WHILE_LET_LOOP,
356 loops::WHILE_LET_ON_ITERATOR,
357 map_clone::MAP_CLONE,
359 matches::MATCH_OVERLAPPING_ARM,
360 matches::MATCH_REF_PATS,
361 matches::SINGLE_MATCH,
362 methods::CHARS_NEXT_CMP,
363 methods::CLONE_DOUBLE_REF,
364 methods::CLONE_ON_COPY,
365 methods::EXTEND_FROM_SLICE,
366 methods::FILTER_NEXT,
368 methods::NEW_RET_NO_SELF,
370 methods::OPTION_MAP_UNWRAP_OR,
371 methods::OPTION_MAP_UNWRAP_OR_ELSE,
372 methods::OR_FUN_CALL,
373 methods::SEARCH_IS_SOME,
374 methods::SHOULD_IMPLEMENT_TRAIT,
375 methods::SINGLE_CHAR_PATTERN,
376 methods::TEMPORARY_CSTRING_AS_PTR,
377 methods::WRONG_SELF_CONVENTION,
383 misc::REDUNDANT_PATTERN,
384 misc::TOPLEVEL_REF_ARG,
385 misc_early::DOUBLE_NEG,
386 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
387 misc_early::MIXED_CASE_HEX_LITERALS,
388 misc_early::REDUNDANT_CLOSURE_CALL,
389 misc_early::UNNEEDED_FIELD_PATTERN,
390 misc_early::ZERO_PREFIXED_LITERAL,
391 module_inception::MODULE_INCEPTION,
392 mut_reference::UNNECESSARY_MUT_PASSED,
393 mutex_atomic::MUTEX_ATOMIC,
394 needless_bool::BOOL_COMPARISON,
395 needless_bool::NEEDLESS_BOOL,
396 needless_borrow::NEEDLESS_BORROW,
397 needless_update::NEEDLESS_UPDATE,
398 neg_multiply::NEG_MULTIPLY,
399 new_without_default::NEW_WITHOUT_DEFAULT,
400 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
401 no_effect::NO_EFFECT,
402 no_effect::UNNECESSARY_OPERATION,
403 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
404 open_options::NONSENSICAL_OPEN_OPTIONS,
405 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
407 precedence::PRECEDENCE,
408 print::PRINT_WITH_NEWLINE,
411 ranges::RANGE_STEP_BY_ZERO,
412 ranges::RANGE_ZIP_WITH_LEN,
413 regex::INVALID_REGEX,
415 regex::TRIVIAL_REGEX,
416 returns::LET_AND_RETURN,
417 returns::NEEDLESS_RETURN,
418 serde::SERDE_API_MISUSE,
419 strings::STRING_LIT_AS_BYTES,
420 swap::ALMOST_SWAPPED,
422 temporary_assignment::TEMPORARY_ASSIGNMENT,
423 transmute::CROSSPOINTER_TRANSMUTE,
424 transmute::TRANSMUTE_PTR_TO_REF,
425 transmute::USELESS_TRANSMUTE,
426 transmute::WRONG_TRANSMUTE,
427 types::ABSURD_EXTREME_COMPARISONS,
429 types::CHAR_LIT_AS_U8,
430 types::LET_UNIT_VALUE,
432 types::TYPE_COMPLEXITY,
434 unicode::ZERO_WIDTH_SPACE,
435 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
436 unused_label::UNUSED_LABEL,
438 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
442 // only exists to let the dogfood integration test works.
443 // Don't run clippy as an executable directly
444 #[allow(dead_code, print_stdout)]
446 panic!("Please use the cargo-clippy executable");