1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(collections)]
5 #![feature(custom_attribute)]
8 #![feature(rustc_private)]
9 #![feature(slice_patterns)]
10 #![feature(stmt_expr_attributes)]
11 #![feature(conservative_impl_trait)]
13 #![allow(indexing_slicing, shadow_reuse, unknown_lints, missing_docs_in_private_items)]
16 extern crate syntax_pos;
19 extern crate rustc_data_structures;
23 // Only for the compile time checking of paths
25 extern crate collections;
27 // for unicode nfc normalization
28 extern crate unicode_normalization;
30 // for semver check in attrs.rs
34 extern crate regex_syntax;
36 // for finding minimal boolean expressions
37 extern crate quine_mc_cluskey;
39 extern crate rustc_errors;
40 extern crate rustc_plugin;
41 extern crate rustc_const_eval;
42 extern crate rustc_const_math;
45 extern crate matches as matches_macro;
48 extern crate serde_derive;
52 extern crate lazy_static;
54 macro_rules! declare_restriction_lint {
55 { pub $name:tt, $description:tt } => {
56 declare_lint! { pub $name, Allow, $description }
64 // begin lints modules, do not remove this comment, it’s used in `update_lints`
67 pub mod array_indexing;
71 pub mod blacklisted_name;
72 pub mod block_in_if_condition;
74 pub mod collapsible_if;
76 pub mod cyclomatic_complexity;
79 pub mod double_parens;
80 pub mod drop_forget_ref;
84 pub mod enum_glob_use;
85 pub mod enum_variants;
88 pub mod eta_reduction;
89 pub mod eval_order_dependence;
94 pub mod if_let_redundant_pattern_matching;
96 pub mod items_after_statements;
97 pub mod large_enum_variant;
111 pub mod mut_reference;
112 pub mod mutex_atomic;
113 pub mod needless_bool;
114 pub mod needless_borrow;
115 pub mod needless_continue;
116 pub mod needless_pass_by_value;
117 pub mod needless_update;
118 pub mod neg_multiply;
119 pub mod new_without_default;
121 pub mod non_expressive_names;
123 pub mod open_options;
124 pub mod overflow_check_conditional;
126 pub mod partialeq_ne_impl;
136 pub mod should_assert_eq;
139 pub mod temporary_assignment;
143 pub mod unsafe_removed_from_name;
144 pub mod unused_io_amount;
145 pub mod unused_label;
147 pub mod zero_div_zero;
148 // end lints modules, do not remove this comment, it’s used in `update_lints`
151 pub use syntax::ast::{Name, NodeId};
154 #[cfg_attr(rustfmt, rustfmt_skip)]
155 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
156 let conf = match utils::conf::file_from_args(reg.args()) {
158 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
159 // do not require the file to exist
160 let file_name = if let Some(file_name) = file_name {
163 match utils::conf::lookup_conf_file() {
166 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
172 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
174 // all conf errors are non-fatal, we just use the default conf in case of error
175 for error in errors {
176 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
181 Err((err, span)) => {
182 reg.sess.struct_span_err(span, err)
183 .span_note(span, "Clippy will use default configuration")
185 toml::from_str("").expect("we never error on empty config files")
189 let mut store = reg.sess.lint_store.borrow_mut();
190 store.register_removed(
192 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
194 store.register_removed(
196 "`Vec::as_slice` has been stabilized in 1.7",
198 store.register_removed(
199 "unstable_as_mut_slice",
200 "`Vec::as_mut_slice` has been stabilized in 1.7",
202 store.register_removed(
204 "using `str::to_string` is common even today and specialization will likely happen soon",
206 store.register_removed(
208 "using `string::to_string` is common even today and specialization will likely happen soon",
210 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
212 reg.register_late_lint_pass(box serde_api::Serde);
213 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
214 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
215 reg.register_late_lint_pass(box utils::inspector::Pass);
216 reg.register_late_lint_pass(box types::TypePass);
217 reg.register_late_lint_pass(box booleans::NonminimalBool);
218 reg.register_late_lint_pass(box eq_op::EqOp);
219 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
220 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
221 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
222 reg.register_late_lint_pass(box bit_mask::BitMask);
223 reg.register_late_lint_pass(box ptr::PointerPass);
224 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
225 reg.register_late_lint_pass(box needless_bool::BoolComparison);
226 reg.register_late_lint_pass(box approx_const::Pass);
227 reg.register_late_lint_pass(box misc::Pass);
228 reg.register_early_lint_pass(box precedence::Precedence);
229 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
230 reg.register_late_lint_pass(box eta_reduction::EtaPass);
231 reg.register_late_lint_pass(box identity_op::IdentityOp);
232 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
233 reg.register_late_lint_pass(box mut_mut::MutMut);
234 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
235 reg.register_late_lint_pass(box len_zero::LenZero);
236 reg.register_late_lint_pass(box attrs::AttrPass);
237 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
238 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
239 reg.register_late_lint_pass(box unicode::Unicode);
240 reg.register_late_lint_pass(box strings::StringAdd);
241 reg.register_early_lint_pass(box returns::ReturnPass);
242 reg.register_late_lint_pass(box methods::Pass);
243 reg.register_late_lint_pass(box shadow::Pass);
244 reg.register_late_lint_pass(box types::LetPass);
245 reg.register_late_lint_pass(box types::UnitCmp);
246 reg.register_late_lint_pass(box loops::Pass);
247 reg.register_late_lint_pass(box lifetimes::LifetimePass);
248 reg.register_late_lint_pass(box entry::HashMapLint);
249 reg.register_late_lint_pass(box ranges::StepByZero);
250 reg.register_late_lint_pass(box types::CastPass);
251 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
252 reg.register_late_lint_pass(box matches::MatchPass);
253 reg.register_late_lint_pass(box minmax::MinMaxPass);
254 reg.register_late_lint_pass(box open_options::NonSensical);
255 reg.register_late_lint_pass(box zero_div_zero::Pass);
256 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
257 reg.register_late_lint_pass(box needless_update::Pass);
258 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
259 reg.register_late_lint_pass(box no_effect::Pass);
260 reg.register_late_lint_pass(box map_clone::Pass);
261 reg.register_late_lint_pass(box temporary_assignment::Pass);
262 reg.register_late_lint_pass(box transmute::Transmute);
263 reg.register_late_lint_pass(
264 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
266 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
267 reg.register_early_lint_pass(box misc_early::MiscEarly);
268 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
269 reg.register_late_lint_pass(box panic::Pass);
270 reg.register_late_lint_pass(box strings::StringLitAsBytes);
271 reg.register_late_lint_pass(box derive::Derive);
272 reg.register_late_lint_pass(box types::CharLitAsU8);
273 reg.register_late_lint_pass(box print::Pass);
274 reg.register_late_lint_pass(box vec::Pass);
275 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
276 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
278 reg.register_late_lint_pass(box drop_forget_ref::Pass);
279 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
280 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
281 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
282 reg.register_late_lint_pass(box regex::Pass::default());
283 reg.register_late_lint_pass(box copies::CopyAndPaste);
284 reg.register_late_lint_pass(box format::Pass);
285 reg.register_early_lint_pass(box formatting::Formatting);
286 reg.register_late_lint_pass(box swap::Swap);
287 reg.register_early_lint_pass(box if_not_else::IfNotElse);
288 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
289 reg.register_late_lint_pass(box unused_label::UnusedLabel);
290 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
291 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
292 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
293 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
294 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
295 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
296 reg.register_late_lint_pass(box mem_forget::MemForget);
297 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
298 reg.register_late_lint_pass(box assign_ops::AssignOps);
299 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
300 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
301 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
302 reg.register_late_lint_pass(box ok_if_let::Pass);
303 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
304 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
305 reg.register_early_lint_pass(box reference::Pass);
306 reg.register_early_lint_pass(box double_parens::DoubleParens);
307 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
308 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
309 reg.register_late_lint_pass(box should_assert_eq::ShouldAssertEq);
310 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
312 reg.register_lint_group("clippy_restrictions", vec![
313 arithmetic::FLOAT_ARITHMETIC,
314 arithmetic::INTEGER_ARITHMETIC,
315 array_indexing::INDEXING_SLICING,
316 assign_ops::ASSIGN_OPS,
319 reg.register_lint_group("clippy_pedantic", vec![
320 booleans::NONMINIMAL_BOOL,
321 empty_enum::EMPTY_ENUM,
322 enum_glob_use::ENUM_GLOB_USE,
323 enum_variants::PUB_ENUM_VARIANT_NAMES,
324 enum_variants::STUTTER,
325 if_not_else::IF_NOT_ELSE,
326 items_after_statements::ITEMS_AFTER_STATEMENTS,
327 matches::SINGLE_MATCH_ELSE,
328 mem_forget::MEM_FORGET,
330 methods::OPTION_MAP_UNWRAP_OR,
331 methods::OPTION_MAP_UNWRAP_OR_ELSE,
332 methods::OPTION_UNWRAP_USED,
333 methods::RESULT_UNWRAP_USED,
334 methods::WRONG_PUB_SELF_CONVENTION,
335 misc::USED_UNDERSCORE_BINDING,
336 misc_early::UNSEPARATED_LITERAL_SUFFIX,
337 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
339 mutex_atomic::MUTEX_INTEGER,
340 non_expressive_names::SIMILAR_NAMES,
343 shadow::SHADOW_REUSE,
345 shadow::SHADOW_UNRELATED,
347 strings::STRING_ADD_ASSIGN,
348 types::CAST_POSSIBLE_TRUNCATION,
349 types::CAST_POSSIBLE_WRAP,
350 types::CAST_PRECISION_LOSS,
351 types::CAST_SIGN_LOSS,
352 types::INVALID_UPCAST_COMPARISONS,
353 unicode::NON_ASCII_LITERAL,
354 unicode::UNICODE_NOT_NFC,
357 reg.register_lint_group("clippy_internal", vec![
358 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
359 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
362 reg.register_lint_group("clippy", vec![
363 approx_const::APPROX_CONSTANT,
364 array_indexing::OUT_OF_BOUNDS_INDEXING,
365 assign_ops::ASSIGN_OP_PATTERN,
366 assign_ops::MISREFACTORED_ASSIGN_OP,
367 attrs::DEPRECATED_SEMVER,
368 attrs::INLINE_ALWAYS,
369 attrs::USELESS_ATTRIBUTE,
370 bit_mask::BAD_BIT_MASK,
371 bit_mask::INEFFECTIVE_BIT_MASK,
372 blacklisted_name::BLACKLISTED_NAME,
373 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
374 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
376 collapsible_if::COLLAPSIBLE_IF,
377 copies::IF_SAME_THEN_ELSE,
378 copies::IFS_SAME_COND,
379 copies::MATCH_SAME_ARMS,
380 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
381 derive::DERIVE_HASH_XOR_EQ,
382 derive::EXPL_IMPL_CLONE_ON_COPY,
384 double_parens::DOUBLE_PARENS,
385 drop_forget_ref::DROP_COPY,
386 drop_forget_ref::DROP_REF,
387 drop_forget_ref::FORGET_COPY,
388 drop_forget_ref::FORGET_REF,
390 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
391 enum_variants::ENUM_VARIANT_NAMES,
392 enum_variants::MODULE_INCEPTION,
396 eta_reduction::REDUNDANT_CLOSURE,
397 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
398 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
399 format::USELESS_FORMAT,
400 formatting::POSSIBLE_MISSING_COMMA,
401 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
402 formatting::SUSPICIOUS_ELSE_FORMATTING,
403 functions::NOT_UNSAFE_PTR_ARG_DEREF,
404 functions::TOO_MANY_ARGUMENTS,
405 identity_op::IDENTITY_OP,
406 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
407 large_enum_variant::LARGE_ENUM_VARIANT,
408 len_zero::LEN_WITHOUT_IS_EMPTY,
410 let_if_seq::USELESS_LET_IF_SEQ,
411 lifetimes::NEEDLESS_LIFETIMES,
412 lifetimes::UNUSED_LIFETIMES,
414 loops::EXPLICIT_COUNTER_LOOP,
415 loops::EXPLICIT_INTO_ITER_LOOP,
416 loops::EXPLICIT_ITER_LOOP,
418 loops::FOR_LOOP_OVER_OPTION,
419 loops::FOR_LOOP_OVER_RESULT,
420 loops::ITER_NEXT_LOOP,
421 loops::NEEDLESS_RANGE_LOOP,
423 loops::REVERSE_RANGE_LOOP,
424 loops::UNUSED_COLLECT,
425 loops::WHILE_LET_LOOP,
426 loops::WHILE_LET_ON_ITERATOR,
427 map_clone::MAP_CLONE,
429 matches::MATCH_OVERLAPPING_ARM,
430 matches::MATCH_REF_PATS,
431 matches::MATCH_WILD_ERR_ARM,
432 matches::SINGLE_MATCH,
433 methods::CHARS_NEXT_CMP,
434 methods::CLONE_DOUBLE_REF,
435 methods::CLONE_ON_COPY,
436 methods::FILTER_NEXT,
438 methods::ITER_CLONED_COLLECT,
440 methods::ITER_SKIP_NEXT,
441 methods::NEW_RET_NO_SELF,
443 methods::OR_FUN_CALL,
444 methods::SEARCH_IS_SOME,
445 methods::SHOULD_IMPLEMENT_TRAIT,
446 methods::SINGLE_CHAR_PATTERN,
447 methods::STRING_EXTEND_CHARS,
448 methods::TEMPORARY_CSTRING_AS_PTR,
449 methods::WRONG_SELF_CONVENTION,
455 misc::REDUNDANT_PATTERN,
456 misc::SHORT_CIRCUIT_STATEMENT,
457 misc::TOPLEVEL_REF_ARG,
459 misc_early::BUILTIN_TYPE_SHADOW,
460 misc_early::DOUBLE_NEG,
461 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
462 misc_early::MIXED_CASE_HEX_LITERALS,
463 misc_early::REDUNDANT_CLOSURE_CALL,
464 misc_early::UNNEEDED_FIELD_PATTERN,
465 misc_early::ZERO_PREFIXED_LITERAL,
466 mut_reference::UNNECESSARY_MUT_PASSED,
467 mutex_atomic::MUTEX_ATOMIC,
468 needless_bool::BOOL_COMPARISON,
469 needless_bool::NEEDLESS_BOOL,
470 needless_borrow::NEEDLESS_BORROW,
471 needless_continue::NEEDLESS_CONTINUE,
472 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
473 needless_update::NEEDLESS_UPDATE,
474 neg_multiply::NEG_MULTIPLY,
475 new_without_default::NEW_WITHOUT_DEFAULT,
476 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
477 no_effect::NO_EFFECT,
478 no_effect::UNNECESSARY_OPERATION,
479 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
480 ok_if_let::IF_LET_SOME_RESULT,
481 open_options::NONSENSICAL_OPEN_OPTIONS,
482 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
484 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
485 precedence::PRECEDENCE,
486 print::PRINT_WITH_NEWLINE,
490 ranges::RANGE_STEP_BY_ZERO,
491 ranges::RANGE_ZIP_WITH_LEN,
492 reference::DEREF_ADDROF,
493 regex::INVALID_REGEX,
495 regex::TRIVIAL_REGEX,
496 returns::LET_AND_RETURN,
497 returns::NEEDLESS_RETURN,
498 serde_api::SERDE_API_MISUSE,
499 should_assert_eq::SHOULD_ASSERT_EQ,
500 strings::STRING_LIT_AS_BYTES,
501 swap::ALMOST_SWAPPED,
503 temporary_assignment::TEMPORARY_ASSIGNMENT,
504 transmute::CROSSPOINTER_TRANSMUTE,
505 transmute::TRANSMUTE_PTR_TO_REF,
506 transmute::USELESS_TRANSMUTE,
507 transmute::WRONG_TRANSMUTE,
508 types::ABSURD_EXTREME_COMPARISONS,
511 types::CHAR_LIT_AS_U8,
512 types::LET_UNIT_VALUE,
514 types::TYPE_COMPLEXITY,
516 types::UNNECESSARY_CAST,
517 unicode::ZERO_WIDTH_SPACE,
518 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
519 unused_io_amount::UNUSED_IO_AMOUNT,
520 unused_label::UNUSED_LABEL,
522 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
526 // only exists to let the dogfood integration test works.
527 // Don't run clippy as an executable directly
528 #[allow(dead_code, print_stdout)]
530 panic!("Please use the cargo-clippy executable");