1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
5 #![feature(custom_attribute)]
8 #![feature(rustc_private)]
9 #![feature(slice_patterns)]
10 #![feature(stmt_expr_attributes)]
11 #![feature(conservative_impl_trait)]
13 #![allow(indexing_slicing, shadow_reuse, unknown_lints, missing_docs_in_private_items)]
16 extern crate syntax_pos;
19 extern crate rustc_data_structures;
23 // Only for the compile time checking of paths
27 // for unicode nfc normalization
28 extern crate unicode_normalization;
30 // for semver check in attrs.rs
34 extern crate regex_syntax;
36 // for finding minimal boolean expressions
37 extern crate quine_mc_cluskey;
39 extern crate rustc_errors;
40 extern crate rustc_plugin;
41 extern crate rustc_const_eval;
42 extern crate rustc_const_math;
45 extern crate matches as matches_macro;
48 extern crate serde_derive;
52 extern crate lazy_static;
54 extern crate itertools;
55 extern crate pulldown_cmark;
57 macro_rules! declare_restriction_lint {
58 { pub $name:tt, $description:tt } => {
59 declare_lint! { pub $name, Allow, $description }
67 // begin lints modules, do not remove this comment, it’s used in `update_lints`
70 pub mod array_indexing;
74 pub mod blacklisted_name;
75 pub mod block_in_if_condition;
77 pub mod collapsible_if;
79 pub mod cyclomatic_complexity;
82 pub mod double_parens;
83 pub mod drop_forget_ref;
87 pub mod enum_glob_use;
88 pub mod enum_variants;
91 pub mod eta_reduction;
92 pub mod eval_order_dependence;
97 pub mod if_let_redundant_pattern_matching;
99 pub mod items_after_statements;
100 pub mod large_enum_variant;
104 pub mod literal_digit_grouping;
115 pub mod mut_reference;
116 pub mod mutex_atomic;
117 pub mod needless_bool;
118 pub mod needless_borrow;
119 pub mod needless_borrowed_ref;
120 pub mod needless_continue;
121 pub mod needless_pass_by_value;
122 pub mod needless_update;
123 pub mod neg_multiply;
124 pub mod new_without_default;
126 pub mod non_expressive_names;
128 pub mod open_options;
129 pub mod overflow_check_conditional;
131 pub mod partialeq_ne_impl;
141 pub mod should_assert_eq;
144 pub mod temporary_assignment;
148 pub mod unsafe_removed_from_name;
149 pub mod unused_io_amount;
150 pub mod unused_label;
152 pub mod zero_div_zero;
153 // end lints modules, do not remove this comment, it’s used in `update_lints`
156 pub use syntax::ast::{Name, NodeId};
159 #[cfg_attr(rustfmt, rustfmt_skip)]
160 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
161 let conf = match utils::conf::file_from_args(reg.args()) {
163 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
164 // do not require the file to exist
165 let file_name = if let Some(file_name) = file_name {
168 match utils::conf::lookup_conf_file() {
171 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
177 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
179 // all conf errors are non-fatal, we just use the default conf in case of error
180 for error in errors {
181 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
186 Err((err, span)) => {
187 reg.sess.struct_span_err(span, err)
188 .span_note(span, "Clippy will use default configuration")
190 toml::from_str("").expect("we never error on empty config files")
194 let mut store = reg.sess.lint_store.borrow_mut();
195 store.register_removed(
197 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
199 store.register_removed(
200 "range_step_by_zero",
201 "`iterator.step_by(0)` panics nowadays",
203 store.register_removed(
205 "`Vec::as_slice` has been stabilized in 1.7",
207 store.register_removed(
208 "unstable_as_mut_slice",
209 "`Vec::as_mut_slice` has been stabilized in 1.7",
211 store.register_removed(
213 "using `str::to_string` is common even today and specialization will likely happen soon",
215 store.register_removed(
217 "using `string::to_string` is common even today and specialization will likely happen soon",
219 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
221 reg.register_late_lint_pass(box serde_api::Serde);
222 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
223 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
224 reg.register_late_lint_pass(box utils::inspector::Pass);
225 reg.register_late_lint_pass(box types::TypePass);
226 reg.register_late_lint_pass(box booleans::NonminimalBool);
227 reg.register_late_lint_pass(box eq_op::EqOp);
228 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
229 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
230 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
231 reg.register_late_lint_pass(box bit_mask::BitMask);
232 reg.register_late_lint_pass(box ptr::PointerPass);
233 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
234 reg.register_late_lint_pass(box needless_bool::BoolComparison);
235 reg.register_late_lint_pass(box approx_const::Pass);
236 reg.register_late_lint_pass(box misc::Pass);
237 reg.register_early_lint_pass(box precedence::Precedence);
238 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
239 reg.register_late_lint_pass(box eta_reduction::EtaPass);
240 reg.register_late_lint_pass(box identity_op::IdentityOp);
241 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
242 reg.register_late_lint_pass(box mut_mut::MutMut);
243 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
244 reg.register_late_lint_pass(box len_zero::LenZero);
245 reg.register_late_lint_pass(box attrs::AttrPass);
246 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
247 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
248 reg.register_late_lint_pass(box unicode::Unicode);
249 reg.register_late_lint_pass(box strings::StringAdd);
250 reg.register_early_lint_pass(box returns::ReturnPass);
251 reg.register_late_lint_pass(box methods::Pass);
252 reg.register_late_lint_pass(box shadow::Pass);
253 reg.register_late_lint_pass(box types::LetPass);
254 reg.register_late_lint_pass(box types::UnitCmp);
255 reg.register_late_lint_pass(box loops::Pass::default());
256 reg.register_late_lint_pass(box lifetimes::LifetimePass);
257 reg.register_late_lint_pass(box entry::HashMapLint);
258 reg.register_late_lint_pass(box ranges::StepByZero);
259 reg.register_late_lint_pass(box types::CastPass);
260 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
261 reg.register_late_lint_pass(box matches::MatchPass);
262 reg.register_late_lint_pass(box minmax::MinMaxPass);
263 reg.register_late_lint_pass(box open_options::NonSensical);
264 reg.register_late_lint_pass(box zero_div_zero::Pass);
265 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
266 reg.register_late_lint_pass(box needless_update::Pass);
267 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
268 reg.register_late_lint_pass(box no_effect::Pass);
269 reg.register_late_lint_pass(box map_clone::Pass);
270 reg.register_late_lint_pass(box temporary_assignment::Pass);
271 reg.register_late_lint_pass(box transmute::Transmute);
272 reg.register_late_lint_pass(
273 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
275 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
276 reg.register_early_lint_pass(box misc_early::MiscEarly);
277 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
278 reg.register_late_lint_pass(box panic::Pass);
279 reg.register_late_lint_pass(box strings::StringLitAsBytes);
280 reg.register_late_lint_pass(box derive::Derive);
281 reg.register_late_lint_pass(box types::CharLitAsU8);
282 reg.register_late_lint_pass(box print::Pass);
283 reg.register_late_lint_pass(box vec::Pass);
284 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
285 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
287 reg.register_late_lint_pass(box drop_forget_ref::Pass);
288 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
289 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
290 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
291 reg.register_late_lint_pass(box regex::Pass::default());
292 reg.register_late_lint_pass(box copies::CopyAndPaste);
293 reg.register_late_lint_pass(box format::Pass);
294 reg.register_early_lint_pass(box formatting::Formatting);
295 reg.register_late_lint_pass(box swap::Swap);
296 reg.register_early_lint_pass(box if_not_else::IfNotElse);
297 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
298 reg.register_late_lint_pass(box unused_label::UnusedLabel);
299 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
300 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
301 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
302 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
303 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
304 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
305 reg.register_late_lint_pass(box mem_forget::MemForget);
306 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
307 reg.register_late_lint_pass(box assign_ops::AssignOps);
308 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
309 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
310 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
311 reg.register_late_lint_pass(box ok_if_let::Pass);
312 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
313 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
314 reg.register_early_lint_pass(box reference::Pass);
315 reg.register_early_lint_pass(box double_parens::DoubleParens);
316 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
317 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
318 reg.register_late_lint_pass(box should_assert_eq::ShouldAssertEq);
319 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
320 reg.register_early_lint_pass(box literal_digit_grouping::LiteralDigitGrouping);
322 reg.register_lint_group("clippy_restrictions", vec![
323 arithmetic::FLOAT_ARITHMETIC,
324 arithmetic::INTEGER_ARITHMETIC,
325 array_indexing::INDEXING_SLICING,
326 assign_ops::ASSIGN_OPS,
329 reg.register_lint_group("clippy_pedantic", vec![
330 booleans::NONMINIMAL_BOOL,
331 empty_enum::EMPTY_ENUM,
332 enum_glob_use::ENUM_GLOB_USE,
333 enum_variants::PUB_ENUM_VARIANT_NAMES,
334 enum_variants::STUTTER,
335 if_not_else::IF_NOT_ELSE,
336 items_after_statements::ITEMS_AFTER_STATEMENTS,
337 matches::SINGLE_MATCH_ELSE,
338 mem_forget::MEM_FORGET,
340 methods::OPTION_MAP_UNWRAP_OR,
341 methods::OPTION_MAP_UNWRAP_OR_ELSE,
342 methods::OPTION_UNWRAP_USED,
343 methods::RESULT_UNWRAP_USED,
344 methods::WRONG_PUB_SELF_CONVENTION,
345 misc::USED_UNDERSCORE_BINDING,
346 misc_early::UNSEPARATED_LITERAL_SUFFIX,
347 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
349 mutex_atomic::MUTEX_INTEGER,
350 non_expressive_names::SIMILAR_NAMES,
353 shadow::SHADOW_REUSE,
355 shadow::SHADOW_UNRELATED,
357 strings::STRING_ADD_ASSIGN,
358 types::CAST_POSSIBLE_TRUNCATION,
359 types::CAST_POSSIBLE_WRAP,
360 types::CAST_PRECISION_LOSS,
361 types::CAST_SIGN_LOSS,
362 types::INVALID_UPCAST_COMPARISONS,
363 unicode::NON_ASCII_LITERAL,
364 unicode::UNICODE_NOT_NFC,
367 reg.register_lint_group("clippy_internal", vec![
368 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
369 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
372 reg.register_lint_group("clippy", vec![
373 approx_const::APPROX_CONSTANT,
374 array_indexing::OUT_OF_BOUNDS_INDEXING,
375 assign_ops::ASSIGN_OP_PATTERN,
376 assign_ops::MISREFACTORED_ASSIGN_OP,
377 attrs::DEPRECATED_SEMVER,
378 attrs::INLINE_ALWAYS,
379 attrs::USELESS_ATTRIBUTE,
380 bit_mask::BAD_BIT_MASK,
381 bit_mask::INEFFECTIVE_BIT_MASK,
382 blacklisted_name::BLACKLISTED_NAME,
383 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
384 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
386 collapsible_if::COLLAPSIBLE_IF,
387 copies::IF_SAME_THEN_ELSE,
388 copies::IFS_SAME_COND,
389 copies::MATCH_SAME_ARMS,
390 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
391 derive::DERIVE_HASH_XOR_EQ,
392 derive::EXPL_IMPL_CLONE_ON_COPY,
394 double_parens::DOUBLE_PARENS,
395 drop_forget_ref::DROP_COPY,
396 drop_forget_ref::DROP_REF,
397 drop_forget_ref::FORGET_COPY,
398 drop_forget_ref::FORGET_REF,
400 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
401 enum_variants::ENUM_VARIANT_NAMES,
402 enum_variants::MODULE_INCEPTION,
406 eta_reduction::REDUNDANT_CLOSURE,
407 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
408 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
409 format::USELESS_FORMAT,
410 formatting::POSSIBLE_MISSING_COMMA,
411 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
412 formatting::SUSPICIOUS_ELSE_FORMATTING,
413 functions::NOT_UNSAFE_PTR_ARG_DEREF,
414 functions::TOO_MANY_ARGUMENTS,
415 identity_op::IDENTITY_OP,
416 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
417 large_enum_variant::LARGE_ENUM_VARIANT,
418 len_zero::LEN_WITHOUT_IS_EMPTY,
420 let_if_seq::USELESS_LET_IF_SEQ,
421 lifetimes::NEEDLESS_LIFETIMES,
422 lifetimes::UNUSED_LIFETIMES,
423 literal_digit_grouping::INCONSISTENT_DIGIT_GROUPING,
424 literal_digit_grouping::LARGE_DIGIT_GROUPS,
425 literal_digit_grouping::UNREADABLE_LITERAL,
427 loops::EXPLICIT_COUNTER_LOOP,
428 loops::EXPLICIT_INTO_ITER_LOOP,
429 loops::EXPLICIT_ITER_LOOP,
431 loops::FOR_LOOP_OVER_OPTION,
432 loops::FOR_LOOP_OVER_RESULT,
433 loops::ITER_NEXT_LOOP,
434 loops::NEEDLESS_RANGE_LOOP,
436 loops::REVERSE_RANGE_LOOP,
437 loops::UNUSED_COLLECT,
438 loops::WHILE_LET_LOOP,
439 loops::WHILE_LET_ON_ITERATOR,
440 map_clone::MAP_CLONE,
442 matches::MATCH_OVERLAPPING_ARM,
443 matches::MATCH_REF_PATS,
444 matches::MATCH_WILD_ERR_ARM,
445 matches::SINGLE_MATCH,
446 methods::CHARS_NEXT_CMP,
447 methods::CLONE_DOUBLE_REF,
448 methods::CLONE_ON_COPY,
449 methods::FILTER_NEXT,
451 methods::ITER_CLONED_COLLECT,
453 methods::ITER_SKIP_NEXT,
454 methods::NEW_RET_NO_SELF,
456 methods::OR_FUN_CALL,
457 methods::SEARCH_IS_SOME,
458 methods::SHOULD_IMPLEMENT_TRAIT,
459 methods::SINGLE_CHAR_PATTERN,
460 methods::STRING_EXTEND_CHARS,
461 methods::TEMPORARY_CSTRING_AS_PTR,
462 methods::WRONG_SELF_CONVENTION,
468 misc::REDUNDANT_PATTERN,
469 misc::SHORT_CIRCUIT_STATEMENT,
470 misc::TOPLEVEL_REF_ARG,
472 misc_early::BUILTIN_TYPE_SHADOW,
473 misc_early::DOUBLE_NEG,
474 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
475 misc_early::MIXED_CASE_HEX_LITERALS,
476 misc_early::REDUNDANT_CLOSURE_CALL,
477 misc_early::UNNEEDED_FIELD_PATTERN,
478 misc_early::ZERO_PREFIXED_LITERAL,
479 mut_reference::UNNECESSARY_MUT_PASSED,
480 mutex_atomic::MUTEX_ATOMIC,
481 needless_bool::BOOL_COMPARISON,
482 needless_bool::NEEDLESS_BOOL,
483 needless_borrow::NEEDLESS_BORROW,
484 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
485 needless_continue::NEEDLESS_CONTINUE,
486 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
487 needless_update::NEEDLESS_UPDATE,
488 neg_multiply::NEG_MULTIPLY,
489 new_without_default::NEW_WITHOUT_DEFAULT,
490 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
491 no_effect::NO_EFFECT,
492 no_effect::UNNECESSARY_OPERATION,
493 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
494 ok_if_let::IF_LET_SOME_RESULT,
495 open_options::NONSENSICAL_OPEN_OPTIONS,
496 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
498 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
499 precedence::PRECEDENCE,
500 print::PRINT_WITH_NEWLINE,
504 ranges::ITERATOR_STEP_BY_ZERO,
505 ranges::RANGE_ZIP_WITH_LEN,
506 reference::DEREF_ADDROF,
507 regex::INVALID_REGEX,
509 regex::TRIVIAL_REGEX,
510 returns::LET_AND_RETURN,
511 returns::NEEDLESS_RETURN,
512 serde_api::SERDE_API_MISUSE,
513 should_assert_eq::SHOULD_ASSERT_EQ,
514 strings::STRING_LIT_AS_BYTES,
515 swap::ALMOST_SWAPPED,
517 temporary_assignment::TEMPORARY_ASSIGNMENT,
518 transmute::CROSSPOINTER_TRANSMUTE,
519 transmute::TRANSMUTE_PTR_TO_REF,
520 transmute::USELESS_TRANSMUTE,
521 transmute::WRONG_TRANSMUTE,
522 types::ABSURD_EXTREME_COMPARISONS,
525 types::CHAR_LIT_AS_U8,
526 types::LET_UNIT_VALUE,
528 types::TYPE_COMPLEXITY,
530 types::UNNECESSARY_CAST,
531 unicode::ZERO_WIDTH_SPACE,
532 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
533 unused_io_amount::UNUSED_IO_AMOUNT,
534 unused_label::UNUSED_LABEL,
536 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
540 // only exists to let the dogfood integration test works.
541 // Don't run clippy as an executable directly
542 #[allow(dead_code, print_stdout)]
544 panic!("Please use the cargo-clippy executable");