]> git.lizzy.rs Git - rust.git/blob - clippy_lints/src/lib.rs
Auto merge of #8030 - WaffleLapkin:ignore_trait_assoc_types_type_complexity, r=llogiq
[rust.git] / clippy_lints / src / lib.rs
1 // error-pattern:cargo-clippy
2
3 #![feature(box_patterns)]
4 #![feature(drain_filter)]
5 #![feature(in_band_lifetimes)]
6 #![feature(iter_zip)]
7 #![feature(once_cell)]
8 #![feature(rustc_private)]
9 #![feature(stmt_expr_attributes)]
10 #![feature(control_flow_enum)]
11 #![feature(let_else)]
12 #![recursion_limit = "512"]
13 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
14 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
15 #![warn(trivial_casts, trivial_numeric_casts)]
16 // warn on lints, that are included in `rust-lang/rust`s bootstrap
17 #![warn(rust_2018_idioms, unused_lifetimes)]
18 // warn on rustc internal lints
19 #![warn(rustc::internal)]
20
21 // FIXME: switch to something more ergonomic here, once available.
22 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
23 extern crate rustc_ast;
24 extern crate rustc_ast_pretty;
25 extern crate rustc_data_structures;
26 extern crate rustc_driver;
27 extern crate rustc_errors;
28 extern crate rustc_hir;
29 extern crate rustc_hir_pretty;
30 extern crate rustc_index;
31 extern crate rustc_infer;
32 extern crate rustc_lexer;
33 extern crate rustc_lint;
34 extern crate rustc_middle;
35 extern crate rustc_mir_dataflow;
36 extern crate rustc_parse;
37 extern crate rustc_parse_format;
38 extern crate rustc_session;
39 extern crate rustc_span;
40 extern crate rustc_target;
41 extern crate rustc_trait_selection;
42 extern crate rustc_typeck;
43
44 #[macro_use]
45 extern crate clippy_utils;
46
47 use clippy_utils::parse_msrv;
48 use rustc_data_structures::fx::FxHashSet;
49 use rustc_lint::LintId;
50 use rustc_session::Session;
51
52 /// Macro used to declare a Clippy lint.
53 ///
54 /// Every lint declaration consists of 4 parts:
55 ///
56 /// 1. The documentation, which is used for the website
57 /// 2. The `LINT_NAME`. See [lint naming][lint_naming] on lint naming conventions.
58 /// 3. The `lint_level`, which is a mapping from *one* of our lint groups to `Allow`, `Warn` or
59 ///    `Deny`. The lint level here has nothing to do with what lint groups the lint is a part of.
60 /// 4. The `description` that contains a short explanation on what's wrong with code where the
61 ///    lint is triggered.
62 ///
63 /// Currently the categories `style`, `correctness`, `suspicious`, `complexity` and `perf` are
64 /// enabled by default. As said in the README.md of this repository, if the lint level mapping
65 /// changes, please update README.md.
66 ///
67 /// # Example
68 ///
69 /// ```
70 /// #![feature(rustc_private)]
71 /// extern crate rustc_session;
72 /// use rustc_session::declare_tool_lint;
73 /// use clippy_lints::declare_clippy_lint;
74 ///
75 /// declare_clippy_lint! {
76 ///     /// ### What it does
77 ///     /// Checks for ... (describe what the lint matches).
78 ///     ///
79 ///     /// ### Why is this bad?
80 ///     /// Supply the reason for linting the code.
81 ///     ///
82 ///     /// ### Example
83 ///     /// ```rust
84 ///     /// // Bad
85 ///     /// Insert a short example of code that triggers the lint
86 ///     ///
87 ///     /// // Good
88 ///     /// Insert a short example of improved code that doesn't trigger the lint
89 ///     /// ```
90 ///     pub LINT_NAME,
91 ///     pedantic,
92 ///     "description"
93 /// }
94 /// ```
95 /// [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
96 #[macro_export]
97 macro_rules! declare_clippy_lint {
98     { $(#[$attr:meta])* pub $name:tt, style, $description:tt } => {
99         declare_tool_lint! {
100             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
101         }
102     };
103     { $(#[$attr:meta])* pub $name:tt, correctness, $description:tt } => {
104         declare_tool_lint! {
105             $(#[$attr])* pub clippy::$name, Deny, $description, report_in_external_macro: true
106         }
107     };
108     { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
109         declare_tool_lint! {
110             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
111         }
112     };
113     { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
114         declare_tool_lint! {
115             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
116         }
117     };
118     { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
119         declare_tool_lint! {
120             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
121         }
122     };
123     { $(#[$attr:meta])* pub $name:tt, pedantic, $description:tt } => {
124         declare_tool_lint! {
125             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
126         }
127     };
128     { $(#[$attr:meta])* pub $name:tt, restriction, $description:tt } => {
129         declare_tool_lint! {
130             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
131         }
132     };
133     { $(#[$attr:meta])* pub $name:tt, cargo, $description:tt } => {
134         declare_tool_lint! {
135             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
136         }
137     };
138     { $(#[$attr:meta])* pub $name:tt, nursery, $description:tt } => {
139         declare_tool_lint! {
140             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
141         }
142     };
143     { $(#[$attr:meta])* pub $name:tt, internal, $description:tt } => {
144         declare_tool_lint! {
145             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
146         }
147     };
148     { $(#[$attr:meta])* pub $name:tt, internal_warn, $description:tt } => {
149         declare_tool_lint! {
150             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
151         }
152     };
153 }
154
155 #[cfg(feature = "metadata-collector-lint")]
156 mod deprecated_lints;
157 #[cfg_attr(
158     any(feature = "internal-lints", feature = "metadata-collector-lint"),
159     allow(clippy::missing_clippy_version_attribute)
160 )]
161 mod utils;
162
163 // begin lints modules, do not remove this comment, it’s used in `update_lints`
164 mod absurd_extreme_comparisons;
165 mod approx_const;
166 mod arithmetic;
167 mod as_conversions;
168 mod asm_syntax;
169 mod assertions_on_constants;
170 mod assign_ops;
171 mod async_yields_async;
172 mod attrs;
173 mod await_holding_invalid;
174 mod bit_mask;
175 mod blacklisted_name;
176 mod blocks_in_if_conditions;
177 mod bool_assert_comparison;
178 mod booleans;
179 mod bytecount;
180 mod cargo_common_metadata;
181 mod case_sensitive_file_extension_comparisons;
182 mod casts;
183 mod checked_conversions;
184 mod cognitive_complexity;
185 mod collapsible_if;
186 mod collapsible_match;
187 mod comparison_chain;
188 mod copies;
189 mod copy_iterator;
190 mod create_dir;
191 mod dbg_macro;
192 mod default;
193 mod default_numeric_fallback;
194 mod dereference;
195 mod derivable_impls;
196 mod derive;
197 mod disallowed_methods;
198 mod disallowed_script_idents;
199 mod disallowed_types;
200 mod doc;
201 mod double_comparison;
202 mod double_parens;
203 mod drop_forget_ref;
204 mod duration_subsec;
205 mod else_if_without_else;
206 mod empty_enum;
207 mod entry;
208 mod enum_clike;
209 mod enum_variants;
210 mod eq_op;
211 mod equatable_if_let;
212 mod erasing_op;
213 mod escape;
214 mod eta_reduction;
215 mod eval_order_dependence;
216 mod excessive_bools;
217 mod exhaustive_items;
218 mod exit;
219 mod explicit_write;
220 mod fallible_impl_from;
221 mod feature_name;
222 mod float_equality_without_abs;
223 mod float_literal;
224 mod floating_point_arithmetic;
225 mod format;
226 mod format_args;
227 mod formatting;
228 mod from_over_into;
229 mod from_str_radix_10;
230 mod functions;
231 mod future_not_send;
232 mod get_last_with_len;
233 mod identity_op;
234 mod if_let_mutex;
235 mod if_not_else;
236 mod if_then_some_else_none;
237 mod implicit_hasher;
238 mod implicit_return;
239 mod implicit_saturating_sub;
240 mod inconsistent_struct_constructor;
241 mod index_refutable_slice;
242 mod indexing_slicing;
243 mod infinite_iter;
244 mod inherent_impl;
245 mod inherent_to_string;
246 mod inline_fn_without_body;
247 mod int_plus_one;
248 mod integer_division;
249 mod invalid_upcast_comparisons;
250 mod items_after_statements;
251 mod iter_not_returning_iterator;
252 mod large_const_arrays;
253 mod large_enum_variant;
254 mod large_stack_arrays;
255 mod len_zero;
256 mod let_if_seq;
257 mod let_underscore;
258 mod lifetimes;
259 mod literal_representation;
260 mod loops;
261 mod macro_use;
262 mod main_recursion;
263 mod manual_assert;
264 mod manual_async_fn;
265 mod manual_map;
266 mod manual_non_exhaustive;
267 mod manual_ok_or;
268 mod manual_strip;
269 mod manual_unwrap_or;
270 mod map_clone;
271 mod map_err_ignore;
272 mod map_unit_fn;
273 mod match_on_vec_items;
274 mod match_result_ok;
275 mod match_str_case_mismatch;
276 mod matches;
277 mod mem_forget;
278 mod mem_replace;
279 mod methods;
280 mod minmax;
281 mod misc;
282 mod misc_early;
283 mod missing_const_for_fn;
284 mod missing_doc;
285 mod missing_enforced_import_rename;
286 mod missing_inline;
287 mod module_style;
288 mod modulo_arithmetic;
289 mod multiple_crate_versions;
290 mod mut_key;
291 mod mut_mut;
292 mod mut_mutex_lock;
293 mod mut_reference;
294 mod mutable_debug_assertion;
295 mod mutex_atomic;
296 mod needless_arbitrary_self_type;
297 mod needless_bitwise_bool;
298 mod needless_bool;
299 mod needless_borrowed_ref;
300 mod needless_continue;
301 mod needless_for_each;
302 mod needless_late_init;
303 mod needless_option_as_deref;
304 mod needless_pass_by_value;
305 mod needless_question_mark;
306 mod needless_update;
307 mod neg_cmp_op_on_partial_ord;
308 mod neg_multiply;
309 mod new_without_default;
310 mod no_effect;
311 mod non_copy_const;
312 mod non_expressive_names;
313 mod non_octal_unix_permissions;
314 mod non_send_fields_in_send_ty;
315 mod nonstandard_macro_braces;
316 mod octal_escapes;
317 mod open_options;
318 mod option_env_unwrap;
319 mod option_if_let_else;
320 mod overflow_check_conditional;
321 mod panic_in_result_fn;
322 mod panic_unimplemented;
323 mod partialeq_ne_impl;
324 mod pass_by_ref_or_value;
325 mod path_buf_push_overwrite;
326 mod pattern_type_mismatch;
327 mod precedence;
328 mod ptr;
329 mod ptr_eq;
330 mod ptr_offset_with_cast;
331 mod question_mark;
332 mod ranges;
333 mod redundant_clone;
334 mod redundant_closure_call;
335 mod redundant_else;
336 mod redundant_field_names;
337 mod redundant_pub_crate;
338 mod redundant_slicing;
339 mod redundant_static_lifetimes;
340 mod ref_option_ref;
341 mod reference;
342 mod regex;
343 mod repeat_once;
344 mod returns;
345 mod same_name_method;
346 mod self_assignment;
347 mod self_named_constructors;
348 mod semicolon_if_nothing_returned;
349 mod serde_api;
350 mod shadow;
351 mod single_component_path_imports;
352 mod size_of_in_element_count;
353 mod slow_vector_initialization;
354 mod stable_sort_primitive;
355 mod strings;
356 mod strlen_on_c_strings;
357 mod suspicious_operation_groupings;
358 mod suspicious_trait_impl;
359 mod swap;
360 mod tabs_in_doc_comments;
361 mod temporary_assignment;
362 mod to_digit_is_some;
363 mod to_string_in_display;
364 mod trailing_empty_array;
365 mod trait_bounds;
366 mod transmute;
367 mod transmuting_null;
368 mod try_err;
369 mod types;
370 mod undocumented_unsafe_blocks;
371 mod undropped_manually_drops;
372 mod unicode;
373 mod uninit_vec;
374 mod unit_hash;
375 mod unit_return_expecting_ord;
376 mod unit_types;
377 mod unnamed_address;
378 mod unnecessary_self_imports;
379 mod unnecessary_sort_by;
380 mod unnecessary_wraps;
381 mod unnested_or_patterns;
382 mod unsafe_removed_from_name;
383 mod unused_async;
384 mod unused_io_amount;
385 mod unused_self;
386 mod unused_unit;
387 mod unwrap;
388 mod unwrap_in_result;
389 mod upper_case_acronyms;
390 mod use_self;
391 mod useless_conversion;
392 mod vec;
393 mod vec_init_then_push;
394 mod vec_resize_to_zero;
395 mod verbose_file_reads;
396 mod wildcard_dependencies;
397 mod wildcard_imports;
398 mod write;
399 mod zero_div_zero;
400 mod zero_sized_map_values;
401 // end lints modules, do not remove this comment, it’s used in `update_lints`
402
403 pub use crate::utils::conf::Conf;
404 use crate::utils::conf::TryConf;
405
406 /// Register all pre expansion lints
407 ///
408 /// Pre-expansion lints run before any macro expansion has happened.
409 ///
410 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
411 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
412 ///
413 /// Used in `./src/driver.rs`.
414 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
415     // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
416
417     let msrv = conf.msrv.as_ref().and_then(|s| {
418         parse_msrv(s, None, None).or_else(|| {
419             sess.err(&format!(
420                 "error reading Clippy's configuration file. `{}` is not a valid Rust version",
421                 s
422             ));
423             None
424         })
425     });
426
427     store.register_pre_expansion_pass(|| Box::new(write::Write::default()));
428     store.register_pre_expansion_pass(move || Box::new(attrs::EarlyAttributes { msrv }));
429     store.register_pre_expansion_pass(|| Box::new(dbg_macro::DbgMacro));
430 }
431
432 #[doc(hidden)]
433 pub fn read_conf(sess: &Session) -> Conf {
434     let file_name = match utils::conf::lookup_conf_file() {
435         Ok(Some(path)) => path,
436         Ok(None) => return Conf::default(),
437         Err(error) => {
438             sess.struct_err(&format!("error finding Clippy's configuration file: {}", error))
439                 .emit();
440             return Conf::default();
441         },
442     };
443
444     let TryConf { conf, errors } = utils::conf::read(&file_name);
445     // all conf errors are non-fatal, we just use the default conf in case of error
446     for error in errors {
447         sess.struct_err(&format!(
448             "error reading Clippy's configuration file `{}`: {}",
449             file_name.display(),
450             error
451         ))
452         .emit();
453     }
454
455     conf
456 }
457
458 /// Register all lints and lint groups with the rustc plugin registry
459 ///
460 /// Used in `./src/driver.rs`.
461 #[allow(clippy::too_many_lines)]
462 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
463     register_removed_non_tool_lints(store);
464
465     include!("lib.deprecated.rs");
466
467     include!("lib.register_lints.rs");
468     include!("lib.register_restriction.rs");
469     include!("lib.register_pedantic.rs");
470
471     #[cfg(feature = "internal-lints")]
472     include!("lib.register_internal.rs");
473
474     include!("lib.register_all.rs");
475     include!("lib.register_style.rs");
476     include!("lib.register_complexity.rs");
477     include!("lib.register_correctness.rs");
478     include!("lib.register_suspicious.rs");
479     include!("lib.register_perf.rs");
480     include!("lib.register_cargo.rs");
481     include!("lib.register_nursery.rs");
482
483     #[cfg(feature = "metadata-collector-lint")]
484     {
485         if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
486             store.register_late_pass(|| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
487             return;
488         }
489     }
490
491     // all the internal lints
492     #[cfg(feature = "internal-lints")]
493     {
494         store.register_early_pass(|| Box::new(utils::internal_lints::ClippyLintsInternal));
495         store.register_early_pass(|| Box::new(utils::internal_lints::ProduceIce));
496         store.register_late_pass(|| Box::new(utils::inspector::DeepCodeInspector));
497         store.register_late_pass(|| Box::new(utils::internal_lints::CollapsibleCalls));
498         store.register_late_pass(|| Box::new(utils::internal_lints::CompilerLintFunctions::new()));
499         store.register_late_pass(|| Box::new(utils::internal_lints::IfChainStyle));
500         store.register_late_pass(|| Box::new(utils::internal_lints::InvalidPaths));
501         store.register_late_pass(|| Box::new(utils::internal_lints::InterningDefinedSymbol::default()));
502         store.register_late_pass(|| Box::new(utils::internal_lints::LintWithoutLintPass::default()));
503         store.register_late_pass(|| Box::new(utils::internal_lints::MatchTypeOnDiagItem));
504         store.register_late_pass(|| Box::new(utils::internal_lints::OuterExpnDataPass));
505     }
506
507     store.register_late_pass(|| Box::new(utils::author::Author));
508     store.register_late_pass(|| Box::new(await_holding_invalid::AwaitHolding));
509     store.register_late_pass(|| Box::new(serde_api::SerdeApi));
510     let vec_box_size_threshold = conf.vec_box_size_threshold;
511     let type_complexity_threshold = conf.type_complexity_threshold;
512     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
513     store.register_late_pass(move || {
514         Box::new(types::Types::new(
515             vec_box_size_threshold,
516             type_complexity_threshold,
517             avoid_breaking_exported_api,
518         ))
519     });
520     store.register_late_pass(|| Box::new(booleans::NonminimalBool));
521     store.register_late_pass(|| Box::new(needless_bitwise_bool::NeedlessBitwiseBool));
522     store.register_late_pass(|| Box::new(eq_op::EqOp));
523     store.register_late_pass(|| Box::new(enum_clike::UnportableVariant));
524     store.register_late_pass(|| Box::new(float_literal::FloatLiteral));
525     let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
526     store.register_late_pass(move || Box::new(bit_mask::BitMask::new(verbose_bit_mask_threshold)));
527     store.register_late_pass(|| Box::new(ptr::Ptr));
528     store.register_late_pass(|| Box::new(ptr_eq::PtrEq));
529     store.register_late_pass(|| Box::new(needless_bool::NeedlessBool));
530     store.register_late_pass(|| Box::new(needless_option_as_deref::OptionNeedlessDeref));
531     store.register_late_pass(|| Box::new(needless_bool::BoolComparison));
532     store.register_late_pass(|| Box::new(needless_for_each::NeedlessForEach));
533     store.register_late_pass(|| Box::new(misc::MiscLints));
534     store.register_late_pass(|| Box::new(eta_reduction::EtaReduction));
535     store.register_late_pass(|| Box::new(identity_op::IdentityOp));
536     store.register_late_pass(|| Box::new(erasing_op::ErasingOp));
537     store.register_late_pass(|| Box::new(mut_mut::MutMut));
538     store.register_late_pass(|| Box::new(mut_reference::UnnecessaryMutPassed));
539     store.register_late_pass(|| Box::new(len_zero::LenZero));
540     store.register_late_pass(|| Box::new(attrs::Attributes));
541     store.register_late_pass(|| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
542     store.register_late_pass(|| Box::new(collapsible_match::CollapsibleMatch));
543     store.register_late_pass(|| Box::new(unicode::Unicode));
544     store.register_late_pass(|| Box::new(uninit_vec::UninitVec));
545     store.register_late_pass(|| Box::new(unit_hash::UnitHash));
546     store.register_late_pass(|| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
547     store.register_late_pass(|| Box::new(strings::StringAdd));
548     store.register_late_pass(|| Box::new(implicit_return::ImplicitReturn));
549     store.register_late_pass(|| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
550     store.register_late_pass(|| Box::new(default_numeric_fallback::DefaultNumericFallback));
551     store.register_late_pass(|| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
552     store.register_late_pass(|| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
553     store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
554
555     let msrv = conf.msrv.as_ref().and_then(|s| {
556         parse_msrv(s, None, None).or_else(|| {
557             sess.err(&format!(
558                 "error reading Clippy's configuration file. `{}` is not a valid Rust version",
559                 s
560             ));
561             None
562         })
563     });
564
565     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
566     store.register_late_pass(move || Box::new(approx_const::ApproxConstant::new(msrv)));
567     store.register_late_pass(move || Box::new(methods::Methods::new(avoid_breaking_exported_api, msrv)));
568     store.register_late_pass(move || Box::new(matches::Matches::new(msrv)));
569     store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustive::new(msrv)));
570     store.register_late_pass(move || Box::new(manual_strip::ManualStrip::new(msrv)));
571     store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv)));
572     store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv)));
573     store.register_late_pass(move || Box::new(checked_conversions::CheckedConversions::new(msrv)));
574     store.register_late_pass(move || Box::new(mem_replace::MemReplace::new(msrv)));
575     store.register_late_pass(move || Box::new(ranges::Ranges::new(msrv)));
576     store.register_late_pass(move || Box::new(from_over_into::FromOverInto::new(msrv)));
577     store.register_late_pass(move || Box::new(use_self::UseSelf::new(msrv)));
578     store.register_late_pass(move || Box::new(missing_const_for_fn::MissingConstForFn::new(msrv)));
579     store.register_late_pass(move || Box::new(needless_question_mark::NeedlessQuestionMark));
580     store.register_late_pass(move || Box::new(casts::Casts::new(msrv)));
581     store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv)));
582
583     store.register_late_pass(|| Box::new(size_of_in_element_count::SizeOfInElementCount));
584     store.register_late_pass(|| Box::new(same_name_method::SameNameMethod));
585     let max_suggested_slice_pattern_length = conf.max_suggested_slice_pattern_length;
586     store.register_late_pass(move || {
587         Box::new(index_refutable_slice::IndexRefutableSlice::new(
588             max_suggested_slice_pattern_length,
589             msrv,
590         ))
591     });
592     store.register_late_pass(|| Box::new(map_clone::MapClone));
593     store.register_late_pass(|| Box::new(map_err_ignore::MapErrIgnore));
594     store.register_late_pass(|| Box::new(shadow::Shadow::default()));
595     store.register_late_pass(|| Box::new(unit_types::UnitTypes));
596     store.register_late_pass(|| Box::new(loops::Loops));
597     store.register_late_pass(|| Box::new(main_recursion::MainRecursion::default()));
598     store.register_late_pass(|| Box::new(lifetimes::Lifetimes));
599     store.register_late_pass(|| Box::new(entry::HashMapPass));
600     store.register_late_pass(|| Box::new(minmax::MinMaxPass));
601     store.register_late_pass(|| Box::new(open_options::OpenOptions));
602     store.register_late_pass(|| Box::new(zero_div_zero::ZeroDiv));
603     store.register_late_pass(|| Box::new(mutex_atomic::Mutex));
604     store.register_late_pass(|| Box::new(needless_update::NeedlessUpdate));
605     store.register_late_pass(|| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
606     store.register_late_pass(|| Box::new(no_effect::NoEffect));
607     store.register_late_pass(|| Box::new(temporary_assignment::TemporaryAssignment));
608     store.register_late_pass(|| Box::new(transmute::Transmute));
609     let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
610     store.register_late_pass(move || {
611         Box::new(cognitive_complexity::CognitiveComplexity::new(
612             cognitive_complexity_threshold,
613         ))
614     });
615     let too_large_for_stack = conf.too_large_for_stack;
616     store.register_late_pass(move || Box::new(escape::BoxedLocal { too_large_for_stack }));
617     store.register_late_pass(move || Box::new(vec::UselessVec { too_large_for_stack }));
618     store.register_late_pass(|| Box::new(panic_unimplemented::PanicUnimplemented));
619     store.register_late_pass(|| Box::new(strings::StringLitAsBytes));
620     store.register_late_pass(|| Box::new(derive::Derive));
621     store.register_late_pass(|| Box::new(derivable_impls::DerivableImpls));
622     store.register_late_pass(|| Box::new(get_last_with_len::GetLastWithLen));
623     store.register_late_pass(|| Box::new(drop_forget_ref::DropForgetRef));
624     store.register_late_pass(|| Box::new(empty_enum::EmptyEnum));
625     store.register_late_pass(|| Box::new(absurd_extreme_comparisons::AbsurdExtremeComparisons));
626     store.register_late_pass(|| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
627     store.register_late_pass(|| Box::new(regex::Regex));
628     store.register_late_pass(|| Box::new(copies::CopyAndPaste));
629     store.register_late_pass(|| Box::new(copy_iterator::CopyIterator));
630     store.register_late_pass(|| Box::new(format::UselessFormat));
631     store.register_late_pass(|| Box::new(swap::Swap));
632     store.register_late_pass(|| Box::new(overflow_check_conditional::OverflowCheckConditional));
633     store.register_late_pass(|| Box::new(new_without_default::NewWithoutDefault::default()));
634     let blacklisted_names = conf.blacklisted_names.iter().cloned().collect::<FxHashSet<_>>();
635     store.register_late_pass(move || Box::new(blacklisted_name::BlacklistedName::new(blacklisted_names.clone())));
636     let too_many_arguments_threshold = conf.too_many_arguments_threshold;
637     let too_many_lines_threshold = conf.too_many_lines_threshold;
638     store.register_late_pass(move || {
639         Box::new(functions::Functions::new(
640             too_many_arguments_threshold,
641             too_many_lines_threshold,
642         ))
643     });
644     let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
645     store.register_late_pass(move || Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
646     store.register_late_pass(|| Box::new(neg_multiply::NegMultiply));
647     store.register_late_pass(|| Box::new(mem_forget::MemForget));
648     store.register_late_pass(|| Box::new(arithmetic::Arithmetic::default()));
649     store.register_late_pass(|| Box::new(assign_ops::AssignOps));
650     store.register_late_pass(|| Box::new(let_if_seq::LetIfSeq));
651     store.register_late_pass(|| Box::new(eval_order_dependence::EvalOrderDependence));
652     store.register_late_pass(|| Box::new(missing_doc::MissingDoc::new()));
653     store.register_late_pass(|| Box::new(missing_inline::MissingInline));
654     store.register_late_pass(move || Box::new(exhaustive_items::ExhaustiveItems));
655     store.register_late_pass(|| Box::new(match_result_ok::MatchResultOk));
656     store.register_late_pass(|| Box::new(partialeq_ne_impl::PartialEqNeImpl));
657     store.register_late_pass(|| Box::new(unused_io_amount::UnusedIoAmount));
658     let enum_variant_size_threshold = conf.enum_variant_size_threshold;
659     store.register_late_pass(move || Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
660     store.register_late_pass(|| Box::new(explicit_write::ExplicitWrite));
661     store.register_late_pass(|| Box::new(needless_pass_by_value::NeedlessPassByValue));
662     let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
663         conf.trivial_copy_size_limit,
664         conf.pass_by_value_size_limit,
665         conf.avoid_breaking_exported_api,
666         &sess.target,
667     );
668     store.register_late_pass(move || Box::new(pass_by_ref_or_value));
669     store.register_late_pass(|| Box::new(ref_option_ref::RefOptionRef));
670     store.register_late_pass(|| Box::new(try_err::TryErr));
671     store.register_late_pass(|| Box::new(bytecount::ByteCount));
672     store.register_late_pass(|| Box::new(infinite_iter::InfiniteIter));
673     store.register_late_pass(|| Box::new(inline_fn_without_body::InlineFnWithoutBody));
674     store.register_late_pass(|| Box::new(useless_conversion::UselessConversion::default()));
675     store.register_late_pass(|| Box::new(implicit_hasher::ImplicitHasher));
676     store.register_late_pass(|| Box::new(fallible_impl_from::FallibleImplFrom));
677     store.register_late_pass(|| Box::new(double_comparison::DoubleComparisons));
678     store.register_late_pass(|| Box::new(question_mark::QuestionMark));
679     store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
680     store.register_late_pass(|| Box::new(suspicious_trait_impl::SuspiciousImpl));
681     store.register_late_pass(|| Box::new(map_unit_fn::MapUnit));
682     store.register_late_pass(|| Box::new(inherent_impl::MultipleInherentImpl));
683     store.register_late_pass(|| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
684     store.register_late_pass(|| Box::new(unwrap::Unwrap));
685     store.register_late_pass(|| Box::new(duration_subsec::DurationSubsec));
686     store.register_late_pass(|| Box::new(indexing_slicing::IndexingSlicing));
687     store.register_late_pass(|| Box::new(non_copy_const::NonCopyConst));
688     store.register_late_pass(|| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
689     store.register_late_pass(|| Box::new(redundant_clone::RedundantClone));
690     store.register_late_pass(|| Box::new(slow_vector_initialization::SlowVectorInit));
691     store.register_late_pass(|| Box::new(unnecessary_sort_by::UnnecessarySortBy));
692     store.register_late_pass(move || Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
693     store.register_late_pass(|| Box::new(assertions_on_constants::AssertionsOnConstants));
694     store.register_late_pass(|| Box::new(transmuting_null::TransmutingNull));
695     store.register_late_pass(|| Box::new(path_buf_push_overwrite::PathBufPushOverwrite));
696     store.register_late_pass(|| Box::new(integer_division::IntegerDivision));
697     store.register_late_pass(|| Box::new(inherent_to_string::InherentToString));
698     let max_trait_bounds = conf.max_trait_bounds;
699     store.register_late_pass(move || Box::new(trait_bounds::TraitBounds::new(max_trait_bounds)));
700     store.register_late_pass(|| Box::new(comparison_chain::ComparisonChain));
701     store.register_late_pass(|| Box::new(mut_key::MutableKeyType));
702     store.register_late_pass(|| Box::new(modulo_arithmetic::ModuloArithmetic));
703     store.register_early_pass(|| Box::new(reference::DerefAddrOf));
704     store.register_early_pass(|| Box::new(reference::RefInDeref));
705     store.register_early_pass(|| Box::new(double_parens::DoubleParens));
706     store.register_late_pass(|| Box::new(to_string_in_display::ToStringInDisplay::new()));
707     store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
708     store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
709     store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
710     store.register_early_pass(|| Box::new(formatting::Formatting));
711     store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
712     store.register_early_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
713     store.register_late_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
714     store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
715     store.register_late_pass(|| Box::new(returns::Return));
716     store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
717     store.register_early_pass(|| Box::new(items_after_statements::ItemsAfterStatements));
718     store.register_early_pass(|| Box::new(precedence::Precedence));
719     store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
720     store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
721     store.register_late_pass(|| Box::new(create_dir::CreateDir));
722     store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
723     let cargo_ignore_publish = conf.cargo_ignore_publish;
724     store.register_late_pass(move || Box::new(cargo_common_metadata::CargoCommonMetadata::new(cargo_ignore_publish)));
725     store.register_late_pass(|| Box::new(multiple_crate_versions::MultipleCrateVersions));
726     store.register_late_pass(|| Box::new(wildcard_dependencies::WildcardDependencies));
727     let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
728     store.register_early_pass(move || {
729         Box::new(literal_representation::LiteralDigitGrouping::new(
730             literal_representation_lint_fraction_readability,
731         ))
732     });
733     let literal_representation_threshold = conf.literal_representation_threshold;
734     store.register_early_pass(move || {
735         Box::new(literal_representation::DecimalLiteralRepresentation::new(
736             literal_representation_threshold,
737         ))
738     });
739     let enum_variant_name_threshold = conf.enum_variant_name_threshold;
740     store.register_late_pass(move || {
741         Box::new(enum_variants::EnumVariantNames::new(
742             enum_variant_name_threshold,
743             avoid_breaking_exported_api,
744         ))
745     });
746     store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
747     let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
748     store.register_late_pass(move || {
749         Box::new(upper_case_acronyms::UpperCaseAcronyms::new(
750             avoid_breaking_exported_api,
751             upper_case_acronyms_aggressive,
752         ))
753     });
754     store.register_late_pass(|| Box::new(default::Default::default()));
755     store.register_late_pass(|| Box::new(unused_self::UnusedSelf));
756     store.register_late_pass(|| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
757     store.register_late_pass(|| Box::new(exit::Exit));
758     store.register_late_pass(|| Box::new(to_digit_is_some::ToDigitIsSome));
759     let array_size_threshold = conf.array_size_threshold;
760     store.register_late_pass(move || Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
761     store.register_late_pass(move || Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
762     store.register_late_pass(|| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
763     store.register_early_pass(|| Box::new(as_conversions::AsConversions));
764     store.register_late_pass(|| Box::new(let_underscore::LetUnderscore));
765     store.register_early_pass(|| Box::new(single_component_path_imports::SingleComponentPathImports));
766     let max_fn_params_bools = conf.max_fn_params_bools;
767     let max_struct_bools = conf.max_struct_bools;
768     store.register_early_pass(move || {
769         Box::new(excessive_bools::ExcessiveBools::new(
770             max_struct_bools,
771             max_fn_params_bools,
772         ))
773     });
774     store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
775     let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
776     store.register_late_pass(move || Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
777     store.register_late_pass(|| Box::new(verbose_file_reads::VerboseFileReads));
778     store.register_late_pass(|| Box::new(redundant_pub_crate::RedundantPubCrate::default()));
779     store.register_late_pass(|| Box::new(unnamed_address::UnnamedAddress));
780     store.register_late_pass(|| Box::new(dereference::Dereferencing::default()));
781     store.register_late_pass(|| Box::new(option_if_let_else::OptionIfLetElse));
782     store.register_late_pass(|| Box::new(future_not_send::FutureNotSend));
783     store.register_late_pass(|| Box::new(if_let_mutex::IfLetMutex));
784     store.register_late_pass(|| Box::new(if_not_else::IfNotElse));
785     store.register_late_pass(|| Box::new(equatable_if_let::PatternEquality));
786     store.register_late_pass(|| Box::new(mut_mutex_lock::MutMutexLock));
787     store.register_late_pass(|| Box::new(match_on_vec_items::MatchOnVecItems));
788     store.register_late_pass(|| Box::new(manual_async_fn::ManualAsyncFn));
789     store.register_late_pass(|| Box::new(vec_resize_to_zero::VecResizeToZero));
790     store.register_late_pass(|| Box::new(panic_in_result_fn::PanicInResultFn));
791     let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
792     store.register_early_pass(move || {
793         Box::new(non_expressive_names::NonExpressiveNames {
794             single_char_binding_names_threshold,
795         })
796     });
797     let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
798     store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(&macro_matcher)));
799     store.register_late_pass(|| Box::new(macro_use::MacroUseImports::default()));
800     store.register_late_pass(|| Box::new(pattern_type_mismatch::PatternTypeMismatch));
801     store.register_late_pass(|| Box::new(stable_sort_primitive::StableSortPrimitive));
802     store.register_late_pass(|| Box::new(repeat_once::RepeatOnce));
803     store.register_late_pass(|| Box::new(unwrap_in_result::UnwrapInResult));
804     store.register_late_pass(|| Box::new(self_assignment::SelfAssignment));
805     store.register_late_pass(|| Box::new(manual_unwrap_or::ManualUnwrapOr));
806     store.register_late_pass(|| Box::new(manual_ok_or::ManualOkOr));
807     store.register_late_pass(|| Box::new(float_equality_without_abs::FloatEqualityWithoutAbs));
808     store.register_late_pass(|| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
809     store.register_late_pass(|| Box::new(async_yields_async::AsyncYieldsAsync));
810     let disallowed_methods = conf.disallowed_methods.clone();
811     store.register_late_pass(move || Box::new(disallowed_methods::DisallowedMethods::new(disallowed_methods.clone())));
812     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
813     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
814     store.register_late_pass(|| Box::new(undropped_manually_drops::UndroppedManuallyDrops));
815     store.register_late_pass(|| Box::new(strings::StrToString));
816     store.register_late_pass(|| Box::new(strings::StringToString));
817     store.register_late_pass(|| Box::new(zero_sized_map_values::ZeroSizedMapValues));
818     store.register_late_pass(|| Box::new(vec_init_then_push::VecInitThenPush::default()));
819     store.register_late_pass(|| {
820         Box::new(case_sensitive_file_extension_comparisons::CaseSensitiveFileExtensionComparisons)
821     });
822     store.register_late_pass(|| Box::new(redundant_slicing::RedundantSlicing));
823     store.register_late_pass(|| Box::new(from_str_radix_10::FromStrRadix10));
824     store.register_late_pass(|| Box::new(manual_map::ManualMap));
825     store.register_late_pass(move || Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv)));
826     store.register_late_pass(|| Box::new(bool_assert_comparison::BoolAssertComparison));
827     store.register_early_pass(move || Box::new(module_style::ModStyle));
828     store.register_late_pass(|| Box::new(unused_async::UnusedAsync));
829     let disallowed_types = conf.disallowed_types.clone();
830     store.register_late_pass(move || Box::new(disallowed_types::DisallowedTypes::new(disallowed_types.clone())));
831     let import_renames = conf.enforced_import_renames.clone();
832     store.register_late_pass(move || {
833         Box::new(missing_enforced_import_rename::ImportRename::new(
834             import_renames.clone(),
835         ))
836     });
837     let scripts = conf.allowed_scripts.clone();
838     store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
839     store.register_late_pass(|| Box::new(strlen_on_c_strings::StrlenOnCStrings));
840     store.register_late_pass(move || Box::new(self_named_constructors::SelfNamedConstructors));
841     store.register_late_pass(move || Box::new(feature_name::FeatureName));
842     store.register_late_pass(move || Box::new(iter_not_returning_iterator::IterNotReturningIterator));
843     store.register_late_pass(move || Box::new(manual_assert::ManualAssert));
844     let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
845     store.register_late_pass(move || {
846         Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(
847             enable_raw_pointer_heuristic_for_send,
848         ))
849     });
850     store.register_late_pass(move || Box::new(undocumented_unsafe_blocks::UndocumentedUnsafeBlocks::default()));
851     store.register_late_pass(|| Box::new(match_str_case_mismatch::MatchStrCaseMismatch));
852     store.register_late_pass(move || Box::new(format_args::FormatArgs));
853     store.register_late_pass(|| Box::new(trailing_empty_array::TrailingEmptyArray));
854     store.register_early_pass(|| Box::new(octal_escapes::OctalEscapes));
855     store.register_late_pass(|| Box::new(needless_late_init::NeedlessLateInit));
856     // add lints here, do not remove this comment, it's used in `new_lint`
857 }
858
859 #[rustfmt::skip]
860 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
861     store.register_removed(
862         "should_assert_eq",
863         "`assert!()` will be more flexible with RFC 2011",
864     );
865     store.register_removed(
866         "extend_from_slice",
867         "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
868     );
869     store.register_removed(
870         "range_step_by_zero",
871         "`iterator.step_by(0)` panics nowadays",
872     );
873     store.register_removed(
874         "unstable_as_slice",
875         "`Vec::as_slice` has been stabilized in 1.7",
876     );
877     store.register_removed(
878         "unstable_as_mut_slice",
879         "`Vec::as_mut_slice` has been stabilized in 1.7",
880     );
881     store.register_removed(
882         "misaligned_transmute",
883         "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
884     );
885     store.register_removed(
886         "assign_ops",
887         "using compound assignment operators (e.g., `+=`) is harmless",
888     );
889     store.register_removed(
890         "if_let_redundant_pattern_matching",
891         "this lint has been changed to redundant_pattern_matching",
892     );
893     store.register_removed(
894         "unsafe_vector_initialization",
895         "the replacement suggested by this lint had substantially different behavior",
896     );
897     store.register_removed(
898         "reverse_range_loop",
899         "this lint is now included in reversed_empty_ranges",
900     );
901 }
902
903 /// Register renamed lints.
904 ///
905 /// Used in `./src/driver.rs`.
906 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
907     // NOTE: when renaming a lint, add a corresponding test to tests/ui/rename.rs
908     ls.register_renamed("clippy::stutter", "clippy::module_name_repetitions");
909     ls.register_renamed("clippy::new_without_default_derive", "clippy::new_without_default");
910     ls.register_renamed("clippy::cyclomatic_complexity", "clippy::cognitive_complexity");
911     ls.register_renamed("clippy::const_static_lifetime", "clippy::redundant_static_lifetimes");
912     ls.register_renamed("clippy::option_and_then_some", "clippy::bind_instead_of_map");
913     ls.register_renamed("clippy::box_vec", "clippy::box_collection");
914     ls.register_renamed("clippy::block_in_if_condition_expr", "clippy::blocks_in_if_conditions");
915     ls.register_renamed("clippy::block_in_if_condition_stmt", "clippy::blocks_in_if_conditions");
916     ls.register_renamed("clippy::option_map_unwrap_or", "clippy::map_unwrap_or");
917     ls.register_renamed("clippy::option_map_unwrap_or_else", "clippy::map_unwrap_or");
918     ls.register_renamed("clippy::result_map_unwrap_or_else", "clippy::map_unwrap_or");
919     ls.register_renamed("clippy::option_unwrap_used", "clippy::unwrap_used");
920     ls.register_renamed("clippy::result_unwrap_used", "clippy::unwrap_used");
921     ls.register_renamed("clippy::option_expect_used", "clippy::expect_used");
922     ls.register_renamed("clippy::result_expect_used", "clippy::expect_used");
923     ls.register_renamed("clippy::for_loop_over_option", "clippy::for_loops_over_fallibles");
924     ls.register_renamed("clippy::for_loop_over_result", "clippy::for_loops_over_fallibles");
925     ls.register_renamed("clippy::identity_conversion", "clippy::useless_conversion");
926     ls.register_renamed("clippy::zero_width_space", "clippy::invisible_characters");
927     ls.register_renamed("clippy::single_char_push_str", "clippy::single_char_add_str");
928     ls.register_renamed("clippy::if_let_some_result", "clippy::match_result_ok");
929     ls.register_renamed("clippy::disallowed_type", "clippy::disallowed_types");
930     ls.register_renamed("clippy::disallowed_method", "clippy::disallowed_methods");
931
932     // uplifted lints
933     ls.register_renamed("clippy::invalid_ref", "invalid_value");
934     ls.register_renamed("clippy::into_iter_on_array", "array_into_iter");
935     ls.register_renamed("clippy::unused_label", "unused_labels");
936     ls.register_renamed("clippy::drop_bounds", "drop_bounds");
937     ls.register_renamed("clippy::temporary_cstring_as_ptr", "temporary_cstring_as_ptr");
938     ls.register_renamed("clippy::panic_params", "non_fmt_panics");
939     ls.register_renamed("clippy::unknown_clippy_lints", "unknown_lints");
940     ls.register_renamed("clippy::invalid_atomic_ordering", "invalid_atomic_ordering");
941     ls.register_renamed("clippy::mem_discriminant_non_enum", "enum_intrinsics_non_enums");
942 }
943
944 // only exists to let the dogfood integration test works.
945 // Don't run clippy as an executable directly
946 #[allow(dead_code)]
947 fn main() {
948     panic!("Please use the cargo-clippy executable");
949 }