1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(rustc_private)]
5 #![feature(slice_patterns)]
6 #![feature(stmt_expr_attributes)]
7 #![feature(range_contains)]
8 #![feature(macro_vis_matcher)]
9 #![allow(unknown_lints, shadow_reuse, missing_docs_in_private_items)]
10 #![recursion_limit = "256"]
11 #![allow(stable_features)]
12 #![feature(iterator_find_map)]
13 #![feature(macro_at_most_once_rep)]
14 #![feature(rust_2018_preview)]
15 #![warn(rust_2018_idioms)]
22 macro_rules! declare_clippy_lint {
23 { pub $name:tt, style, $description:tt } => {
24 declare_lint! { pub $name, Warn, $description, report_in_external_macro: true }
26 { pub $name:tt, correctness, $description:tt } => {
27 declare_lint! { pub $name, Deny, $description, report_in_external_macro: true }
29 { pub $name:tt, complexity, $description:tt } => {
30 declare_lint! { pub $name, Warn, $description, report_in_external_macro: true }
32 { pub $name:tt, perf, $description:tt } => {
33 declare_lint! { pub $name, Warn, $description, report_in_external_macro: true }
35 { pub $name:tt, pedantic, $description:tt } => {
36 declare_lint! { pub $name, Allow, $description, report_in_external_macro: true }
38 { pub $name:tt, restriction, $description:tt } => {
39 declare_lint! { pub $name, Allow, $description, report_in_external_macro: true }
41 { pub $name:tt, cargo, $description:tt } => {
42 declare_lint! { pub $name, Allow, $description, report_in_external_macro: true }
44 { pub $name:tt, nursery, $description:tt } => {
45 declare_lint! { pub $name, Allow, $description, report_in_external_macro: true }
47 { pub $name:tt, internal, $description:tt } => {
48 declare_lint! { pub $name, Allow, $description, report_in_external_macro: true }
50 { pub $name:tt, internal_warn, $description:tt } => {
51 declare_lint! { pub $name, Warn, $description, report_in_external_macro: true }
59 // begin lints modules, do not remove this comment, it’s used in `update_lints`
65 pub mod blacklisted_name;
66 pub mod block_in_if_condition;
69 pub mod collapsible_if;
70 pub mod const_static_lifetime;
72 pub mod cyclomatic_complexity;
73 pub mod default_trait_access;
76 pub mod double_comparison;
77 pub mod double_parens;
78 pub mod drop_forget_ref;
79 pub mod duration_subsec;
80 pub mod else_if_without_else;
84 pub mod enum_glob_use;
85 pub mod enum_variants;
89 pub mod eta_reduction;
90 pub mod eval_order_dependence;
91 pub mod excessive_precision;
92 pub mod explicit_write;
93 pub mod fallible_impl_from;
97 pub mod identity_conversion;
99 pub mod if_let_redundant_pattern_matching;
101 pub mod indexing_slicing;
102 pub mod infallible_destructuring_match;
103 pub mod infinite_iter;
104 pub mod inherent_impl;
105 pub mod inline_fn_without_body;
106 pub mod int_plus_one;
108 pub mod items_after_statements;
109 pub mod large_enum_variant;
113 pub mod literal_representation;
124 pub mod missing_inline;
125 pub mod multiple_crate_versions;
127 pub mod mut_reference;
128 pub mod mutex_atomic;
129 pub mod needless_bool;
130 pub mod needless_borrow;
131 pub mod needless_borrowed_ref;
132 pub mod needless_continue;
133 pub mod needless_pass_by_value;
134 pub mod needless_update;
135 pub mod neg_cmp_op_on_partial_ord;
136 pub mod neg_multiply;
137 pub mod new_without_default;
139 pub mod non_copy_const;
140 pub mod non_expressive_names;
142 pub mod open_options;
143 pub mod overflow_check_conditional;
144 pub mod panic_unimplemented;
145 pub mod partialeq_ne_impl;
148 pub mod question_mark;
150 pub mod redundant_field_names;
153 pub mod replace_consts;
158 pub mod suspicious_trait_impl;
160 pub mod temporary_assignment;
162 pub mod trivially_copy_pass_by_ref;
165 pub mod unsafe_removed_from_name;
166 pub mod unused_io_amount;
167 pub mod unused_label;
172 pub mod zero_div_zero;
173 // end lints modules, do not remove this comment, it’s used in `update_lints`
176 crate use syntax::ast::{Name, NodeId};
179 pub fn register_pre_expansion_lints(session: &rustc::session::Session, store: &mut rustc::lint::LintStore) {
180 store.register_pre_expansion_pass(Some(session), box write::Pass);
183 #[cfg_attr(rustfmt, rustfmt_skip)]
184 pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>) {
185 let conf = match utils::conf::file_from_args(reg.args()) {
187 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
188 // do not require the file to exist
189 let file_name = if let Some(file_name) = file_name {
192 match utils::conf::lookup_conf_file() {
195 reg.sess.struct_err(&format!("error finding Clippy's configuration file: {}", error)).emit();
201 let file_name = file_name.map(|file_name| if file_name.is_relative() {
203 .local_crate_source_file
205 .and_then(|file| std::path::Path::new(&file).parent().map(std::path::Path::to_path_buf))
212 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
214 // all conf errors are non-fatal, we just use the default conf in case of error
215 for error in errors {
216 reg.sess.struct_err(&format!("error reading Clippy's configuration file `{}`: {}", file_name.as_ref().and_then(|p| p.to_str()).unwrap_or(""), error)).emit();
221 Err((err, span)) => {
222 reg.sess.struct_span_err(span, err)
223 .span_note(span, "Clippy will use default configuration")
225 toml::from_str("").expect("we never error on empty config files")
229 let mut store = reg.sess.lint_store.borrow_mut();
230 store.register_removed(
232 "`assert!()` will be more flexible with RFC 2011",
234 store.register_removed(
236 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
238 store.register_removed(
239 "range_step_by_zero",
240 "`iterator.step_by(0)` panics nowadays",
242 store.register_removed(
244 "`Vec::as_slice` has been stabilized in 1.7",
246 store.register_removed(
247 "unstable_as_mut_slice",
248 "`Vec::as_mut_slice` has been stabilized in 1.7",
250 store.register_removed(
252 "using `str::to_string` is common even today and specialization will likely happen soon",
254 store.register_removed(
256 "using `string::to_string` is common even today and specialization will likely happen soon",
258 store.register_removed(
259 "misaligned_transmute",
260 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
262 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
264 reg.register_late_lint_pass(box serde_api::Serde);
265 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
266 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
267 reg.register_late_lint_pass(box utils::inspector::Pass);
268 reg.register_late_lint_pass(box utils::author::Pass);
269 reg.register_late_lint_pass(box types::TypePass);
270 reg.register_late_lint_pass(box booleans::NonminimalBool);
271 reg.register_late_lint_pass(box eq_op::EqOp);
272 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
273 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
274 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
275 reg.register_late_lint_pass(box excessive_precision::ExcessivePrecision);
276 reg.register_late_lint_pass(box bit_mask::BitMask::new(conf.verbose_bit_mask_threshold));
277 reg.register_late_lint_pass(box ptr::PointerPass);
278 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
279 reg.register_late_lint_pass(box needless_bool::BoolComparison);
280 reg.register_late_lint_pass(box approx_const::Pass);
281 reg.register_late_lint_pass(box misc::Pass);
282 reg.register_early_lint_pass(box precedence::Precedence);
283 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
284 reg.register_late_lint_pass(box eta_reduction::EtaPass);
285 reg.register_late_lint_pass(box identity_op::IdentityOp);
286 reg.register_late_lint_pass(box erasing_op::ErasingOp);
287 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
288 reg.register_late_lint_pass(box mut_mut::MutMut);
289 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
290 reg.register_late_lint_pass(box len_zero::LenZero);
291 reg.register_late_lint_pass(box attrs::AttrPass);
292 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
293 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
294 reg.register_late_lint_pass(box unicode::Unicode);
295 reg.register_late_lint_pass(box strings::StringAdd);
296 reg.register_early_lint_pass(box returns::ReturnPass);
297 reg.register_late_lint_pass(box methods::Pass);
298 reg.register_late_lint_pass(box shadow::Pass);
299 reg.register_late_lint_pass(box types::LetPass);
300 reg.register_late_lint_pass(box types::UnitCmp);
301 reg.register_late_lint_pass(box loops::Pass);
302 reg.register_late_lint_pass(box lifetimes::LifetimePass);
303 reg.register_late_lint_pass(box entry::HashMapLint);
304 reg.register_late_lint_pass(box ranges::Pass);
305 reg.register_late_lint_pass(box types::CastPass);
306 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
307 reg.register_late_lint_pass(box matches::MatchPass);
308 reg.register_late_lint_pass(box minmax::MinMaxPass);
309 reg.register_late_lint_pass(box open_options::NonSensical);
310 reg.register_late_lint_pass(box zero_div_zero::Pass);
311 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
312 reg.register_late_lint_pass(box needless_update::Pass);
313 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
314 reg.register_late_lint_pass(box needless_borrowed_ref::NeedlessBorrowedRef);
315 reg.register_late_lint_pass(box no_effect::Pass);
316 reg.register_late_lint_pass(box map_clone::Pass);
317 reg.register_late_lint_pass(box temporary_assignment::Pass);
318 reg.register_late_lint_pass(box transmute::Transmute);
319 reg.register_late_lint_pass(
320 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
322 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
323 reg.register_early_lint_pass(box misc_early::MiscEarly);
324 reg.register_late_lint_pass(box panic_unimplemented::Pass);
325 reg.register_late_lint_pass(box strings::StringLitAsBytes);
326 reg.register_late_lint_pass(box derive::Derive);
327 reg.register_late_lint_pass(box types::CharLitAsU8);
328 reg.register_late_lint_pass(box vec::Pass);
329 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
330 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
332 reg.register_late_lint_pass(box drop_forget_ref::Pass);
333 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
334 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
335 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
336 reg.register_late_lint_pass(box regex::Pass::default());
337 reg.register_late_lint_pass(box copies::CopyAndPaste);
338 reg.register_late_lint_pass(box format::Pass);
339 reg.register_early_lint_pass(box formatting::Formatting);
340 reg.register_late_lint_pass(box swap::Swap);
341 reg.register_early_lint_pass(box if_not_else::IfNotElse);
342 reg.register_early_lint_pass(box else_if_without_else::ElseIfWithoutElse);
343 reg.register_early_lint_pass(box int_plus_one::IntPlusOne);
344 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
345 reg.register_late_lint_pass(box unused_label::UnusedLabel);
346 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
347 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
348 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
349 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
350 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
351 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
352 reg.register_late_lint_pass(box mem_forget::MemForget);
353 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
354 reg.register_late_lint_pass(box assign_ops::AssignOps);
355 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
356 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
357 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
358 reg.register_late_lint_pass(box missing_inline::MissingInline);
359 reg.register_late_lint_pass(box ok_if_let::Pass);
360 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
361 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
362 reg.register_early_lint_pass(box reference::Pass);
363 reg.register_early_lint_pass(box reference::DerefPass);
364 reg.register_early_lint_pass(box double_parens::DoubleParens);
365 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
366 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
367 reg.register_late_lint_pass(box explicit_write::Pass);
368 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
369 reg.register_late_lint_pass(box trivially_copy_pass_by_ref::TriviallyCopyPassByRef::new(
370 conf.trivial_copy_size_limit,
373 reg.register_early_lint_pass(box literal_representation::LiteralDigitGrouping);
374 reg.register_early_lint_pass(box literal_representation::LiteralRepresentation::new(
375 conf.literal_representation_threshold
377 reg.register_late_lint_pass(box use_self::UseSelf);
378 reg.register_late_lint_pass(box bytecount::ByteCount);
379 reg.register_late_lint_pass(box infinite_iter::Pass);
380 reg.register_late_lint_pass(box inline_fn_without_body::Pass);
381 reg.register_late_lint_pass(box invalid_ref::InvalidRef);
382 reg.register_late_lint_pass(box identity_conversion::IdentityConversion::default());
383 reg.register_late_lint_pass(box types::ImplicitHasher);
384 reg.register_early_lint_pass(box const_static_lifetime::StaticConst);
385 reg.register_late_lint_pass(box fallible_impl_from::FallibleImplFrom);
386 reg.register_late_lint_pass(box replace_consts::ReplaceConsts);
387 reg.register_late_lint_pass(box types::UnitArg);
388 reg.register_late_lint_pass(box double_comparison::DoubleComparisonPass);
389 reg.register_late_lint_pass(box question_mark::QuestionMarkPass);
390 reg.register_late_lint_pass(box suspicious_trait_impl::SuspiciousImpl);
391 reg.register_late_lint_pass(box redundant_field_names::RedundantFieldNames);
392 reg.register_early_lint_pass(box multiple_crate_versions::Pass);
393 reg.register_late_lint_pass(box map_unit_fn::Pass);
394 reg.register_late_lint_pass(box infallible_destructuring_match::Pass);
395 reg.register_late_lint_pass(box inherent_impl::Pass::default());
396 reg.register_late_lint_pass(box neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd);
397 reg.register_late_lint_pass(box unwrap::Pass);
398 reg.register_late_lint_pass(box duration_subsec::DurationSubsec);
399 reg.register_late_lint_pass(box default_trait_access::DefaultTraitAccess);
400 reg.register_late_lint_pass(box indexing_slicing::IndexingSlicing);
401 reg.register_late_lint_pass(box non_copy_const::NonCopyConst);
403 reg.register_lint_group("clippy_restriction", vec![
404 arithmetic::FLOAT_ARITHMETIC,
405 arithmetic::INTEGER_ARITHMETIC,
406 assign_ops::ASSIGN_OPS,
407 else_if_without_else::ELSE_IF_WITHOUT_ELSE,
408 inherent_impl::MULTIPLE_INHERENT_IMPL,
409 literal_representation::DECIMAL_LITERAL_REPRESENTATION,
410 mem_forget::MEM_FORGET,
411 methods::CLONE_ON_REF_PTR,
412 methods::OPTION_UNWRAP_USED,
413 methods::RESULT_UNWRAP_USED,
414 methods::WRONG_PUB_SELF_CONVENTION,
415 misc::FLOAT_CMP_CONST,
416 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
417 missing_inline::MISSING_INLINE_IN_PUBLIC_ITEMS,
418 panic_unimplemented::UNIMPLEMENTED,
419 shadow::SHADOW_REUSE,
421 shadow::SHADOW_UNRELATED,
427 reg.register_lint_group("clippy_pedantic", vec![
428 attrs::INLINE_ALWAYS,
429 copies::MATCH_SAME_ARMS,
430 default_trait_access::DEFAULT_TRAIT_ACCESS,
431 derive::EXPL_IMPL_CLONE_ON_COPY,
433 empty_enum::EMPTY_ENUM,
434 enum_glob_use::ENUM_GLOB_USE,
435 enum_variants::PUB_ENUM_VARIANT_NAMES,
436 enum_variants::STUTTER,
437 if_not_else::IF_NOT_ELSE,
438 indexing_slicing::INDEXING_SLICING,
439 infinite_iter::MAYBE_INFINITE_ITER,
440 items_after_statements::ITEMS_AFTER_STATEMENTS,
441 matches::SINGLE_MATCH_ELSE,
443 methods::OPTION_MAP_UNWRAP_OR,
444 methods::OPTION_MAP_UNWRAP_OR_ELSE,
445 methods::RESULT_MAP_UNWRAP_OR_ELSE,
446 misc::USED_UNDERSCORE_BINDING,
447 misc_early::UNSEPARATED_LITERAL_SUFFIX,
449 needless_continue::NEEDLESS_CONTINUE,
450 non_expressive_names::SIMILAR_NAMES,
451 replace_consts::REPLACE_CONSTS,
452 strings::STRING_ADD_ASSIGN,
453 types::CAST_POSSIBLE_TRUNCATION,
454 types::CAST_POSSIBLE_WRAP,
455 types::CAST_PRECISION_LOSS,
456 types::CAST_SIGN_LOSS,
457 types::INVALID_UPCAST_COMPARISONS,
459 unicode::NON_ASCII_LITERAL,
460 unicode::UNICODE_NOT_NFC,
464 reg.register_lint_group("clippy_internal", vec![
465 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
466 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
469 reg.register_lint_group("clippy", vec![
470 approx_const::APPROX_CONSTANT,
471 assign_ops::ASSIGN_OP_PATTERN,
472 assign_ops::MISREFACTORED_ASSIGN_OP,
473 attrs::DEPRECATED_SEMVER,
474 attrs::USELESS_ATTRIBUTE,
475 bit_mask::BAD_BIT_MASK,
476 bit_mask::INEFFECTIVE_BIT_MASK,
477 bit_mask::VERBOSE_BIT_MASK,
478 blacklisted_name::BLACKLISTED_NAME,
479 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
480 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
482 booleans::NONMINIMAL_BOOL,
483 bytecount::NAIVE_BYTECOUNT,
484 collapsible_if::COLLAPSIBLE_IF,
485 const_static_lifetime::CONST_STATIC_LIFETIME,
486 copies::IF_SAME_THEN_ELSE,
487 copies::IFS_SAME_COND,
488 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
489 derive::DERIVE_HASH_XOR_EQ,
490 double_comparison::DOUBLE_COMPARISONS,
491 double_parens::DOUBLE_PARENS,
492 drop_forget_ref::DROP_COPY,
493 drop_forget_ref::DROP_REF,
494 drop_forget_ref::FORGET_COPY,
495 drop_forget_ref::FORGET_REF,
496 duration_subsec::DURATION_SUBSEC,
498 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
499 enum_variants::ENUM_VARIANT_NAMES,
500 enum_variants::MODULE_INCEPTION,
503 erasing_op::ERASING_OP,
505 eta_reduction::REDUNDANT_CLOSURE,
506 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
507 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
508 excessive_precision::EXCESSIVE_PRECISION,
509 explicit_write::EXPLICIT_WRITE,
510 format::USELESS_FORMAT,
511 formatting::POSSIBLE_MISSING_COMMA,
512 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
513 formatting::SUSPICIOUS_ELSE_FORMATTING,
514 functions::NOT_UNSAFE_PTR_ARG_DEREF,
515 functions::TOO_MANY_ARGUMENTS,
516 identity_conversion::IDENTITY_CONVERSION,
517 identity_op::IDENTITY_OP,
518 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
519 indexing_slicing::OUT_OF_BOUNDS_INDEXING,
520 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
521 infinite_iter::INFINITE_ITER,
522 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
523 int_plus_one::INT_PLUS_ONE,
524 invalid_ref::INVALID_REF,
525 large_enum_variant::LARGE_ENUM_VARIANT,
526 len_zero::LEN_WITHOUT_IS_EMPTY,
528 let_if_seq::USELESS_LET_IF_SEQ,
529 lifetimes::EXTRA_UNUSED_LIFETIMES,
530 lifetimes::NEEDLESS_LIFETIMES,
531 literal_representation::INCONSISTENT_DIGIT_GROUPING,
532 literal_representation::LARGE_DIGIT_GROUPS,
533 literal_representation::UNREADABLE_LITERAL,
535 loops::EXPLICIT_COUNTER_LOOP,
536 loops::EXPLICIT_INTO_ITER_LOOP,
537 loops::EXPLICIT_ITER_LOOP,
539 loops::FOR_LOOP_OVER_OPTION,
540 loops::FOR_LOOP_OVER_RESULT,
541 loops::ITER_NEXT_LOOP,
542 loops::MANUAL_MEMCPY,
543 loops::MUT_RANGE_BOUND,
544 loops::NEEDLESS_RANGE_LOOP,
546 loops::REVERSE_RANGE_LOOP,
547 loops::UNUSED_COLLECT,
548 loops::WHILE_IMMUTABLE_CONDITION,
549 loops::WHILE_LET_LOOP,
550 loops::WHILE_LET_ON_ITERATOR,
551 map_clone::MAP_CLONE,
552 map_unit_fn::OPTION_MAP_UNIT_FN,
553 map_unit_fn::RESULT_MAP_UNIT_FN,
554 matches::MATCH_AS_REF,
556 matches::MATCH_OVERLAPPING_ARM,
557 matches::MATCH_REF_PATS,
558 matches::MATCH_WILD_ERR_ARM,
559 matches::SINGLE_MATCH,
560 methods::CHARS_LAST_CMP,
561 methods::CHARS_NEXT_CMP,
562 methods::CLONE_DOUBLE_REF,
563 methods::CLONE_ON_COPY,
564 methods::EXPECT_FUN_CALL,
565 methods::FILTER_NEXT,
567 methods::ITER_CLONED_COLLECT,
569 methods::ITER_SKIP_NEXT,
570 methods::NEW_RET_NO_SELF,
572 methods::OPTION_MAP_OR_NONE,
573 methods::OR_FUN_CALL,
574 methods::SEARCH_IS_SOME,
575 methods::SHOULD_IMPLEMENT_TRAIT,
576 methods::SINGLE_CHAR_PATTERN,
577 methods::STRING_EXTEND_CHARS,
578 methods::TEMPORARY_CSTRING_AS_PTR,
579 methods::UNNECESSARY_FOLD,
580 methods::USELESS_ASREF,
581 methods::WRONG_SELF_CONVENTION,
587 misc::REDUNDANT_PATTERN,
588 misc::SHORT_CIRCUIT_STATEMENT,
589 misc::TOPLEVEL_REF_ARG,
591 misc_early::BUILTIN_TYPE_SHADOW,
592 misc_early::DOUBLE_NEG,
593 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
594 misc_early::MIXED_CASE_HEX_LITERALS,
595 misc_early::REDUNDANT_CLOSURE_CALL,
596 misc_early::UNNEEDED_FIELD_PATTERN,
597 misc_early::ZERO_PREFIXED_LITERAL,
598 mut_reference::UNNECESSARY_MUT_PASSED,
599 mutex_atomic::MUTEX_ATOMIC,
600 needless_bool::BOOL_COMPARISON,
601 needless_bool::NEEDLESS_BOOL,
602 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
603 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
604 needless_update::NEEDLESS_UPDATE,
605 neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
606 neg_multiply::NEG_MULTIPLY,
607 new_without_default::NEW_WITHOUT_DEFAULT,
608 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
609 no_effect::NO_EFFECT,
610 no_effect::UNNECESSARY_OPERATION,
611 non_copy_const::BORROW_INTERIOR_MUTABLE_CONST,
612 non_copy_const::DECLARE_INTERIOR_MUTABLE_CONST,
613 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
614 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
615 ok_if_let::IF_LET_SOME_RESULT,
616 open_options::NONSENSICAL_OPEN_OPTIONS,
617 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
618 panic_unimplemented::PANIC_PARAMS,
619 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
620 precedence::PRECEDENCE,
624 question_mark::QUESTION_MARK,
625 ranges::ITERATOR_STEP_BY_ZERO,
626 ranges::RANGE_MINUS_ONE,
627 ranges::RANGE_ZIP_WITH_LEN,
628 redundant_field_names::REDUNDANT_FIELD_NAMES,
629 reference::DEREF_ADDROF,
630 reference::REF_IN_DEREF,
631 regex::INVALID_REGEX,
633 regex::TRIVIAL_REGEX,
634 returns::LET_AND_RETURN,
635 returns::NEEDLESS_RETURN,
636 serde_api::SERDE_API_MISUSE,
637 strings::STRING_LIT_AS_BYTES,
638 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
639 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
640 swap::ALMOST_SWAPPED,
642 temporary_assignment::TEMPORARY_ASSIGNMENT,
643 transmute::CROSSPOINTER_TRANSMUTE,
644 transmute::TRANSMUTE_BYTES_TO_STR,
645 transmute::TRANSMUTE_INT_TO_BOOL,
646 transmute::TRANSMUTE_INT_TO_CHAR,
647 transmute::TRANSMUTE_INT_TO_FLOAT,
648 transmute::TRANSMUTE_PTR_TO_PTR,
649 transmute::TRANSMUTE_PTR_TO_REF,
650 transmute::USELESS_TRANSMUTE,
651 transmute::WRONG_TRANSMUTE,
652 trivially_copy_pass_by_ref::TRIVIALLY_COPY_PASS_BY_REF,
653 types::ABSURD_EXTREME_COMPARISONS,
656 types::CAST_LOSSLESS,
657 types::CAST_PTR_ALIGNMENT,
658 types::CHAR_LIT_AS_U8,
659 types::FN_TO_NUMERIC_CAST,
660 types::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
661 types::IMPLICIT_HASHER,
662 types::LET_UNIT_VALUE,
663 types::OPTION_OPTION,
664 types::TYPE_COMPLEXITY,
667 types::UNNECESSARY_CAST,
668 unicode::ZERO_WIDTH_SPACE,
669 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
670 unused_io_amount::UNUSED_IO_AMOUNT,
671 unused_label::UNUSED_LABEL,
673 write::PRINT_LITERAL,
674 write::PRINT_WITH_NEWLINE,
675 write::PRINTLN_EMPTY_STRING,
676 write::WRITE_LITERAL,
677 write::WRITE_WITH_NEWLINE,
678 write::WRITELN_EMPTY_STRING,
679 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
682 reg.register_lint_group("clippy_style", vec![
683 assign_ops::ASSIGN_OP_PATTERN,
684 bit_mask::VERBOSE_BIT_MASK,
685 blacklisted_name::BLACKLISTED_NAME,
686 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
687 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
688 collapsible_if::COLLAPSIBLE_IF,
689 const_static_lifetime::CONST_STATIC_LIFETIME,
690 enum_variants::ENUM_VARIANT_NAMES,
691 enum_variants::MODULE_INCEPTION,
693 eta_reduction::REDUNDANT_CLOSURE,
694 excessive_precision::EXCESSIVE_PRECISION,
695 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
696 formatting::SUSPICIOUS_ELSE_FORMATTING,
697 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
698 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
699 len_zero::LEN_WITHOUT_IS_EMPTY,
701 let_if_seq::USELESS_LET_IF_SEQ,
702 literal_representation::INCONSISTENT_DIGIT_GROUPING,
703 literal_representation::LARGE_DIGIT_GROUPS,
704 literal_representation::UNREADABLE_LITERAL,
706 loops::EXPLICIT_INTO_ITER_LOOP,
707 loops::EXPLICIT_ITER_LOOP,
709 loops::NEEDLESS_RANGE_LOOP,
710 loops::WHILE_LET_ON_ITERATOR,
711 map_clone::MAP_CLONE,
713 matches::MATCH_OVERLAPPING_ARM,
714 matches::MATCH_REF_PATS,
715 matches::MATCH_WILD_ERR_ARM,
716 matches::SINGLE_MATCH,
717 methods::CHARS_LAST_CMP,
719 methods::ITER_CLONED_COLLECT,
720 methods::ITER_SKIP_NEXT,
721 methods::NEW_RET_NO_SELF,
723 methods::OPTION_MAP_OR_NONE,
724 methods::SHOULD_IMPLEMENT_TRAIT,
725 methods::STRING_EXTEND_CHARS,
726 methods::UNNECESSARY_FOLD,
727 methods::WRONG_SELF_CONVENTION,
728 misc::REDUNDANT_PATTERN,
729 misc::TOPLEVEL_REF_ARG,
731 misc_early::BUILTIN_TYPE_SHADOW,
732 misc_early::DOUBLE_NEG,
733 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
734 misc_early::MIXED_CASE_HEX_LITERALS,
735 misc_early::UNNEEDED_FIELD_PATTERN,
736 mut_reference::UNNECESSARY_MUT_PASSED,
737 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
738 neg_multiply::NEG_MULTIPLY,
739 new_without_default::NEW_WITHOUT_DEFAULT,
740 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
741 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
742 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
743 ok_if_let::IF_LET_SOME_RESULT,
744 panic_unimplemented::PANIC_PARAMS,
747 question_mark::QUESTION_MARK,
748 ranges::RANGE_MINUS_ONE,
749 redundant_field_names::REDUNDANT_FIELD_NAMES,
751 regex::TRIVIAL_REGEX,
752 returns::LET_AND_RETURN,
753 returns::NEEDLESS_RETURN,
754 strings::STRING_LIT_AS_BYTES,
755 types::FN_TO_NUMERIC_CAST,
756 types::IMPLICIT_HASHER,
757 types::LET_UNIT_VALUE,
758 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
759 write::PRINT_LITERAL,
760 write::PRINT_WITH_NEWLINE,
761 write::PRINTLN_EMPTY_STRING,
762 write::WRITE_LITERAL,
763 write::WRITE_WITH_NEWLINE,
764 write::WRITELN_EMPTY_STRING,
767 reg.register_lint_group("clippy_complexity", vec![
768 assign_ops::MISREFACTORED_ASSIGN_OP,
769 booleans::NONMINIMAL_BOOL,
770 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
771 double_comparison::DOUBLE_COMPARISONS,
772 double_parens::DOUBLE_PARENS,
773 duration_subsec::DURATION_SUBSEC,
774 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
775 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
776 explicit_write::EXPLICIT_WRITE,
777 format::USELESS_FORMAT,
778 functions::TOO_MANY_ARGUMENTS,
779 identity_conversion::IDENTITY_CONVERSION,
780 identity_op::IDENTITY_OP,
781 int_plus_one::INT_PLUS_ONE,
782 lifetimes::EXTRA_UNUSED_LIFETIMES,
783 lifetimes::NEEDLESS_LIFETIMES,
784 loops::EXPLICIT_COUNTER_LOOP,
785 loops::MUT_RANGE_BOUND,
786 loops::WHILE_LET_LOOP,
787 map_unit_fn::OPTION_MAP_UNIT_FN,
788 map_unit_fn::RESULT_MAP_UNIT_FN,
789 matches::MATCH_AS_REF,
790 methods::CHARS_NEXT_CMP,
791 methods::CLONE_ON_COPY,
792 methods::FILTER_NEXT,
793 methods::SEARCH_IS_SOME,
794 methods::USELESS_ASREF,
795 misc::SHORT_CIRCUIT_STATEMENT,
796 misc_early::REDUNDANT_CLOSURE_CALL,
797 misc_early::ZERO_PREFIXED_LITERAL,
798 needless_bool::BOOL_COMPARISON,
799 needless_bool::NEEDLESS_BOOL,
800 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
801 needless_update::NEEDLESS_UPDATE,
802 neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
803 no_effect::NO_EFFECT,
804 no_effect::UNNECESSARY_OPERATION,
805 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
806 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
807 precedence::PRECEDENCE,
808 ranges::RANGE_ZIP_WITH_LEN,
809 reference::DEREF_ADDROF,
810 reference::REF_IN_DEREF,
812 temporary_assignment::TEMPORARY_ASSIGNMENT,
813 transmute::CROSSPOINTER_TRANSMUTE,
814 transmute::TRANSMUTE_BYTES_TO_STR,
815 transmute::TRANSMUTE_INT_TO_BOOL,
816 transmute::TRANSMUTE_INT_TO_CHAR,
817 transmute::TRANSMUTE_INT_TO_FLOAT,
818 transmute::TRANSMUTE_PTR_TO_PTR,
819 transmute::TRANSMUTE_PTR_TO_REF,
820 transmute::USELESS_TRANSMUTE,
822 types::CAST_LOSSLESS,
823 types::CHAR_LIT_AS_U8,
824 types::OPTION_OPTION,
825 types::TYPE_COMPLEXITY,
827 types::UNNECESSARY_CAST,
828 unused_label::UNUSED_LABEL,
829 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
832 reg.register_lint_group("clippy_correctness", vec![
833 approx_const::APPROX_CONSTANT,
834 attrs::DEPRECATED_SEMVER,
835 attrs::USELESS_ATTRIBUTE,
836 bit_mask::BAD_BIT_MASK,
837 bit_mask::INEFFECTIVE_BIT_MASK,
839 copies::IF_SAME_THEN_ELSE,
840 copies::IFS_SAME_COND,
841 derive::DERIVE_HASH_XOR_EQ,
842 drop_forget_ref::DROP_COPY,
843 drop_forget_ref::DROP_REF,
844 drop_forget_ref::FORGET_COPY,
845 drop_forget_ref::FORGET_REF,
846 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
848 erasing_op::ERASING_OP,
849 formatting::POSSIBLE_MISSING_COMMA,
850 functions::NOT_UNSAFE_PTR_ARG_DEREF,
851 indexing_slicing::OUT_OF_BOUNDS_INDEXING,
852 infinite_iter::INFINITE_ITER,
853 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
854 invalid_ref::INVALID_REF,
855 loops::FOR_LOOP_OVER_OPTION,
856 loops::FOR_LOOP_OVER_RESULT,
857 loops::ITER_NEXT_LOOP,
859 loops::REVERSE_RANGE_LOOP,
860 loops::WHILE_IMMUTABLE_CONDITION,
861 methods::CLONE_DOUBLE_REF,
862 methods::TEMPORARY_CSTRING_AS_PTR,
867 non_copy_const::BORROW_INTERIOR_MUTABLE_CONST,
868 non_copy_const::DECLARE_INTERIOR_MUTABLE_CONST,
869 open_options::NONSENSICAL_OPEN_OPTIONS,
871 ranges::ITERATOR_STEP_BY_ZERO,
872 regex::INVALID_REGEX,
873 serde_api::SERDE_API_MISUSE,
874 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
875 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
876 swap::ALMOST_SWAPPED,
877 transmute::WRONG_TRANSMUTE,
878 types::ABSURD_EXTREME_COMPARISONS,
879 types::CAST_PTR_ALIGNMENT,
880 types::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
882 unicode::ZERO_WIDTH_SPACE,
883 unused_io_amount::UNUSED_IO_AMOUNT,
886 reg.register_lint_group("clippy_perf", vec![
887 bytecount::NAIVE_BYTECOUNT,
890 large_enum_variant::LARGE_ENUM_VARIANT,
891 loops::MANUAL_MEMCPY,
892 loops::UNUSED_COLLECT,
893 methods::EXPECT_FUN_CALL,
895 methods::OR_FUN_CALL,
896 methods::SINGLE_CHAR_PATTERN,
898 mutex_atomic::MUTEX_ATOMIC,
899 trivially_copy_pass_by_ref::TRIVIALLY_COPY_PASS_BY_REF,
904 reg.register_lint_group("clippy_cargo", vec![
905 multiple_crate_versions::MULTIPLE_CRATE_VERSIONS,
908 reg.register_lint_group("clippy_nursery", vec![
909 attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
910 fallible_impl_from::FALLIBLE_IMPL_FROM,
911 mutex_atomic::MUTEX_INTEGER,
912 needless_borrow::NEEDLESS_BORROW,
913 ranges::RANGE_PLUS_ONE,
914 unwrap::PANICKING_UNWRAP,
915 unwrap::UNNECESSARY_UNWRAP,
919 // only exists to let the dogfood integration test works.
920 // Don't run clippy as an executable directly
921 #[allow(dead_code, print_stdout)]
923 panic!("Please use the cargo-clippy executable");