1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
5 #![feature(custom_attribute)]
8 #![feature(rustc_private)]
9 #![feature(slice_patterns)]
10 #![feature(stmt_expr_attributes)]
11 #![feature(conservative_impl_trait)]
13 #![allow(indexing_slicing, shadow_reuse, unknown_lints, missing_docs_in_private_items)]
16 extern crate syntax_pos;
19 extern crate rustc_data_structures;
23 // Only for the compile time checking of paths
27 // for unicode nfc normalization
28 extern crate unicode_normalization;
30 // for semver check in attrs.rs
34 extern crate regex_syntax;
36 // for finding minimal boolean expressions
37 extern crate quine_mc_cluskey;
39 extern crate rustc_errors;
40 extern crate rustc_plugin;
41 extern crate rustc_const_eval;
42 extern crate rustc_const_math;
45 extern crate matches as matches_macro;
48 extern crate serde_derive;
52 extern crate lazy_static;
54 extern crate itertools;
55 extern crate pulldown_cmark;
57 macro_rules! declare_restriction_lint {
58 { pub $name:tt, $description:tt } => {
59 declare_lint! { pub $name, Allow, $description }
67 // begin lints modules, do not remove this comment, it’s used in `update_lints`
70 pub mod array_indexing;
74 pub mod blacklisted_name;
75 pub mod block_in_if_condition;
77 pub mod collapsible_if;
79 pub mod cyclomatic_complexity;
82 pub mod double_parens;
83 pub mod drop_forget_ref;
87 pub mod enum_glob_use;
88 pub mod enum_variants;
91 pub mod eta_reduction;
92 pub mod eval_order_dependence;
97 pub mod if_let_redundant_pattern_matching;
99 pub mod items_after_statements;
100 pub mod large_enum_variant;
104 pub mod literal_digit_grouping;
115 pub mod mut_reference;
116 pub mod mutex_atomic;
117 pub mod needless_bool;
118 pub mod needless_borrow;
119 pub mod needless_borrowed_ref;
120 pub mod needless_continue;
121 pub mod needless_pass_by_value;
122 pub mod needless_update;
123 pub mod neg_multiply;
124 pub mod new_without_default;
126 pub mod non_expressive_names;
128 pub mod open_options;
129 pub mod overflow_check_conditional;
131 pub mod partialeq_ne_impl;
141 pub mod should_assert_eq;
144 pub mod temporary_assignment;
148 pub mod unsafe_removed_from_name;
149 pub mod unused_io_amount;
150 pub mod unused_label;
153 pub mod zero_div_zero;
154 // end lints modules, do not remove this comment, it’s used in `update_lints`
157 pub use syntax::ast::{Name, NodeId};
160 #[cfg_attr(rustfmt, rustfmt_skip)]
161 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
162 let conf = match utils::conf::file_from_args(reg.args()) {
164 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
165 // do not require the file to exist
166 let file_name = if let Some(file_name) = file_name {
169 match utils::conf::lookup_conf_file() {
172 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
178 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
180 // all conf errors are non-fatal, we just use the default conf in case of error
181 for error in errors {
182 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
187 Err((err, span)) => {
188 reg.sess.struct_span_err(span, err)
189 .span_note(span, "Clippy will use default configuration")
191 toml::from_str("").expect("we never error on empty config files")
195 let mut store = reg.sess.lint_store.borrow_mut();
196 store.register_removed(
198 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
200 store.register_removed(
201 "range_step_by_zero",
202 "`iterator.step_by(0)` panics nowadays",
204 store.register_removed(
206 "`Vec::as_slice` has been stabilized in 1.7",
208 store.register_removed(
209 "unstable_as_mut_slice",
210 "`Vec::as_mut_slice` has been stabilized in 1.7",
212 store.register_removed(
214 "using `str::to_string` is common even today and specialization will likely happen soon",
216 store.register_removed(
218 "using `string::to_string` is common even today and specialization will likely happen soon",
220 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
222 reg.register_late_lint_pass(box serde_api::Serde);
223 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
224 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
225 reg.register_late_lint_pass(box utils::inspector::Pass);
226 reg.register_late_lint_pass(box utils::author::Pass);
227 reg.register_late_lint_pass(box types::TypePass);
228 reg.register_late_lint_pass(box booleans::NonminimalBool);
229 reg.register_late_lint_pass(box eq_op::EqOp);
230 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
231 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
232 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
233 reg.register_late_lint_pass(box bit_mask::BitMask);
234 reg.register_late_lint_pass(box ptr::PointerPass);
235 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
236 reg.register_late_lint_pass(box needless_bool::BoolComparison);
237 reg.register_late_lint_pass(box approx_const::Pass);
238 reg.register_late_lint_pass(box misc::Pass);
239 reg.register_early_lint_pass(box precedence::Precedence);
240 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
241 reg.register_late_lint_pass(box eta_reduction::EtaPass);
242 reg.register_late_lint_pass(box identity_op::IdentityOp);
243 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
244 reg.register_late_lint_pass(box mut_mut::MutMut);
245 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
246 reg.register_late_lint_pass(box len_zero::LenZero);
247 reg.register_late_lint_pass(box attrs::AttrPass);
248 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
249 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
250 reg.register_late_lint_pass(box unicode::Unicode);
251 reg.register_late_lint_pass(box strings::StringAdd);
252 reg.register_early_lint_pass(box returns::ReturnPass);
253 reg.register_late_lint_pass(box methods::Pass);
254 reg.register_late_lint_pass(box shadow::Pass);
255 reg.register_late_lint_pass(box types::LetPass);
256 reg.register_late_lint_pass(box types::UnitCmp);
257 reg.register_late_lint_pass(box loops::Pass);
258 reg.register_late_lint_pass(box lifetimes::LifetimePass);
259 reg.register_late_lint_pass(box entry::HashMapLint);
260 reg.register_late_lint_pass(box ranges::StepByZero);
261 reg.register_late_lint_pass(box types::CastPass);
262 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
263 reg.register_late_lint_pass(box matches::MatchPass);
264 reg.register_late_lint_pass(box minmax::MinMaxPass);
265 reg.register_late_lint_pass(box open_options::NonSensical);
266 reg.register_late_lint_pass(box zero_div_zero::Pass);
267 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
268 reg.register_late_lint_pass(box needless_update::Pass);
269 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
270 reg.register_late_lint_pass(box no_effect::Pass);
271 reg.register_late_lint_pass(box map_clone::Pass);
272 reg.register_late_lint_pass(box temporary_assignment::Pass);
273 reg.register_late_lint_pass(box transmute::Transmute);
274 reg.register_late_lint_pass(
275 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
277 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
278 reg.register_early_lint_pass(box misc_early::MiscEarly);
279 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
280 reg.register_late_lint_pass(box panic::Pass);
281 reg.register_late_lint_pass(box strings::StringLitAsBytes);
282 reg.register_late_lint_pass(box derive::Derive);
283 reg.register_late_lint_pass(box types::CharLitAsU8);
284 reg.register_late_lint_pass(box print::Pass);
285 reg.register_late_lint_pass(box vec::Pass);
286 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
287 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
289 reg.register_late_lint_pass(box drop_forget_ref::Pass);
290 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
291 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
292 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
293 reg.register_late_lint_pass(box regex::Pass::default());
294 reg.register_late_lint_pass(box copies::CopyAndPaste);
295 reg.register_late_lint_pass(box format::Pass);
296 reg.register_early_lint_pass(box formatting::Formatting);
297 reg.register_late_lint_pass(box swap::Swap);
298 reg.register_early_lint_pass(box if_not_else::IfNotElse);
299 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
300 reg.register_late_lint_pass(box unused_label::UnusedLabel);
301 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
302 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
303 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
304 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
305 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
306 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
307 reg.register_late_lint_pass(box mem_forget::MemForget);
308 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
309 reg.register_late_lint_pass(box assign_ops::AssignOps);
310 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
311 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
312 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
313 reg.register_late_lint_pass(box ok_if_let::Pass);
314 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
315 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
316 reg.register_early_lint_pass(box reference::Pass);
317 reg.register_early_lint_pass(box double_parens::DoubleParens);
318 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
319 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
320 reg.register_late_lint_pass(box should_assert_eq::ShouldAssertEq);
321 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
322 reg.register_early_lint_pass(box literal_digit_grouping::LiteralDigitGrouping);
323 reg.register_late_lint_pass(box use_self::UseSelf);
325 reg.register_lint_group("clippy_restrictions", vec![
326 arithmetic::FLOAT_ARITHMETIC,
327 arithmetic::INTEGER_ARITHMETIC,
328 array_indexing::INDEXING_SLICING,
329 assign_ops::ASSIGN_OPS,
332 reg.register_lint_group("clippy_pedantic", vec![
333 booleans::NONMINIMAL_BOOL,
334 empty_enum::EMPTY_ENUM,
335 enum_glob_use::ENUM_GLOB_USE,
336 enum_variants::PUB_ENUM_VARIANT_NAMES,
337 enum_variants::STUTTER,
338 if_not_else::IF_NOT_ELSE,
339 items_after_statements::ITEMS_AFTER_STATEMENTS,
340 matches::SINGLE_MATCH_ELSE,
341 mem_forget::MEM_FORGET,
343 methods::OPTION_MAP_UNWRAP_OR,
344 methods::OPTION_MAP_UNWRAP_OR_ELSE,
345 methods::OPTION_UNWRAP_USED,
346 methods::RESULT_UNWRAP_USED,
347 methods::WRONG_PUB_SELF_CONVENTION,
348 misc::USED_UNDERSCORE_BINDING,
349 misc_early::UNSEPARATED_LITERAL_SUFFIX,
350 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
352 mutex_atomic::MUTEX_INTEGER,
353 non_expressive_names::SIMILAR_NAMES,
356 shadow::SHADOW_REUSE,
358 shadow::SHADOW_UNRELATED,
360 strings::STRING_ADD_ASSIGN,
361 types::CAST_POSSIBLE_TRUNCATION,
362 types::CAST_POSSIBLE_WRAP,
363 types::CAST_PRECISION_LOSS,
364 types::CAST_SIGN_LOSS,
365 types::INVALID_UPCAST_COMPARISONS,
366 unicode::NON_ASCII_LITERAL,
367 unicode::UNICODE_NOT_NFC,
370 reg.register_lint_group("clippy_internal", vec![
371 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
372 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
375 reg.register_lint_group("clippy", vec![
376 approx_const::APPROX_CONSTANT,
377 array_indexing::OUT_OF_BOUNDS_INDEXING,
378 assign_ops::ASSIGN_OP_PATTERN,
379 assign_ops::MISREFACTORED_ASSIGN_OP,
380 attrs::DEPRECATED_SEMVER,
381 attrs::INLINE_ALWAYS,
382 attrs::USELESS_ATTRIBUTE,
383 bit_mask::BAD_BIT_MASK,
384 bit_mask::INEFFECTIVE_BIT_MASK,
385 bit_mask::VERBOSE_BIT_MASK,
386 blacklisted_name::BLACKLISTED_NAME,
387 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
388 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
390 collapsible_if::COLLAPSIBLE_IF,
391 copies::IF_SAME_THEN_ELSE,
392 copies::IFS_SAME_COND,
393 copies::MATCH_SAME_ARMS,
394 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
395 derive::DERIVE_HASH_XOR_EQ,
396 derive::EXPL_IMPL_CLONE_ON_COPY,
398 double_parens::DOUBLE_PARENS,
399 drop_forget_ref::DROP_COPY,
400 drop_forget_ref::DROP_REF,
401 drop_forget_ref::FORGET_COPY,
402 drop_forget_ref::FORGET_REF,
404 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
405 enum_variants::ENUM_VARIANT_NAMES,
406 enum_variants::MODULE_INCEPTION,
410 eta_reduction::REDUNDANT_CLOSURE,
411 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
412 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
413 format::USELESS_FORMAT,
414 formatting::POSSIBLE_MISSING_COMMA,
415 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
416 formatting::SUSPICIOUS_ELSE_FORMATTING,
417 functions::NOT_UNSAFE_PTR_ARG_DEREF,
418 functions::TOO_MANY_ARGUMENTS,
419 identity_op::IDENTITY_OP,
420 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
421 large_enum_variant::LARGE_ENUM_VARIANT,
422 len_zero::LEN_WITHOUT_IS_EMPTY,
424 let_if_seq::USELESS_LET_IF_SEQ,
425 lifetimes::NEEDLESS_LIFETIMES,
426 lifetimes::UNUSED_LIFETIMES,
427 literal_digit_grouping::INCONSISTENT_DIGIT_GROUPING,
428 literal_digit_grouping::LARGE_DIGIT_GROUPS,
429 literal_digit_grouping::UNREADABLE_LITERAL,
431 loops::EXPLICIT_COUNTER_LOOP,
432 loops::EXPLICIT_INTO_ITER_LOOP,
433 loops::EXPLICIT_ITER_LOOP,
435 loops::FOR_LOOP_OVER_OPTION,
436 loops::FOR_LOOP_OVER_RESULT,
437 loops::ITER_NEXT_LOOP,
438 loops::NEEDLESS_RANGE_LOOP,
440 loops::REVERSE_RANGE_LOOP,
441 loops::UNUSED_COLLECT,
442 loops::WHILE_LET_LOOP,
443 loops::WHILE_LET_ON_ITERATOR,
444 map_clone::MAP_CLONE,
446 matches::MATCH_OVERLAPPING_ARM,
447 matches::MATCH_REF_PATS,
448 matches::MATCH_WILD_ERR_ARM,
449 matches::SINGLE_MATCH,
450 methods::CHARS_NEXT_CMP,
451 methods::CLONE_DOUBLE_REF,
452 methods::CLONE_ON_COPY,
453 methods::FILTER_NEXT,
455 methods::ITER_CLONED_COLLECT,
457 methods::ITER_SKIP_NEXT,
458 methods::NEW_RET_NO_SELF,
460 methods::OR_FUN_CALL,
461 methods::SEARCH_IS_SOME,
462 methods::SHOULD_IMPLEMENT_TRAIT,
463 methods::SINGLE_CHAR_PATTERN,
464 methods::STRING_EXTEND_CHARS,
465 methods::TEMPORARY_CSTRING_AS_PTR,
466 methods::WRONG_SELF_CONVENTION,
472 misc::REDUNDANT_PATTERN,
473 misc::SHORT_CIRCUIT_STATEMENT,
474 misc::TOPLEVEL_REF_ARG,
476 misc_early::BUILTIN_TYPE_SHADOW,
477 misc_early::DOUBLE_NEG,
478 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
479 misc_early::MIXED_CASE_HEX_LITERALS,
480 misc_early::REDUNDANT_CLOSURE_CALL,
481 misc_early::UNNEEDED_FIELD_PATTERN,
482 misc_early::ZERO_PREFIXED_LITERAL,
483 mut_reference::UNNECESSARY_MUT_PASSED,
484 mutex_atomic::MUTEX_ATOMIC,
485 needless_bool::BOOL_COMPARISON,
486 needless_bool::NEEDLESS_BOOL,
487 needless_borrow::NEEDLESS_BORROW,
488 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
489 needless_continue::NEEDLESS_CONTINUE,
490 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
491 needless_update::NEEDLESS_UPDATE,
492 neg_multiply::NEG_MULTIPLY,
493 new_without_default::NEW_WITHOUT_DEFAULT,
494 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
495 no_effect::NO_EFFECT,
496 no_effect::UNNECESSARY_OPERATION,
497 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
498 ok_if_let::IF_LET_SOME_RESULT,
499 open_options::NONSENSICAL_OPEN_OPTIONS,
500 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
502 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
503 precedence::PRECEDENCE,
504 print::PRINT_WITH_NEWLINE,
508 ranges::ITERATOR_STEP_BY_ZERO,
509 ranges::RANGE_ZIP_WITH_LEN,
510 reference::DEREF_ADDROF,
511 regex::INVALID_REGEX,
513 regex::TRIVIAL_REGEX,
514 returns::LET_AND_RETURN,
515 returns::NEEDLESS_RETURN,
516 serde_api::SERDE_API_MISUSE,
517 should_assert_eq::SHOULD_ASSERT_EQ,
518 strings::STRING_LIT_AS_BYTES,
519 swap::ALMOST_SWAPPED,
521 temporary_assignment::TEMPORARY_ASSIGNMENT,
522 transmute::CROSSPOINTER_TRANSMUTE,
523 transmute::TRANSMUTE_PTR_TO_REF,
524 transmute::USELESS_TRANSMUTE,
525 transmute::WRONG_TRANSMUTE,
526 types::ABSURD_EXTREME_COMPARISONS,
529 types::CHAR_LIT_AS_U8,
530 types::LET_UNIT_VALUE,
532 types::TYPE_COMPLEXITY,
534 types::UNNECESSARY_CAST,
535 unicode::ZERO_WIDTH_SPACE,
536 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
537 unused_io_amount::UNUSED_IO_AMOUNT,
538 unused_label::UNUSED_LABEL,
540 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
544 // only exists to let the dogfood integration test works.
545 // Don't run clippy as an executable directly
546 #[allow(dead_code, print_stdout)]
548 panic!("Please use the cargo-clippy executable");