1 // error-pattern:cargo-clippy
3 #![feature(type_macros)]
4 #![feature(plugin_registrar, box_syntax)]
5 #![feature(rustc_private, collections)]
6 #![feature(iter_arith)]
7 #![feature(custom_attribute)]
8 #![feature(slice_patterns)]
9 #![feature(question_mark)]
10 #![feature(stmt_expr_attributes)]
11 #![allow(indexing_slicing, shadow_reuse, unknown_lints)]
13 extern crate rustc_driver;
23 // Only for the compile time checking of paths
25 extern crate collections;
27 // for unicode nfc normalization
28 extern crate unicode_normalization;
30 // for semver check in attrs.rs
34 extern crate regex_syntax;
36 // for finding minimal boolean expressions
37 extern crate quine_mc_cluskey;
39 extern crate rustc_serialize;
41 extern crate rustc_plugin;
42 extern crate rustc_const_eval;
43 extern crate rustc_const_math;
45 macro_rules! declare_restriction_lint {
46 { pub $name:tt, $description:tt } => {
47 declare_lint! { pub $name, Allow, $description }
55 // begin lints modules, do not remove this comment, it’s used in `update_lints`
58 pub mod array_indexing;
62 pub mod blacklisted_name;
63 pub mod block_in_if_condition;
65 pub mod collapsible_if;
67 pub mod cyclomatic_complexity;
73 pub mod enum_glob_use;
74 pub mod enum_variants;
77 pub mod eta_reduction;
83 pub mod items_after_statements;
96 pub mod mut_reference;
98 pub mod needless_bool;
99 pub mod needless_borrow;
100 pub mod needless_update;
101 pub mod neg_multiply;
102 pub mod new_without_default;
104 pub mod non_expressive_names;
105 pub mod open_options;
106 pub mod overflow_check_conditional;
117 pub mod temporary_assignment;
121 pub mod unsafe_removed_from_name;
122 pub mod unused_label;
124 pub mod zero_div_zero;
125 // end lints modules, do not remove this comment, it’s used in `update_lints`
128 pub use syntax::ast::{Name, NodeId};
131 #[cfg_attr(rustfmt, rustfmt_skip)]
132 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
133 let conf = match utils::conf::conf_file(reg.args()) {
135 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
136 // do not require the file to exist
137 let (ref file_name, must_exist) = if let Some(ref file_name) = file_name {
140 ("clippy.toml", false)
143 let (conf, errors) = utils::conf::read_conf(file_name, must_exist);
145 // all conf errors are non-fatal, we just use the default conf in case of error
146 for error in errors {
147 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
152 Err((err, span)) => {
153 reg.sess.struct_span_err(span, err)
154 .span_note(span, "Clippy will use default configuration")
156 utils::conf::Conf::default()
160 let mut store = reg.sess.lint_store.borrow_mut();
161 store.register_removed("unstable_as_slice", "`Vec::as_slice` has been stabilized in 1.7");
162 store.register_removed("unstable_as_mut_slice", "`Vec::as_mut_slice` has been stabilized in 1.7");
163 store.register_removed("str_to_string", "using `str::to_string` is common even today and specialization will likely happen soon");
164 store.register_removed("string_to_string", "using `string::to_string` is common even today and specialization will likely happen soon");
165 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
167 reg.register_late_lint_pass(box types::TypePass);
168 reg.register_late_lint_pass(box booleans::NonminimalBool);
169 reg.register_late_lint_pass(box misc::TopLevelRefPass);
170 reg.register_late_lint_pass(box misc::CmpNan);
171 reg.register_late_lint_pass(box eq_op::EqOp);
172 reg.register_early_lint_pass(box enum_variants::EnumVariantNames);
173 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
174 reg.register_late_lint_pass(box enum_clike::EnumClikeUnportableVariant);
175 reg.register_late_lint_pass(box bit_mask::BitMask);
176 reg.register_late_lint_pass(box ptr_arg::PtrArg);
177 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
178 reg.register_late_lint_pass(box needless_bool::BoolComparison);
179 reg.register_late_lint_pass(box approx_const::ApproxConstant);
180 reg.register_late_lint_pass(box misc::FloatCmp);
181 reg.register_early_lint_pass(box precedence::Precedence);
182 reg.register_late_lint_pass(box eta_reduction::EtaPass);
183 reg.register_late_lint_pass(box identity_op::IdentityOp);
184 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
185 reg.register_late_lint_pass(box mut_mut::MutMut);
186 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
187 reg.register_late_lint_pass(box len_zero::LenZero);
188 reg.register_late_lint_pass(box misc::CmpOwned);
189 reg.register_late_lint_pass(box attrs::AttrPass);
190 reg.register_late_lint_pass(box collapsible_if::CollapsibleIf);
191 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
192 reg.register_late_lint_pass(box misc::ModuloOne);
193 reg.register_late_lint_pass(box unicode::Unicode);
194 reg.register_late_lint_pass(box strings::StringAdd);
195 reg.register_early_lint_pass(box returns::ReturnPass);
196 reg.register_late_lint_pass(box methods::MethodsPass);
197 reg.register_late_lint_pass(box shadow::ShadowPass);
198 reg.register_late_lint_pass(box types::LetPass);
199 reg.register_late_lint_pass(box types::UnitCmp);
200 reg.register_late_lint_pass(box loops::LoopsPass);
201 reg.register_late_lint_pass(box lifetimes::LifetimePass);
202 reg.register_late_lint_pass(box entry::HashMapLint);
203 reg.register_late_lint_pass(box ranges::StepByZero);
204 reg.register_late_lint_pass(box types::CastPass);
205 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
206 reg.register_late_lint_pass(box matches::MatchPass);
207 reg.register_late_lint_pass(box misc::PatternPass);
208 reg.register_late_lint_pass(box minmax::MinMaxPass);
209 reg.register_late_lint_pass(box open_options::NonSensicalOpenOptions);
210 reg.register_late_lint_pass(box zero_div_zero::ZeroDivZeroPass);
211 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
212 reg.register_late_lint_pass(box needless_update::NeedlessUpdatePass);
213 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
214 reg.register_late_lint_pass(box no_effect::NoEffectPass);
215 reg.register_late_lint_pass(box map_clone::MapClonePass);
216 reg.register_late_lint_pass(box temporary_assignment::TemporaryAssignmentPass);
217 reg.register_late_lint_pass(box transmute::Transmute);
218 reg.register_late_lint_pass(box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold));
219 reg.register_late_lint_pass(box escape::EscapePass);
220 reg.register_early_lint_pass(box misc_early::MiscEarly);
221 reg.register_late_lint_pass(box misc::UsedUnderscoreBinding);
222 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
223 reg.register_late_lint_pass(box panic::PanicPass);
224 reg.register_late_lint_pass(box strings::StringLitAsBytes);
225 reg.register_late_lint_pass(box derive::Derive);
226 reg.register_late_lint_pass(box types::CharLitAsU8);
227 reg.register_late_lint_pass(box print::PrintLint);
228 reg.register_late_lint_pass(box vec::UselessVec);
229 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
230 max_single_char_names: conf.max_single_char_names,
232 reg.register_late_lint_pass(box drop_ref::DropRefPass);
233 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
234 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
235 reg.register_late_lint_pass(box regex::RegexPass::default());
236 reg.register_late_lint_pass(box copies::CopyAndPaste);
237 reg.register_late_lint_pass(box format::FormatMacLint);
238 reg.register_early_lint_pass(box formatting::Formatting);
239 reg.register_late_lint_pass(box swap::Swap);
240 reg.register_early_lint_pass(box if_not_else::IfNotElse);
241 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
242 reg.register_late_lint_pass(box unused_label::UnusedLabel);
243 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
244 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
245 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
246 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
247 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
248 reg.register_late_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
249 reg.register_late_lint_pass(box mem_forget::MemForget);
250 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
251 reg.register_late_lint_pass(box assign_ops::AssignOps);
252 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
254 reg.register_lint_group("clippy_restrictions", vec![
255 arithmetic::FLOAT_ARITHMETIC,
256 arithmetic::INTEGER_ARITHMETIC,
257 assign_ops::ASSIGN_OPS,
260 reg.register_lint_group("clippy_pedantic", vec![
261 array_indexing::INDEXING_SLICING,
262 booleans::NONMINIMAL_BOOL,
263 enum_glob_use::ENUM_GLOB_USE,
264 if_not_else::IF_NOT_ELSE,
265 items_after_statements::ITEMS_AFTER_STATEMENTS,
266 matches::SINGLE_MATCH_ELSE,
267 mem_forget::MEM_FORGET,
268 methods::OPTION_UNWRAP_USED,
269 methods::RESULT_UNWRAP_USED,
270 methods::WRONG_PUB_SELF_CONVENTION,
271 misc::USED_UNDERSCORE_BINDING,
273 mutex_atomic::MUTEX_INTEGER,
274 non_expressive_names::SIMILAR_NAMES,
277 shadow::SHADOW_REUSE,
279 shadow::SHADOW_UNRELATED,
281 strings::STRING_ADD_ASSIGN,
282 types::CAST_POSSIBLE_TRUNCATION,
283 types::CAST_POSSIBLE_WRAP,
284 types::CAST_PRECISION_LOSS,
285 types::CAST_SIGN_LOSS,
286 types::INVALID_UPCAST_COMPARISONS,
287 unicode::NON_ASCII_LITERAL,
288 unicode::UNICODE_NOT_NFC,
291 reg.register_lint_group("clippy", vec![
292 approx_const::APPROX_CONSTANT,
293 array_indexing::OUT_OF_BOUNDS_INDEXING,
294 assign_ops::ASSIGN_OP_PATTERN,
295 attrs::DEPRECATED_SEMVER,
296 attrs::INLINE_ALWAYS,
297 bit_mask::BAD_BIT_MASK,
298 bit_mask::INEFFECTIVE_BIT_MASK,
299 blacklisted_name::BLACKLISTED_NAME,
300 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
301 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
303 collapsible_if::COLLAPSIBLE_IF,
304 copies::IF_SAME_THEN_ELSE,
305 copies::IFS_SAME_COND,
306 copies::MATCH_SAME_ARMS,
307 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
308 derive::DERIVE_HASH_XOR_EQ,
309 derive::EXPL_IMPL_CLONE_ON_COPY,
313 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
314 enum_variants::ENUM_VARIANT_NAMES,
317 eta_reduction::REDUNDANT_CLOSURE,
318 format::USELESS_FORMAT,
319 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
320 formatting::SUSPICIOUS_ELSE_FORMATTING,
321 functions::TOO_MANY_ARGUMENTS,
322 identity_op::IDENTITY_OP,
323 len_zero::LEN_WITHOUT_IS_EMPTY,
325 let_if_seq::USELESS_LET_IF_SEQ,
326 lifetimes::NEEDLESS_LIFETIMES,
327 lifetimes::UNUSED_LIFETIMES,
329 loops::EXPLICIT_COUNTER_LOOP,
330 loops::EXPLICIT_ITER_LOOP,
332 loops::FOR_LOOP_OVER_OPTION,
333 loops::FOR_LOOP_OVER_RESULT,
334 loops::ITER_NEXT_LOOP,
335 loops::NEEDLESS_RANGE_LOOP,
336 loops::REVERSE_RANGE_LOOP,
337 loops::UNUSED_COLLECT,
338 loops::WHILE_LET_LOOP,
339 loops::WHILE_LET_ON_ITERATOR,
340 map_clone::MAP_CLONE,
342 matches::MATCH_OVERLAPPING_ARM,
343 matches::MATCH_REF_PATS,
344 matches::SINGLE_MATCH,
345 methods::CHARS_NEXT_CMP,
346 methods::CLONE_DOUBLE_REF,
347 methods::CLONE_ON_COPY,
348 methods::EXTEND_FROM_SLICE,
349 methods::FILTER_NEXT,
350 methods::NEW_RET_NO_SELF,
352 methods::OPTION_MAP_UNWRAP_OR,
353 methods::OPTION_MAP_UNWRAP_OR_ELSE,
354 methods::OR_FUN_CALL,
355 methods::SEARCH_IS_SOME,
356 methods::SHOULD_IMPLEMENT_TRAIT,
357 methods::SINGLE_CHAR_PATTERN,
358 methods::TEMPORARY_CSTRING_AS_PTR,
359 methods::WRONG_SELF_CONVENTION,
365 misc::REDUNDANT_PATTERN,
366 misc::TOPLEVEL_REF_ARG,
367 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
368 misc_early::REDUNDANT_CLOSURE_CALL,
369 misc_early::UNNEEDED_FIELD_PATTERN,
370 mut_reference::UNNECESSARY_MUT_PASSED,
371 mutex_atomic::MUTEX_ATOMIC,
372 needless_bool::BOOL_COMPARISON,
373 needless_bool::NEEDLESS_BOOL,
374 needless_borrow::NEEDLESS_BORROW,
375 needless_update::NEEDLESS_UPDATE,
376 neg_multiply::NEG_MULTIPLY,
377 new_without_default::NEW_WITHOUT_DEFAULT,
378 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
379 no_effect::NO_EFFECT,
380 no_effect::UNNECESSARY_OPERATION,
381 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
382 open_options::NONSENSICAL_OPEN_OPTIONS,
383 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
385 precedence::PRECEDENCE,
387 ranges::RANGE_STEP_BY_ZERO,
388 ranges::RANGE_ZIP_WITH_LEN,
389 regex::INVALID_REGEX,
391 regex::TRIVIAL_REGEX,
392 returns::LET_AND_RETURN,
393 returns::NEEDLESS_RETURN,
394 strings::STRING_LIT_AS_BYTES,
395 swap::ALMOST_SWAPPED,
397 temporary_assignment::TEMPORARY_ASSIGNMENT,
398 transmute::CROSSPOINTER_TRANSMUTE,
399 transmute::TRANSMUTE_PTR_TO_REF,
400 transmute::USELESS_TRANSMUTE,
401 types::ABSURD_EXTREME_COMPARISONS,
403 types::CHAR_LIT_AS_U8,
404 types::LET_UNIT_VALUE,
406 types::TYPE_COMPLEXITY,
408 unicode::ZERO_WIDTH_SPACE,
409 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
410 unused_label::UNUSED_LABEL,
412 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
416 // only exists to let the dogfood integration test works.
417 // Don't run clippy as an executable directly
418 #[allow(dead_code, print_stdout)]
420 panic!("Please use the cargo-clippy executable");