]> git.lizzy.rs Git - rust.git/blob - clippy_lints/src/lib.rs
Remove iter::zip feature gate from clippy
[rust.git] / clippy_lints / src / lib.rs
1 // error-pattern:cargo-clippy
2
3 #![feature(box_patterns)]
4 #![feature(drain_filter)]
5 #![feature(in_band_lifetimes)]
6 #![feature(once_cell)]
7 #![feature(rustc_private)]
8 #![feature(stmt_expr_attributes)]
9 #![feature(control_flow_enum)]
10 #![feature(let_else)]
11 #![recursion_limit = "512"]
12 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
13 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
14 #![warn(trivial_casts, trivial_numeric_casts)]
15 // warn on lints, that are included in `rust-lang/rust`s bootstrap
16 #![warn(rust_2018_idioms, unused_lifetimes)]
17 // warn on rustc internal lints
18 #![warn(rustc::internal)]
19
20 // FIXME: switch to something more ergonomic here, once available.
21 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
22 extern crate rustc_ast;
23 extern crate rustc_ast_pretty;
24 extern crate rustc_data_structures;
25 extern crate rustc_driver;
26 extern crate rustc_errors;
27 extern crate rustc_hir;
28 extern crate rustc_hir_pretty;
29 extern crate rustc_index;
30 extern crate rustc_infer;
31 extern crate rustc_lexer;
32 extern crate rustc_lint;
33 extern crate rustc_middle;
34 extern crate rustc_mir_dataflow;
35 extern crate rustc_parse;
36 extern crate rustc_parse_format;
37 extern crate rustc_session;
38 extern crate rustc_span;
39 extern crate rustc_target;
40 extern crate rustc_trait_selection;
41 extern crate rustc_typeck;
42
43 #[macro_use]
44 extern crate clippy_utils;
45
46 use clippy_utils::parse_msrv;
47 use rustc_data_structures::fx::FxHashSet;
48 use rustc_lint::LintId;
49 use rustc_session::Session;
50
51 /// Macro used to declare a Clippy lint.
52 ///
53 /// Every lint declaration consists of 4 parts:
54 ///
55 /// 1. The documentation, which is used for the website
56 /// 2. The `LINT_NAME`. See [lint naming][lint_naming] on lint naming conventions.
57 /// 3. The `lint_level`, which is a mapping from *one* of our lint groups to `Allow`, `Warn` or
58 ///    `Deny`. The lint level here has nothing to do with what lint groups the lint is a part of.
59 /// 4. The `description` that contains a short explanation on what's wrong with code where the
60 ///    lint is triggered.
61 ///
62 /// Currently the categories `style`, `correctness`, `suspicious`, `complexity` and `perf` are
63 /// enabled by default. As said in the README.md of this repository, if the lint level mapping
64 /// changes, please update README.md.
65 ///
66 /// # Example
67 ///
68 /// ```
69 /// #![feature(rustc_private)]
70 /// extern crate rustc_session;
71 /// use rustc_session::declare_tool_lint;
72 /// use clippy_lints::declare_clippy_lint;
73 ///
74 /// declare_clippy_lint! {
75 ///     /// ### What it does
76 ///     /// Checks for ... (describe what the lint matches).
77 ///     ///
78 ///     /// ### Why is this bad?
79 ///     /// Supply the reason for linting the code.
80 ///     ///
81 ///     /// ### Example
82 ///     /// ```rust
83 ///     /// // Bad
84 ///     /// Insert a short example of code that triggers the lint
85 ///     ///
86 ///     /// // Good
87 ///     /// Insert a short example of improved code that doesn't trigger the lint
88 ///     /// ```
89 ///     pub LINT_NAME,
90 ///     pedantic,
91 ///     "description"
92 /// }
93 /// ```
94 /// [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
95 #[macro_export]
96 macro_rules! declare_clippy_lint {
97     { $(#[$attr:meta])* pub $name:tt, style, $description:tt } => {
98         declare_tool_lint! {
99             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
100         }
101     };
102     { $(#[$attr:meta])* pub $name:tt, correctness, $description:tt } => {
103         declare_tool_lint! {
104             $(#[$attr])* pub clippy::$name, Deny, $description, report_in_external_macro: true
105         }
106     };
107     { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
108         declare_tool_lint! {
109             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
110         }
111     };
112     { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
113         declare_tool_lint! {
114             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
115         }
116     };
117     { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
118         declare_tool_lint! {
119             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
120         }
121     };
122     { $(#[$attr:meta])* pub $name:tt, pedantic, $description:tt } => {
123         declare_tool_lint! {
124             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
125         }
126     };
127     { $(#[$attr:meta])* pub $name:tt, restriction, $description:tt } => {
128         declare_tool_lint! {
129             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
130         }
131     };
132     { $(#[$attr:meta])* pub $name:tt, cargo, $description:tt } => {
133         declare_tool_lint! {
134             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
135         }
136     };
137     { $(#[$attr:meta])* pub $name:tt, nursery, $description:tt } => {
138         declare_tool_lint! {
139             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
140         }
141     };
142     { $(#[$attr:meta])* pub $name:tt, internal, $description:tt } => {
143         declare_tool_lint! {
144             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
145         }
146     };
147     { $(#[$attr:meta])* pub $name:tt, internal_warn, $description:tt } => {
148         declare_tool_lint! {
149             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
150         }
151     };
152 }
153
154 #[cfg(feature = "metadata-collector-lint")]
155 mod deprecated_lints;
156 #[cfg_attr(
157     any(feature = "internal-lints", feature = "metadata-collector-lint"),
158     allow(clippy::missing_clippy_version_attribute)
159 )]
160 mod utils;
161
162 // begin lints modules, do not remove this comment, it’s used in `update_lints`
163 mod absurd_extreme_comparisons;
164 mod approx_const;
165 mod arithmetic;
166 mod as_conversions;
167 mod asm_syntax;
168 mod assertions_on_constants;
169 mod assign_ops;
170 mod async_yields_async;
171 mod attrs;
172 mod await_holding_invalid;
173 mod bit_mask;
174 mod blacklisted_name;
175 mod blocks_in_if_conditions;
176 mod bool_assert_comparison;
177 mod booleans;
178 mod bytecount;
179 mod cargo_common_metadata;
180 mod case_sensitive_file_extension_comparisons;
181 mod casts;
182 mod checked_conversions;
183 mod cognitive_complexity;
184 mod collapsible_if;
185 mod collapsible_match;
186 mod comparison_chain;
187 mod copies;
188 mod copy_iterator;
189 mod create_dir;
190 mod dbg_macro;
191 mod default;
192 mod default_numeric_fallback;
193 mod dereference;
194 mod derivable_impls;
195 mod derive;
196 mod disallowed_methods;
197 mod disallowed_script_idents;
198 mod disallowed_types;
199 mod doc;
200 mod double_comparison;
201 mod double_parens;
202 mod drop_forget_ref;
203 mod duration_subsec;
204 mod else_if_without_else;
205 mod empty_enum;
206 mod entry;
207 mod enum_clike;
208 mod enum_variants;
209 mod eq_op;
210 mod equatable_if_let;
211 mod erasing_op;
212 mod escape;
213 mod eta_reduction;
214 mod eval_order_dependence;
215 mod excessive_bools;
216 mod exhaustive_items;
217 mod exit;
218 mod explicit_write;
219 mod fallible_impl_from;
220 mod feature_name;
221 mod float_equality_without_abs;
222 mod float_literal;
223 mod floating_point_arithmetic;
224 mod format;
225 mod format_args;
226 mod formatting;
227 mod from_over_into;
228 mod from_str_radix_10;
229 mod functions;
230 mod future_not_send;
231 mod get_last_with_len;
232 mod identity_op;
233 mod if_let_mutex;
234 mod if_not_else;
235 mod if_then_some_else_none;
236 mod implicit_hasher;
237 mod implicit_return;
238 mod implicit_saturating_sub;
239 mod inconsistent_struct_constructor;
240 mod index_refutable_slice;
241 mod indexing_slicing;
242 mod infinite_iter;
243 mod inherent_impl;
244 mod inherent_to_string;
245 mod inline_fn_without_body;
246 mod int_plus_one;
247 mod integer_division;
248 mod invalid_upcast_comparisons;
249 mod items_after_statements;
250 mod iter_not_returning_iterator;
251 mod large_const_arrays;
252 mod large_enum_variant;
253 mod large_stack_arrays;
254 mod len_zero;
255 mod let_if_seq;
256 mod let_underscore;
257 mod lifetimes;
258 mod literal_representation;
259 mod loops;
260 mod macro_use;
261 mod main_recursion;
262 mod manual_assert;
263 mod manual_async_fn;
264 mod manual_map;
265 mod manual_non_exhaustive;
266 mod manual_ok_or;
267 mod manual_strip;
268 mod manual_unwrap_or;
269 mod map_clone;
270 mod map_err_ignore;
271 mod map_unit_fn;
272 mod match_on_vec_items;
273 mod match_result_ok;
274 mod match_str_case_mismatch;
275 mod matches;
276 mod mem_forget;
277 mod mem_replace;
278 mod methods;
279 mod minmax;
280 mod misc;
281 mod misc_early;
282 mod missing_const_for_fn;
283 mod missing_doc;
284 mod missing_enforced_import_rename;
285 mod missing_inline;
286 mod module_style;
287 mod modulo_arithmetic;
288 mod multiple_crate_versions;
289 mod mut_key;
290 mod mut_mut;
291 mod mut_mutex_lock;
292 mod mut_reference;
293 mod mutable_debug_assertion;
294 mod mutex_atomic;
295 mod needless_arbitrary_self_type;
296 mod needless_bitwise_bool;
297 mod needless_bool;
298 mod needless_borrowed_ref;
299 mod needless_continue;
300 mod needless_for_each;
301 mod needless_late_init;
302 mod needless_option_as_deref;
303 mod needless_pass_by_value;
304 mod needless_question_mark;
305 mod needless_update;
306 mod neg_cmp_op_on_partial_ord;
307 mod neg_multiply;
308 mod new_without_default;
309 mod no_effect;
310 mod non_copy_const;
311 mod non_expressive_names;
312 mod non_octal_unix_permissions;
313 mod non_send_fields_in_send_ty;
314 mod nonstandard_macro_braces;
315 mod octal_escapes;
316 mod open_options;
317 mod option_env_unwrap;
318 mod option_if_let_else;
319 mod overflow_check_conditional;
320 mod panic_in_result_fn;
321 mod panic_unimplemented;
322 mod partialeq_ne_impl;
323 mod pass_by_ref_or_value;
324 mod path_buf_push_overwrite;
325 mod pattern_type_mismatch;
326 mod precedence;
327 mod ptr;
328 mod ptr_eq;
329 mod ptr_offset_with_cast;
330 mod question_mark;
331 mod ranges;
332 mod redundant_clone;
333 mod redundant_closure_call;
334 mod redundant_else;
335 mod redundant_field_names;
336 mod redundant_pub_crate;
337 mod redundant_slicing;
338 mod redundant_static_lifetimes;
339 mod ref_option_ref;
340 mod reference;
341 mod regex;
342 mod repeat_once;
343 mod returns;
344 mod same_name_method;
345 mod self_assignment;
346 mod self_named_constructors;
347 mod semicolon_if_nothing_returned;
348 mod serde_api;
349 mod shadow;
350 mod single_component_path_imports;
351 mod size_of_in_element_count;
352 mod slow_vector_initialization;
353 mod stable_sort_primitive;
354 mod strings;
355 mod strlen_on_c_strings;
356 mod suspicious_operation_groupings;
357 mod suspicious_trait_impl;
358 mod swap;
359 mod tabs_in_doc_comments;
360 mod temporary_assignment;
361 mod to_digit_is_some;
362 mod to_string_in_display;
363 mod trailing_empty_array;
364 mod trait_bounds;
365 mod transmute;
366 mod transmuting_null;
367 mod try_err;
368 mod types;
369 mod undocumented_unsafe_blocks;
370 mod undropped_manually_drops;
371 mod unicode;
372 mod uninit_vec;
373 mod unit_hash;
374 mod unit_return_expecting_ord;
375 mod unit_types;
376 mod unnamed_address;
377 mod unnecessary_self_imports;
378 mod unnecessary_sort_by;
379 mod unnecessary_wraps;
380 mod unnested_or_patterns;
381 mod unsafe_removed_from_name;
382 mod unused_async;
383 mod unused_io_amount;
384 mod unused_self;
385 mod unused_unit;
386 mod unwrap;
387 mod unwrap_in_result;
388 mod upper_case_acronyms;
389 mod use_self;
390 mod useless_conversion;
391 mod vec;
392 mod vec_init_then_push;
393 mod vec_resize_to_zero;
394 mod verbose_file_reads;
395 mod wildcard_dependencies;
396 mod wildcard_imports;
397 mod write;
398 mod zero_div_zero;
399 mod zero_sized_map_values;
400 // end lints modules, do not remove this comment, it’s used in `update_lints`
401
402 pub use crate::utils::conf::Conf;
403 use crate::utils::conf::TryConf;
404
405 /// Register all pre expansion lints
406 ///
407 /// Pre-expansion lints run before any macro expansion has happened.
408 ///
409 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
410 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
411 ///
412 /// Used in `./src/driver.rs`.
413 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
414     // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
415
416     let msrv = conf.msrv.as_ref().and_then(|s| {
417         parse_msrv(s, None, None).or_else(|| {
418             sess.err(&format!(
419                 "error reading Clippy's configuration file. `{}` is not a valid Rust version",
420                 s
421             ));
422             None
423         })
424     });
425
426     store.register_pre_expansion_pass(|| Box::new(write::Write::default()));
427     store.register_pre_expansion_pass(move || Box::new(attrs::EarlyAttributes { msrv }));
428     store.register_pre_expansion_pass(|| Box::new(dbg_macro::DbgMacro));
429 }
430
431 #[doc(hidden)]
432 pub fn read_conf(sess: &Session) -> Conf {
433     let file_name = match utils::conf::lookup_conf_file() {
434         Ok(Some(path)) => path,
435         Ok(None) => return Conf::default(),
436         Err(error) => {
437             sess.struct_err(&format!("error finding Clippy's configuration file: {}", error))
438                 .emit();
439             return Conf::default();
440         },
441     };
442
443     let TryConf { conf, errors } = utils::conf::read(&file_name);
444     // all conf errors are non-fatal, we just use the default conf in case of error
445     for error in errors {
446         sess.struct_err(&format!(
447             "error reading Clippy's configuration file `{}`: {}",
448             file_name.display(),
449             error
450         ))
451         .emit();
452     }
453
454     conf
455 }
456
457 /// Register all lints and lint groups with the rustc plugin registry
458 ///
459 /// Used in `./src/driver.rs`.
460 #[allow(clippy::too_many_lines)]
461 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
462     register_removed_non_tool_lints(store);
463
464     include!("lib.deprecated.rs");
465
466     include!("lib.register_lints.rs");
467     include!("lib.register_restriction.rs");
468     include!("lib.register_pedantic.rs");
469
470     #[cfg(feature = "internal-lints")]
471     include!("lib.register_internal.rs");
472
473     include!("lib.register_all.rs");
474     include!("lib.register_style.rs");
475     include!("lib.register_complexity.rs");
476     include!("lib.register_correctness.rs");
477     include!("lib.register_suspicious.rs");
478     include!("lib.register_perf.rs");
479     include!("lib.register_cargo.rs");
480     include!("lib.register_nursery.rs");
481
482     #[cfg(feature = "metadata-collector-lint")]
483     {
484         if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
485             store.register_late_pass(|| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
486             return;
487         }
488     }
489
490     // all the internal lints
491     #[cfg(feature = "internal-lints")]
492     {
493         store.register_early_pass(|| Box::new(utils::internal_lints::ClippyLintsInternal));
494         store.register_early_pass(|| Box::new(utils::internal_lints::ProduceIce));
495         store.register_late_pass(|| Box::new(utils::inspector::DeepCodeInspector));
496         store.register_late_pass(|| Box::new(utils::internal_lints::CollapsibleCalls));
497         store.register_late_pass(|| Box::new(utils::internal_lints::CompilerLintFunctions::new()));
498         store.register_late_pass(|| Box::new(utils::internal_lints::IfChainStyle));
499         store.register_late_pass(|| Box::new(utils::internal_lints::InvalidPaths));
500         store.register_late_pass(|| Box::new(utils::internal_lints::InterningDefinedSymbol::default()));
501         store.register_late_pass(|| Box::new(utils::internal_lints::LintWithoutLintPass::default()));
502         store.register_late_pass(|| Box::new(utils::internal_lints::MatchTypeOnDiagItem));
503         store.register_late_pass(|| Box::new(utils::internal_lints::OuterExpnDataPass));
504     }
505
506     store.register_late_pass(|| Box::new(utils::author::Author));
507     store.register_late_pass(|| Box::new(await_holding_invalid::AwaitHolding));
508     store.register_late_pass(|| Box::new(serde_api::SerdeApi));
509     let vec_box_size_threshold = conf.vec_box_size_threshold;
510     let type_complexity_threshold = conf.type_complexity_threshold;
511     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
512     store.register_late_pass(move || {
513         Box::new(types::Types::new(
514             vec_box_size_threshold,
515             type_complexity_threshold,
516             avoid_breaking_exported_api,
517         ))
518     });
519     store.register_late_pass(|| Box::new(booleans::NonminimalBool));
520     store.register_late_pass(|| Box::new(needless_bitwise_bool::NeedlessBitwiseBool));
521     store.register_late_pass(|| Box::new(eq_op::EqOp));
522     store.register_late_pass(|| Box::new(enum_clike::UnportableVariant));
523     store.register_late_pass(|| Box::new(float_literal::FloatLiteral));
524     let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
525     store.register_late_pass(move || Box::new(bit_mask::BitMask::new(verbose_bit_mask_threshold)));
526     store.register_late_pass(|| Box::new(ptr::Ptr));
527     store.register_late_pass(|| Box::new(ptr_eq::PtrEq));
528     store.register_late_pass(|| Box::new(needless_bool::NeedlessBool));
529     store.register_late_pass(|| Box::new(needless_option_as_deref::OptionNeedlessDeref));
530     store.register_late_pass(|| Box::new(needless_bool::BoolComparison));
531     store.register_late_pass(|| Box::new(needless_for_each::NeedlessForEach));
532     store.register_late_pass(|| Box::new(misc::MiscLints));
533     store.register_late_pass(|| Box::new(eta_reduction::EtaReduction));
534     store.register_late_pass(|| Box::new(identity_op::IdentityOp));
535     store.register_late_pass(|| Box::new(erasing_op::ErasingOp));
536     store.register_late_pass(|| Box::new(mut_mut::MutMut));
537     store.register_late_pass(|| Box::new(mut_reference::UnnecessaryMutPassed));
538     store.register_late_pass(|| Box::new(len_zero::LenZero));
539     store.register_late_pass(|| Box::new(attrs::Attributes));
540     store.register_late_pass(|| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
541     store.register_late_pass(|| Box::new(collapsible_match::CollapsibleMatch));
542     store.register_late_pass(|| Box::new(unicode::Unicode));
543     store.register_late_pass(|| Box::new(uninit_vec::UninitVec));
544     store.register_late_pass(|| Box::new(unit_hash::UnitHash));
545     store.register_late_pass(|| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
546     store.register_late_pass(|| Box::new(strings::StringAdd));
547     store.register_late_pass(|| Box::new(implicit_return::ImplicitReturn));
548     store.register_late_pass(|| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
549     store.register_late_pass(|| Box::new(default_numeric_fallback::DefaultNumericFallback));
550     store.register_late_pass(|| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
551     store.register_late_pass(|| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
552     store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
553
554     let msrv = conf.msrv.as_ref().and_then(|s| {
555         parse_msrv(s, None, None).or_else(|| {
556             sess.err(&format!(
557                 "error reading Clippy's configuration file. `{}` is not a valid Rust version",
558                 s
559             ));
560             None
561         })
562     });
563
564     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
565     store.register_late_pass(move || Box::new(approx_const::ApproxConstant::new(msrv)));
566     store.register_late_pass(move || Box::new(methods::Methods::new(avoid_breaking_exported_api, msrv)));
567     store.register_late_pass(move || Box::new(matches::Matches::new(msrv)));
568     store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustive::new(msrv)));
569     store.register_late_pass(move || Box::new(manual_strip::ManualStrip::new(msrv)));
570     store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv)));
571     store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv)));
572     store.register_late_pass(move || Box::new(checked_conversions::CheckedConversions::new(msrv)));
573     store.register_late_pass(move || Box::new(mem_replace::MemReplace::new(msrv)));
574     store.register_late_pass(move || Box::new(ranges::Ranges::new(msrv)));
575     store.register_late_pass(move || Box::new(from_over_into::FromOverInto::new(msrv)));
576     store.register_late_pass(move || Box::new(use_self::UseSelf::new(msrv)));
577     store.register_late_pass(move || Box::new(missing_const_for_fn::MissingConstForFn::new(msrv)));
578     store.register_late_pass(move || Box::new(needless_question_mark::NeedlessQuestionMark));
579     store.register_late_pass(move || Box::new(casts::Casts::new(msrv)));
580     store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv)));
581
582     store.register_late_pass(|| Box::new(size_of_in_element_count::SizeOfInElementCount));
583     store.register_late_pass(|| Box::new(same_name_method::SameNameMethod));
584     let max_suggested_slice_pattern_length = conf.max_suggested_slice_pattern_length;
585     store.register_late_pass(move || {
586         Box::new(index_refutable_slice::IndexRefutableSlice::new(
587             max_suggested_slice_pattern_length,
588             msrv,
589         ))
590     });
591     store.register_late_pass(|| Box::new(map_clone::MapClone));
592     store.register_late_pass(|| Box::new(map_err_ignore::MapErrIgnore));
593     store.register_late_pass(|| Box::new(shadow::Shadow::default()));
594     store.register_late_pass(|| Box::new(unit_types::UnitTypes));
595     store.register_late_pass(|| Box::new(loops::Loops));
596     store.register_late_pass(|| Box::new(main_recursion::MainRecursion::default()));
597     store.register_late_pass(|| Box::new(lifetimes::Lifetimes));
598     store.register_late_pass(|| Box::new(entry::HashMapPass));
599     store.register_late_pass(|| Box::new(minmax::MinMaxPass));
600     store.register_late_pass(|| Box::new(open_options::OpenOptions));
601     store.register_late_pass(|| Box::new(zero_div_zero::ZeroDiv));
602     store.register_late_pass(|| Box::new(mutex_atomic::Mutex));
603     store.register_late_pass(|| Box::new(needless_update::NeedlessUpdate));
604     store.register_late_pass(|| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
605     store.register_late_pass(|| Box::new(no_effect::NoEffect));
606     store.register_late_pass(|| Box::new(temporary_assignment::TemporaryAssignment));
607     store.register_late_pass(|| Box::new(transmute::Transmute));
608     let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
609     store.register_late_pass(move || {
610         Box::new(cognitive_complexity::CognitiveComplexity::new(
611             cognitive_complexity_threshold,
612         ))
613     });
614     let too_large_for_stack = conf.too_large_for_stack;
615     store.register_late_pass(move || Box::new(escape::BoxedLocal { too_large_for_stack }));
616     store.register_late_pass(move || Box::new(vec::UselessVec { too_large_for_stack }));
617     store.register_late_pass(|| Box::new(panic_unimplemented::PanicUnimplemented));
618     store.register_late_pass(|| Box::new(strings::StringLitAsBytes));
619     store.register_late_pass(|| Box::new(derive::Derive));
620     store.register_late_pass(|| Box::new(derivable_impls::DerivableImpls));
621     store.register_late_pass(|| Box::new(get_last_with_len::GetLastWithLen));
622     store.register_late_pass(|| Box::new(drop_forget_ref::DropForgetRef));
623     store.register_late_pass(|| Box::new(empty_enum::EmptyEnum));
624     store.register_late_pass(|| Box::new(absurd_extreme_comparisons::AbsurdExtremeComparisons));
625     store.register_late_pass(|| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
626     store.register_late_pass(|| Box::new(regex::Regex));
627     store.register_late_pass(|| Box::new(copies::CopyAndPaste));
628     store.register_late_pass(|| Box::new(copy_iterator::CopyIterator));
629     store.register_late_pass(|| Box::new(format::UselessFormat));
630     store.register_late_pass(|| Box::new(swap::Swap));
631     store.register_late_pass(|| Box::new(overflow_check_conditional::OverflowCheckConditional));
632     store.register_late_pass(|| Box::new(new_without_default::NewWithoutDefault::default()));
633     let blacklisted_names = conf.blacklisted_names.iter().cloned().collect::<FxHashSet<_>>();
634     store.register_late_pass(move || Box::new(blacklisted_name::BlacklistedName::new(blacklisted_names.clone())));
635     let too_many_arguments_threshold = conf.too_many_arguments_threshold;
636     let too_many_lines_threshold = conf.too_many_lines_threshold;
637     store.register_late_pass(move || {
638         Box::new(functions::Functions::new(
639             too_many_arguments_threshold,
640             too_many_lines_threshold,
641         ))
642     });
643     let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
644     store.register_late_pass(move || Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
645     store.register_late_pass(|| Box::new(neg_multiply::NegMultiply));
646     store.register_late_pass(|| Box::new(mem_forget::MemForget));
647     store.register_late_pass(|| Box::new(arithmetic::Arithmetic::default()));
648     store.register_late_pass(|| Box::new(assign_ops::AssignOps));
649     store.register_late_pass(|| Box::new(let_if_seq::LetIfSeq));
650     store.register_late_pass(|| Box::new(eval_order_dependence::EvalOrderDependence));
651     store.register_late_pass(|| Box::new(missing_doc::MissingDoc::new()));
652     store.register_late_pass(|| Box::new(missing_inline::MissingInline));
653     store.register_late_pass(move || Box::new(exhaustive_items::ExhaustiveItems));
654     store.register_late_pass(|| Box::new(match_result_ok::MatchResultOk));
655     store.register_late_pass(|| Box::new(partialeq_ne_impl::PartialEqNeImpl));
656     store.register_late_pass(|| Box::new(unused_io_amount::UnusedIoAmount));
657     let enum_variant_size_threshold = conf.enum_variant_size_threshold;
658     store.register_late_pass(move || Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
659     store.register_late_pass(|| Box::new(explicit_write::ExplicitWrite));
660     store.register_late_pass(|| Box::new(needless_pass_by_value::NeedlessPassByValue));
661     let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
662         conf.trivial_copy_size_limit,
663         conf.pass_by_value_size_limit,
664         conf.avoid_breaking_exported_api,
665         &sess.target,
666     );
667     store.register_late_pass(move || Box::new(pass_by_ref_or_value));
668     store.register_late_pass(|| Box::new(ref_option_ref::RefOptionRef));
669     store.register_late_pass(|| Box::new(try_err::TryErr));
670     store.register_late_pass(|| Box::new(bytecount::ByteCount));
671     store.register_late_pass(|| Box::new(infinite_iter::InfiniteIter));
672     store.register_late_pass(|| Box::new(inline_fn_without_body::InlineFnWithoutBody));
673     store.register_late_pass(|| Box::new(useless_conversion::UselessConversion::default()));
674     store.register_late_pass(|| Box::new(implicit_hasher::ImplicitHasher));
675     store.register_late_pass(|| Box::new(fallible_impl_from::FallibleImplFrom));
676     store.register_late_pass(|| Box::new(double_comparison::DoubleComparisons));
677     store.register_late_pass(|| Box::new(question_mark::QuestionMark));
678     store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
679     store.register_late_pass(|| Box::new(suspicious_trait_impl::SuspiciousImpl));
680     store.register_late_pass(|| Box::new(map_unit_fn::MapUnit));
681     store.register_late_pass(|| Box::new(inherent_impl::MultipleInherentImpl));
682     store.register_late_pass(|| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
683     store.register_late_pass(|| Box::new(unwrap::Unwrap));
684     store.register_late_pass(|| Box::new(duration_subsec::DurationSubsec));
685     store.register_late_pass(|| Box::new(indexing_slicing::IndexingSlicing));
686     store.register_late_pass(|| Box::new(non_copy_const::NonCopyConst));
687     store.register_late_pass(|| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
688     store.register_late_pass(|| Box::new(redundant_clone::RedundantClone));
689     store.register_late_pass(|| Box::new(slow_vector_initialization::SlowVectorInit));
690     store.register_late_pass(|| Box::new(unnecessary_sort_by::UnnecessarySortBy));
691     store.register_late_pass(move || Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
692     store.register_late_pass(|| Box::new(assertions_on_constants::AssertionsOnConstants));
693     store.register_late_pass(|| Box::new(transmuting_null::TransmutingNull));
694     store.register_late_pass(|| Box::new(path_buf_push_overwrite::PathBufPushOverwrite));
695     store.register_late_pass(|| Box::new(integer_division::IntegerDivision));
696     store.register_late_pass(|| Box::new(inherent_to_string::InherentToString));
697     let max_trait_bounds = conf.max_trait_bounds;
698     store.register_late_pass(move || Box::new(trait_bounds::TraitBounds::new(max_trait_bounds)));
699     store.register_late_pass(|| Box::new(comparison_chain::ComparisonChain));
700     store.register_late_pass(|| Box::new(mut_key::MutableKeyType));
701     store.register_late_pass(|| Box::new(modulo_arithmetic::ModuloArithmetic));
702     store.register_early_pass(|| Box::new(reference::DerefAddrOf));
703     store.register_early_pass(|| Box::new(reference::RefInDeref));
704     store.register_early_pass(|| Box::new(double_parens::DoubleParens));
705     store.register_late_pass(|| Box::new(to_string_in_display::ToStringInDisplay::new()));
706     store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
707     store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
708     store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
709     store.register_early_pass(|| Box::new(formatting::Formatting));
710     store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
711     store.register_early_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
712     store.register_late_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
713     store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
714     store.register_late_pass(|| Box::new(returns::Return));
715     store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
716     store.register_early_pass(|| Box::new(items_after_statements::ItemsAfterStatements));
717     store.register_early_pass(|| Box::new(precedence::Precedence));
718     store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
719     store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
720     store.register_late_pass(|| Box::new(create_dir::CreateDir));
721     store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
722     let cargo_ignore_publish = conf.cargo_ignore_publish;
723     store.register_late_pass(move || Box::new(cargo_common_metadata::CargoCommonMetadata::new(cargo_ignore_publish)));
724     store.register_late_pass(|| Box::new(multiple_crate_versions::MultipleCrateVersions));
725     store.register_late_pass(|| Box::new(wildcard_dependencies::WildcardDependencies));
726     let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
727     store.register_early_pass(move || {
728         Box::new(literal_representation::LiteralDigitGrouping::new(
729             literal_representation_lint_fraction_readability,
730         ))
731     });
732     let literal_representation_threshold = conf.literal_representation_threshold;
733     store.register_early_pass(move || {
734         Box::new(literal_representation::DecimalLiteralRepresentation::new(
735             literal_representation_threshold,
736         ))
737     });
738     let enum_variant_name_threshold = conf.enum_variant_name_threshold;
739     store.register_late_pass(move || {
740         Box::new(enum_variants::EnumVariantNames::new(
741             enum_variant_name_threshold,
742             avoid_breaking_exported_api,
743         ))
744     });
745     store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
746     let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
747     store.register_late_pass(move || {
748         Box::new(upper_case_acronyms::UpperCaseAcronyms::new(
749             avoid_breaking_exported_api,
750             upper_case_acronyms_aggressive,
751         ))
752     });
753     store.register_late_pass(|| Box::new(default::Default::default()));
754     store.register_late_pass(|| Box::new(unused_self::UnusedSelf));
755     store.register_late_pass(|| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
756     store.register_late_pass(|| Box::new(exit::Exit));
757     store.register_late_pass(|| Box::new(to_digit_is_some::ToDigitIsSome));
758     let array_size_threshold = conf.array_size_threshold;
759     store.register_late_pass(move || Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
760     store.register_late_pass(move || Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
761     store.register_late_pass(|| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
762     store.register_early_pass(|| Box::new(as_conversions::AsConversions));
763     store.register_late_pass(|| Box::new(let_underscore::LetUnderscore));
764     store.register_early_pass(|| Box::new(single_component_path_imports::SingleComponentPathImports));
765     let max_fn_params_bools = conf.max_fn_params_bools;
766     let max_struct_bools = conf.max_struct_bools;
767     store.register_early_pass(move || {
768         Box::new(excessive_bools::ExcessiveBools::new(
769             max_struct_bools,
770             max_fn_params_bools,
771         ))
772     });
773     store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
774     let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
775     store.register_late_pass(move || Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
776     store.register_late_pass(|| Box::new(verbose_file_reads::VerboseFileReads));
777     store.register_late_pass(|| Box::new(redundant_pub_crate::RedundantPubCrate::default()));
778     store.register_late_pass(|| Box::new(unnamed_address::UnnamedAddress));
779     store.register_late_pass(|| Box::new(dereference::Dereferencing::default()));
780     store.register_late_pass(|| Box::new(option_if_let_else::OptionIfLetElse));
781     store.register_late_pass(|| Box::new(future_not_send::FutureNotSend));
782     store.register_late_pass(|| Box::new(if_let_mutex::IfLetMutex));
783     store.register_late_pass(|| Box::new(if_not_else::IfNotElse));
784     store.register_late_pass(|| Box::new(equatable_if_let::PatternEquality));
785     store.register_late_pass(|| Box::new(mut_mutex_lock::MutMutexLock));
786     store.register_late_pass(|| Box::new(match_on_vec_items::MatchOnVecItems));
787     store.register_late_pass(|| Box::new(manual_async_fn::ManualAsyncFn));
788     store.register_late_pass(|| Box::new(vec_resize_to_zero::VecResizeToZero));
789     store.register_late_pass(|| Box::new(panic_in_result_fn::PanicInResultFn));
790     let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
791     store.register_early_pass(move || {
792         Box::new(non_expressive_names::NonExpressiveNames {
793             single_char_binding_names_threshold,
794         })
795     });
796     let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
797     store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(&macro_matcher)));
798     store.register_late_pass(|| Box::new(macro_use::MacroUseImports::default()));
799     store.register_late_pass(|| Box::new(pattern_type_mismatch::PatternTypeMismatch));
800     store.register_late_pass(|| Box::new(stable_sort_primitive::StableSortPrimitive));
801     store.register_late_pass(|| Box::new(repeat_once::RepeatOnce));
802     store.register_late_pass(|| Box::new(unwrap_in_result::UnwrapInResult));
803     store.register_late_pass(|| Box::new(self_assignment::SelfAssignment));
804     store.register_late_pass(|| Box::new(manual_unwrap_or::ManualUnwrapOr));
805     store.register_late_pass(|| Box::new(manual_ok_or::ManualOkOr));
806     store.register_late_pass(|| Box::new(float_equality_without_abs::FloatEqualityWithoutAbs));
807     store.register_late_pass(|| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
808     store.register_late_pass(|| Box::new(async_yields_async::AsyncYieldsAsync));
809     let disallowed_methods = conf.disallowed_methods.clone();
810     store.register_late_pass(move || Box::new(disallowed_methods::DisallowedMethods::new(disallowed_methods.clone())));
811     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
812     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
813     store.register_late_pass(|| Box::new(undropped_manually_drops::UndroppedManuallyDrops));
814     store.register_late_pass(|| Box::new(strings::StrToString));
815     store.register_late_pass(|| Box::new(strings::StringToString));
816     store.register_late_pass(|| Box::new(zero_sized_map_values::ZeroSizedMapValues));
817     store.register_late_pass(|| Box::new(vec_init_then_push::VecInitThenPush::default()));
818     store.register_late_pass(|| {
819         Box::new(case_sensitive_file_extension_comparisons::CaseSensitiveFileExtensionComparisons)
820     });
821     store.register_late_pass(|| Box::new(redundant_slicing::RedundantSlicing));
822     store.register_late_pass(|| Box::new(from_str_radix_10::FromStrRadix10));
823     store.register_late_pass(|| Box::new(manual_map::ManualMap));
824     store.register_late_pass(move || Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv)));
825     store.register_late_pass(|| Box::new(bool_assert_comparison::BoolAssertComparison));
826     store.register_early_pass(move || Box::new(module_style::ModStyle));
827     store.register_late_pass(|| Box::new(unused_async::UnusedAsync));
828     let disallowed_types = conf.disallowed_types.clone();
829     store.register_late_pass(move || Box::new(disallowed_types::DisallowedTypes::new(disallowed_types.clone())));
830     let import_renames = conf.enforced_import_renames.clone();
831     store.register_late_pass(move || {
832         Box::new(missing_enforced_import_rename::ImportRename::new(
833             import_renames.clone(),
834         ))
835     });
836     let scripts = conf.allowed_scripts.clone();
837     store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
838     store.register_late_pass(|| Box::new(strlen_on_c_strings::StrlenOnCStrings));
839     store.register_late_pass(move || Box::new(self_named_constructors::SelfNamedConstructors));
840     store.register_late_pass(move || Box::new(feature_name::FeatureName));
841     store.register_late_pass(move || Box::new(iter_not_returning_iterator::IterNotReturningIterator));
842     store.register_late_pass(move || Box::new(manual_assert::ManualAssert));
843     let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
844     store.register_late_pass(move || {
845         Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(
846             enable_raw_pointer_heuristic_for_send,
847         ))
848     });
849     store.register_late_pass(move || Box::new(undocumented_unsafe_blocks::UndocumentedUnsafeBlocks::default()));
850     store.register_late_pass(|| Box::new(match_str_case_mismatch::MatchStrCaseMismatch));
851     store.register_late_pass(move || Box::new(format_args::FormatArgs));
852     store.register_late_pass(|| Box::new(trailing_empty_array::TrailingEmptyArray));
853     store.register_early_pass(|| Box::new(octal_escapes::OctalEscapes));
854     store.register_late_pass(|| Box::new(needless_late_init::NeedlessLateInit));
855     // add lints here, do not remove this comment, it's used in `new_lint`
856 }
857
858 #[rustfmt::skip]
859 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
860     store.register_removed(
861         "should_assert_eq",
862         "`assert!()` will be more flexible with RFC 2011",
863     );
864     store.register_removed(
865         "extend_from_slice",
866         "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
867     );
868     store.register_removed(
869         "range_step_by_zero",
870         "`iterator.step_by(0)` panics nowadays",
871     );
872     store.register_removed(
873         "unstable_as_slice",
874         "`Vec::as_slice` has been stabilized in 1.7",
875     );
876     store.register_removed(
877         "unstable_as_mut_slice",
878         "`Vec::as_mut_slice` has been stabilized in 1.7",
879     );
880     store.register_removed(
881         "misaligned_transmute",
882         "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
883     );
884     store.register_removed(
885         "assign_ops",
886         "using compound assignment operators (e.g., `+=`) is harmless",
887     );
888     store.register_removed(
889         "if_let_redundant_pattern_matching",
890         "this lint has been changed to redundant_pattern_matching",
891     );
892     store.register_removed(
893         "unsafe_vector_initialization",
894         "the replacement suggested by this lint had substantially different behavior",
895     );
896     store.register_removed(
897         "reverse_range_loop",
898         "this lint is now included in reversed_empty_ranges",
899     );
900 }
901
902 /// Register renamed lints.
903 ///
904 /// Used in `./src/driver.rs`.
905 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
906     // NOTE: when renaming a lint, add a corresponding test to tests/ui/rename.rs
907     ls.register_renamed("clippy::stutter", "clippy::module_name_repetitions");
908     ls.register_renamed("clippy::new_without_default_derive", "clippy::new_without_default");
909     ls.register_renamed("clippy::cyclomatic_complexity", "clippy::cognitive_complexity");
910     ls.register_renamed("clippy::const_static_lifetime", "clippy::redundant_static_lifetimes");
911     ls.register_renamed("clippy::option_and_then_some", "clippy::bind_instead_of_map");
912     ls.register_renamed("clippy::box_vec", "clippy::box_collection");
913     ls.register_renamed("clippy::block_in_if_condition_expr", "clippy::blocks_in_if_conditions");
914     ls.register_renamed("clippy::block_in_if_condition_stmt", "clippy::blocks_in_if_conditions");
915     ls.register_renamed("clippy::option_map_unwrap_or", "clippy::map_unwrap_or");
916     ls.register_renamed("clippy::option_map_unwrap_or_else", "clippy::map_unwrap_or");
917     ls.register_renamed("clippy::result_map_unwrap_or_else", "clippy::map_unwrap_or");
918     ls.register_renamed("clippy::option_unwrap_used", "clippy::unwrap_used");
919     ls.register_renamed("clippy::result_unwrap_used", "clippy::unwrap_used");
920     ls.register_renamed("clippy::option_expect_used", "clippy::expect_used");
921     ls.register_renamed("clippy::result_expect_used", "clippy::expect_used");
922     ls.register_renamed("clippy::for_loop_over_option", "clippy::for_loops_over_fallibles");
923     ls.register_renamed("clippy::for_loop_over_result", "clippy::for_loops_over_fallibles");
924     ls.register_renamed("clippy::identity_conversion", "clippy::useless_conversion");
925     ls.register_renamed("clippy::zero_width_space", "clippy::invisible_characters");
926     ls.register_renamed("clippy::single_char_push_str", "clippy::single_char_add_str");
927     ls.register_renamed("clippy::if_let_some_result", "clippy::match_result_ok");
928     ls.register_renamed("clippy::disallowed_type", "clippy::disallowed_types");
929     ls.register_renamed("clippy::disallowed_method", "clippy::disallowed_methods");
930
931     // uplifted lints
932     ls.register_renamed("clippy::invalid_ref", "invalid_value");
933     ls.register_renamed("clippy::into_iter_on_array", "array_into_iter");
934     ls.register_renamed("clippy::unused_label", "unused_labels");
935     ls.register_renamed("clippy::drop_bounds", "drop_bounds");
936     ls.register_renamed("clippy::temporary_cstring_as_ptr", "temporary_cstring_as_ptr");
937     ls.register_renamed("clippy::panic_params", "non_fmt_panics");
938     ls.register_renamed("clippy::unknown_clippy_lints", "unknown_lints");
939     ls.register_renamed("clippy::invalid_atomic_ordering", "invalid_atomic_ordering");
940     ls.register_renamed("clippy::mem_discriminant_non_enum", "enum_intrinsics_non_enums");
941 }
942
943 // only exists to let the dogfood integration test works.
944 // Don't run clippy as an executable directly
945 #[allow(dead_code)]
946 fn main() {
947     panic!("Please use the cargo-clippy executable");
948 }