1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(collections)]
5 #![feature(custom_attribute)]
6 #![feature(dotdot_in_tuple_patterns)]
7 #![feature(question_mark)]
8 #![feature(rustc_private)]
9 #![feature(slice_patterns)]
10 #![feature(stmt_expr_attributes)]
11 #![feature(type_macros)]
13 #![allow(indexing_slicing, shadow_reuse, unknown_lints)]
22 // Only for the compile time checking of paths
24 extern crate collections;
26 // for unicode nfc normalization
27 extern crate unicode_normalization;
29 // for semver check in attrs.rs
33 extern crate regex_syntax;
35 // for finding minimal boolean expressions
36 extern crate quine_mc_cluskey;
38 extern crate rustc_serialize;
40 extern crate rustc_errors;
41 extern crate rustc_plugin;
42 extern crate rustc_const_eval;
43 extern crate rustc_const_math;
46 extern crate matches as matches_macro;
48 macro_rules! declare_restriction_lint {
49 { pub $name:tt, $description:tt } => {
50 declare_lint! { pub $name, Allow, $description }
58 // begin lints modules, do not remove this comment, it’s used in `update_lints`
61 pub mod array_indexing;
65 pub mod blacklisted_name;
66 pub mod block_in_if_condition;
68 pub mod collapsible_if;
70 pub mod cyclomatic_complexity;
76 pub mod enum_glob_use;
77 pub mod enum_variants;
80 pub mod eta_reduction;
81 pub mod eval_order_dependence;
87 pub mod items_after_statements;
100 pub mod mut_reference;
101 pub mod mutex_atomic;
102 pub mod needless_bool;
103 pub mod needless_borrow;
104 pub mod needless_update;
105 pub mod neg_multiply;
106 pub mod new_without_default;
108 pub mod non_expressive_names;
109 pub mod open_options;
110 pub mod overflow_check_conditional;
122 pub mod temporary_assignment;
126 pub mod unsafe_removed_from_name;
127 pub mod unused_label;
129 pub mod zero_div_zero;
130 // end lints modules, do not remove this comment, it’s used in `update_lints`
133 pub use syntax::ast::{Name, NodeId};
136 #[cfg_attr(rustfmt, rustfmt_skip)]
137 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
138 let conf = match utils::conf::file(reg.args()) {
140 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
141 // do not require the file to exist
142 let (file_name, must_exist) = if let Some(ref file_name) = file_name {
145 ("clippy.toml", false)
148 let (conf, errors) = utils::conf::read(file_name, must_exist);
150 // all conf errors are non-fatal, we just use the default conf in case of error
151 for error in errors {
152 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
157 Err((err, span)) => {
158 reg.sess.struct_span_err(span, err)
159 .span_note(span, "Clippy will use default configuration")
161 utils::conf::Conf::default()
165 let mut store = reg.sess.lint_store.borrow_mut();
166 store.register_removed("unstable_as_slice", "`Vec::as_slice` has been stabilized in 1.7");
167 store.register_removed("unstable_as_mut_slice", "`Vec::as_mut_slice` has been stabilized in 1.7");
168 store.register_removed("str_to_string", "using `str::to_string` is common even today and specialization will likely happen soon");
169 store.register_removed("string_to_string", "using `string::to_string` is common even today and specialization will likely happen soon");
170 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
172 reg.register_late_lint_pass(box serde::Serde);
173 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
174 reg.register_late_lint_pass(box types::TypePass);
175 reg.register_late_lint_pass(box booleans::NonminimalBool);
176 reg.register_late_lint_pass(box misc::TopLevelRefPass);
177 reg.register_late_lint_pass(box misc::CmpNan);
178 reg.register_late_lint_pass(box eq_op::EqOp);
179 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
180 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
181 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
182 reg.register_late_lint_pass(box bit_mask::BitMask);
183 reg.register_late_lint_pass(box ptr_arg::PtrArg);
184 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
185 reg.register_late_lint_pass(box needless_bool::BoolComparison);
186 reg.register_late_lint_pass(box approx_const::Pass);
187 reg.register_late_lint_pass(box misc::FloatCmp);
188 reg.register_early_lint_pass(box precedence::Precedence);
189 reg.register_late_lint_pass(box eta_reduction::EtaPass);
190 reg.register_late_lint_pass(box identity_op::IdentityOp);
191 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
192 reg.register_late_lint_pass(box mut_mut::MutMut);
193 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
194 reg.register_late_lint_pass(box len_zero::LenZero);
195 reg.register_late_lint_pass(box misc::CmpOwned);
196 reg.register_late_lint_pass(box attrs::AttrPass);
197 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
198 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
199 reg.register_late_lint_pass(box misc::ModuloOne);
200 reg.register_late_lint_pass(box unicode::Unicode);
201 reg.register_late_lint_pass(box strings::StringAdd);
202 reg.register_early_lint_pass(box returns::ReturnPass);
203 reg.register_late_lint_pass(box methods::Pass);
204 reg.register_late_lint_pass(box shadow::Pass);
205 reg.register_late_lint_pass(box types::LetPass);
206 reg.register_late_lint_pass(box types::UnitCmp);
207 reg.register_late_lint_pass(box loops::Pass);
208 reg.register_late_lint_pass(box lifetimes::LifetimePass);
209 reg.register_late_lint_pass(box entry::HashMapLint);
210 reg.register_late_lint_pass(box ranges::StepByZero);
211 reg.register_late_lint_pass(box types::CastPass);
212 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
213 reg.register_late_lint_pass(box matches::MatchPass);
214 reg.register_late_lint_pass(box misc::PatternPass);
215 reg.register_late_lint_pass(box minmax::MinMaxPass);
216 reg.register_late_lint_pass(box open_options::NonSensical);
217 reg.register_late_lint_pass(box zero_div_zero::Pass);
218 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
219 reg.register_late_lint_pass(box needless_update::Pass);
220 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
221 reg.register_late_lint_pass(box no_effect::Pass);
222 reg.register_late_lint_pass(box map_clone::Pass);
223 reg.register_late_lint_pass(box temporary_assignment::Pass);
224 reg.register_late_lint_pass(box transmute::Transmute);
225 reg.register_late_lint_pass(box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold));
226 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
227 reg.register_early_lint_pass(box misc_early::MiscEarly);
228 reg.register_late_lint_pass(box misc::UsedUnderscoreBinding);
229 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
230 reg.register_late_lint_pass(box panic::Pass);
231 reg.register_late_lint_pass(box strings::StringLitAsBytes);
232 reg.register_late_lint_pass(box derive::Derive);
233 reg.register_late_lint_pass(box types::CharLitAsU8);
234 reg.register_late_lint_pass(box print::Pass);
235 reg.register_late_lint_pass(box vec::Pass);
236 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
237 max_single_char_names: conf.max_single_char_names,
239 reg.register_late_lint_pass(box drop_ref::Pass);
240 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
241 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
242 reg.register_late_lint_pass(box regex::Pass::default());
243 reg.register_late_lint_pass(box copies::CopyAndPaste);
244 reg.register_late_lint_pass(box format::Pass);
245 reg.register_early_lint_pass(box formatting::Formatting);
246 reg.register_late_lint_pass(box swap::Swap);
247 reg.register_early_lint_pass(box if_not_else::IfNotElse);
248 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
249 reg.register_late_lint_pass(box unused_label::UnusedLabel);
250 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
251 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
252 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
253 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
254 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
255 reg.register_late_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
256 reg.register_late_lint_pass(box mem_forget::MemForget);
257 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
258 reg.register_late_lint_pass(box assign_ops::AssignOps);
259 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
260 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
262 reg.register_lint_group("clippy_restrictions", vec![
263 arithmetic::FLOAT_ARITHMETIC,
264 arithmetic::INTEGER_ARITHMETIC,
265 array_indexing::INDEXING_SLICING,
266 assign_ops::ASSIGN_OPS,
269 reg.register_lint_group("clippy_pedantic", vec![
270 booleans::NONMINIMAL_BOOL,
271 enum_glob_use::ENUM_GLOB_USE,
272 enum_variants::STUTTER,
273 if_not_else::IF_NOT_ELSE,
274 items_after_statements::ITEMS_AFTER_STATEMENTS,
275 matches::SINGLE_MATCH_ELSE,
276 mem_forget::MEM_FORGET,
278 methods::OPTION_UNWRAP_USED,
279 methods::RESULT_UNWRAP_USED,
280 methods::WRONG_PUB_SELF_CONVENTION,
281 misc::USED_UNDERSCORE_BINDING,
282 misc_early::UNSEPARATED_LITERAL_SUFFIX,
284 mutex_atomic::MUTEX_INTEGER,
285 non_expressive_names::SIMILAR_NAMES,
288 shadow::SHADOW_REUSE,
290 shadow::SHADOW_UNRELATED,
292 strings::STRING_ADD_ASSIGN,
293 types::CAST_POSSIBLE_TRUNCATION,
294 types::CAST_POSSIBLE_WRAP,
295 types::CAST_PRECISION_LOSS,
296 types::CAST_SIGN_LOSS,
297 types::INVALID_UPCAST_COMPARISONS,
298 unicode::NON_ASCII_LITERAL,
299 unicode::UNICODE_NOT_NFC,
302 reg.register_lint_group("clippy", vec![
303 approx_const::APPROX_CONSTANT,
304 array_indexing::OUT_OF_BOUNDS_INDEXING,
305 assign_ops::ASSIGN_OP_PATTERN,
306 assign_ops::MISREFACTORED_ASSIGN_OP,
307 attrs::DEPRECATED_SEMVER,
308 attrs::INLINE_ALWAYS,
309 bit_mask::BAD_BIT_MASK,
310 bit_mask::INEFFECTIVE_BIT_MASK,
311 blacklisted_name::BLACKLISTED_NAME,
312 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
313 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
315 collapsible_if::COLLAPSIBLE_IF,
316 copies::IF_SAME_THEN_ELSE,
317 copies::IFS_SAME_COND,
318 copies::MATCH_SAME_ARMS,
319 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
320 derive::DERIVE_HASH_XOR_EQ,
321 derive::EXPL_IMPL_CLONE_ON_COPY,
325 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
326 enum_variants::ENUM_VARIANT_NAMES,
329 eta_reduction::REDUNDANT_CLOSURE,
330 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
331 format::USELESS_FORMAT,
332 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
333 formatting::SUSPICIOUS_ELSE_FORMATTING,
334 functions::NOT_UNSAFE_PTR_ARG_DEREF,
335 functions::TOO_MANY_ARGUMENTS,
336 identity_op::IDENTITY_OP,
337 len_zero::LEN_WITHOUT_IS_EMPTY,
339 let_if_seq::USELESS_LET_IF_SEQ,
340 lifetimes::NEEDLESS_LIFETIMES,
341 lifetimes::UNUSED_LIFETIMES,
343 loops::EXPLICIT_COUNTER_LOOP,
344 loops::EXPLICIT_ITER_LOOP,
346 loops::FOR_LOOP_OVER_OPTION,
347 loops::FOR_LOOP_OVER_RESULT,
348 loops::ITER_NEXT_LOOP,
349 loops::NEEDLESS_RANGE_LOOP,
350 loops::REVERSE_RANGE_LOOP,
351 loops::UNUSED_COLLECT,
352 loops::WHILE_LET_LOOP,
353 loops::WHILE_LET_ON_ITERATOR,
354 map_clone::MAP_CLONE,
356 matches::MATCH_OVERLAPPING_ARM,
357 matches::MATCH_REF_PATS,
358 matches::SINGLE_MATCH,
359 methods::CHARS_NEXT_CMP,
360 methods::CLONE_DOUBLE_REF,
361 methods::CLONE_ON_COPY,
362 methods::EXTEND_FROM_SLICE,
363 methods::FILTER_NEXT,
365 methods::NEW_RET_NO_SELF,
367 methods::OPTION_MAP_UNWRAP_OR,
368 methods::OPTION_MAP_UNWRAP_OR_ELSE,
369 methods::OR_FUN_CALL,
370 methods::SEARCH_IS_SOME,
371 methods::SHOULD_IMPLEMENT_TRAIT,
372 methods::SINGLE_CHAR_PATTERN,
373 methods::TEMPORARY_CSTRING_AS_PTR,
374 methods::WRONG_SELF_CONVENTION,
380 misc::REDUNDANT_PATTERN,
381 misc::TOPLEVEL_REF_ARG,
382 misc_early::DOUBLE_NEG,
383 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
384 misc_early::MIXED_CASE_HEX_LITERALS,
385 misc_early::REDUNDANT_CLOSURE_CALL,
386 misc_early::UNNEEDED_FIELD_PATTERN,
387 mut_reference::UNNECESSARY_MUT_PASSED,
388 mutex_atomic::MUTEX_ATOMIC,
389 needless_bool::BOOL_COMPARISON,
390 needless_bool::NEEDLESS_BOOL,
391 needless_borrow::NEEDLESS_BORROW,
392 needless_update::NEEDLESS_UPDATE,
393 neg_multiply::NEG_MULTIPLY,
394 new_without_default::NEW_WITHOUT_DEFAULT,
395 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
396 no_effect::NO_EFFECT,
397 no_effect::UNNECESSARY_OPERATION,
398 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
399 open_options::NONSENSICAL_OPEN_OPTIONS,
400 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
402 precedence::PRECEDENCE,
404 ranges::RANGE_STEP_BY_ZERO,
405 ranges::RANGE_ZIP_WITH_LEN,
406 regex::INVALID_REGEX,
408 regex::TRIVIAL_REGEX,
409 returns::LET_AND_RETURN,
410 returns::NEEDLESS_RETURN,
411 serde::SERDE_API_MISUSE,
412 strings::STRING_LIT_AS_BYTES,
413 swap::ALMOST_SWAPPED,
415 temporary_assignment::TEMPORARY_ASSIGNMENT,
416 transmute::CROSSPOINTER_TRANSMUTE,
417 transmute::TRANSMUTE_PTR_TO_REF,
418 transmute::USELESS_TRANSMUTE,
419 transmute::WRONG_TRANSMUTE,
420 types::ABSURD_EXTREME_COMPARISONS,
422 types::CHAR_LIT_AS_U8,
423 types::LET_UNIT_VALUE,
425 types::TYPE_COMPLEXITY,
427 unicode::ZERO_WIDTH_SPACE,
428 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
429 unused_label::UNUSED_LABEL,
431 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
435 // only exists to let the dogfood integration test works.
436 // Don't run clippy as an executable directly
437 #[allow(dead_code, print_stdout)]
439 panic!("Please use the cargo-clippy executable");