1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(custom_attribute)]
7 #![feature(rustc_private)]
8 #![feature(slice_patterns)]
9 #![feature(stmt_expr_attributes)]
10 #![feature(conservative_impl_trait)]
11 #![feature(inclusive_range_syntax, range_contains)]
12 #![feature(macro_vis_matcher)]
13 #![allow(unknown_lints, indexing_slicing, shadow_reuse, missing_docs_in_private_items)]
14 #![recursion_limit = "256"]
18 extern crate rustc_typeck;
20 extern crate syntax_pos;
24 // for unicode nfc normalization
26 extern crate unicode_normalization;
28 // for semver check in attrs.rs
34 extern crate regex_syntax;
36 // for finding minimal boolean expressions
38 extern crate quine_mc_cluskey;
40 extern crate rustc_const_eval;
41 extern crate rustc_const_math;
42 extern crate rustc_errors;
43 extern crate rustc_plugin;
46 extern crate matches as matches_macro;
50 extern crate serde_derive;
53 extern crate lazy_static;
55 extern crate itertools;
56 extern crate pulldown_cmark;
60 extern crate if_chain;
62 macro_rules! declare_restriction_lint {
63 { pub $name:tt, $description:tt } => {
64 declare_lint! { pub $name, Allow, $description }
72 // begin lints modules, do not remove this comment, it’s used in `update_lints`
75 pub mod array_indexing;
79 pub mod blacklisted_name;
80 pub mod block_in_if_condition;
83 pub mod collapsible_if;
84 pub mod const_static_lifetime;
86 pub mod cyclomatic_complexity;
89 pub mod double_parens;
90 pub mod drop_forget_ref;
94 pub mod enum_glob_use;
95 pub mod enum_variants;
99 pub mod eta_reduction;
100 pub mod eval_order_dependence;
101 pub mod explicit_write;
102 pub mod fallible_impl_from;
106 pub mod identity_conversion;
108 pub mod if_let_redundant_pattern_matching;
110 pub mod infinite_iter;
111 pub mod int_plus_one;
113 pub mod is_unit_expr;
114 pub mod items_after_statements;
115 pub mod large_enum_variant;
119 pub mod literal_digit_grouping;
130 pub mod mut_reference;
131 pub mod mutex_atomic;
132 pub mod needless_bool;
133 pub mod needless_borrow;
134 pub mod needless_borrowed_ref;
135 pub mod needless_continue;
136 pub mod needless_pass_by_value;
137 pub mod needless_update;
138 pub mod neg_multiply;
139 pub mod new_without_default;
141 pub mod non_expressive_names;
143 pub mod open_options;
144 pub mod overflow_check_conditional;
146 pub mod partialeq_ne_impl;
158 pub mod temporary_assignment;
162 pub mod unsafe_removed_from_name;
163 pub mod unused_io_amount;
164 pub mod unused_label;
167 pub mod zero_div_zero;
168 // end lints modules, do not remove this comment, it’s used in `update_lints`
171 pub use syntax::ast::{Name, NodeId};
174 #[cfg_attr(rustfmt, rustfmt_skip)]
175 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
176 let conf = match utils::conf::file_from_args(reg.args()) {
178 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
179 // do not require the file to exist
180 let file_name = if let Some(file_name) = file_name {
183 match utils::conf::lookup_conf_file() {
186 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
192 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
194 // all conf errors are non-fatal, we just use the default conf in case of error
195 for error in errors {
196 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
201 Err((err, span)) => {
202 reg.sess.struct_span_err(span, err)
203 .span_note(span, "Clippy will use default configuration")
205 toml::from_str("").expect("we never error on empty config files")
209 let mut store = reg.sess.lint_store.borrow_mut();
210 store.register_removed(
212 "`assert!()` will be more flexible with RFC 2011",
214 store.register_removed(
216 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
218 store.register_removed(
219 "range_step_by_zero",
220 "`iterator.step_by(0)` panics nowadays",
222 store.register_removed(
224 "`Vec::as_slice` has been stabilized in 1.7",
226 store.register_removed(
227 "unstable_as_mut_slice",
228 "`Vec::as_mut_slice` has been stabilized in 1.7",
230 store.register_removed(
232 "using `str::to_string` is common even today and specialization will likely happen soon",
234 store.register_removed(
236 "using `string::to_string` is common even today and specialization will likely happen soon",
238 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
240 reg.register_late_lint_pass(box serde_api::Serde);
241 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
242 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
243 reg.register_late_lint_pass(box utils::inspector::Pass);
244 reg.register_late_lint_pass(box utils::author::Pass);
245 reg.register_late_lint_pass(box types::TypePass);
246 reg.register_late_lint_pass(box booleans::NonminimalBool);
247 reg.register_late_lint_pass(box eq_op::EqOp);
248 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
249 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
250 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
251 reg.register_late_lint_pass(box bit_mask::BitMask::new(conf.verbose_bit_mask_threshold));
252 reg.register_late_lint_pass(box ptr::PointerPass);
253 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
254 reg.register_late_lint_pass(box needless_bool::BoolComparison);
255 reg.register_late_lint_pass(box approx_const::Pass);
256 reg.register_late_lint_pass(box misc::Pass);
257 reg.register_early_lint_pass(box precedence::Precedence);
258 reg.register_early_lint_pass(box is_unit_expr::UnitExpr);
259 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
260 reg.register_late_lint_pass(box eta_reduction::EtaPass);
261 reg.register_late_lint_pass(box identity_op::IdentityOp);
262 reg.register_late_lint_pass(box erasing_op::ErasingOp);
263 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
264 reg.register_late_lint_pass(box mut_mut::MutMut);
265 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
266 reg.register_late_lint_pass(box len_zero::LenZero);
267 reg.register_late_lint_pass(box attrs::AttrPass);
268 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
269 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
270 reg.register_late_lint_pass(box unicode::Unicode);
271 reg.register_late_lint_pass(box strings::StringAdd);
272 reg.register_early_lint_pass(box returns::ReturnPass);
273 reg.register_late_lint_pass(box methods::Pass);
274 reg.register_late_lint_pass(box shadow::Pass);
275 reg.register_late_lint_pass(box types::LetPass);
276 reg.register_late_lint_pass(box types::UnitCmp);
277 reg.register_late_lint_pass(box loops::Pass);
278 reg.register_late_lint_pass(box lifetimes::LifetimePass);
279 reg.register_late_lint_pass(box entry::HashMapLint);
280 reg.register_late_lint_pass(box ranges::Pass);
281 reg.register_late_lint_pass(box types::CastPass);
282 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
283 reg.register_late_lint_pass(box matches::MatchPass);
284 reg.register_late_lint_pass(box minmax::MinMaxPass);
285 reg.register_late_lint_pass(box open_options::NonSensical);
286 reg.register_late_lint_pass(box zero_div_zero::Pass);
287 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
288 reg.register_late_lint_pass(box needless_update::Pass);
289 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
290 reg.register_late_lint_pass(box needless_borrowed_ref::NeedlessBorrowedRef);
291 reg.register_late_lint_pass(box no_effect::Pass);
292 reg.register_late_lint_pass(box map_clone::Pass);
293 reg.register_late_lint_pass(box temporary_assignment::Pass);
294 reg.register_late_lint_pass(box transmute::Transmute);
295 reg.register_late_lint_pass(
296 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
298 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
299 reg.register_early_lint_pass(box misc_early::MiscEarly);
300 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
301 reg.register_late_lint_pass(box panic::Pass);
302 reg.register_late_lint_pass(box strings::StringLitAsBytes);
303 reg.register_late_lint_pass(box derive::Derive);
304 reg.register_late_lint_pass(box types::CharLitAsU8);
305 reg.register_late_lint_pass(box print::Pass);
306 reg.register_late_lint_pass(box vec::Pass);
307 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
308 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
310 reg.register_late_lint_pass(box drop_forget_ref::Pass);
311 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
312 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
313 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
314 reg.register_late_lint_pass(box regex::Pass::default());
315 reg.register_late_lint_pass(box copies::CopyAndPaste);
316 reg.register_late_lint_pass(box format::Pass);
317 reg.register_early_lint_pass(box formatting::Formatting);
318 reg.register_late_lint_pass(box swap::Swap);
319 reg.register_early_lint_pass(box if_not_else::IfNotElse);
320 reg.register_early_lint_pass(box int_plus_one::IntPlusOne);
321 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
322 reg.register_late_lint_pass(box unused_label::UnusedLabel);
323 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
324 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
325 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
326 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
327 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
328 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
329 reg.register_late_lint_pass(box mem_forget::MemForget);
330 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
331 reg.register_late_lint_pass(box assign_ops::AssignOps);
332 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
333 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
334 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
335 reg.register_late_lint_pass(box ok_if_let::Pass);
336 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
337 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
338 reg.register_early_lint_pass(box reference::Pass);
339 reg.register_early_lint_pass(box double_parens::DoubleParens);
340 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
341 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
342 reg.register_late_lint_pass(box explicit_write::Pass);
343 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
344 reg.register_early_lint_pass(box literal_digit_grouping::LiteralDigitGrouping);
345 reg.register_late_lint_pass(box use_self::UseSelf);
346 reg.register_late_lint_pass(box bytecount::ByteCount);
347 reg.register_late_lint_pass(box infinite_iter::Pass);
348 reg.register_late_lint_pass(box invalid_ref::InvalidRef);
349 reg.register_late_lint_pass(box identity_conversion::IdentityConversion::default());
350 reg.register_late_lint_pass(box types::ImplicitHasher);
351 reg.register_early_lint_pass(box const_static_lifetime::StaticConst);
352 reg.register_late_lint_pass(box fallible_impl_from::FallibleImplFrom);
354 reg.register_lint_group("clippy_restrictions", vec![
355 arithmetic::FLOAT_ARITHMETIC,
356 arithmetic::INTEGER_ARITHMETIC,
357 array_indexing::INDEXING_SLICING,
358 assign_ops::ASSIGN_OPS,
361 reg.register_lint_group("clippy_pedantic", vec![
362 booleans::NONMINIMAL_BOOL,
363 empty_enum::EMPTY_ENUM,
364 enum_glob_use::ENUM_GLOB_USE,
365 enum_variants::PUB_ENUM_VARIANT_NAMES,
366 enum_variants::STUTTER,
367 fallible_impl_from::FALLIBLE_IMPL_FROM,
368 if_not_else::IF_NOT_ELSE,
369 infinite_iter::MAYBE_INFINITE_ITER,
370 int_plus_one::INT_PLUS_ONE,
371 items_after_statements::ITEMS_AFTER_STATEMENTS,
372 matches::SINGLE_MATCH_ELSE,
373 mem_forget::MEM_FORGET,
375 methods::OPTION_MAP_UNWRAP_OR,
376 methods::OPTION_MAP_UNWRAP_OR_ELSE,
377 methods::RESULT_MAP_UNWRAP_OR_ELSE,
378 methods::OPTION_UNWRAP_USED,
379 methods::RESULT_UNWRAP_USED,
380 methods::WRONG_PUB_SELF_CONVENTION,
381 misc::USED_UNDERSCORE_BINDING,
382 misc_early::UNSEPARATED_LITERAL_SUFFIX,
383 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
385 mutex_atomic::MUTEX_INTEGER,
386 non_expressive_names::SIMILAR_NAMES,
389 ranges::RANGE_PLUS_ONE,
390 shadow::SHADOW_REUSE,
392 shadow::SHADOW_UNRELATED,
394 strings::STRING_ADD_ASSIGN,
395 types::CAST_POSSIBLE_TRUNCATION,
396 types::CAST_POSSIBLE_WRAP,
397 types::CAST_PRECISION_LOSS,
398 types::CAST_SIGN_LOSS,
399 types::INVALID_UPCAST_COMPARISONS,
400 unicode::NON_ASCII_LITERAL,
401 unicode::UNICODE_NOT_NFC,
405 reg.register_lint_group("clippy_internal", vec![
406 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
407 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
410 reg.register_lint_group("clippy", vec![
411 approx_const::APPROX_CONSTANT,
412 array_indexing::OUT_OF_BOUNDS_INDEXING,
413 assign_ops::ASSIGN_OP_PATTERN,
414 assign_ops::MISREFACTORED_ASSIGN_OP,
415 attrs::DEPRECATED_SEMVER,
416 attrs::INLINE_ALWAYS,
417 attrs::USELESS_ATTRIBUTE,
418 bit_mask::BAD_BIT_MASK,
419 bit_mask::INEFFECTIVE_BIT_MASK,
420 bit_mask::VERBOSE_BIT_MASK,
421 blacklisted_name::BLACKLISTED_NAME,
422 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
423 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
425 bytecount::NAIVE_BYTECOUNT,
426 collapsible_if::COLLAPSIBLE_IF,
427 const_static_lifetime::CONST_STATIC_LIFETIME,
428 copies::IF_SAME_THEN_ELSE,
429 copies::IFS_SAME_COND,
430 copies::MATCH_SAME_ARMS,
431 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
432 derive::DERIVE_HASH_XOR_EQ,
433 derive::EXPL_IMPL_CLONE_ON_COPY,
435 double_parens::DOUBLE_PARENS,
436 drop_forget_ref::DROP_COPY,
437 drop_forget_ref::DROP_REF,
438 drop_forget_ref::FORGET_COPY,
439 drop_forget_ref::FORGET_REF,
441 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
442 enum_variants::ENUM_VARIANT_NAMES,
443 enum_variants::MODULE_INCEPTION,
446 erasing_op::ERASING_OP,
448 eta_reduction::REDUNDANT_CLOSURE,
449 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
450 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
451 explicit_write::EXPLICIT_WRITE,
452 format::USELESS_FORMAT,
453 formatting::POSSIBLE_MISSING_COMMA,
454 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
455 formatting::SUSPICIOUS_ELSE_FORMATTING,
456 functions::NOT_UNSAFE_PTR_ARG_DEREF,
457 functions::TOO_MANY_ARGUMENTS,
458 identity_conversion::IDENTITY_CONVERSION,
459 identity_op::IDENTITY_OP,
460 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
461 infinite_iter::INFINITE_ITER,
462 invalid_ref::INVALID_REF,
463 is_unit_expr::UNIT_EXPR,
464 large_enum_variant::LARGE_ENUM_VARIANT,
465 len_zero::LEN_WITHOUT_IS_EMPTY,
467 let_if_seq::USELESS_LET_IF_SEQ,
468 lifetimes::NEEDLESS_LIFETIMES,
469 lifetimes::UNUSED_LIFETIMES,
470 literal_digit_grouping::INCONSISTENT_DIGIT_GROUPING,
471 literal_digit_grouping::LARGE_DIGIT_GROUPS,
472 literal_digit_grouping::UNREADABLE_LITERAL,
474 loops::EXPLICIT_COUNTER_LOOP,
475 loops::EXPLICIT_INTO_ITER_LOOP,
476 loops::EXPLICIT_ITER_LOOP,
478 loops::FOR_LOOP_OVER_OPTION,
479 loops::FOR_LOOP_OVER_RESULT,
480 loops::ITER_NEXT_LOOP,
481 loops::MANUAL_MEMCPY,
482 loops::MUT_RANGE_BOUND,
483 loops::NEEDLESS_RANGE_LOOP,
485 loops::REVERSE_RANGE_LOOP,
486 loops::UNUSED_COLLECT,
487 loops::WHILE_LET_LOOP,
488 loops::WHILE_LET_ON_ITERATOR,
489 map_clone::MAP_CLONE,
491 matches::MATCH_OVERLAPPING_ARM,
492 matches::MATCH_REF_PATS,
493 matches::MATCH_WILD_ERR_ARM,
494 matches::SINGLE_MATCH,
495 methods::CHARS_LAST_CMP,
496 methods::CHARS_NEXT_CMP,
497 methods::CLONE_DOUBLE_REF,
498 methods::CLONE_ON_COPY,
499 methods::CLONE_ON_REF_PTR,
500 methods::FILTER_NEXT,
502 methods::ITER_CLONED_COLLECT,
504 methods::ITER_SKIP_NEXT,
505 methods::NEW_RET_NO_SELF,
507 methods::OPTION_MAP_OR_NONE,
508 methods::OR_FUN_CALL,
509 methods::SEARCH_IS_SOME,
510 methods::SHOULD_IMPLEMENT_TRAIT,
511 methods::SINGLE_CHAR_PATTERN,
512 methods::STRING_EXTEND_CHARS,
513 methods::TEMPORARY_CSTRING_AS_PTR,
514 methods::USELESS_ASREF,
515 methods::WRONG_SELF_CONVENTION,
521 misc::REDUNDANT_PATTERN,
522 misc::SHORT_CIRCUIT_STATEMENT,
523 misc::TOPLEVEL_REF_ARG,
525 misc_early::BUILTIN_TYPE_SHADOW,
526 misc_early::DOUBLE_NEG,
527 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
528 misc_early::MIXED_CASE_HEX_LITERALS,
529 misc_early::REDUNDANT_CLOSURE_CALL,
530 misc_early::UNNEEDED_FIELD_PATTERN,
531 misc_early::ZERO_PREFIXED_LITERAL,
532 mut_reference::UNNECESSARY_MUT_PASSED,
533 mutex_atomic::MUTEX_ATOMIC,
534 needless_bool::BOOL_COMPARISON,
535 needless_bool::NEEDLESS_BOOL,
536 needless_borrow::NEEDLESS_BORROW,
537 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
538 needless_continue::NEEDLESS_CONTINUE,
539 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
540 needless_update::NEEDLESS_UPDATE,
541 neg_multiply::NEG_MULTIPLY,
542 new_without_default::NEW_WITHOUT_DEFAULT,
543 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
544 no_effect::NO_EFFECT,
545 no_effect::UNNECESSARY_OPERATION,
546 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
547 ok_if_let::IF_LET_SOME_RESULT,
548 open_options::NONSENSICAL_OPEN_OPTIONS,
549 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
551 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
552 precedence::PRECEDENCE,
553 print::PRINT_WITH_NEWLINE,
554 print::PRINTLN_EMPTY_STRING,
558 ranges::ITERATOR_STEP_BY_ZERO,
559 ranges::RANGE_MINUS_ONE,
560 ranges::RANGE_ZIP_WITH_LEN,
561 reference::DEREF_ADDROF,
562 regex::INVALID_REGEX,
564 regex::TRIVIAL_REGEX,
565 returns::LET_AND_RETURN,
566 returns::NEEDLESS_RETURN,
567 serde_api::SERDE_API_MISUSE,
568 strings::STRING_LIT_AS_BYTES,
569 swap::ALMOST_SWAPPED,
571 temporary_assignment::TEMPORARY_ASSIGNMENT,
572 transmute::CROSSPOINTER_TRANSMUTE,
573 transmute::TRANSMUTE_INT_TO_BOOL,
574 transmute::TRANSMUTE_INT_TO_CHAR,
575 transmute::TRANSMUTE_INT_TO_FLOAT,
576 transmute::TRANSMUTE_PTR_TO_REF,
577 transmute::USELESS_TRANSMUTE,
578 transmute::WRONG_TRANSMUTE,
579 types::ABSURD_EXTREME_COMPARISONS,
582 types::CAST_LOSSLESS,
583 types::CHAR_LIT_AS_U8,
584 types::IMPLICIT_HASHER,
585 types::LET_UNIT_VALUE,
587 types::TYPE_COMPLEXITY,
589 types::UNNECESSARY_CAST,
590 unicode::ZERO_WIDTH_SPACE,
591 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
592 unused_io_amount::UNUSED_IO_AMOUNT,
593 unused_label::UNUSED_LABEL,
595 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
599 // only exists to let the dogfood integration test works.
600 // Don't run clippy as an executable directly
601 #[allow(dead_code, print_stdout)]
603 panic!("Please use the cargo-clippy executable");