1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(custom_attribute)]
7 #![feature(rustc_private)]
8 #![feature(slice_patterns)]
9 #![feature(stmt_expr_attributes)]
10 #![feature(conservative_impl_trait)]
11 #![feature(inclusive_range_syntax, range_contains)]
12 #![allow(unknown_lints, indexing_slicing, shadow_reuse, missing_docs_in_private_items)]
17 extern crate syntax_pos;
21 // for unicode nfc normalization
23 extern crate unicode_normalization;
25 // for semver check in attrs.rs
31 extern crate regex_syntax;
33 // for finding minimal boolean expressions
35 extern crate quine_mc_cluskey;
37 extern crate rustc_const_eval;
38 extern crate rustc_const_math;
39 extern crate rustc_errors;
40 extern crate rustc_plugin;
43 extern crate matches as matches_macro;
47 extern crate serde_derive;
50 extern crate lazy_static;
52 extern crate itertools;
53 extern crate pulldown_cmark;
56 macro_rules! declare_restriction_lint {
57 { pub $name:tt, $description:tt } => {
58 declare_lint! { pub $name, Allow, $description }
66 // begin lints modules, do not remove this comment, it’s used in `update_lints`
69 pub mod array_indexing;
73 pub mod blacklisted_name;
74 pub mod block_in_if_condition;
77 pub mod collapsible_if;
79 pub mod cyclomatic_complexity;
82 pub mod double_parens;
83 pub mod drop_forget_ref;
87 pub mod enum_glob_use;
88 pub mod enum_variants;
91 pub mod eta_reduction;
92 pub mod eval_order_dependence;
96 pub mod identity_conversion;
98 pub mod if_let_redundant_pattern_matching;
100 pub mod infinite_iter;
101 pub mod int_plus_one;
103 pub mod is_unit_expr;
104 pub mod items_after_statements;
105 pub mod large_enum_variant;
109 pub mod literal_digit_grouping;
120 pub mod mut_reference;
121 pub mod mutex_atomic;
122 pub mod needless_bool;
123 pub mod needless_borrow;
124 pub mod needless_borrowed_ref;
125 pub mod needless_continue;
126 pub mod needless_pass_by_value;
127 pub mod needless_update;
128 pub mod neg_multiply;
129 pub mod new_without_default;
131 pub mod non_expressive_names;
133 pub mod open_options;
134 pub mod overflow_check_conditional;
136 pub mod partialeq_ne_impl;
146 pub mod should_assert_eq;
149 pub mod temporary_assignment;
153 pub mod unsafe_removed_from_name;
154 pub mod unused_io_amount;
155 pub mod unused_label;
158 pub mod zero_div_zero;
159 // end lints modules, do not remove this comment, it’s used in `update_lints`
162 pub use syntax::ast::{Name, NodeId};
165 #[cfg_attr(rustfmt, rustfmt_skip)]
166 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
167 let conf = match utils::conf::file_from_args(reg.args()) {
169 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
170 // do not require the file to exist
171 let file_name = if let Some(file_name) = file_name {
174 match utils::conf::lookup_conf_file() {
177 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
183 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
185 // all conf errors are non-fatal, we just use the default conf in case of error
186 for error in errors {
187 reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
192 Err((err, span)) => {
193 reg.sess.struct_span_err(span, err)
194 .span_note(span, "Clippy will use default configuration")
196 toml::from_str("").expect("we never error on empty config files")
200 let mut store = reg.sess.lint_store.borrow_mut();
201 store.register_removed(
203 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
205 store.register_removed(
206 "range_step_by_zero",
207 "`iterator.step_by(0)` panics nowadays",
209 store.register_removed(
211 "`Vec::as_slice` has been stabilized in 1.7",
213 store.register_removed(
214 "unstable_as_mut_slice",
215 "`Vec::as_mut_slice` has been stabilized in 1.7",
217 store.register_removed(
219 "using `str::to_string` is common even today and specialization will likely happen soon",
221 store.register_removed(
223 "using `string::to_string` is common even today and specialization will likely happen soon",
225 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
227 reg.register_late_lint_pass(box serde_api::Serde);
228 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
229 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
230 reg.register_late_lint_pass(box utils::inspector::Pass);
231 reg.register_late_lint_pass(box utils::author::Pass);
232 reg.register_late_lint_pass(box types::TypePass);
233 reg.register_late_lint_pass(box booleans::NonminimalBool);
234 reg.register_late_lint_pass(box eq_op::EqOp);
235 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
236 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
237 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
238 reg.register_late_lint_pass(box bit_mask::BitMask::new(conf.verbose_bit_mask_threshold));
239 reg.register_late_lint_pass(box ptr::PointerPass);
240 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
241 reg.register_late_lint_pass(box needless_bool::BoolComparison);
242 reg.register_late_lint_pass(box approx_const::Pass);
243 reg.register_late_lint_pass(box misc::Pass);
244 reg.register_early_lint_pass(box precedence::Precedence);
245 reg.register_early_lint_pass(box is_unit_expr::UnitExpr);
246 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
247 reg.register_late_lint_pass(box eta_reduction::EtaPass);
248 reg.register_late_lint_pass(box identity_op::IdentityOp);
249 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
250 reg.register_late_lint_pass(box mut_mut::MutMut);
251 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
252 reg.register_late_lint_pass(box len_zero::LenZero);
253 reg.register_late_lint_pass(box attrs::AttrPass);
254 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
255 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
256 reg.register_late_lint_pass(box unicode::Unicode);
257 reg.register_late_lint_pass(box strings::StringAdd);
258 reg.register_early_lint_pass(box returns::ReturnPass);
259 reg.register_late_lint_pass(box methods::Pass);
260 reg.register_late_lint_pass(box shadow::Pass);
261 reg.register_late_lint_pass(box types::LetPass);
262 reg.register_late_lint_pass(box types::UnitCmp);
263 reg.register_late_lint_pass(box loops::Pass);
264 reg.register_late_lint_pass(box lifetimes::LifetimePass);
265 reg.register_late_lint_pass(box entry::HashMapLint);
266 reg.register_late_lint_pass(box ranges::Pass);
267 reg.register_late_lint_pass(box types::CastPass);
268 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
269 reg.register_late_lint_pass(box matches::MatchPass);
270 reg.register_late_lint_pass(box minmax::MinMaxPass);
271 reg.register_late_lint_pass(box open_options::NonSensical);
272 reg.register_late_lint_pass(box zero_div_zero::Pass);
273 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
274 reg.register_late_lint_pass(box needless_update::Pass);
275 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
276 reg.register_late_lint_pass(box needless_borrowed_ref::NeedlessBorrowedRef);
277 reg.register_late_lint_pass(box no_effect::Pass);
278 reg.register_late_lint_pass(box map_clone::Pass);
279 reg.register_late_lint_pass(box temporary_assignment::Pass);
280 reg.register_late_lint_pass(box transmute::Transmute);
281 reg.register_late_lint_pass(
282 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
284 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
285 reg.register_early_lint_pass(box misc_early::MiscEarly);
286 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
287 reg.register_late_lint_pass(box panic::Pass);
288 reg.register_late_lint_pass(box strings::StringLitAsBytes);
289 reg.register_late_lint_pass(box derive::Derive);
290 reg.register_late_lint_pass(box types::CharLitAsU8);
291 reg.register_late_lint_pass(box print::Pass);
292 reg.register_late_lint_pass(box vec::Pass);
293 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
294 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
296 reg.register_late_lint_pass(box drop_forget_ref::Pass);
297 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
298 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
299 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
300 reg.register_late_lint_pass(box regex::Pass::default());
301 reg.register_late_lint_pass(box copies::CopyAndPaste);
302 reg.register_late_lint_pass(box format::Pass);
303 reg.register_early_lint_pass(box formatting::Formatting);
304 reg.register_late_lint_pass(box swap::Swap);
305 reg.register_early_lint_pass(box if_not_else::IfNotElse);
306 reg.register_early_lint_pass(box int_plus_one::IntPlusOne);
307 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
308 reg.register_late_lint_pass(box unused_label::UnusedLabel);
309 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
310 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
311 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
312 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
313 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
314 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
315 reg.register_late_lint_pass(box mem_forget::MemForget);
316 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
317 reg.register_late_lint_pass(box assign_ops::AssignOps);
318 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
319 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
320 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
321 reg.register_late_lint_pass(box ok_if_let::Pass);
322 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
323 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
324 reg.register_early_lint_pass(box reference::Pass);
325 reg.register_early_lint_pass(box double_parens::DoubleParens);
326 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
327 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
328 reg.register_late_lint_pass(box should_assert_eq::ShouldAssertEq);
329 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
330 reg.register_early_lint_pass(box literal_digit_grouping::LiteralDigitGrouping);
331 reg.register_late_lint_pass(box use_self::UseSelf);
332 reg.register_late_lint_pass(box bytecount::ByteCount);
333 reg.register_late_lint_pass(box infinite_iter::Pass);
334 reg.register_late_lint_pass(box invalid_ref::InvalidRef);
335 reg.register_late_lint_pass(box identity_conversion::IdentityConversion::default());
337 reg.register_lint_group("clippy_restrictions", vec![
338 arithmetic::FLOAT_ARITHMETIC,
339 arithmetic::INTEGER_ARITHMETIC,
340 array_indexing::INDEXING_SLICING,
341 assign_ops::ASSIGN_OPS,
344 reg.register_lint_group("clippy_pedantic", vec![
345 booleans::NONMINIMAL_BOOL,
346 empty_enum::EMPTY_ENUM,
347 enum_glob_use::ENUM_GLOB_USE,
348 enum_variants::PUB_ENUM_VARIANT_NAMES,
349 enum_variants::STUTTER,
350 if_not_else::IF_NOT_ELSE,
351 infinite_iter::MAYBE_INFINITE_ITER,
352 int_plus_one::INT_PLUS_ONE,
353 invalid_ref::INVALID_REF,
354 items_after_statements::ITEMS_AFTER_STATEMENTS,
355 matches::SINGLE_MATCH_ELSE,
356 mem_forget::MEM_FORGET,
358 methods::OPTION_MAP_UNWRAP_OR,
359 methods::OPTION_MAP_UNWRAP_OR_ELSE,
360 methods::OPTION_UNWRAP_USED,
361 methods::RESULT_UNWRAP_USED,
362 methods::WRONG_PUB_SELF_CONVENTION,
363 misc::USED_UNDERSCORE_BINDING,
364 misc_early::UNSEPARATED_LITERAL_SUFFIX,
365 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
367 mutex_atomic::MUTEX_INTEGER,
368 non_expressive_names::SIMILAR_NAMES,
371 shadow::SHADOW_REUSE,
373 shadow::SHADOW_UNRELATED,
375 strings::STRING_ADD_ASSIGN,
376 types::CAST_POSSIBLE_TRUNCATION,
377 types::CAST_POSSIBLE_WRAP,
378 types::CAST_PRECISION_LOSS,
379 types::CAST_SIGN_LOSS,
380 types::INVALID_UPCAST_COMPARISONS,
381 unicode::NON_ASCII_LITERAL,
382 unicode::UNICODE_NOT_NFC,
386 reg.register_lint_group("clippy_internal", vec![
387 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
388 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
391 reg.register_lint_group("clippy", vec![
392 approx_const::APPROX_CONSTANT,
393 array_indexing::OUT_OF_BOUNDS_INDEXING,
394 assign_ops::ASSIGN_OP_PATTERN,
395 assign_ops::MISREFACTORED_ASSIGN_OP,
396 attrs::DEPRECATED_SEMVER,
397 attrs::INLINE_ALWAYS,
398 attrs::USELESS_ATTRIBUTE,
399 bit_mask::BAD_BIT_MASK,
400 bit_mask::INEFFECTIVE_BIT_MASK,
401 bit_mask::VERBOSE_BIT_MASK,
402 blacklisted_name::BLACKLISTED_NAME,
403 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
404 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
406 bytecount::NAIVE_BYTECOUNT,
407 collapsible_if::COLLAPSIBLE_IF,
408 copies::IF_SAME_THEN_ELSE,
409 copies::IFS_SAME_COND,
410 copies::MATCH_SAME_ARMS,
411 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
412 derive::DERIVE_HASH_XOR_EQ,
413 derive::EXPL_IMPL_CLONE_ON_COPY,
415 double_parens::DOUBLE_PARENS,
416 drop_forget_ref::DROP_COPY,
417 drop_forget_ref::DROP_REF,
418 drop_forget_ref::FORGET_COPY,
419 drop_forget_ref::FORGET_REF,
421 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
422 enum_variants::ENUM_VARIANT_NAMES,
423 enum_variants::MODULE_INCEPTION,
427 eta_reduction::REDUNDANT_CLOSURE,
428 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
429 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
430 format::USELESS_FORMAT,
431 formatting::POSSIBLE_MISSING_COMMA,
432 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
433 formatting::SUSPICIOUS_ELSE_FORMATTING,
434 functions::NOT_UNSAFE_PTR_ARG_DEREF,
435 functions::TOO_MANY_ARGUMENTS,
436 identity_conversion::IDENTITY_CONVERSION,
437 identity_op::IDENTITY_OP,
438 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
439 infinite_iter::INFINITE_ITER,
440 is_unit_expr::UNIT_EXPR,
441 large_enum_variant::LARGE_ENUM_VARIANT,
442 len_zero::LEN_WITHOUT_IS_EMPTY,
444 let_if_seq::USELESS_LET_IF_SEQ,
445 lifetimes::NEEDLESS_LIFETIMES,
446 lifetimes::UNUSED_LIFETIMES,
447 literal_digit_grouping::INCONSISTENT_DIGIT_GROUPING,
448 literal_digit_grouping::LARGE_DIGIT_GROUPS,
449 literal_digit_grouping::UNREADABLE_LITERAL,
451 loops::EXPLICIT_COUNTER_LOOP,
452 loops::EXPLICIT_INTO_ITER_LOOP,
453 loops::EXPLICIT_ITER_LOOP,
455 loops::FOR_LOOP_OVER_OPTION,
456 loops::FOR_LOOP_OVER_RESULT,
457 loops::ITER_NEXT_LOOP,
458 loops::MANUAL_MEMCPY,
459 loops::MUT_RANGE_BOUND,
460 loops::NEEDLESS_RANGE_LOOP,
462 loops::REVERSE_RANGE_LOOP,
463 loops::UNUSED_COLLECT,
464 loops::WHILE_LET_LOOP,
465 loops::WHILE_LET_ON_ITERATOR,
466 map_clone::MAP_CLONE,
468 matches::MATCH_OVERLAPPING_ARM,
469 matches::MATCH_REF_PATS,
470 matches::MATCH_WILD_ERR_ARM,
471 matches::SINGLE_MATCH,
472 methods::CHARS_LAST_CMP,
473 methods::CHARS_NEXT_CMP,
474 methods::CLONE_DOUBLE_REF,
475 methods::CLONE_ON_COPY,
476 methods::CLONE_ON_REF_PTR,
477 methods::FILTER_NEXT,
479 methods::ITER_CLONED_COLLECT,
481 methods::ITER_SKIP_NEXT,
482 methods::NEW_RET_NO_SELF,
484 methods::OR_FUN_CALL,
485 methods::SEARCH_IS_SOME,
486 methods::SHOULD_IMPLEMENT_TRAIT,
487 methods::SINGLE_CHAR_PATTERN,
488 methods::STRING_EXTEND_CHARS,
489 methods::TEMPORARY_CSTRING_AS_PTR,
490 methods::WRONG_SELF_CONVENTION,
496 misc::REDUNDANT_PATTERN,
497 misc::SHORT_CIRCUIT_STATEMENT,
498 misc::TOPLEVEL_REF_ARG,
500 misc_early::BUILTIN_TYPE_SHADOW,
501 misc_early::DOUBLE_NEG,
502 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
503 misc_early::MIXED_CASE_HEX_LITERALS,
504 misc_early::REDUNDANT_CLOSURE_CALL,
505 misc_early::UNNEEDED_FIELD_PATTERN,
506 misc_early::ZERO_PREFIXED_LITERAL,
507 mut_reference::UNNECESSARY_MUT_PASSED,
508 mutex_atomic::MUTEX_ATOMIC,
509 needless_bool::BOOL_COMPARISON,
510 needless_bool::NEEDLESS_BOOL,
511 needless_borrow::NEEDLESS_BORROW,
512 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
513 needless_continue::NEEDLESS_CONTINUE,
514 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
515 needless_update::NEEDLESS_UPDATE,
516 neg_multiply::NEG_MULTIPLY,
517 new_without_default::NEW_WITHOUT_DEFAULT,
518 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
519 no_effect::NO_EFFECT,
520 no_effect::UNNECESSARY_OPERATION,
521 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
522 ok_if_let::IF_LET_SOME_RESULT,
523 open_options::NONSENSICAL_OPEN_OPTIONS,
524 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
526 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
527 precedence::PRECEDENCE,
528 print::PRINT_WITH_NEWLINE,
532 ranges::ITERATOR_STEP_BY_ZERO,
533 ranges::RANGE_ZIP_WITH_LEN,
534 reference::DEREF_ADDROF,
535 regex::INVALID_REGEX,
537 regex::TRIVIAL_REGEX,
538 returns::LET_AND_RETURN,
539 returns::NEEDLESS_RETURN,
540 serde_api::SERDE_API_MISUSE,
541 should_assert_eq::SHOULD_ASSERT_EQ,
542 strings::STRING_LIT_AS_BYTES,
543 swap::ALMOST_SWAPPED,
545 temporary_assignment::TEMPORARY_ASSIGNMENT,
546 transmute::CROSSPOINTER_TRANSMUTE,
547 transmute::TRANSMUTE_PTR_TO_REF,
548 transmute::USELESS_TRANSMUTE,
549 transmute::WRONG_TRANSMUTE,
550 transmute::TRANSMUTE_INT_TO_CHAR,
551 transmute::TRANSMUTE_INT_TO_BOOL,
552 transmute::TRANSMUTE_INT_TO_FLOAT,
553 types::ABSURD_EXTREME_COMPARISONS,
556 types::CAST_LOSSLESS,
557 types::CHAR_LIT_AS_U8,
558 types::LET_UNIT_VALUE,
560 types::TYPE_COMPLEXITY,
562 types::UNNECESSARY_CAST,
563 unicode::ZERO_WIDTH_SPACE,
564 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
565 unused_io_amount::UNUSED_IO_AMOUNT,
566 unused_label::UNUSED_LABEL,
568 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
572 // only exists to let the dogfood integration test works.
573 // Don't run clippy as an executable directly
574 #[allow(dead_code, print_stdout)]
576 panic!("Please use the cargo-clippy executable");