1 use crate::utils::{snippet, span_lint_and_then};
2 use if_chain::if_chain;
4 use rustc::hir::def::Def;
5 use rustc::hir::BindingAnnotation;
6 use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
7 use rustc::{declare_lint_pass, declare_tool_lint};
8 use rustc_errors::Applicability;
10 declare_clippy_lint! {
11 /// **What it does:** Checks for variable declarations immediately followed by a
12 /// conditional affectation.
14 /// **Why is this bad?** This is not idiomatic Rust.
16 /// **Known problems:** None.
28 /// let mut baz = None;
38 /// let foo = if bar() {
44 /// let baz = if bar() {
50 pub USELESS_LET_IF_SEQ,
52 "unidiomatic `let mut` declaration followed by initialization in `if`"
55 declare_lint_pass!(LetIfSeq => [USELESS_LET_IF_SEQ]);
57 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for LetIfSeq {
58 fn check_block(&mut self, cx: &LateContext<'a, 'tcx>, block: &'tcx hir::Block) {
59 let mut it = block.stmts.iter().peekable();
60 while let Some(stmt) = it.next() {
62 if let Some(expr) = it.peek();
63 if let hir::StmtKind::Local(ref local) = stmt.node;
64 if let hir::PatKind::Binding(mode, canonical_id, ident, None) = local.pat.node;
65 if let hir::StmtKind::Expr(ref if_) = expr.node;
66 if let hir::ExprKind::If(ref cond, ref then, ref else_) = if_.node;
67 if !used_in_expr(cx, canonical_id, cond);
68 if let hir::ExprKind::Block(ref then, _) = then.node;
69 if let Some(value) = check_assign(cx, canonical_id, &*then);
70 if !used_in_expr(cx, canonical_id, value);
72 let span = stmt.span.to(if_.span);
74 let (default_multi_stmts, default) = if let Some(ref else_) = *else_ {
75 if let hir::ExprKind::Block(ref else_, _) = else_.node {
76 if let Some(default) = check_assign(cx, canonical_id, else_) {
77 (else_.stmts.len() > 1, default)
78 } else if let Some(ref default) = local.init {
86 } else if let Some(ref default) = local.init {
92 let mutability = match mode {
93 BindingAnnotation::RefMut | BindingAnnotation::Mutable => "<mut> ",
97 // FIXME: this should not suggest `mut` if we can detect that the variable is not
98 // use mutably after the `if`
101 "let {mut}{name} = if {cond} {{{then} {value} }} else {{{else} {default} }};",
104 cond=snippet(cx, cond.span, "_"),
105 then=if then.stmts.len() > 1 { " ..;" } else { "" },
106 else=if default_multi_stmts { " ..;" } else { "" },
107 value=snippet(cx, value.span, "<value>"),
108 default=snippet(cx, default.span, "<default>"),
110 span_lint_and_then(cx,
113 "`if _ { .. } else { .. }` is an expression",
117 "it is more idiomatic to write",
119 Applicability::HasPlaceholders,
121 if !mutability.is_empty() {
122 db.note("you might not need `mut` at all");
131 struct UsedVisitor<'a, 'tcx: 'a> {
132 cx: &'a LateContext<'a, 'tcx>,
137 impl<'a, 'tcx> hir::intravisit::Visitor<'tcx> for UsedVisitor<'a, 'tcx> {
138 fn visit_expr(&mut self, expr: &'tcx hir::Expr) {
140 if let hir::ExprKind::Path(ref qpath) = expr.node;
141 if let Def::Local(local_id) = self.cx.tables.qpath_def(qpath, expr.hir_id);
142 if self.id == local_id;
148 hir::intravisit::walk_expr(self, expr);
150 fn nested_visit_map<'this>(&'this mut self) -> hir::intravisit::NestedVisitorMap<'this, 'tcx> {
151 hir::intravisit::NestedVisitorMap::None
155 fn check_assign<'a, 'tcx>(
156 cx: &LateContext<'a, 'tcx>,
158 block: &'tcx hir::Block,
159 ) -> Option<&'tcx hir::Expr> {
161 if block.expr.is_none();
162 if let Some(expr) = block.stmts.iter().last();
163 if let hir::StmtKind::Semi(ref expr) = expr.node;
164 if let hir::ExprKind::Assign(ref var, ref value) = expr.node;
165 if let hir::ExprKind::Path(ref qpath) = var.node;
166 if let Def::Local(local_id) = cx.tables.qpath_def(qpath, var.hir_id);
169 let mut v = UsedVisitor {
175 for s in block.stmts.iter().take(block.stmts.len()-1) {
176 hir::intravisit::walk_stmt(&mut v, s);
190 fn used_in_expr<'a, 'tcx: 'a>(cx: &LateContext<'a, 'tcx>, id: hir::HirId, expr: &'tcx hir::Expr) -> bool {
191 let mut v = UsedVisitor { cx, id, used: false };
192 hir::intravisit::walk_expr(&mut v, expr);