1 use rustc::hir::def_id::DefId;
5 use std::collections::HashSet;
6 use syntax::ast::{Lit, LitKind, Name};
7 use syntax::codemap::{Span, Spanned};
8 use crate::utils::{get_item_name, in_macro, snippet, span_lint, span_lint_and_sugg, walk_ptrs_ty};
10 /// **What it does:** Checks for getting the length of something via `.len()`
11 /// just to compare to zero, and suggests using `.is_empty()` where applicable.
13 /// **Why is this bad?** Some structures can answer `.is_empty()` much faster
14 /// than calculating their length. Notably, for slices, getting the length
15 /// requires a subtraction whereas `.is_empty()` is just a comparison. So it is
16 /// good to get into the habit of using `.is_empty()`, and having it is cheap.
17 /// Besides, it makes the intent clearer than a manual comparison.
19 /// **Known problems:** None.
23 /// if x.len() == 0 { .. }
25 declare_clippy_lint! {
28 "checking `.len() == 0` or `.len() > 0` (or similar) when `.is_empty()` \
29 could be used instead"
32 /// **What it does:** Checks for items that implement `.len()` but not
35 /// **Why is this bad?** It is good custom to have both methods, because for
36 /// some data structures, asking about the length will be a costly operation,
37 /// whereas `.is_empty()` can usually answer in constant time. Also it used to
38 /// lead to false positives on the [`len_zero`](#len_zero) lint – currently that
39 /// lint will ignore such entities.
41 /// **Known problems:** None.
46 /// pub fn len(&self) -> usize { .. }
49 declare_clippy_lint! {
50 pub LEN_WITHOUT_IS_EMPTY,
52 "traits or impls with a public `len` method but no corresponding `is_empty` method"
55 #[derive(Copy, Clone)]
58 impl LintPass for LenZero {
59 fn get_lints(&self) -> LintArray {
60 lint_array!(LEN_ZERO, LEN_WITHOUT_IS_EMPTY)
64 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for LenZero {
65 fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item) {
66 if in_macro(item.span) {
71 ItemTrait(_, _, _, _, ref trait_items) => check_trait_items(cx, item, trait_items),
72 ItemImpl(_, _, _, _, None, _, ref impl_items) => check_impl_items(cx, item, impl_items),
77 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
78 if in_macro(expr.span) {
82 if let ExprBinary(Spanned { node: cmp, .. }, ref left, ref right) = expr.node {
85 check_cmp(cx, expr.span, left, right, "", 0); // len == 0
86 check_cmp(cx, expr.span, right, left, "", 0); // 0 == len
89 check_cmp(cx, expr.span, left, right, "!", 0); // len != 0
90 check_cmp(cx, expr.span, right, left, "!", 0); // 0 != len
93 check_cmp(cx, expr.span, left, right, "!", 0); // len > 0
94 check_cmp(cx, expr.span, right, left, "", 1); // 1 > len
97 check_cmp(cx, expr.span, left, right, "", 1); // len < 1
98 check_cmp(cx, expr.span, right, left, "!", 0); // 0 < len
100 BiGe => check_cmp(cx, expr.span, left, right, "!", 1), // len <= 1
101 BiLe => check_cmp(cx, expr.span, right, left, "!", 1), // 1 >= len
108 fn check_trait_items(cx: &LateContext, visited_trait: &Item, trait_items: &[TraitItemRef]) {
109 fn is_named_self(cx: &LateContext, item: &TraitItemRef, name: &str) -> bool {
110 item.name == name && if let AssociatedItemKind::Method { has_self } = item.kind {
112 let did = cx.tcx.hir.local_def_id(item.id.node_id);
113 cx.tcx.fn_sig(did).inputs().skip_binder().len() == 1
120 // fill the set with current and super traits
121 fn fill_trait_set(traitt: DefId, set: &mut HashSet<DefId>, cx: &LateContext) {
122 if set.insert(traitt) {
123 for supertrait in ::rustc::traits::supertrait_def_ids(cx.tcx, traitt) {
124 fill_trait_set(supertrait, set, cx);
129 if cx.access_levels.is_exported(visited_trait.id) && trait_items.iter().any(|i| is_named_self(cx, i, "len")) {
130 let mut current_and_super_traits = HashSet::new();
131 let visited_trait_def_id = cx.tcx.hir.local_def_id(visited_trait.id);
132 fill_trait_set(visited_trait_def_id, &mut current_and_super_traits, cx);
134 let is_empty_method_found = current_and_super_traits
136 .flat_map(|&i| cx.tcx.associated_items(i))
138 i.kind == ty::AssociatedKind::Method && i.method_has_self_argument && i.name == "is_empty"
139 && cx.tcx.fn_sig(i.def_id).inputs().skip_binder().len() == 1
142 if !is_empty_method_found {
145 LEN_WITHOUT_IS_EMPTY,
148 "trait `{}` has a `len` method but no (possibly inherited) `is_empty` method",
156 fn check_impl_items(cx: &LateContext, item: &Item, impl_items: &[ImplItemRef]) {
157 fn is_named_self(cx: &LateContext, item: &ImplItemRef, name: &str) -> bool {
158 item.name == name && if let AssociatedItemKind::Method { has_self } = item.kind {
160 let did = cx.tcx.hir.local_def_id(item.id.node_id);
161 cx.tcx.fn_sig(did).inputs().skip_binder().len() == 1
168 let is_empty = if let Some(is_empty) = impl_items.iter().find(|i| is_named_self(cx, i, "is_empty")) {
169 if cx.access_levels.is_exported(is_empty.id.node_id) {
178 if let Some(i) = impl_items.iter().find(|i| is_named_self(cx, i, "len")) {
179 if cx.access_levels.is_exported(i.id.node_id) {
180 let def_id = cx.tcx.hir.local_def_id(item.id);
181 let ty = cx.tcx.type_of(def_id);
185 LEN_WITHOUT_IS_EMPTY,
188 "item `{}` has a public `len` method but {} `is_empty` method",
196 fn check_cmp(cx: &LateContext, span: Span, method: &Expr, lit: &Expr, op: &str, compare_to: u32) {
197 if let (&ExprMethodCall(ref method_path, _, ref args), &ExprLit(ref lit)) = (&method.node, &lit.node) {
198 // check if we are in an is_empty() method
199 if let Some(name) = get_item_name(cx, method) {
200 if name == "is_empty" {
205 check_len(cx, span, method_path.name, args, lit, op, compare_to)
209 fn check_len(cx: &LateContext, span: Span, method_name: Name, args: &[Expr], lit: &Lit, op: &str, compare_to: u32) {
211 node: LitKind::Int(lit, _),
215 // check if length is compared to the specified number
216 if lit != u128::from(compare_to) {
220 if method_name == "len" && args.len() == 1 && has_is_empty(cx, &args[0]) {
225 &format!("length comparison to {}", if compare_to == 0 { "zero" } else { "one" }),
226 "using `is_empty` is more concise",
227 format!("{}{}.is_empty()", op, snippet(cx, args[0].span, "_")),
233 /// Check if this type has an `is_empty` method.
234 fn has_is_empty(cx: &LateContext, expr: &Expr) -> bool {
235 /// Get an `AssociatedItem` and return true if it matches `is_empty(self)`.
236 fn is_is_empty(cx: &LateContext, item: &ty::AssociatedItem) -> bool {
237 if let ty::AssociatedKind::Method = item.kind {
238 if item.name == "is_empty" {
239 let sig = cx.tcx.fn_sig(item.def_id);
240 let ty = sig.skip_binder();
241 ty.inputs().len() == 1
250 /// Check the inherent impl's items for an `is_empty(self)` method.
251 fn has_is_empty_impl(cx: &LateContext, id: DefId) -> bool {
252 cx.tcx.inherent_impls(id).iter().any(|imp| {
254 .associated_items(*imp)
255 .any(|item| is_is_empty(cx, &item))
259 let ty = &walk_ptrs_ty(cx.tables.expr_ty(expr));
261 ty::TyDynamic(..) => cx.tcx
262 .associated_items(ty.ty_to_def_id().expect("trait impl not found"))
263 .any(|item| is_is_empty(cx, &item)),
264 ty::TyProjection(_) => ty.ty_to_def_id()
265 .map_or(false, |id| has_is_empty_impl(cx, id)),
266 ty::TyAdt(id, _) => has_is_empty_impl(cx, id.did),
267 ty::TyArray(..) | ty::TySlice(..) | ty::TyStr => true,