1 //! checks for `#[inline]` on trait methods without bodies
3 use crate::utils::span_lint_and_then;
4 use crate::utils::sugg::DiagnosticBuilderExt;
5 use rustc_ast::ast::Attribute;
6 use rustc_errors::Applicability;
7 use rustc_hir::{TraitFn, TraitItem, TraitItemKind};
8 use rustc_lint::{LateContext, LateLintPass};
9 use rustc_session::{declare_lint_pass, declare_tool_lint};
10 use rustc_span::Symbol;
12 declare_clippy_lint! {
13 /// **What it does:** Checks for `#[inline]` on trait methods without bodies
15 /// **Why is this bad?** Only implementations of trait methods may be inlined.
16 /// The inline attribute is ignored for trait methods without bodies.
18 /// **Known problems:** None.
24 /// fn name(&self) -> &'static str;
27 pub INLINE_FN_WITHOUT_BODY,
29 "use of `#[inline]` on trait methods without bodies"
32 declare_lint_pass!(InlineFnWithoutBody => [INLINE_FN_WITHOUT_BODY]);
34 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for InlineFnWithoutBody {
35 fn check_trait_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx TraitItem<'_>) {
36 if let TraitItemKind::Fn(_, TraitFn::Required(_)) = item.kind {
37 check_attrs(cx, item.ident.name, &item.attrs);
42 fn check_attrs(cx: &LateContext<'_, '_>, name: Symbol, attrs: &[Attribute]) {
44 if !attr.check_name(sym!(inline)) {
50 INLINE_FN_WITHOUT_BODY,
52 &format!("use of `#[inline]` on trait method `{}` which has no body", name),
54 diag.suggest_remove_item(cx, attr.span, "remove", Applicability::MachineApplicable);