2 attr_by_name, attrs::is_proc_macro, is_must_use_ty, iter_input_pats, match_def_path, must_use_attr, qpath_res,
3 return_ty, snippet, snippet_opt, span_help_and_lint, span_lint, span_lint_and_then, trait_ref_of_method,
4 type_is_unsafe_function,
7 use rustc::hir::intravisit;
8 use rustc::impl_lint_pass;
9 use rustc::lint::{in_external_macro, LateContext, LateLintPass, LintArray, LintContext, LintPass};
10 use rustc::ty::{self, Ty};
11 use rustc_data_structures::fx::FxHashSet;
12 use rustc_errors::Applicability;
14 use rustc_hir::{def::Res, def_id::DefId};
15 use rustc_session::declare_tool_lint;
16 use rustc_span::source_map::Span;
17 use rustc_target::spec::abi::Abi;
18 use syntax::ast::Attribute;
20 declare_clippy_lint! {
21 /// **What it does:** Checks for functions with too many parameters.
23 /// **Why is this bad?** Functions with lots of parameters are considered bad
24 /// style and reduce readability (“what does the 5th parameter mean?”). Consider
25 /// grouping some parameters into a new type.
27 /// **Known problems:** None.
32 /// fn foo(x: u32, y: u32, name: &str, c: Color, w: f32, h: f32, a: f32, b: f32) {
36 pub TOO_MANY_ARGUMENTS,
38 "functions with too many arguments"
41 declare_clippy_lint! {
42 /// **What it does:** Checks for functions with a large amount of lines.
44 /// **Why is this bad?** Functions with a lot of lines are harder to understand
45 /// due to having to look at a larger amount of code to understand what the
46 /// function is doing. Consider splitting the body of the function into
47 /// multiple functions.
49 /// **Known problems:** None.
53 /// fn im_too_long() {
55 /// // ... 100 more LoC
61 "functions with too many lines"
64 declare_clippy_lint! {
65 /// **What it does:** Checks for public functions that dereference raw pointer
66 /// arguments but are not marked unsafe.
68 /// **Why is this bad?** The function should probably be marked `unsafe`, since
69 /// for an arbitrary raw pointer, there is no way of telling for sure if it is
72 /// **Known problems:**
74 /// * It does not check functions recursively so if the pointer is passed to a
75 /// private non-`unsafe` function which does the dereferencing, the lint won't
77 /// * It only checks for arguments whose type are raw pointers, not raw pointers
78 /// got from an argument in some other way (`fn foo(bar: &[*const u8])` or
79 /// `some_argument.get_raw_ptr()`).
83 /// pub fn foo(x: *const u8) {
84 /// println!("{}", unsafe { *x });
87 pub NOT_UNSAFE_PTR_ARG_DEREF,
89 "public functions dereferencing raw pointer arguments but not marked `unsafe`"
92 declare_clippy_lint! {
93 /// **What it does:** Checks for a [`#[must_use]`] attribute on
94 /// unit-returning functions and methods.
96 /// [`#[must_use]`]: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute
98 /// **Why is this bad?** Unit values are useless. The attribute is likely
99 /// a remnant of a refactoring that removed the return type.
101 /// **Known problems:** None.
110 "`#[must_use]` attribute on a unit-returning function / method"
113 declare_clippy_lint! {
114 /// **What it does:** Checks for a [`#[must_use]`] attribute without
115 /// further information on functions and methods that return a type already
116 /// marked as `#[must_use]`.
118 /// [`#[must_use]`]: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute
120 /// **Why is this bad?** The attribute isn't needed. Not using the result
121 /// will already be reported. Alternatively, one can add some text to the
122 /// attribute to improve the lint message.
124 /// **Known problems:** None.
129 /// fn double_must_use() -> Result<(), ()> {
130 /// unimplemented!();
135 "`#[must_use]` attribute on a `#[must_use]`-returning function / method"
138 declare_clippy_lint! {
139 /// **What it does:** Checks for public functions that have no
140 /// [`#[must_use]`] attribute, but return something not already marked
141 /// must-use, have no mutable arg and mutate no statics.
143 /// [`#[must_use]`]: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute
145 /// **Why is this bad?** Not bad at all, this lint just shows places where
146 /// you could add the attribute.
148 /// **Known problems:** The lint only checks the arguments for mutable
149 /// types without looking if they are actually changed. On the other hand,
150 /// it also ignores a broad range of potentially interesting side effects,
151 /// because we cannot decide whether the programmer intends the function to
152 /// be called for the side effect or the result. Expect many false
153 /// positives. At least we don't lint if the result type is unit or already
158 /// // this could be annotated with `#[must_use]`.
159 /// fn id<T>(t: T) -> T { t }
161 pub MUST_USE_CANDIDATE,
163 "function or method that could take a `#[must_use]` attribute"
166 #[derive(Copy, Clone)]
167 pub struct Functions {
173 pub fn new(threshold: u64, max_lines: u64) -> Self {
174 Self { threshold, max_lines }
178 impl_lint_pass!(Functions => [
181 NOT_UNSAFE_PTR_ARG_DEREF,
187 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Functions {
190 cx: &LateContext<'a, 'tcx>,
191 kind: intravisit::FnKind<'tcx>,
192 decl: &'tcx hir::FnDecl<'_>,
193 body: &'tcx hir::Body<'_>,
197 let is_impl = if let Some(hir::Node::Item(item)) = cx.tcx.hir().find(cx.tcx.hir().get_parent_node(hir_id)) {
198 matches!(item.kind, hir::ItemKind::Impl(_, _, _, _, Some(_), _, _))
203 let unsafety = match kind {
204 intravisit::FnKind::ItemFn(_, _, hir::FnHeader { unsafety, .. }, _, _) => unsafety,
205 intravisit::FnKind::Method(_, sig, _, _) => sig.header.unsafety,
206 intravisit::FnKind::Closure(_) => return,
209 // don't warn for implementations, it's not their fault
211 // don't lint extern functions decls, it's not their fault either
213 intravisit::FnKind::Method(
216 header: hir::FnHeader { abi: Abi::Rust, .. },
222 | intravisit::FnKind::ItemFn(_, _, hir::FnHeader { abi: Abi::Rust, .. }, _, _) => {
223 self.check_arg_number(cx, decl, span.with_hi(decl.output.span().hi()))
229 Self::check_raw_ptr(cx, unsafety, decl, body, hir_id);
230 self.check_line_number(cx, span, body);
233 fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx hir::Item<'_>) {
234 let attr = must_use_attr(&item.attrs);
235 if let hir::ItemKind::Fn(ref sig, ref _generics, ref body_id) = item.kind {
236 if let Some(attr) = attr {
237 let fn_header_span = item.span.with_hi(sig.decl.output.span().hi());
238 check_needless_must_use(cx, &sig.decl, item.hir_id, item.span, fn_header_span, attr);
241 if cx.access_levels.is_exported(item.hir_id)
242 && !is_proc_macro(&item.attrs)
243 && attr_by_name(&item.attrs, "no_mangle").is_none()
245 check_must_use_candidate(
248 cx.tcx.hir().body(*body_id),
251 item.span.with_hi(sig.decl.output.span().hi()),
252 "this function could have a `#[must_use]` attribute",
258 fn check_impl_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx hir::ImplItem<'_>) {
259 if let hir::ImplItemKind::Method(ref sig, ref body_id) = item.kind {
260 let attr = must_use_attr(&item.attrs);
261 if let Some(attr) = attr {
262 let fn_header_span = item.span.with_hi(sig.decl.output.span().hi());
263 check_needless_must_use(cx, &sig.decl, item.hir_id, item.span, fn_header_span, attr);
264 } else if cx.access_levels.is_exported(item.hir_id)
265 && !is_proc_macro(&item.attrs)
266 && trait_ref_of_method(cx, item.hir_id).is_none()
268 check_must_use_candidate(
271 cx.tcx.hir().body(*body_id),
274 item.span.with_hi(sig.decl.output.span().hi()),
275 "this method could have a `#[must_use]` attribute",
281 fn check_trait_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx hir::TraitItem<'_>) {
282 if let hir::TraitItemKind::Method(ref sig, ref eid) = item.kind {
283 // don't lint extern functions decls, it's not their fault
284 if sig.header.abi == Abi::Rust {
285 self.check_arg_number(cx, &sig.decl, item.span.with_hi(sig.decl.output.span().hi()));
288 let attr = must_use_attr(&item.attrs);
289 if let Some(attr) = attr {
290 let fn_header_span = item.span.with_hi(sig.decl.output.span().hi());
291 check_needless_must_use(cx, &sig.decl, item.hir_id, item.span, fn_header_span, attr);
293 if let hir::TraitMethod::Provided(eid) = *eid {
294 let body = cx.tcx.hir().body(eid);
295 Self::check_raw_ptr(cx, sig.header.unsafety, &sig.decl, body, item.hir_id);
297 if attr.is_none() && cx.access_levels.is_exported(item.hir_id) && !is_proc_macro(&item.attrs) {
298 check_must_use_candidate(
304 item.span.with_hi(sig.decl.output.span().hi()),
305 "this method could have a `#[must_use]` attribute",
313 impl<'a, 'tcx> Functions {
314 fn check_arg_number(self, cx: &LateContext<'_, '_>, decl: &hir::FnDecl<'_>, fn_span: Span) {
315 let args = decl.inputs.len() as u64;
316 if args > self.threshold {
321 &format!("this function has too many arguments ({}/{})", args, self.threshold),
326 fn check_line_number(self, cx: &LateContext<'_, '_>, span: Span, body: &'tcx hir::Body<'_>) {
327 if in_external_macro(cx.sess(), span) {
331 let code_snippet = snippet(cx, body.value.span, "..");
332 let mut line_count: u64 = 0;
333 let mut in_comment = false;
334 let mut code_in_line;
336 // Skip the surrounding function decl.
337 let start_brace_idx = code_snippet.find('{').map_or(0, |i| i + 1);
338 let end_brace_idx = code_snippet.rfind('}').unwrap_or_else(|| code_snippet.len());
339 let function_lines = code_snippet[start_brace_idx..end_brace_idx].lines();
341 for mut line in function_lines {
342 code_in_line = false;
344 line = line.trim_start();
349 match line.find("*/") {
351 line = &line[i + 2..];
358 let multi_idx = line.find("/*").unwrap_or_else(|| line.len());
359 let single_idx = line.find("//").unwrap_or_else(|| line.len());
360 code_in_line |= multi_idx > 0 && single_idx > 0;
361 // Implies multi_idx is below line.len()
362 if multi_idx < single_idx {
363 line = &line[multi_idx + 2..];
375 if line_count > self.max_lines {
376 span_lint(cx, TOO_MANY_LINES, span, "This function has a large number of lines.")
381 cx: &LateContext<'a, 'tcx>,
382 unsafety: hir::Unsafety,
383 decl: &'tcx hir::FnDecl<'_>,
384 body: &'tcx hir::Body<'_>,
387 let expr = &body.value;
388 if unsafety == hir::Unsafety::Normal && cx.access_levels.is_exported(hir_id) {
389 let raw_ptrs = iter_input_pats(decl, body)
390 .zip(decl.inputs.iter())
391 .filter_map(|(arg, ty)| raw_ptr_arg(arg, ty))
392 .collect::<FxHashSet<_>>();
394 if !raw_ptrs.is_empty() {
395 let tables = cx.tcx.body_tables(body.id());
396 let mut v = DerefVisitor {
402 intravisit::walk_expr(&mut v, expr);
408 fn check_needless_must_use(
409 cx: &LateContext<'_, '_>,
410 decl: &hir::FnDecl<'_>,
413 fn_header_span: Span,
416 if in_external_macro(cx.sess(), item_span) {
419 if returns_unit(decl) {
424 "this unit-returning function has a `#[must_use]` attribute",
428 "remove the attribute",
430 Applicability::MachineApplicable,
434 } else if !attr.is_value_str() && is_must_use_ty(cx, return_ty(cx, item_id)) {
439 "this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]`",
440 "either add some descriptive text or remove the attribute",
445 fn check_must_use_candidate<'a, 'tcx>(
446 cx: &LateContext<'a, 'tcx>,
447 decl: &'tcx hir::FnDecl<'_>,
448 body: &'tcx hir::Body<'_>,
454 if has_mutable_arg(cx, body)
455 || mutates_static(cx, body)
456 || in_external_macro(cx.sess(), item_span)
457 || returns_unit(decl)
458 || !cx.access_levels.is_exported(item_id)
459 || is_must_use_ty(cx, return_ty(cx, item_id))
463 span_lint_and_then(cx, MUST_USE_CANDIDATE, fn_span, msg, |db| {
464 if let Some(snippet) = snippet_opt(cx, fn_span) {
468 format!("#[must_use] {}", snippet),
469 Applicability::MachineApplicable,
475 fn returns_unit(decl: &hir::FnDecl<'_>) -> bool {
477 hir::FunctionRetTy::DefaultReturn(_) => true,
478 hir::FunctionRetTy::Return(ref ty) => match ty.kind {
479 hir::TyKind::Tup(ref tys) => tys.is_empty(),
480 hir::TyKind::Never => true,
486 fn has_mutable_arg(cx: &LateContext<'_, '_>, body: &hir::Body<'_>) -> bool {
487 let mut tys = FxHashSet::default();
488 body.params.iter().any(|param| is_mutable_pat(cx, ¶m.pat, &mut tys))
491 fn is_mutable_pat(cx: &LateContext<'_, '_>, pat: &hir::Pat<'_>, tys: &mut FxHashSet<DefId>) -> bool {
492 if let hir::PatKind::Wild = pat.kind {
493 return false; // ignore `_` patterns
495 let def_id = pat.hir_id.owner_def_id();
496 if cx.tcx.has_typeck_tables(def_id) {
497 is_mutable_ty(cx, &cx.tcx.typeck_tables_of(def_id).pat_ty(pat), pat.span, tys)
503 static KNOWN_WRAPPER_TYS: &[&[&str]] = &[&["alloc", "rc", "Rc"], &["std", "sync", "Arc"]];
505 fn is_mutable_ty<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, ty: Ty<'tcx>, span: Span, tys: &mut FxHashSet<DefId>) -> bool {
508 // primitive types are never mutable
509 Bool | Char | Int(_) | Uint(_) | Float(_) | Str => false,
510 Adt(ref adt, ref substs) => {
511 tys.insert(adt.did) && !ty.is_freeze(cx.tcx, cx.param_env, span)
512 || KNOWN_WRAPPER_TYS.iter().any(|path| match_def_path(cx, adt.did, path))
513 && substs.types().any(|ty| is_mutable_ty(cx, ty, span, tys))
515 Tuple(ref substs) => substs.types().any(|ty| is_mutable_ty(cx, ty, span, tys)),
516 Array(ty, _) | Slice(ty) => is_mutable_ty(cx, ty, span, tys),
517 RawPtr(ty::TypeAndMut { ty, mutbl }) | Ref(_, ty, mutbl) => {
518 mutbl == hir::Mutability::Mut || is_mutable_ty(cx, ty, span, tys)
520 // calling something constitutes a side effect, so return true on all callables
521 // also never calls need not be used, so return true for them, too
526 fn raw_ptr_arg(arg: &hir::Param<'_>, ty: &hir::Ty<'_>) -> Option<hir::HirId> {
527 if let (&hir::PatKind::Binding(_, id, _, _), &hir::TyKind::Ptr(_)) = (&arg.pat.kind, &ty.kind) {
534 struct DerefVisitor<'a, 'tcx> {
535 cx: &'a LateContext<'a, 'tcx>,
536 ptrs: FxHashSet<hir::HirId>,
537 tables: &'a ty::TypeckTables<'tcx>,
540 impl<'a, 'tcx> intravisit::Visitor<'tcx> for DerefVisitor<'a, 'tcx> {
541 fn visit_expr(&mut self, expr: &'tcx hir::Expr<'_>) {
543 hir::ExprKind::Call(ref f, args) => {
544 let ty = self.tables.expr_ty(f);
546 if type_is_unsafe_function(self.cx, ty) {
552 hir::ExprKind::MethodCall(_, _, args) => {
553 let def_id = self.tables.type_dependent_def_id(expr.hir_id).unwrap();
554 let base_type = self.cx.tcx.type_of(def_id);
556 if type_is_unsafe_function(self.cx, base_type) {
562 hir::ExprKind::Unary(hir::UnOp::UnDeref, ref ptr) => self.check_arg(ptr),
566 intravisit::walk_expr(self, expr);
569 fn nested_visit_map<'this>(&'this mut self) -> intravisit::NestedVisitorMap<'this, 'tcx> {
570 intravisit::NestedVisitorMap::None
574 impl<'a, 'tcx> DerefVisitor<'a, 'tcx> {
575 fn check_arg(&self, ptr: &hir::Expr<'_>) {
576 if let hir::ExprKind::Path(ref qpath) = ptr.kind {
577 if let Res::Local(id) = qpath_res(self.cx, qpath, ptr.hir_id) {
578 if self.ptrs.contains(&id) {
581 NOT_UNSAFE_PTR_ARG_DEREF,
583 "this public function dereferences a raw pointer but is not marked `unsafe`",
591 struct StaticMutVisitor<'a, 'tcx> {
592 cx: &'a LateContext<'a, 'tcx>,
593 mutates_static: bool,
596 impl<'a, 'tcx> intravisit::Visitor<'tcx> for StaticMutVisitor<'a, 'tcx> {
597 fn visit_expr(&mut self, expr: &'tcx hir::Expr<'_>) {
598 use hir::ExprKind::*;
600 if self.mutates_static {
604 Call(_, args) | MethodCall(_, _, args) => {
605 let mut tys = FxHashSet::default();
607 let def_id = arg.hir_id.owner_def_id();
608 if self.cx.tcx.has_typeck_tables(def_id)
611 self.cx.tcx.typeck_tables_of(def_id).expr_ty(arg),
615 && is_mutated_static(self.cx, arg)
617 self.mutates_static = true;
623 Assign(ref target, ..) | AssignOp(_, ref target, _) | AddrOf(_, hir::Mutability::Mut, ref target) => {
624 self.mutates_static |= is_mutated_static(self.cx, target)
630 fn nested_visit_map<'this>(&'this mut self) -> intravisit::NestedVisitorMap<'this, 'tcx> {
631 intravisit::NestedVisitorMap::None
635 fn is_mutated_static(cx: &LateContext<'_, '_>, e: &hir::Expr<'_>) -> bool {
636 use hir::ExprKind::*;
640 if let Res::Local(_) = qpath_res(cx, qpath, e.hir_id) {
646 Field(ref inner, _) | Index(ref inner, _) => is_mutated_static(cx, inner),
651 fn mutates_static<'a, 'tcx>(cx: &'a LateContext<'a, 'tcx>, body: &'tcx hir::Body<'_>) -> bool {
652 let mut v = StaticMutVisitor {
654 mutates_static: false,
656 intravisit::walk_expr(&mut v, &body.value);