1 use clippy_utils::diagnostics::span_lint_and_then;
2 use clippy_utils::macros::{is_panic, root_macro_call_first_node};
3 use clippy_utils::method_chain_args;
4 use clippy_utils::ty::is_type_diagnostic_item;
5 use if_chain::if_chain;
7 use rustc_lint::{LateContext, LateLintPass};
9 use rustc_session::{declare_lint_pass, declare_tool_lint};
10 use rustc_span::{sym, Span};
12 declare_clippy_lint! {
14 /// Checks for impls of `From<..>` that contain `panic!()` or `unwrap()`
16 /// ### Why is this bad?
17 /// `TryFrom` should be used if there's a possibility of failure.
24 /// impl From<String> for Foo {
25 /// fn from(s: String) -> Self {
26 /// Foo(s.parse().unwrap())
35 /// use std::convert::TryFrom;
36 /// impl TryFrom<String> for Foo {
38 /// fn try_from(s: String) -> Result<Self, Self::Error> {
39 /// if let Ok(parsed) = s.parse() {
47 #[clippy::version = "pre 1.29.0"]
48 pub FALLIBLE_IMPL_FROM,
50 "Warn on impls of `From<..>` that contain `panic!()` or `unwrap()`"
53 declare_lint_pass!(FallibleImplFrom => [FALLIBLE_IMPL_FROM]);
55 impl<'tcx> LateLintPass<'tcx> for FallibleImplFrom {
56 fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx hir::Item<'_>) {
57 // check for `impl From<???> for ..`
59 if let hir::ItemKind::Impl(impl_) = &item.kind;
60 if let Some(impl_trait_ref) = cx.tcx.impl_trait_ref(item.def_id);
61 if cx.tcx.is_diagnostic_item(sym::From, impl_trait_ref.def_id);
63 lint_impl_body(cx, item.span, impl_.items);
69 fn lint_impl_body<'tcx>(cx: &LateContext<'tcx>, impl_span: Span, impl_items: &[hir::ImplItemRef]) {
70 use rustc_hir::intravisit::{self, Visitor};
71 use rustc_hir::{Expr, ImplItemKind};
73 struct FindPanicUnwrap<'a, 'tcx> {
74 lcx: &'a LateContext<'tcx>,
75 typeck_results: &'tcx ty::TypeckResults<'tcx>,
79 impl<'a, 'tcx> Visitor<'tcx> for FindPanicUnwrap<'a, 'tcx> {
80 fn visit_expr(&mut self, expr: &'tcx Expr<'_>) {
81 if let Some(macro_call) = root_macro_call_first_node(self.lcx, expr) {
82 if is_panic(self.lcx, macro_call.def_id) {
83 self.result.push(expr.span);
88 if let Some(arglists) = method_chain_args(expr, &["unwrap"]) {
89 let reciever_ty = self.typeck_results.expr_ty(&arglists[0][0]).peel_refs();
90 if is_type_diagnostic_item(self.lcx, reciever_ty, sym::Option)
91 || is_type_diagnostic_item(self.lcx, reciever_ty, sym::Result)
93 self.result.push(expr.span);
97 // and check sub-expressions
98 intravisit::walk_expr(self, expr);
102 for impl_item in impl_items {
104 if impl_item.ident.name == sym::from;
105 if let ImplItemKind::Fn(_, body_id) =
106 cx.tcx.hir().impl_item(impl_item.id).kind;
108 // check the body for `begin_panic` or `unwrap`
109 let body = cx.tcx.hir().body(body_id);
110 let mut fpu = FindPanicUnwrap {
112 typeck_results: cx.tcx.typeck(impl_item.id.def_id),
115 fpu.visit_expr(&body.value);
117 // if we've found one, lint
118 if !fpu.result.is_empty() {
123 "consider implementing `TryFrom` instead",
126 "`From` is intended for infallible conversions only. \
127 Use `TryFrom` if there's a possibility for the conversion to fail");
128 diag.span_note(fpu.result, "potential failure(s)");