clippy_lints/src/explicit_write.rs

   1 // Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
   2 // file at the top-level directory of this distribution.
   3 //
   4 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
   5 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
   6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
   7 // option. This file may not be copied, modified, or distributed
   8 // except according to those terms.
   9
  10 use crate::rustc::hir::*;
  11 use crate::rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
  12 use crate::rustc::{declare_tool_lint, lint_array};
  13 use crate::utils::opt_def_id;
  14 use crate::utils::{is_expn_of, match_def_path, resolve_node, span_lint};
  15 use if_chain::if_chain;
  16
  17 /// **What it does:** Checks for usage of `write!()` / `writeln()!` which can be
  18 /// replaced with `(e)print!()` / `(e)println!()`
  19 ///
  20 /// **Why is this bad?** Using `(e)println! is clearer and more concise
  21 ///
  22 /// **Known problems:** None.
  23 ///
  24 /// **Example:**
  25 /// ```rust
  26 /// // this would be clearer as `eprintln!("foo: {:?}", bar);`
  27 /// writeln!(&mut io::stderr(), "foo: {:?}", bar).unwrap();
  28 /// ```
  29 declare_clippy_lint! {
  30     pub EXPLICIT_WRITE,
  31     complexity,
  32     "using the `write!()` family of functions instead of the `print!()` family of functions, when using the latter would work"
  33 }
  34
  35 #[derive(Copy, Clone, Debug)]
  36 pub struct Pass;
  37
  38 impl LintPass for Pass {
  39     fn get_lints(&self) -> LintArray {
  40         lint_array!(EXPLICIT_WRITE)
  41     }
  42 }
  43
  44 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
  45     fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
  46         if_chain! {
  47             // match call to unwrap
  48             if let ExprKind::MethodCall(ref unwrap_fun, _, ref unwrap_args) = expr.node;
  49             if unwrap_fun.ident.name == "unwrap";
  50             // match call to write_fmt
  51             if unwrap_args.len() > 0;
  52             if let ExprKind::MethodCall(ref write_fun, _, ref write_args) =
  53                 unwrap_args[0].node;
  54             if write_fun.ident.name == "write_fmt";
  55             // match calls to std::io::stdout() / std::io::stderr ()
  56             if write_args.len() > 0;
  57             if let ExprKind::Call(ref dest_fun, _) = write_args[0].node;
  58             if let ExprKind::Path(ref qpath) = dest_fun.node;
  59             if let Some(dest_fun_id) =
  60                 opt_def_id(resolve_node(cx, qpath, dest_fun.hir_id));
  61             if let Some(dest_name) = if match_def_path(cx.tcx, dest_fun_id, &["std", "io", "stdio", "stdout"]) {
  62                 Some("stdout")
  63             } else if match_def_path(cx.tcx, dest_fun_id, &["std", "io", "stdio", "stderr"]) {
  64                 Some("stderr")
  65             } else {
  66                 None
  67             };
  68             then {
  69                 let write_span = unwrap_args[0].span;
  70                 let calling_macro =
  71                     // ordering is important here, since `writeln!` uses `write!` internally
  72                     if is_expn_of(write_span, "writeln").is_some() {
  73                         Some("writeln")
  74                     } else if is_expn_of(write_span, "write").is_some() {
  75                         Some("write")
  76                     } else {
  77                         None
  78                     };
  79                 let prefix = if dest_name == "stderr" {
  80                     "e"
  81                 } else {
  82                     ""
  83                 };
  84                 if let Some(macro_name) = calling_macro {
  85                     span_lint(
  86                         cx,
  87                         EXPLICIT_WRITE,
  88                         expr.span,
  89                         &format!(
  90                             "use of `{}!({}(), ...).unwrap()`. Consider using `{}{}!` instead",
  91                             macro_name,
  92                             dest_name,
  93                             prefix,
  94                             macro_name.replace("write", "print")
  95                         )
  96                     );
  97                 } else {
  98                     span_lint(
  99                         cx,
 100                         EXPLICIT_WRITE,
 101                         expr.span,
 102                         &format!(
 103                             "use of `{}().write_fmt(...).unwrap()`. Consider using `{}print!` instead",
 104                             dest_name,
 105                             prefix,
 106                         )
 107                     );
 108                 }
 109             }
 110         }
 111     }
 112 }