clippy_lints/src/duration_subsec.rs

   1 use if_chain::if_chain;
   2 use rustc::hir::*;
   3 use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
   4 use rustc::{declare_lint_pass, declare_tool_lint};
   5 use rustc_errors::Applicability;
   6 use syntax::source_map::Spanned;
   7
   8 use crate::consts::{constant, Constant};
   9 use crate::utils::paths;
  10 use crate::utils::{match_type, snippet_with_applicability, span_lint_and_sugg, walk_ptrs_ty};
  11
  12 declare_clippy_lint! {
  13     /// **What it does:** Checks for calculation of subsecond microseconds or milliseconds
  14     /// from other `Duration` methods.
  15     ///
  16     /// **Why is this bad?** It's more concise to call `Duration::subsec_micros()` or
  17     /// `Duration::subsec_millis()` than to calculate them.
  18     ///
  19     /// **Known problems:** None.
  20     ///
  21     /// **Example:**
  22     /// ```rust
  23     /// let dur = Duration::new(5, 0);
  24     /// let _micros = dur.subsec_nanos() / 1_000;
  25     /// let _millis = dur.subsec_nanos() / 1_000_000;
  26     /// ```
  27     pub DURATION_SUBSEC,
  28     complexity,
  29     "checks for calculation of subsecond microseconds or milliseconds"
  30 }
  31
  32 declare_lint_pass!(DurationSubsec => [DURATION_SUBSEC]);
  33
  34 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for DurationSubsec {
  35     fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
  36         if_chain! {
  37             if let ExprKind::Binary(Spanned { node: BinOpKind::Div, .. }, ref left, ref right) = expr.node;
  38             if let ExprKind::MethodCall(ref method_path, _ , ref args) = left.node;
  39             if match_type(cx, walk_ptrs_ty(cx.tables.expr_ty(&args[0])), &paths::DURATION);
  40             if let Some((Constant::Int(divisor), _)) = constant(cx, cx.tables, right);
  41             then {
  42                 let suggested_fn = match (method_path.ident.as_str().as_ref(), divisor) {
  43                     ("subsec_micros", 1_000) | ("subsec_nanos", 1_000_000) => "subsec_millis",
  44                     ("subsec_nanos", 1_000) => "subsec_micros",
  45                     _ => return,
  46                 };
  47                 let mut applicability = Applicability::MachineApplicable;
  48                 span_lint_and_sugg(
  49                     cx,
  50                     DURATION_SUBSEC,
  51                     expr.span,
  52                     &format!("Calling `{}()` is more concise than this calculation", suggested_fn),
  53                     "try",
  54                     format!(
  55                         "{}.{}()",
  56                         snippet_with_applicability(cx, args[0].span, "_", &mut applicability),
  57                         suggested_fn
  58                     ),
  59                     applicability,
  60                 );
  61             }
  62         }
  63     }
  64 }