1 use crate::utils::paths;
2 use crate::utils::{is_automatically_derived, is_copy, match_path, span_lint_and_then};
3 use if_chain::if_chain;
5 use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
6 use rustc::ty::{self, Ty};
7 use rustc::{declare_lint_pass, declare_tool_lint};
8 use syntax::source_map::Span;
10 declare_clippy_lint! {
11 /// **What it does:** Checks for deriving `Hash` but implementing `PartialEq`
12 /// explicitly or vice versa.
14 /// **Why is this bad?** The implementation of these traits must agree (for
15 /// example for use with `HashMap`) so it’s probably a bad idea to use a
16 /// default-generated `Hash` implementation with an explicitly defined
17 /// `PartialEq`. In particular, the following must hold for any type:
20 /// k1 == k2 ⇒ hash(k1) == hash(k2)
23 /// **Known problems:** None.
30 /// impl PartialEq for Foo {
34 pub DERIVE_HASH_XOR_EQ,
36 "deriving `Hash` but implementing `PartialEq` explicitly"
39 declare_clippy_lint! {
40 /// **What it does:** Checks for explicit `Clone` implementations for `Copy`
43 /// **Why is this bad?** To avoid surprising behaviour, these traits should
44 /// agree and the behaviour of `Copy` cannot be overridden. In almost all
45 /// situations a `Copy` type should have a `Clone` implementation that does
46 /// nothing more than copy the object, which is what `#[derive(Copy, Clone)]`
49 /// **Known problems:** Bounds of generic types are sometimes wrong: https://github.com/rust-lang/rust/issues/26925
56 /// impl Clone for Foo {
60 pub EXPL_IMPL_CLONE_ON_COPY,
62 "implementing `Clone` explicitly on `Copy` types"
65 declare_lint_pass!(Derive => [EXPL_IMPL_CLONE_ON_COPY, DERIVE_HASH_XOR_EQ]);
67 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Derive {
68 fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item) {
69 if let ItemKind::Impl(_, _, _, _, Some(ref trait_ref), _, _) = item.kind {
70 let ty = cx.tcx.type_of(cx.tcx.hir().local_def_id(item.hir_id));
71 let is_automatically_derived = is_automatically_derived(&*item.attrs);
73 check_hash_peq(cx, item.span, trait_ref, ty, is_automatically_derived);
75 if !is_automatically_derived {
76 check_copy_clone(cx, item, trait_ref, ty);
82 /// Implementation of the `DERIVE_HASH_XOR_EQ` lint.
83 fn check_hash_peq<'a, 'tcx>(
84 cx: &LateContext<'a, 'tcx>,
88 hash_is_automatically_derived: bool,
91 if match_path(&trait_ref.path, &paths::HASH);
92 if let Some(peq_trait_def_id) = cx.tcx.lang_items().eq_trait();
93 if !&trait_ref.trait_def_id().is_local();
95 // Look for the PartialEq implementations for `ty`
96 cx.tcx.for_each_relevant_impl(peq_trait_def_id, ty, |impl_id| {
97 let peq_is_automatically_derived = is_automatically_derived(&cx.tcx.get_attrs(impl_id));
99 if peq_is_automatically_derived == hash_is_automatically_derived {
103 let trait_ref = cx.tcx.impl_trait_ref(impl_id).expect("must be a trait implementation");
105 // Only care about `impl PartialEq<Foo> for Foo`
106 // For `impl PartialEq<B> for A, input_types is [A, B]
107 if trait_ref.substs.type_at(1) == ty {
108 let mess = if peq_is_automatically_derived {
109 "you are implementing `Hash` explicitly but have derived `PartialEq`"
111 "you are deriving `Hash` but have implemented `PartialEq` explicitly"
115 cx, DERIVE_HASH_XOR_EQ, span,
118 if let Some(node_id) = cx.tcx.hir().as_local_hir_id(impl_id) {
120 cx.tcx.hir().span(node_id),
121 "`PartialEq` implemented here"
131 /// Implementation of the `EXPL_IMPL_CLONE_ON_COPY` lint.
132 fn check_copy_clone<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, item: &Item, trait_ref: &TraitRef, ty: Ty<'tcx>) {
133 if match_path(&trait_ref.path, &paths::CLONE_TRAIT) {
134 if !is_copy(cx, ty) {
139 ty::Adt(def, _) if def.is_union() => return,
141 // Some types are not Clone by default but could be cloned “by hand” if necessary
142 ty::Adt(def, substs) => {
143 for variant in &def.variants {
144 for field in &variant.fields {
145 if let ty::FnDef(..) = field.ty(cx.tcx, substs).kind {
149 for subst in substs {
150 if let ty::subst::GenericArgKind::Type(subst) = subst.unpack() {
151 if let ty::Param(_) = subst.kind {
163 EXPL_IMPL_CLONE_ON_COPY,
165 "you are implementing `Clone` explicitly on a `Copy` type",
167 db.span_note(item.span, "consider deriving `Clone` or removing `Copy`");