1 use crate::utils::{get_parent_expr, in_macro, snippet, span_lint_and_then, span_note_and_lint};
2 use crate::utils::{SpanlessEq, SpanlessHash};
4 use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
6 use rustc::{declare_tool_lint, lint_array};
7 use rustc_data_structures::fx::FxHashMap;
8 use smallvec::SmallVec;
9 use std::collections::hash_map::Entry;
10 use std::hash::BuildHasherDefault;
11 use syntax::symbol::LocalInternedString;
13 /// **What it does:** Checks for consecutive `if`s with the same condition.
15 /// **Why is this bad?** This is probably a copy & paste error.
17 /// **Known problems:** Hopefully none.
23 /// } else if a == b {
28 /// Note that this lint ignores all conditions with a function call as it could
29 /// have side effects:
34 /// } else if foo() { // not linted
38 declare_clippy_lint! {
41 "consecutive `ifs` with the same condition"
44 /// **What it does:** Checks for `if/else` with the same body as the *then* part
45 /// and the *else* part.
47 /// **Why is this bad?** This is probably a copy & paste error.
49 /// **Known problems:** Hopefully none.
59 declare_clippy_lint! {
60 pub IF_SAME_THEN_ELSE,
62 "if with the same *then* and *else* blocks"
65 /// **What it does:** Checks for `match` with identical arm bodies.
67 /// **Why is this bad?** This is probably a copy & paste error. If arm bodies
68 /// are the same on purpose, you can factor them
69 /// [using `|`](https://doc.rust-lang.org/book/patterns.html#multiple-patterns).
71 /// **Known problems:** False positive possible with order dependent `match`
73 /// [#860](https://github.com/rust-lang/rust-clippy/issues/860)).
80 /// Baz => bar(), // <= oops
84 /// This should probably be
89 /// Baz => baz(), // <= fixed
93 /// or if the original code was not a typo:
96 /// Bar | Baz => bar(), // <= shows the intent better
100 declare_clippy_lint! {
103 "`match` with identical arm bodies"
106 #[derive(Copy, Clone, Debug)]
107 pub struct CopyAndPaste;
109 impl LintPass for CopyAndPaste {
110 fn get_lints(&self) -> LintArray {
111 lint_array![IFS_SAME_COND, IF_SAME_THEN_ELSE, MATCH_SAME_ARMS]
114 fn name(&self) -> &'static str {
119 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for CopyAndPaste {
120 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
121 if !in_macro(expr.span) {
122 // skip ifs directly in else, it will be checked in the parent if
124 node: ExprKind::If(_, _, Some(ref else_expr)),
126 }) = get_parent_expr(cx, expr)
128 if else_expr.id == expr.id {
133 let (conds, blocks) = if_sequence(expr);
134 lint_same_then_else(cx, &blocks);
135 lint_same_cond(cx, &conds);
136 lint_match_arms(cx, expr);
141 /// Implementation of `IF_SAME_THEN_ELSE`.
142 fn lint_same_then_else(cx: &LateContext<'_, '_>, blocks: &[&Block]) {
143 let eq: &dyn Fn(&&Block, &&Block) -> bool = &|&lhs, &rhs| -> bool { SpanlessEq::new(cx).eq_block(lhs, rhs) };
145 if let Some((i, j)) = search_same_sequenced(blocks, eq) {
150 "this `if` has identical blocks",
157 /// Implementation of `IFS_SAME_COND`.
158 fn lint_same_cond(cx: &LateContext<'_, '_>, conds: &[&Expr]) {
159 let hash: &dyn Fn(&&Expr) -> u64 = &|expr| -> u64 {
160 let mut h = SpanlessHash::new(cx, cx.tables);
165 let eq: &dyn Fn(&&Expr, &&Expr) -> bool =
166 &|&lhs, &rhs| -> bool { SpanlessEq::new(cx).ignore_fn().eq_expr(lhs, rhs) };
168 if let Some((i, j)) = search_same(conds, hash, eq) {
173 "this `if` has the same condition as a previous if",
180 /// Implementation of `MATCH_SAME_ARMS`.
181 fn lint_match_arms(cx: &LateContext<'_, '_>, expr: &Expr) {
182 if let ExprKind::Match(_, ref arms, MatchSource::Normal) = expr.node {
183 let hash = |&(_, arm): &(usize, &Arm)| -> u64 {
184 let mut h = SpanlessHash::new(cx, cx.tables);
185 h.hash_expr(&arm.body);
189 let eq = |&(lindex, lhs): &(usize, &Arm), &(rindex, rhs): &(usize, &Arm)| -> bool {
190 let min_index = usize::min(lindex, rindex);
191 let max_index = usize::max(lindex, rindex);
192 // Arms with a guard are ignored, those can’t always be merged together
193 // This is also the case for arms in-between each there is an arm with a guard
194 (min_index..=max_index).all(|index| arms[index].guard.is_none()) &&
195 SpanlessEq::new(cx).eq_expr(&lhs.body, &rhs.body) &&
196 // all patterns should have the same bindings
197 bindings(cx, &lhs.pats[0]) == bindings(cx, &rhs.pats[0])
200 let indexed_arms: Vec<(usize, &Arm)> = arms.iter().enumerate().collect();
201 if let Some((&(_, i), &(_, j))) = search_same(&indexed_arms, hash, eq) {
206 "this `match` has identical arm bodies",
208 db.span_note(i.body.span, "same as this");
210 // Note: this does not use `span_suggestion_with_applicability` on purpose:
211 // there is no clean way
212 // to remove the other arm. Building a span and suggest to replace it to ""
213 // makes an even more confusing error message. Also in order not to make up a
214 // span for the whole pattern, the suggestion is only shown when there is only
215 // one pattern. The user should know about `|` if they are already using it…
217 if i.pats.len() == 1 && j.pats.len() == 1 {
218 let lhs = snippet(cx, i.pats[0].span, "<pat1>");
219 let rhs = snippet(cx, j.pats[0].span, "<pat2>");
221 if let PatKind::Wild = j.pats[0].node {
222 // if the last arm is _, then i could be integrated into _
223 // note that i.pats[0] cannot be _, because that would mean that we're
224 // hiding all the subsequent arms, and rust won't compile
228 "`{}` has the same arm body as the `_` wildcard, consider removing it`",
233 db.span_note(i.body.span, &format!("consider refactoring into `{} | {}`", lhs, rhs));
242 /// Return the list of condition expressions and the list of blocks in a
243 /// sequence of `if/else`.
244 /// Eg. would return `([a, b], [c, d, e])` for the expression
245 /// `if a { c } else if b { d } else { e }`.
246 fn if_sequence(mut expr: &Expr) -> (SmallVec<[&Expr; 1]>, SmallVec<[&Block; 1]>) {
247 let mut conds = SmallVec::new();
248 let mut blocks: SmallVec<[&Block; 1]> = SmallVec::new();
250 while let ExprKind::If(ref cond, ref then_expr, ref else_expr) = expr.node {
252 if let ExprKind::Block(ref block, _) = then_expr.node {
255 panic!("ExprKind::If node is not an ExprKind::Block");
258 if let Some(ref else_expr) = *else_expr {
266 if !blocks.is_empty() {
267 if let ExprKind::Block(ref block, _) = expr.node {
268 blocks.push(&**block);
275 /// Return the list of bindings in a pattern.
276 fn bindings<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, pat: &Pat) -> FxHashMap<LocalInternedString, Ty<'tcx>> {
277 fn bindings_impl<'a, 'tcx>(
278 cx: &LateContext<'a, 'tcx>,
280 map: &mut FxHashMap<LocalInternedString, Ty<'tcx>>,
283 PatKind::Box(ref pat) | PatKind::Ref(ref pat, _) => bindings_impl(cx, pat, map),
284 PatKind::TupleStruct(_, ref pats, _) => {
286 bindings_impl(cx, pat, map);
289 PatKind::Binding(_, _, ident, ref as_pat) => {
290 if let Entry::Vacant(v) = map.entry(ident.as_str()) {
291 v.insert(cx.tables.pat_ty(pat));
293 if let Some(ref as_pat) = *as_pat {
294 bindings_impl(cx, as_pat, map);
297 PatKind::Struct(_, ref fields, _) => {
299 bindings_impl(cx, &pat.node.pat, map);
302 PatKind::Tuple(ref fields, _) => {
304 bindings_impl(cx, pat, map);
307 PatKind::Slice(ref lhs, ref mid, ref rhs) => {
309 bindings_impl(cx, pat, map);
311 if let Some(ref mid) = *mid {
312 bindings_impl(cx, mid, map);
315 bindings_impl(cx, pat, map);
318 PatKind::Lit(..) | PatKind::Range(..) | PatKind::Wild | PatKind::Path(..) => (),
322 let mut result = FxHashMap::default();
323 bindings_impl(cx, pat, &mut result);
327 fn search_same_sequenced<T, Eq>(exprs: &[T], eq: Eq) -> Option<(&T, &T)>
329 Eq: Fn(&T, &T) -> bool,
331 for win in exprs.windows(2) {
332 if eq(&win[0], &win[1]) {
333 return Some((&win[0], &win[1]));
339 fn search_same<T, Hash, Eq>(exprs: &[T], hash: Hash, eq: Eq) -> Option<(&T, &T)>
342 Eq: Fn(&T, &T) -> bool,
347 } else if exprs.len() == 2 {
348 return if eq(&exprs[0], &exprs[1]) {
349 Some((&exprs[0], &exprs[1]))
355 let mut map: FxHashMap<_, Vec<&_>> =
356 FxHashMap::with_capacity_and_hasher(exprs.len(), BuildHasherDefault::default());
359 match map.entry(hash(expr)) {
360 Entry::Occupied(mut o) => {
363 return Some((o, expr));
366 o.get_mut().push(expr);
368 Entry::Vacant(v) => {
369 v.insert(vec![expr]);