1 use clippy_utils::diagnostics::{span_lint_and_note, span_lint_and_then};
2 use clippy_utils::source::{first_line_of_span, indent_of, reindent_multiline, snippet, snippet_opt};
4 both, count_eq, eq_expr_value, get_enclosing_block, get_parent_expr, if_sequence, in_macro, parent_node_is_if_expr,
5 run_lints, search_same, ContainsName, SpanlessEq, SpanlessHash,
7 use if_chain::if_chain;
8 use rustc_data_structures::fx::FxHashSet;
9 use rustc_errors::{Applicability, DiagnosticBuilder};
10 use rustc_hir::intravisit::{self, NestedVisitorMap, Visitor};
11 use rustc_hir::{Block, Expr, ExprKind, HirId};
12 use rustc_lint::{LateContext, LateLintPass};
13 use rustc_middle::hir::map::Map;
14 use rustc_session::{declare_lint_pass, declare_tool_lint};
15 use rustc_span::{source_map::Span, symbol::Symbol, BytePos};
18 declare_clippy_lint! {
19 /// **What it does:** Checks for consecutive `if`s with the same condition.
21 /// **Why is this bad?** This is probably a copy & paste error.
23 /// **Known problems:** Hopefully none.
29 /// } else if a == b {
34 /// Note that this lint ignores all conditions with a function call as it could
35 /// have side effects:
40 /// } else if foo() { // not linted
46 "consecutive `if`s with the same condition"
49 declare_clippy_lint! {
50 /// **What it does:** Checks for consecutive `if`s with the same function call.
52 /// **Why is this bad?** This is probably a copy & paste error.
53 /// Despite the fact that function can have side effects and `if` works as
54 /// intended, such an approach is implicit and can be considered a "code smell".
56 /// **Known problems:** Hopefully none.
62 /// } else if foo() == bar {
67 /// This probably should be:
71 /// } else if foo() == baz {
76 /// or if the original code was not a typo and called function mutates a state,
77 /// consider move the mutation out of the `if` condition to avoid similarity to
78 /// a copy & paste error:
81 /// let first = foo();
85 /// let second = foo();
86 /// if second == bar {
91 pub SAME_FUNCTIONS_IN_IF_CONDITION,
93 "consecutive `if`s with the same function call"
96 declare_clippy_lint! {
97 /// **What it does:** Checks for `if/else` with the same body as the *then* part
98 /// and the *else* part.
100 /// **Why is this bad?** This is probably a copy & paste error.
102 /// **Known problems:** Hopefully none.
112 pub IF_SAME_THEN_ELSE,
114 "`if` with the same `then` and `else` blocks"
117 declare_clippy_lint! {
118 /// **What it does:** Checks if the `if` and `else` block contain shared code that can be
119 /// moved out of the blocks.
121 /// **Why is this bad?** Duplicate code is less maintainable.
123 /// **Known problems:** Hopefully none.
128 /// println!("Hello World");
131 /// println!("Hello World");
136 /// Could be written as:
138 /// println!("Hello World");
145 pub BRANCHES_SHARING_CODE,
147 "`if` statement with shared code in all blocks"
150 declare_lint_pass!(CopyAndPaste => [
152 SAME_FUNCTIONS_IN_IF_CONDITION,
154 BRANCHES_SHARING_CODE
157 impl<'tcx> LateLintPass<'tcx> for CopyAndPaste {
158 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
159 if !expr.span.from_expansion() {
160 if let ExprKind::If(_, _, _) = expr.kind {
161 // skip ifs directly in else, it will be checked in the parent if
163 kind: ExprKind::If(_, _, Some(ref else_expr)),
165 }) = get_parent_expr(cx, expr)
167 if else_expr.hir_id == expr.hir_id {
172 let (conds, blocks) = if_sequence(expr);
174 lint_same_cond(cx, &conds);
175 lint_same_fns_in_if_cond(cx, &conds);
177 lint_same_then_else(cx, &blocks, conds.len() == blocks.len(), expr);
183 /// Implementation of `BRANCHES_SHARING_CODE` and `IF_SAME_THEN_ELSE` if the blocks are equal.
184 fn lint_same_then_else<'tcx>(
185 cx: &LateContext<'tcx>,
186 blocks: &[&Block<'tcx>],
187 has_conditional_else: bool,
188 expr: &'tcx Expr<'_>,
190 // We only lint ifs with multiple blocks
191 if blocks.len() < 2 || parent_node_is_if_expr(expr, cx) {
195 // Check if each block has shared code
196 let has_expr = blocks[0].expr.is_some();
197 let (start_eq, mut end_eq, expr_eq) = scan_block_for_eq(cx, blocks);
199 // BRANCHES_SHARING_CODE prerequisites
200 if has_conditional_else || (start_eq == 0 && end_eq == 0 && (has_expr && !expr_eq)) {
204 // Only the start is the same
205 if start_eq != 0 && end_eq == 0 && (!has_expr || !expr_eq) {
206 let block = blocks[0];
207 let start_stmts = block.stmts.split_at(start_eq).0;
209 let mut start_walker = UsedValueFinderVisitor::new(cx);
210 for stmt in start_stmts {
211 intravisit::walk_stmt(&mut start_walker, stmt);
214 emit_branches_sharing_code_lint(
219 check_for_warn_of_moved_symbol(cx, &start_walker.def_symbols, expr),
223 } else if end_eq != 0 || (has_expr && expr_eq) {
224 let block = blocks[blocks.len() - 1];
225 let (start_stmts, block_stmts) = block.stmts.split_at(start_eq);
226 let (block_stmts, end_stmts) = block_stmts.split_at(block_stmts.len() - end_eq);
229 let mut start_walker = UsedValueFinderVisitor::new(cx);
230 for stmt in start_stmts {
231 intravisit::walk_stmt(&mut start_walker, stmt);
233 let mut moved_syms = start_walker.def_symbols;
236 let mut block_walker = UsedValueFinderVisitor::new(cx);
237 for stmt in block_stmts {
238 intravisit::walk_stmt(&mut block_walker, stmt);
240 let mut block_defs = block_walker.defs;
243 let mut moved_start: Option<usize> = None;
244 let mut end_walker = UsedValueFinderVisitor::new(cx);
245 for (index, stmt) in end_stmts.iter().enumerate() {
246 intravisit::walk_stmt(&mut end_walker, stmt);
248 for value in &end_walker.uses {
249 // Well we can't move this and all prev statements. So reset
250 if block_defs.contains(&value) {
251 moved_start = Some(index + 1);
252 end_walker.defs.drain().for_each(|x| {
253 block_defs.insert(x);
256 end_walker.def_symbols.clear();
260 end_walker.uses.clear();
263 if let Some(moved_start) = moved_start {
264 end_eq -= moved_start;
267 let end_linable = block.expr.map_or_else(
270 intravisit::walk_expr(&mut end_walker, expr);
271 end_walker.uses.iter().any(|x| !block_defs.contains(x))
276 end_walker.def_symbols.drain().for_each(|x| {
277 moved_syms.insert(x);
281 emit_branches_sharing_code_lint(
286 check_for_warn_of_moved_symbol(cx, &moved_syms, expr),
293 fn scan_block_for_eq(cx: &LateContext<'tcx>, blocks: &[&Block<'tcx>]) -> (usize, usize, bool) {
294 let mut start_eq = usize::MAX;
295 let mut end_eq = usize::MAX;
296 let mut expr_eq = true;
297 for win in blocks.windows(2) {
298 let l_stmts = win[0].stmts;
299 let r_stmts = win[1].stmts;
301 // `SpanlessEq` now keeps track of the locals and is therefore context sensitive clippy#6752.
302 // The comparison therefore needs to be done in a way that builds the correct context.
303 let mut evaluator = SpanlessEq::new(cx);
304 let mut evaluator = evaluator.inter_expr();
306 let current_start_eq = count_eq(&mut l_stmts.iter(), &mut r_stmts.iter(), |l, r| evaluator.eq_stmt(l, r));
308 let current_end_eq = {
309 // We skip the middle statements which can't be equal
310 let end_comparison_count = l_stmts.len().min(r_stmts.len()) - current_start_eq;
311 let it1 = l_stmts.iter().skip(l_stmts.len() - end_comparison_count);
312 let it2 = r_stmts.iter().skip(r_stmts.len() - end_comparison_count);
314 .fold(0, |acc, (l, r)| if evaluator.eq_stmt(l, r) { acc + 1 } else { 0 })
316 let block_expr_eq = both(&win[0].expr, &win[1].expr, |l, r| evaluator.eq_expr(l, r));
321 if l_stmts.len() == r_stmts.len();
322 if l_stmts.len() == current_start_eq;
323 if run_lints(cx, &[IF_SAME_THEN_ELSE], win[0].hir_id);
324 if run_lints(cx, &[IF_SAME_THEN_ELSE], win[1].hir_id);
330 "this `if` has identical blocks",
335 return (0, 0, false);
339 start_eq = start_eq.min(current_start_eq);
340 end_eq = end_eq.min(current_end_eq);
341 expr_eq &= block_expr_eq;
344 let has_expr = blocks[0].expr.is_some();
345 if has_expr && !expr_eq {
349 // Check if the regions are overlapping. Set `end_eq` to prevent the overlap
350 let min_block_size = blocks.iter().map(|x| x.stmts.len()).min().unwrap();
351 if (start_eq + end_eq) > min_block_size {
352 end_eq = min_block_size - start_eq;
355 (start_eq, end_eq, expr_eq)
358 fn check_for_warn_of_moved_symbol(
359 cx: &LateContext<'tcx>,
360 symbols: &FxHashSet<Symbol>,
361 if_expr: &'tcx Expr<'_>,
363 get_enclosing_block(cx, if_expr.hir_id).map_or(false, |block| {
364 let ignore_span = block.span.shrink_to_lo().to(if_expr.span);
368 .filter(|sym| !sym.as_str().starts_with('_'))
370 let mut walker = ContainsName {
379 .filter(|stmt| !ignore_span.overlaps(stmt.span))
380 .for_each(|stmt| intravisit::walk_stmt(&mut walker, stmt));
382 if let Some(expr) = block.expr {
383 intravisit::walk_expr(&mut walker, expr);
391 fn emit_branches_sharing_code_lint(
392 cx: &LateContext<'tcx>,
396 warn_about_moved_symbol: bool,
397 blocks: &[&Block<'tcx>],
398 if_expr: &'tcx Expr<'_>,
400 if start_stmts == 0 && !lint_end {
404 // (help, span, suggestion)
405 let mut suggestions: Vec<(&str, Span, String)> = vec![];
406 let mut add_expr_note = false;
408 // Construct suggestions
410 let block = blocks[0];
411 let span_start = first_line_of_span(cx, if_expr.span).shrink_to_lo();
412 let span_end = block.stmts[start_stmts - 1].span.source_callsite();
414 let cond_span = first_line_of_span(cx, if_expr.span).until(block.span);
415 let cond_snippet = reindent_multiline(snippet(cx, cond_span, "_"), false, None);
416 let cond_indent = indent_of(cx, cond_span);
417 let moved_span = block.stmts[0].span.source_callsite().to(span_end);
418 let moved_snippet = reindent_multiline(snippet(cx, moved_span, "_"), true, None);
419 let suggestion = moved_snippet.to_string() + "\n" + &cond_snippet + "{";
420 let suggestion = reindent_multiline(Cow::Borrowed(&suggestion), true, cond_indent);
422 let span = span_start.to(span_end);
423 suggestions.push(("start", span, suggestion.to_string()));
427 let block = blocks[blocks.len() - 1];
428 let span_end = block.span.shrink_to_hi();
430 let moved_start = if end_stmts == 0 && block.expr.is_some() {
431 block.expr.unwrap().span
433 block.stmts[block.stmts.len() - end_stmts].span
436 let moved_end = block
438 .map_or_else(|| block.stmts[block.stmts.len() - 1].span, |expr| expr.span)
441 let moved_span = moved_start.to(moved_end);
442 let moved_snipped = reindent_multiline(snippet(cx, moved_span, "_"), true, None);
443 let indent = indent_of(cx, if_expr.span.shrink_to_hi());
444 let suggestion = "}\n".to_string() + &moved_snipped;
445 let suggestion = reindent_multiline(Cow::Borrowed(&suggestion), true, indent);
447 let mut span = moved_start.to(span_end);
448 // Improve formatting if the inner block has indention (i.e. normal Rust formatting)
449 let test_span = Span::new(span.lo() - BytePos(4), span.lo(), span.ctxt());
450 if snippet_opt(cx, test_span)
451 .map(|snip| snip == " ")
454 span = span.with_lo(test_span.lo());
457 suggestions.push(("end", span, suggestion.to_string()));
458 add_expr_note = !cx.typeck_results().expr_ty(if_expr).is_unit()
461 let add_optional_msgs = |diag: &mut DiagnosticBuilder<'_>| {
463 diag.note("The end suggestion probably needs some adjustments to use the expression result correctly");
466 if warn_about_moved_symbol {
467 diag.warn("Some moved values might need to be renamed to avoid wrong references");
472 if suggestions.len() == 1 {
473 let (place_str, span, sugg) = suggestions.pop().unwrap();
474 let msg = format!("all if blocks contain the same code at the {}", place_str);
475 let help = format!("consider moving the {} statements out like this", place_str);
476 span_lint_and_then(cx, BRANCHES_SHARING_CODE, span, msg.as_str(), |diag| {
477 diag.span_suggestion(span, help.as_str(), sugg, Applicability::Unspecified);
479 add_optional_msgs(diag);
481 } else if suggestions.len() == 2 {
482 let (_, end_span, end_sugg) = suggestions.pop().unwrap();
483 let (_, start_span, start_sugg) = suggestions.pop().unwrap();
486 BRANCHES_SHARING_CODE,
488 "all if blocks contain the same code at the start and the end. Here at the start",
490 diag.span_note(end_span, "and here at the end");
492 diag.span_suggestion(
494 "consider moving the start statements out like this",
496 Applicability::Unspecified,
499 diag.span_suggestion(
501 "and consider moving the end statements out like this",
503 Applicability::Unspecified,
506 add_optional_msgs(diag);
512 /// This visitor collects `HirId`s and Symbols of defined symbols and `HirId`s of used values.
513 struct UsedValueFinderVisitor<'a, 'tcx> {
514 cx: &'a LateContext<'tcx>,
516 /// The `HirId`s of defined values in the scanned statements
517 defs: FxHashSet<HirId>,
519 /// The Symbols of the defined symbols in the scanned statements
520 def_symbols: FxHashSet<Symbol>,
522 /// The `HirId`s of the used values
523 uses: FxHashSet<HirId>,
526 impl<'a, 'tcx> UsedValueFinderVisitor<'a, 'tcx> {
527 fn new(cx: &'a LateContext<'tcx>) -> Self {
528 UsedValueFinderVisitor {
530 defs: FxHashSet::default(),
531 def_symbols: FxHashSet::default(),
532 uses: FxHashSet::default(),
537 impl<'a, 'tcx> Visitor<'tcx> for UsedValueFinderVisitor<'a, 'tcx> {
538 type Map = Map<'tcx>;
540 fn nested_visit_map(&mut self) -> NestedVisitorMap<Self::Map> {
541 NestedVisitorMap::All(self.cx.tcx.hir())
544 fn visit_local(&mut self, l: &'tcx rustc_hir::Local<'tcx>) {
545 let local_id = l.pat.hir_id;
546 self.defs.insert(local_id);
548 if let Some(sym) = l.pat.simple_ident() {
549 self.def_symbols.insert(sym.name);
552 if let Some(expr) = l.init {
553 intravisit::walk_expr(self, expr);
557 fn visit_qpath(&mut self, qpath: &'tcx rustc_hir::QPath<'tcx>, id: HirId, _span: rustc_span::Span) {
558 if let rustc_hir::QPath::Resolved(_, ref path) = *qpath {
559 if path.segments.len() == 1 {
560 if let rustc_hir::def::Res::Local(var) = self.cx.qpath_res(qpath, id) {
561 self.uses.insert(var);
568 /// Implementation of `IFS_SAME_COND`.
569 fn lint_same_cond(cx: &LateContext<'_>, conds: &[&Expr<'_>]) {
570 let hash: &dyn Fn(&&Expr<'_>) -> u64 = &|expr| -> u64 {
571 let mut h = SpanlessHash::new(cx);
576 let eq: &dyn Fn(&&Expr<'_>, &&Expr<'_>) -> bool = &|&lhs, &rhs| -> bool { eq_expr_value(cx, lhs, rhs) };
578 for (i, j) in search_same(conds, hash, eq) {
583 "this `if` has the same condition as a previous `if`",
590 /// Implementation of `SAME_FUNCTIONS_IN_IF_CONDITION`.
591 fn lint_same_fns_in_if_cond(cx: &LateContext<'_>, conds: &[&Expr<'_>]) {
592 let hash: &dyn Fn(&&Expr<'_>) -> u64 = &|expr| -> u64 {
593 let mut h = SpanlessHash::new(cx);
598 let eq: &dyn Fn(&&Expr<'_>, &&Expr<'_>) -> bool = &|&lhs, &rhs| -> bool {
599 // Do not lint if any expr originates from a macro
600 if in_macro(lhs.span) || in_macro(rhs.span) {
603 // Do not spawn warning if `IFS_SAME_COND` already produced it.
604 if eq_expr_value(cx, lhs, rhs) {
607 SpanlessEq::new(cx).eq_expr(lhs, rhs)
610 for (i, j) in search_same(conds, hash, eq) {
613 SAME_FUNCTIONS_IN_IF_CONDITION,
615 "this `if` has the same function call as a previous `if`",