1 //! Checks for if expressions that contain only an if expression.
3 //! For example, the lint would catch:
8 //! println!("Hello world");
13 //! This lint is **warn** by default
18 use utils::{in_macro, snippet_block, span_lint_and_then};
19 use utils::sugg::Sugg;
21 /// **What it does:** This lint checks for nested `if`-statements which can be collapsed by
22 /// `&&`-combining their conditions and for `else { if .. }` expressions that can be collapsed to
25 /// **Why is this bad?** Each `if`-statement adds one level of nesting, which makes code look more complex than it really is.
27 /// **Known problems:** None
48 /// Should be written:
66 "`if`s that can be collapsed (e.g. `if x { if y { ... } }` and `else { if x { ... } }`)"
70 pub struct CollapsibleIf;
72 impl LintPass for CollapsibleIf {
73 fn get_lints(&self) -> LintArray {
74 lint_array!(COLLAPSIBLE_IF)
78 impl EarlyLintPass for CollapsibleIf {
79 fn check_expr(&mut self, cx: &EarlyContext, expr: &ast::Expr) {
80 if !in_macro(cx, expr.span) {
86 fn check_if(cx: &EarlyContext, expr: &ast::Expr) {
88 ast::ExprKind::If(ref check, ref then, ref else_) => {
89 if let Some(ref else_) = *else_ {
90 check_collapsible_maybe_if_let(cx, else_);
92 check_collapsible_no_if_let(cx, expr, check, then);
95 ast::ExprKind::IfLet(_, _, _, Some(ref else_)) => {
96 check_collapsible_maybe_if_let(cx, else_);
102 fn check_collapsible_maybe_if_let(cx: &EarlyContext, else_: &ast::Expr) {
104 let ast::ExprKind::Block(ref block) = else_.node,
105 let Some(ref else_) = expr_block(block),
106 !in_macro(cx, else_.span),
109 ast::ExprKind::If(..) | ast::ExprKind::IfLet(..) => {
110 span_lint_and_then(cx,
113 "this `else { if .. }` block can be collapsed", |db| {
114 db.span_suggestion(block.span, "try", snippet_block(cx, else_.span, "..").into_owned());
122 fn check_collapsible_no_if_let(
129 let Some(inner) = expr_block(then),
130 let ast::ExprKind::If(ref check_inner, ref content, None) = inner.node,
132 if expr.span.expn_id != inner.span.expn_id {
135 span_lint_and_then(cx, COLLAPSIBLE_IF, expr.span, "this if statement can be collapsed", |db| {
136 let lhs = Sugg::ast(cx, check, "..");
137 let rhs = Sugg::ast(cx, check_inner, "..");
138 db.span_suggestion(expr.span,
142 snippet_block(cx, content.span, "..")));
147 /// If the block contains only one expression, returns it.
148 fn expr_block(block: &ast::Block) -> Option<&ast::Expr> {
149 let mut it = block.stmts.iter();
151 if let (Some(stmt), None) = (it.next(), it.next()) {
153 ast::StmtKind::Expr(ref expr) | ast::StmtKind::Semi(ref expr) => Some(expr),