clippy_lints/src/casts/unnecessary_cast.rs

   1 use clippy_utils::diagnostics::span_lint_and_sugg;
   2 use clippy_utils::get_parent_expr;
   3 use clippy_utils::numeric_literal::NumericLiteral;
   4 use clippy_utils::source::snippet_opt;
   5 use if_chain::if_chain;
   6 use rustc_ast::{LitFloatType, LitIntType, LitKind};
   7 use rustc_errors::Applicability;
   8 use rustc_hir::def::Res;
   9 use rustc_hir::{Expr, ExprKind, Lit, QPath, TyKind, UnOp};
  10 use rustc_lint::{LateContext, LintContext};
  11 use rustc_middle::lint::in_external_macro;
  12 use rustc_middle::ty::{self, FloatTy, InferTy, Ty};
  13
  14 use super::UNNECESSARY_CAST;
  15
  16 pub(super) fn check<'tcx>(
  17     cx: &LateContext<'tcx>,
  18     expr: &Expr<'tcx>,
  19     cast_expr: &Expr<'tcx>,
  20     cast_from: Ty<'tcx>,
  21     cast_to: Ty<'tcx>,
  22 ) -> bool {
  23     // skip non-primitive type cast
  24     if_chain! {
  25         if let ExprKind::Cast(_, cast_to) = expr.kind;
  26         if let TyKind::Path(QPath::Resolved(_, path)) = &cast_to.kind;
  27         if let Res::PrimTy(_) = path.res;
  28         then {}
  29         else {
  30             return false
  31         }
  32     }
  33
  34     let cast_str = snippet_opt(cx, cast_expr.span).unwrap_or_default();
  35
  36     if let Some(lit) = get_numeric_literal(cast_expr) {
  37         let literal_str = &cast_str;
  38
  39         if_chain! {
  40             if let LitKind::Int(n, _) = lit.node;
  41             if let Some(src) = snippet_opt(cx, cast_expr.span);
  42             if cast_to.is_floating_point();
  43             if let Some(num_lit) = NumericLiteral::from_lit_kind(&src, &lit.node);
  44             let from_nbits = 128 - n.leading_zeros();
  45             let to_nbits = fp_ty_mantissa_nbits(cast_to);
  46             if from_nbits != 0 && to_nbits != 0 && from_nbits <= to_nbits && num_lit.is_decimal();
  47             then {
  48                 lint_unnecessary_cast(cx, expr, num_lit.integer, cast_from, cast_to);
  49                 return true
  50             }
  51         }
  52
  53         match lit.node {
  54             LitKind::Int(_, LitIntType::Unsuffixed) if cast_to.is_integral() => {
  55                 lint_unnecessary_cast(cx, expr, literal_str, cast_from, cast_to);
  56                 return false;
  57             },
  58             LitKind::Float(_, LitFloatType::Unsuffixed) if cast_to.is_floating_point() => {
  59                 lint_unnecessary_cast(cx, expr, literal_str, cast_from, cast_to);
  60                 return false;
  61             },
  62             LitKind::Int(_, LitIntType::Unsuffixed) | LitKind::Float(_, LitFloatType::Unsuffixed) => {
  63                 return false;
  64             },
  65             LitKind::Int(_, LitIntType::Signed(_) | LitIntType::Unsigned(_))
  66             | LitKind::Float(_, LitFloatType::Suffixed(_))
  67                 if cast_from.kind() == cast_to.kind() =>
  68             {
  69                 if let Some(src) = snippet_opt(cx, cast_expr.span) {
  70                     if let Some(num_lit) = NumericLiteral::from_lit_kind(&src, &lit.node) {
  71                         lint_unnecessary_cast(cx, expr, num_lit.integer, cast_from, cast_to);
  72                         return true;
  73                     }
  74                 }
  75             },
  76             _ => {},
  77         }
  78     }
  79
  80     if cast_from.kind() == cast_to.kind() && !in_external_macro(cx.sess(), expr.span) {
  81         span_lint_and_sugg(
  82             cx,
  83             UNNECESSARY_CAST,
  84             expr.span,
  85             &format!("casting to the same type is unnecessary (`{cast_from}` -> `{cast_to}`)"),
  86             "try",
  87             cast_str,
  88             Applicability::MachineApplicable,
  89         );
  90         return true;
  91     }
  92
  93     false
  94 }
  95
  96 fn lint_unnecessary_cast(
  97     cx: &LateContext<'_>,
  98     expr: &Expr<'_>,
  99     raw_literal_str: &str,
 100     cast_from: Ty<'_>,
 101     cast_to: Ty<'_>,
 102 ) {
 103     let literal_kind_name = if cast_from.is_integral() { "integer" } else { "float" };
 104     // first we remove all matches so `-(1)` become `-1`, and remove trailing dots, so `1.` become `1`
 105     let literal_str = raw_literal_str
 106         .replace(['(', ')'], "")
 107         .trim_end_matches('.')
 108         .to_string();
 109     // we know need to check if the parent is a method call, to add parenthesis accordingly (eg:
 110     // (-1).foo() instead of -1.foo())
 111     let sugg = if let Some(parent_expr) = get_parent_expr(cx, expr)
 112         && let ExprKind::MethodCall(..) = parent_expr.kind
 113         && literal_str.starts_with('-')
 114         {
 115             format!("({literal_str}_{cast_to})")
 116
 117         } else {
 118             format!("{literal_str}_{cast_to}")
 119     };
 120
 121     span_lint_and_sugg(
 122         cx,
 123         UNNECESSARY_CAST,
 124         expr.span,
 125         &format!("casting {literal_kind_name} literal to `{cast_to}` is unnecessary"),
 126         "try",
 127         sugg,
 128         Applicability::MachineApplicable,
 129     );
 130 }
 131
 132 fn get_numeric_literal<'e>(expr: &'e Expr<'e>) -> Option<&'e Lit> {
 133     match expr.kind {
 134         ExprKind::Lit(ref lit) => Some(lit),
 135         ExprKind::Unary(UnOp::Neg, e) => {
 136             if let ExprKind::Lit(ref lit) = e.kind {
 137                 Some(lit)
 138             } else {
 139                 None
 140             }
 141         },
 142         _ => None,
 143     }
 144 }
 145
 146 /// Returns the mantissa bits wide of a fp type.
 147 /// Will return 0 if the type is not a fp
 148 fn fp_ty_mantissa_nbits(typ: Ty<'_>) -> u32 {
 149     match typ.kind() {
 150         ty::Float(FloatTy::F32) => 23,
 151         ty::Float(FloatTy::F64) | ty::Infer(InferTy::FloatVar(_)) => 52,
 152         _ => 0,
 153     }
 154 }