1 use crate::utils::{match_def_path, paths, span_lint_and_note};
2 use rustc_hir::def_id::DefId;
3 use rustc_hir::{AsyncGeneratorKind, Body, BodyId, GeneratorKind};
4 use rustc_lint::{LateContext, LateLintPass};
5 use rustc_middle::ty::GeneratorInteriorTypeCause;
6 use rustc_session::{declare_lint_pass, declare_tool_lint};
10 /// **What it does:** Checks for calls to await while holding a
11 /// non-async-aware MutexGuard.
13 /// **Why is this bad?** The Mutex types found in syd::sync and parking_lot
14 /// are not designed to operator in an async context across await points.
16 /// There are two potential solutions. One is to use an asynx-aware Mutex
17 /// type. Many asynchronous foundation crates provide such a Mutex type. The
18 /// other solution is to ensure the mutex is unlocked before calling await,
19 /// either by introducing a scope or an explicit call to Drop::drop.
21 /// **Known problems:** None.
26 /// use std::sync::Mutex;
28 /// async fn foo(x: &Mutex<u32>) {
29 /// let guard = x.lock().unwrap();
37 /// use std::sync::Mutex;
39 /// async fn foo(x: &Mutex<u32>) {
41 /// let guard = x.lock().unwrap();
47 pub AWAIT_HOLDING_LOCK,
49 "Inside an async function, holding a MutexGuard while calling await"
52 declare_lint_pass!(AwaitHoldingLock => [AWAIT_HOLDING_LOCK]);
54 impl LateLintPass<'_, '_> for AwaitHoldingLock {
55 fn check_body(&mut self, cx: &LateContext<'_, '_>, body: &'_ Body<'_>) {
56 use AsyncGeneratorKind::{Block, Closure, Fn};
57 match body.generator_kind {
58 Some(GeneratorKind::Async(Block))
59 | Some(GeneratorKind::Async(Closure))
60 | Some(GeneratorKind::Async(Fn)) => {
61 let body_id = BodyId {
62 hir_id: body.value.hir_id,
64 let def_id = cx.tcx.hir().body_owner_def_id(body_id);
65 let tables = cx.tcx.typeck_tables_of(def_id);
66 check_interior_types(cx, &tables.generator_interior_types, body.value.span);
73 fn check_interior_types(cx: &LateContext<'_, '_>, ty_causes: &[GeneratorInteriorTypeCause<'_>], span: Span) {
74 for ty_cause in ty_causes {
75 if let rustc_middle::ty::Adt(adt, _) = ty_cause.ty.kind {
76 if is_mutex_guard(cx, adt.did) {
81 "this MutexGuard is held across an 'await' point. Consider using an async-aware Mutex type or ensuring the MutexGuard is dropped before calling await.",
82 ty_cause.scope_span.or(Some(span)),
83 "these are all the await points this lock is held through",
90 fn is_mutex_guard(cx: &LateContext<'_, '_>, def_id: DefId) -> bool {
91 match_def_path(cx, def_id, &paths::MUTEX_GUARD)
92 || match_def_path(cx, def_id, &paths::RWLOCK_READ_GUARD)
93 || match_def_path(cx, def_id, &paths::RWLOCK_WRITE_GUARD)
94 || match_def_path(cx, def_id, &paths::PARKING_LOT_MUTEX_GUARD)
95 || match_def_path(cx, def_id, &paths::PARKING_LOT_RWLOCK_READ_GUARD)
96 || match_def_path(cx, def_id, &paths::PARKING_LOT_RWLOCK_WRITE_GUARD)