1 //! checks for attributes
3 use crate::reexport::*;
5 is_present_in_source, last_line_of_span, match_def_path, paths, snippet_opt, span_lint, span_lint_and_sugg,
6 span_lint_and_then, without_block_comments,
8 use if_chain::if_chain;
9 use rustc::declare_lint_pass;
12 in_external_macro, CheckLintNameResult, EarlyContext, EarlyLintPass, LateContext, LateLintPass, LintArray,
13 LintContext, LintPass,
16 use rustc_errors::Applicability;
17 use rustc_session::declare_tool_lint;
18 use rustc_span::symbol::Symbol;
20 use syntax::ast::{AttrKind, AttrStyle, Attribute, Lit, LitKind, MetaItemKind, NestedMetaItem};
21 use syntax::source_map::Span;
22 use syntax::util::lev_distance::find_best_match_for_name;
24 declare_clippy_lint! {
25 /// **What it does:** Checks for items annotated with `#[inline(always)]`,
26 /// unless the annotated function is empty or simply panics.
28 /// **Why is this bad?** While there are valid uses of this annotation (and once
29 /// you know when to use it, by all means `allow` this lint), it's a common
30 /// newbie-mistake to pepper one's code with it.
32 /// As a rule of thumb, before slapping `#[inline(always)]` on a function,
33 /// measure if that additional function call really affects your runtime profile
34 /// sufficiently to make up for the increase in compile time.
36 /// **Known problems:** False positives, big time. This lint is meant to be
37 /// deactivated by everyone doing serious performance work. This means having
38 /// done the measurement.
43 /// fn not_quite_hot_code(..) { ... }
47 "use of `#[inline(always)]`"
50 declare_clippy_lint! {
51 /// **What it does:** Checks for `extern crate` and `use` items annotated with
54 /// This lint whitelists `#[allow(unused_imports)]`, `#[allow(deprecated)]` and
55 /// `#[allow(unreachable_pub)]` on `use` items and `#[allow(unused_imports)]` on
56 /// `extern crate` items with a `#[macro_use]` attribute.
58 /// **Why is this bad?** Lint attributes have no effect on crate imports. Most
59 /// likely a `!` was forgotten.
61 /// **Known problems:** None.
66 /// #[deny(dead_code)]
68 /// #[forbid(dead_code)]
72 /// #[allow(unused_imports)]
74 /// #[allow(unused_imports)]
78 pub USELESS_ATTRIBUTE,
80 "use of lint attributes on `extern crate` items"
83 declare_clippy_lint! {
84 /// **What it does:** Checks for `#[deprecated]` annotations with a `since`
85 /// field that is not a valid semantic version.
87 /// **Why is this bad?** For checking the version of the deprecation, it must be
88 /// a valid semver. Failing that, the contained information is useless.
90 /// **Known problems:** None.
94 /// #[deprecated(since = "forever")]
95 /// fn something_else() { /* ... */ }
97 pub DEPRECATED_SEMVER,
99 "use of `#[deprecated(since = \"x\")]` where x is not semver"
102 declare_clippy_lint! {
103 /// **What it does:** Checks for empty lines after outer attributes
105 /// **Why is this bad?**
106 /// Most likely the attribute was meant to be an inner attribute using a '!'.
107 /// If it was meant to be an outer attribute, then the following item
108 /// should not be separated by empty lines.
110 /// **Known problems:** Can cause false positives.
112 /// From the clippy side it's difficult to detect empty lines between an attributes and the
113 /// following item because empty lines and comments are not part of the AST. The parsing
114 /// currently works for basic cases but is not perfect.
118 /// // Good (as inner attribute)
119 /// #![inline(always)]
121 /// fn this_is_fine() { }
124 /// #[inline(always)]
126 /// fn not_quite_good_code() { }
128 /// // Good (as outer attribute)
129 /// #[inline(always)]
130 /// fn this_is_fine_too() { }
132 pub EMPTY_LINE_AFTER_OUTER_ATTR,
134 "empty line after outer attribute"
137 declare_clippy_lint! {
138 /// **What it does:** Checks for `allow`/`warn`/`deny`/`forbid` attributes with scoped clippy
139 /// lints and if those lints exist in clippy. If there is an uppercase letter in the lint name
140 /// (not the tool name) and a lowercase version of this lint exists, it will suggest to lowercase
143 /// **Why is this bad?** A lint attribute with a mistyped lint name won't have an effect.
145 /// **Known problems:** None.
150 /// #![warn(if_not_els)]
151 /// #![deny(clippy::All)]
156 /// #![warn(if_not_else)]
157 /// #![deny(clippy::all)]
159 pub UNKNOWN_CLIPPY_LINTS,
161 "unknown_lints for scoped Clippy lints"
164 declare_clippy_lint! {
165 /// **What it does:** Checks for `#[cfg_attr(rustfmt, rustfmt_skip)]` and suggests to replace it
166 /// with `#[rustfmt::skip]`.
168 /// **Why is this bad?** Since tool_attributes ([rust-lang/rust#44690](https://github.com/rust-lang/rust/issues/44690))
169 /// are stable now, they should be used instead of the old `cfg_attr(rustfmt)` attributes.
171 /// **Known problems:** This lint doesn't detect crate level inner attributes, because they get
172 /// processed before the PreExpansionPass lints get executed. See
173 /// [#3123](https://github.com/rust-lang/rust-clippy/pull/3123#issuecomment-422321765)
179 /// #[cfg_attr(rustfmt, rustfmt_skip)]
188 pub DEPRECATED_CFG_ATTR,
190 "usage of `cfg_attr(rustfmt)` instead of `tool_attributes`"
193 declare_lint_pass!(Attributes => [
197 EMPTY_LINE_AFTER_OUTER_ATTR,
198 UNKNOWN_CLIPPY_LINTS,
201 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Attributes {
202 fn check_attribute(&mut self, cx: &LateContext<'a, 'tcx>, attr: &'tcx Attribute) {
203 if let Some(items) = &attr.meta_item_list() {
204 if let Some(ident) = attr.ident() {
205 match &*ident.as_str() {
206 "allow" | "warn" | "deny" | "forbid" => {
207 check_clippy_lint_names(cx, items);
211 if items.is_empty() || !attr.check_name(sym!(deprecated)) {
216 if let NestedMetaItem::MetaItem(mi) = &item;
217 if let MetaItemKind::NameValue(lit) = &mi.kind;
218 if mi.check_name(sym!(since));
220 check_semver(cx, item.span(), lit);
228 fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item<'_>) {
229 if is_relevant_item(cx, item) {
230 check_attrs(cx, item.span, item.ident.name, &item.attrs)
233 ItemKind::ExternCrate(..) | ItemKind::Use(..) => {
234 let skip_unused_imports = item.attrs.iter().any(|attr| attr.check_name(sym!(macro_use)));
236 for attr in item.attrs {
237 if in_external_macro(cx.sess(), attr.span) {
240 if let Some(lint_list) = &attr.meta_item_list() {
241 if let Some(ident) = attr.ident() {
242 match &*ident.as_str() {
243 "allow" | "warn" | "deny" | "forbid" => {
244 // whitelist `unused_imports`, `deprecated` and `unreachable_pub` for `use` items
245 // and `unused_imports` for `extern crate` items with `macro_use`
246 for lint in lint_list {
248 ItemKind::Use(..) => {
249 if is_word(lint, sym!(unused_imports))
250 || is_word(lint, sym!(deprecated))
251 || is_word(lint, sym!(unreachable_pub))
256 ItemKind::ExternCrate(..) => {
257 if is_word(lint, sym!(unused_imports)) && skip_unused_imports {
260 if is_word(lint, sym!(unused_extern_crates)) {
267 let line_span = last_line_of_span(cx, attr.span);
269 if let Some(mut sugg) = snippet_opt(cx, line_span) {
270 if sugg.contains("#[") {
275 "useless lint attribute",
277 sugg = sugg.replacen("#[", "#![", 1);
280 "if you just forgot a `!`, use",
282 Applicability::MaybeIncorrect,
299 fn check_impl_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx ImplItem<'_>) {
300 if is_relevant_impl(cx, item) {
301 check_attrs(cx, item.span, item.ident.name, &item.attrs)
305 fn check_trait_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx TraitItem<'_>) {
306 if is_relevant_trait(cx, item) {
307 check_attrs(cx, item.span, item.ident.name, &item.attrs)
312 #[allow(clippy::single_match_else)]
313 fn check_clippy_lint_names(cx: &LateContext<'_, '_>, items: &[NestedMetaItem]) {
314 let lint_store = cx.lints();
317 if let Some(meta_item) = lint.meta_item();
318 if meta_item.path.segments.len() > 1;
319 if let tool_name = meta_item.path.segments[0].ident;
320 if tool_name.as_str() == "clippy";
321 let name = meta_item.path.segments.last().unwrap().ident.name;
322 if let CheckLintNameResult::Tool(Err((None, _))) = lint_store.check_lint_name(
324 Some(tool_name.name),
329 UNKNOWN_CLIPPY_LINTS,
331 &format!("unknown clippy lint: clippy::{}", name),
333 let name_lower = name.as_str().to_lowercase();
334 let symbols = lint_store.get_lints().iter().map(
335 |l| Symbol::intern(&l.name_lower())
336 ).collect::<Vec<_>>();
337 let sugg = find_best_match_for_name(
339 &format!("clippy::{}", name_lower),
342 if name.as_str().chars().any(char::is_uppercase)
343 && lint_store.find_lints(&format!("clippy::{}", name_lower)).is_ok() {
346 "lowercase the lint name",
347 format!("clippy::{}", name_lower),
348 Applicability::MachineApplicable,
350 } else if let Some(sugg) = sugg {
355 Applicability::MachineApplicable,
365 fn is_relevant_item(cx: &LateContext<'_, '_>, item: &Item<'_>) -> bool {
366 if let ItemKind::Fn(_, _, eid) = item.kind {
367 is_relevant_expr(cx, cx.tcx.body_tables(eid), &cx.tcx.hir().body(eid).value)
373 fn is_relevant_impl(cx: &LateContext<'_, '_>, item: &ImplItem<'_>) -> bool {
375 ImplItemKind::Method(_, eid) => is_relevant_expr(cx, cx.tcx.body_tables(eid), &cx.tcx.hir().body(eid).value),
380 fn is_relevant_trait(cx: &LateContext<'_, '_>, item: &TraitItem<'_>) -> bool {
382 TraitItemKind::Method(_, TraitMethod::Required(_)) => true,
383 TraitItemKind::Method(_, TraitMethod::Provided(eid)) => {
384 is_relevant_expr(cx, cx.tcx.body_tables(eid), &cx.tcx.hir().body(eid).value)
390 fn is_relevant_block(cx: &LateContext<'_, '_>, tables: &ty::TypeckTables<'_>, block: &Block<'_>) -> bool {
391 if let Some(stmt) = block.stmts.first() {
393 StmtKind::Local(_) => true,
394 StmtKind::Expr(expr) | StmtKind::Semi(expr) => is_relevant_expr(cx, tables, expr),
398 block.expr.as_ref().map_or(false, |e| is_relevant_expr(cx, tables, e))
402 fn is_relevant_expr(cx: &LateContext<'_, '_>, tables: &ty::TypeckTables<'_>, expr: &Expr<'_>) -> bool {
404 ExprKind::Block(block, _) => is_relevant_block(cx, tables, block),
405 ExprKind::Ret(Some(e)) => is_relevant_expr(cx, tables, e),
406 ExprKind::Ret(None) | ExprKind::Break(_, None) => false,
407 ExprKind::Call(path_expr, _) => {
408 if let ExprKind::Path(qpath) = &path_expr.kind {
409 if let Some(fun_id) = tables.qpath_res(qpath, path_expr.hir_id).opt_def_id() {
410 !match_def_path(cx, fun_id, &paths::BEGIN_PANIC)
422 fn check_attrs(cx: &LateContext<'_, '_>, span: Span, name: Name, attrs: &[Attribute]) {
423 if span.from_expansion() {
428 let attr_item = if let AttrKind::Normal(ref attr) = attr.kind {
434 if attr.style == AttrStyle::Outer {
435 if attr_item.args.inner_tokens().is_empty() || !is_present_in_source(cx, attr.span) {
439 let begin_of_attr_to_item = Span::new(attr.span.lo(), span.lo(), span.ctxt());
440 let end_of_attr_to_item = Span::new(attr.span.hi(), span.lo(), span.ctxt());
442 if let Some(snippet) = snippet_opt(cx, end_of_attr_to_item) {
443 let lines = snippet.split('\n').collect::<Vec<_>>();
444 let lines = without_block_comments(lines);
446 if lines.iter().filter(|l| l.trim().is_empty()).count() > 2 {
449 EMPTY_LINE_AFTER_OUTER_ATTR,
450 begin_of_attr_to_item,
451 "Found an empty line after an outer attribute. \
452 Perhaps you forgot to add a '!' to make it an inner attribute?",
458 if let Some(values) = attr.meta_item_list() {
459 if values.len() != 1 || !attr.check_name(sym!(inline)) {
462 if is_word(&values[0], sym!(always)) {
468 "you have declared `#[inline(always)]` on `{}`. This is usually a bad idea",
477 fn check_semver(cx: &LateContext<'_, '_>, span: Span, lit: &Lit) {
478 if let LitKind::Str(is, _) = lit.kind {
479 if Version::parse(&is.as_str()).is_ok() {
487 "the since field must contain a semver-compliant version",
491 fn is_word(nmi: &NestedMetaItem, expected: Symbol) -> bool {
492 if let NestedMetaItem::MetaItem(mi) = &nmi {
493 mi.is_word() && mi.check_name(expected)
499 declare_lint_pass!(DeprecatedCfgAttribute => [DEPRECATED_CFG_ATTR]);
501 impl EarlyLintPass for DeprecatedCfgAttribute {
502 fn check_attribute(&mut self, cx: &EarlyContext<'_>, attr: &Attribute) {
505 if attr.check_name(sym!(cfg_attr));
506 if let Some(items) = attr.meta_item_list();
508 // check for `rustfmt`
509 if let Some(feature_item) = items[0].meta_item();
510 if feature_item.check_name(sym!(rustfmt));
511 // check for `rustfmt_skip` and `rustfmt::skip`
512 if let Some(skip_item) = &items[1].meta_item();
513 if skip_item.check_name(sym!(rustfmt_skip)) ||
514 skip_item.path.segments.last().expect("empty path in attribute").ident.name == sym!(skip);
515 // Only lint outer attributes, because custom inner attributes are unstable
516 // Tracking issue: https://github.com/rust-lang/rust/issues/54726
517 if let AttrStyle::Outer = attr.style;
523 "`cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes",
525 "#[rustfmt::skip]".to_string(),
526 Applicability::MachineApplicable,