1 use if_chain::if_chain;
2 use rustc::hir::{Expr, ExprKind};
3 use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
4 use rustc::{declare_lint_pass, declare_tool_lint};
7 use crate::consts::{constant, Constant};
8 use crate::utils::{in_macro_or_desugar, is_direct_expn_of, span_help_and_lint};
10 declare_clippy_lint! {
11 /// **What it does:** Checks for `assert!(true)` and `assert!(false)` calls.
13 /// **Why is this bad?** Will be optimized out by the compiler or should probably be replaced by a
14 /// panic!() or unreachable!()
16 /// **Known problems:** None
24 /// const B: bool = false;
27 pub ASSERTIONS_ON_CONSTANTS,
29 "`assert!(true)` / `assert!(false)` will be optimized out by the compiler, and should probably be replaced by a `panic!()` or `unreachable!()`"
32 declare_lint_pass!(AssertionsOnConstants => [ASSERTIONS_ON_CONSTANTS]);
34 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for AssertionsOnConstants {
35 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
36 let mut is_debug_assert = false;
37 let debug_assert_not_in_macro_or_desugar = |span: Span| {
38 is_debug_assert = true;
39 // Check that `debug_assert!` itself is not inside a macro
40 !in_macro_or_desugar(span)
43 if let Some(assert_span) = is_direct_expn_of(e.span, "assert");
44 if !in_macro_or_desugar(assert_span)
45 || is_direct_expn_of(assert_span, "debug_assert")
46 .map_or(false, debug_assert_not_in_macro_or_desugar);
47 if let ExprKind::Unary(_, ref lit) = e.node;
48 if let Some(bool_const) = constant(cx, cx.tables, lit);
51 Constant::Bool(true) => {
54 ASSERTIONS_ON_CONSTANTS,
56 "`assert!(true)` will be optimized out by the compiler",
60 Constant::Bool(false) if !is_debug_assert => {
63 ASSERTIONS_ON_CONSTANTS,
65 "`assert!(false)` should probably be replaced",
66 "use `panic!()` or `unreachable!()`"