1 use if_chain::if_chain;
2 use rustc::hir::{Expr, ExprKind};
3 use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
4 use rustc::{declare_tool_lint, lint_array};
6 use crate::consts::{constant, Constant};
7 use crate::syntax::ast::LitKind;
8 use crate::utils::{in_macro, is_direct_expn_of, span_help_and_lint};
10 declare_clippy_lint! {
11 /// **What it does:** Checks for `assert!(true)` and `assert!(false)` calls.
13 /// **Why is this bad?** Will be optimized out by the compiler or should probably be replaced by a
14 /// panic!() or unreachable!()
16 /// **Known problems:** None
24 /// const B: bool = false;
27 pub ASSERTIONS_ON_CONSTANTS,
29 "`assert!(true)` / `assert!(false)` will be optimized out by the compiler, and should probably be replaced by a `panic!()` or `unreachable!()`"
32 pub struct AssertionsOnConstants;
34 impl LintPass for AssertionsOnConstants {
35 fn get_lints(&self) -> LintArray {
36 lint_array![ASSERTIONS_ON_CONSTANTS]
39 fn name(&self) -> &'static str {
40 "AssertionsOnConstants"
44 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for AssertionsOnConstants {
45 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
47 if let Some(assert_span) = is_direct_expn_of(e.span, "assert");
48 if !in_macro(assert_span)
49 || is_direct_expn_of(assert_span, "debug_assert").map_or(false, |span| !in_macro(span));
50 if let ExprKind::Unary(_, ref lit) = e.node;
52 if let ExprKind::Lit(ref inner) = lit.node {
54 LitKind::Bool(true) => {
55 span_help_and_lint(cx, ASSERTIONS_ON_CONSTANTS, e.span,
56 "assert!(true) will be optimized out by the compiler",
59 LitKind::Bool(false) => {
61 cx, ASSERTIONS_ON_CONSTANTS, e.span,
62 "assert!(false) should probably be replaced",
63 "use panic!() or unreachable!()");
67 } else if let Some(bool_const) = constant(cx, cx.tables, lit) {
69 Constant::Bool(true) => {
70 span_help_and_lint(cx, ASSERTIONS_ON_CONSTANTS, e.span,
71 "assert!(const: true) will be optimized out by the compiler",
74 Constant::Bool(false) => {
75 span_help_and_lint(cx, ASSERTIONS_ON_CONSTANTS, e.span,
76 "assert!(const: false) should probably be replaced",
77 "use panic!() or unreachable!()");