1 use itertools::Itertools;
3 use std::collections::{BTreeSet, HashMap};
6 use std::lazy::SyncLazy;
10 use crate::clippy_project_root;
12 const GENERATED_FILE_COMMENT: &str = "// This file was generated by `cargo dev update_lints`.\n\
13 // Use that command to update this file and do not edit by hand.\n\
14 // Manual edits will be overwritten.\n\n";
16 static DEC_CLIPPY_LINT_RE: SyncLazy<Regex> = SyncLazy::new(|| {
19 declare_clippy_lint!\s*[\{(]
21 \s+pub\s+(?P<name>[A-Z_][A-Z_0-9]*)\s*,\s*
22 (?P<cat>[a-z_]+)\s*,\s*
23 "(?P<desc>(?:[^"\\]+|\\(?s).(?-s))*)"\s*[})]
29 static DEC_DEPRECATED_LINT_RE: SyncLazy<Regex> = SyncLazy::new(|| {
32 declare_deprecated_lint!\s*[{(]\s*
34 \s+pub\s+(?P<name>[A-Z_][A-Z_0-9]*)\s*,\s*
35 "(?P<desc>(?:[^"\\]+|\\(?s).(?-s))*)"\s*[})]
40 static NL_ESCAPE_RE: SyncLazy<Regex> = SyncLazy::new(|| Regex::new(r#"\\\n\s*"#).unwrap());
42 static DOCS_LINK: &str = "https://rust-lang.github.io/rust-clippy/master/index.html";
44 #[derive(Clone, Copy, PartialEq)]
50 /// Runs the `update_lints` command.
52 /// This updates various generated values from the lint source code.
54 /// `update_mode` indicates if the files should be updated or if updates should be checked for.
58 /// Panics if a file path could not read from or then written to
59 #[allow(clippy::too_many_lines)]
60 pub fn run(update_mode: UpdateMode) {
61 let lint_list: Vec<Lint> = gather_all().collect();
63 let internal_lints = Lint::internal_lints(&lint_list);
64 let deprecated_lints = Lint::deprecated_lints(&lint_list);
65 let usable_lints = Lint::usable_lints(&lint_list);
66 let mut sorted_usable_lints = usable_lints.clone();
67 sorted_usable_lints.sort_by_key(|lint| lint.name.clone());
69 let usable_lint_count = round_to_fifty(usable_lints.len());
71 let mut file_change = false;
73 file_change |= replace_region_in_file(
74 Path::new("README.md"),
76 r#"\[There are over \d+ lints included in this crate!\]\({}\)"#,
81 update_mode == UpdateMode::Change,
84 "[There are over {} lints included in this crate!]({})",
85 usable_lint_count, DOCS_LINK
91 file_change |= replace_region_in_file(
92 Path::new("CHANGELOG.md"),
93 "<!-- begin autogenerated links to lint list -->",
94 "<!-- end autogenerated links to lint list -->",
96 update_mode == UpdateMode::Change,
97 || gen_changelog_lint_list(usable_lints.iter().chain(deprecated_lints.iter())),
101 // This has to be in lib.rs, otherwise rustfmt doesn't work
102 file_change |= replace_region_in_file(
103 Path::new("clippy_lints/src/lib.rs"),
104 "begin lints modules",
107 update_mode == UpdateMode::Change,
108 || vec![gen_modules_list(usable_lints.iter())],
112 if file_change && update_mode == UpdateMode::Check {
117 "clippy_lints/src/lib.register_lints.rs",
119 &gen_register_lint_list(internal_lints.iter(), usable_lints.iter()),
122 "clippy_lints/src/lib.deprecated.rs",
124 &gen_deprecated(deprecated_lints.iter()),
127 let all_group_lints = usable_lints.iter().filter(|l| {
130 "correctness" | "suspicious" | "style" | "complexity" | "perf"
133 let content = gen_lint_group_list("all", all_group_lints);
134 process_file("clippy_lints/src/lib.register_all.rs", update_mode, &content);
136 for (lint_group, lints) in Lint::by_lint_group(usable_lints.into_iter().chain(internal_lints)) {
137 let content = gen_lint_group_list(&lint_group, lints.iter());
139 &format!("clippy_lints/src/lib.register_{}.rs", lint_group),
146 pub fn print_lints() {
147 let lint_list: Vec<Lint> = gather_all().collect();
148 let usable_lints = Lint::usable_lints(&lint_list);
149 let usable_lint_count = usable_lints.len();
150 let grouped_by_lint_group = Lint::by_lint_group(usable_lints.into_iter());
152 for (lint_group, mut lints) in grouped_by_lint_group {
153 if lint_group == "Deprecated" {
156 println!("\n## {}", lint_group);
158 lints.sort_by_key(|l| l.name.clone());
161 println!("* [{}]({}#{}) ({})", lint.name, DOCS_LINK, lint.name, lint.desc);
165 println!("there are {} lints", usable_lint_count);
168 fn round_to_fifty(count: usize) -> usize {
172 fn process_file(path: impl AsRef<Path>, update_mode: UpdateMode, content: &str) {
173 if update_mode == UpdateMode::Check {
175 fs::read_to_string(&path).unwrap_or_else(|e| panic!("Cannot read from {}: {}", path.as_ref().display(), e));
176 if content != old_content {
180 fs::write(&path, content.as_bytes())
181 .unwrap_or_else(|e| panic!("Cannot write to {}: {}", path.as_ref().display(), e));
185 fn exit_with_failure() {
187 "Not all lints defined properly. \
188 Please run `cargo dev update_lints` to make sure all lints are defined properly."
190 std::process::exit(1);
193 /// Lint data parsed from the Clippy source code.
194 #[derive(Clone, PartialEq, Debug)]
199 deprecation: Option<String>,
205 fn new(name: &str, group: &str, desc: &str, deprecation: Option<&str>, module: &str) -> Self {
207 name: name.to_lowercase(),
208 group: group.to_string(),
209 desc: NL_ESCAPE_RE.replace(&desc.replace("\\\"", "\""), "").to_string(),
210 deprecation: deprecation.map(ToString::to_string),
211 module: module.to_string(),
215 /// Returns all non-deprecated lints and non-internal lints
217 fn usable_lints(lints: &[Self]) -> Vec<Self> {
220 .filter(|l| l.deprecation.is_none() && !l.group.starts_with("internal"))
225 /// Returns all internal lints (not `internal_warn` lints)
227 fn internal_lints(lints: &[Self]) -> Vec<Self> {
228 lints.iter().filter(|l| l.group == "internal").cloned().collect()
231 /// Returns all deprecated lints
233 fn deprecated_lints(lints: &[Self]) -> Vec<Self> {
234 lints.iter().filter(|l| l.deprecation.is_some()).cloned().collect()
237 /// Returns the lints in a `HashMap`, grouped by the different lint groups
239 fn by_lint_group(lints: impl Iterator<Item = Self>) -> HashMap<String, Vec<Self>> {
240 lints.map(|lint| (lint.group.to_string(), lint)).into_group_map()
244 /// Generates the code for registering a group
245 fn gen_lint_group_list<'a>(group_name: &str, lints: impl Iterator<Item = &'a Lint>) -> String {
246 let mut details: Vec<_> = lints.map(|l| (&l.module, l.name.to_uppercase())).collect();
247 details.sort_unstable();
249 let mut output = GENERATED_FILE_COMMENT.to_string();
251 output.push_str(&format!(
252 "store.register_group(true, \"clippy::{0}\", Some(\"clippy_{0}\"), vec![\n",
255 for (module, name) in details {
256 output.push_str(&format!(" LintId::of({}::{}),\n", module, name));
258 output.push_str("])\n");
263 /// Generates the module declarations for `lints`
265 fn gen_modules_list<'a>(lints: impl Iterator<Item = &'a Lint>) -> String {
266 let module_names: BTreeSet<_> = lints.map(|l| &l.module).collect();
268 let mut output = GENERATED_FILE_COMMENT.to_string();
269 for name in module_names {
270 output.push_str(&format!("mod {};\n", name));
275 /// Generates the list of lint links at the bottom of the CHANGELOG
277 fn gen_changelog_lint_list<'a>(lints: impl Iterator<Item = &'a Lint>) -> Vec<String> {
279 .sorted_by_key(|l| &l.name)
280 .map(|l| format!("[`{}`]: {}#{}", l.name, DOCS_LINK, l.name))
284 /// Generates the `register_removed` code
286 fn gen_deprecated<'a>(lints: impl Iterator<Item = &'a Lint>) -> String {
287 let mut output = GENERATED_FILE_COMMENT.to_string();
288 output.push_str("{\n");
289 for Lint { name, deprecation, .. } in lints {
290 output.push_str(&format!(
292 " store.register_removed(\n",
293 " \"clippy::{}\",\n",
298 deprecation.as_ref().expect("`lints` are deprecated")
301 output.push_str("}\n");
306 /// Generates the code for registering lints
308 fn gen_register_lint_list<'a>(
309 internal_lints: impl Iterator<Item = &'a Lint>,
310 usable_lints: impl Iterator<Item = &'a Lint>,
312 let mut details: Vec<_> = internal_lints
313 .map(|l| (false, &l.module, l.name.to_uppercase()))
314 .chain(usable_lints.map(|l| (true, &l.module, l.name.to_uppercase())))
316 details.sort_unstable();
318 let mut output = GENERATED_FILE_COMMENT.to_string();
319 output.push_str("store.register_lints(&[\n");
321 for (is_public, module_name, lint_name) in details {
323 output.push_str(" #[cfg(feature = \"internal-lints\")]\n");
325 output.push_str(&format!(" {}::{},\n", module_name, lint_name));
327 output.push_str("])\n");
332 /// Gathers all files in `src/clippy_lints` and gathers all lints inside
333 fn gather_all() -> impl Iterator<Item = Lint> {
334 lint_files().flat_map(|f| gather_from_file(&f))
337 fn gather_from_file(dir_entry: &walkdir::DirEntry) -> impl Iterator<Item = Lint> {
338 let content = fs::read_to_string(dir_entry.path()).unwrap();
339 let path = dir_entry.path();
340 let filename = path.file_stem().unwrap();
341 let path_buf = path.with_file_name(filename);
342 let mut rel_path = path_buf
343 .strip_prefix(clippy_project_root().join("clippy_lints/src"))
344 .expect("only files in `clippy_lints/src` should be looked at");
345 // If the lints are stored in mod.rs, we get the module name from
346 // the containing directory:
347 if filename == "mod" {
348 rel_path = rel_path.parent().unwrap();
351 let module = rel_path
353 .map(|c| c.as_os_str().to_str().unwrap())
357 parse_contents(&content, &module)
360 fn parse_contents(content: &str, module: &str) -> impl Iterator<Item = Lint> {
361 let lints = DEC_CLIPPY_LINT_RE
362 .captures_iter(content)
363 .map(|m| Lint::new(&m["name"], &m["cat"], &m["desc"], None, module));
364 let deprecated = DEC_DEPRECATED_LINT_RE
365 .captures_iter(content)
366 .map(|m| Lint::new(&m["name"], "Deprecated", &m["desc"], Some(&m["desc"]), module));
367 // Removing the `.collect::<Vec<Lint>>().into_iter()` causes some lifetime issues due to the map
368 lints.chain(deprecated).collect::<Vec<Lint>>().into_iter()
371 /// Collects all .rs files in the `clippy_lints/src` directory
372 fn lint_files() -> impl Iterator<Item = walkdir::DirEntry> {
373 // We use `WalkDir` instead of `fs::read_dir` here in order to recurse into subdirectories.
374 // Otherwise we would not collect all the lints, for example in `clippy_lints/src/methods/`.
375 let path = clippy_project_root().join("clippy_lints/src");
378 .filter_map(Result::ok)
379 .filter(|f| f.path().extension() == Some(OsStr::new("rs")))
382 /// Whether a file has had its text changed or not
383 #[derive(PartialEq, Debug)]
389 /// Replaces a region in a file delimited by two lines matching regexes.
391 /// `path` is the relative path to the file on which you want to perform the replacement.
393 /// See `replace_region_in_text` for documentation of the other options.
397 /// Panics if the path could not read or then written
398 fn replace_region_in_file<F>(
407 F: FnOnce() -> Vec<String>,
409 let contents = fs::read_to_string(path).unwrap_or_else(|e| panic!("Cannot read from {}: {}", path.display(), e));
410 let file_change = replace_region_in_text(&contents, start, end, replace_start, replacements);
413 if let Err(e) = fs::write(path, file_change.new_lines.as_bytes()) {
414 panic!("Cannot write to {}: {}", path.display(), e);
420 /// Replaces a region in a text delimited by two lines matching regexes.
422 /// * `text` is the input text on which you want to perform the replacement
423 /// * `start` is a `&str` that describes the delimiter line before the region you want to replace.
424 /// As the `&str` will be converted to a `Regex`, this can contain regex syntax, too.
425 /// * `end` is a `&str` that describes the delimiter line until where the replacement should happen.
426 /// As the `&str` will be converted to a `Regex`, this can contain regex syntax, too.
427 /// * If `replace_start` is true, the `start` delimiter line is replaced as well. The `end`
428 /// delimiter line is never replaced.
429 /// * `replacements` is a closure that has to return a `Vec<String>` which contains the new text.
431 /// If you want to perform the replacement on files instead of already parsed text,
432 /// use `replace_region_in_file`.
437 /// let the_text = "replace_start\nsome text\nthat will be replaced\nreplace_end";
439 /// replace_region_in_text(the_text, "replace_start", "replace_end", false, || {
440 /// vec!["a different".to_string(), "text".to_string()]
443 /// assert_eq!("replace_start\na different\ntext\nreplace_end", result);
448 /// Panics if start or end is not valid regex
449 fn replace_region_in_text<F>(text: &str, start: &str, end: &str, replace_start: bool, replacements: F) -> FileChange
451 F: FnOnce() -> Vec<String>,
453 let replace_it = replacements();
454 let mut in_old_region = false;
455 let mut found = false;
456 let mut new_lines = vec![];
457 let start = Regex::new(start).unwrap();
458 let end = Regex::new(end).unwrap();
460 for line in text.lines() {
462 if end.is_match(line) {
463 in_old_region = false;
464 new_lines.extend(replace_it.clone());
465 new_lines.push(line.to_string());
467 } else if start.is_match(line) {
469 new_lines.push(line.to_string());
471 in_old_region = true;
474 new_lines.push(line.to_string());
479 // This happens if the provided regex in `clippy_dev/src/main.rs` does not match in the
480 // given text or file. Most likely this is an error on the programmer's side and the Regex
482 eprintln!("error: regex \n{:?}\ndoesn't match. You may have to update it.", start);
483 std::process::exit(1);
486 let mut new_lines = new_lines.join("\n");
487 if text.ends_with('\n') {
488 new_lines.push('\n');
490 let changed = new_lines != text;
491 FileChange { changed, new_lines }
495 fn test_parse_contents() {
496 let result: Vec<Lint> = parse_contents(
498 declare_clippy_lint! {
505 declare_clippy_lint!{
512 declare_deprecated_lint! {
513 pub SHOULD_ASSERT_EQ,
514 "`assert!()` will be more flexible with RFC 2011"
522 Lint::new("ptr_arg", "style", "really long text", None, "module_name"),
523 Lint::new("doc_markdown", "pedantic", "single line", None, "module_name"),
527 "`assert!()` will be more flexible with RFC 2011",
528 Some("`assert!()` will be more flexible with RFC 2011"),
532 assert_eq!(expected, result);
540 fn test_replace_region() {
541 let text = "\nabc\n123\n789\ndef\nghi";
542 let expected = FileChange {
544 new_lines: "\nabc\nhello world\ndef\nghi".to_string(),
546 let result = replace_region_in_text(text, r#"^\s*abc$"#, r#"^\s*def"#, false, || {
547 vec!["hello world".to_string()]
549 assert_eq!(expected, result);
553 fn test_replace_region_with_start() {
554 let text = "\nabc\n123\n789\ndef\nghi";
555 let expected = FileChange {
557 new_lines: "\nhello world\ndef\nghi".to_string(),
559 let result = replace_region_in_text(text, r#"^\s*abc$"#, r#"^\s*def"#, true, || {
560 vec!["hello world".to_string()]
562 assert_eq!(expected, result);
566 fn test_replace_region_no_changes() {
567 let text = "123\n456\n789";
568 let expected = FileChange {
570 new_lines: "123\n456\n789".to_string(),
572 let result = replace_region_in_text(text, r#"^\s*123$"#, r#"^\s*456"#, false, Vec::new);
573 assert_eq!(expected, result);
577 fn test_usable_lints() {
579 Lint::new("should_assert_eq", "Deprecated", "abc", Some("Reason"), "module_name"),
580 Lint::new("should_assert_eq2", "Not Deprecated", "abc", None, "module_name"),
581 Lint::new("should_assert_eq2", "internal", "abc", None, "module_name"),
582 Lint::new("should_assert_eq2", "internal_style", "abc", None, "module_name"),
584 let expected = vec![Lint::new(
591 assert_eq!(expected, Lint::usable_lints(&lints));
595 fn test_by_lint_group() {
597 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
598 Lint::new("should_assert_eq2", "group2", "abc", None, "module_name"),
599 Lint::new("incorrect_match", "group1", "abc", None, "module_name"),
601 let mut expected: HashMap<String, Vec<Lint>> = HashMap::new();
603 "group1".to_string(),
605 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
606 Lint::new("incorrect_match", "group1", "abc", None, "module_name"),
610 "group2".to_string(),
611 vec![Lint::new("should_assert_eq2", "group2", "abc", None, "module_name")],
613 assert_eq!(expected, Lint::by_lint_group(lints.into_iter()));
617 fn test_gen_changelog_lint_list() {
619 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
620 Lint::new("should_assert_eq2", "group2", "abc", None, "module_name"),
623 format!("[`should_assert_eq`]: {}#should_assert_eq", DOCS_LINK.to_string()),
624 format!("[`should_assert_eq2`]: {}#should_assert_eq2", DOCS_LINK.to_string()),
626 assert_eq!(expected, gen_changelog_lint_list(lints.iter()));
630 fn test_gen_deprecated() {
636 Some("has been superseded by should_assert_eq2"),
640 "another_deprecated",
643 Some("will be removed"),
648 let expected = GENERATED_FILE_COMMENT.to_string()
651 " store.register_removed(",
652 " \"clippy::should_assert_eq\",",
653 " \"has been superseded by should_assert_eq2\",",
655 " store.register_removed(",
656 " \"clippy::another_deprecated\",",
657 " \"will be removed\",",
664 assert_eq!(expected, gen_deprecated(lints.iter()));
669 fn test_gen_deprecated_fail() {
670 let lints = vec![Lint::new("should_assert_eq2", "group2", "abc", None, "module_name")];
671 let _deprecated_lints = gen_deprecated(lints.iter());
675 fn test_gen_modules_list() {
677 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
678 Lint::new("incorrect_stuff", "group3", "abc", None, "another_module"),
681 GENERATED_FILE_COMMENT.to_string() + &["mod another_module;", "mod module_name;"].join("\n") + "\n";
682 assert_eq!(expected, gen_modules_list(lints.iter()));
686 fn test_gen_lint_group_list() {
688 Lint::new("abc", "group1", "abc", None, "module_name"),
689 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
690 Lint::new("internal", "internal_style", "abc", None, "module_name"),
692 let expected = GENERATED_FILE_COMMENT.to_string()
694 "store.register_group(true, \"clippy::group1\", Some(\"clippy_group1\"), vec![",
695 " LintId::of(module_name::ABC),",
696 " LintId::of(module_name::INTERNAL),",
697 " LintId::of(module_name::SHOULD_ASSERT_EQ),",
703 let result = gen_lint_group_list("group1", lints.iter());
705 assert_eq!(expected, result);