1 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
3 use itertools::Itertools;
4 use lazy_static::lazy_static;
6 use std::collections::HashMap;
9 use std::path::{Path, PathBuf};
13 static ref DEC_CLIPPY_LINT_RE: Regex = Regex::new(
15 declare_clippy_lint!\s*[\{(]
17 \s+pub\s+(?P<name>[A-Z_][A-Z_0-9]*)\s*,\s*
18 (?P<cat>[a-z_]+)\s*,\s*
19 "(?P<desc>(?:[^"\\]+|\\(?s).(?-s))*)"\s*[})]
23 static ref DEC_DEPRECATED_LINT_RE: Regex = Regex::new(
25 declare_deprecated_lint!\s*[{(]\s*
27 \s+pub\s+(?P<name>[A-Z_][A-Z_0-9]*)\s*,\s*
28 "(?P<desc>(?:[^"\\]+|\\(?s).(?-s))*)"\s*[})]
32 static ref NL_ESCAPE_RE: Regex = Regex::new(r#"\\\n\s*"#).unwrap();
35 pub static DOCS_LINK: &str = "https://rust-lang.github.io/rust-clippy/master/index.html";
37 /// Lint data parsed from the Clippy source code.
38 #[derive(Clone, PartialEq, Debug)]
43 pub deprecation: Option<String>,
49 pub fn new(name: &str, group: &str, desc: &str, deprecation: Option<&str>, module: &str) -> Self {
51 name: name.to_lowercase(),
52 group: group.to_string(),
53 desc: NL_ESCAPE_RE.replace(&desc.replace("\\\"", "\""), "").to_string(),
54 deprecation: deprecation.map(ToString::to_string),
55 module: module.to_string(),
59 /// Returns all non-deprecated lints and non-internal lints
60 pub fn usable_lints(lints: impl Iterator<Item = Self>) -> impl Iterator<Item = Self> {
61 lints.filter(|l| l.deprecation.is_none() && !l.is_internal())
64 /// Returns the lints in a `HashMap`, grouped by the different lint groups
66 pub fn by_lint_group(lints: impl Iterator<Item = Self>) -> HashMap<String, Vec<Self>> {
67 lints.map(|lint| (lint.group.to_string(), lint)).into_group_map()
71 pub fn is_internal(&self) -> bool {
72 self.group.starts_with("internal")
76 /// Generates the Vec items for `register_lint_group` calls in `clippy_lints/src/lib.rs`.
78 pub fn gen_lint_group_list(lints: Vec<Lint>) -> Vec<String> {
82 if l.is_internal() || l.deprecation.is_some() {
85 Some(format!(" LintId::of(&{}::{}),", l.module, l.name.to_uppercase()))
89 .collect::<Vec<String>>()
92 /// Generates the `pub mod module_name` list in `clippy_lints/src/lib.rs`.
94 pub fn gen_modules_list(lints: Vec<Lint>) -> Vec<String> {
98 if l.is_internal() || l.deprecation.is_some() {
105 .map(|module| format!("pub mod {};", module))
107 .collect::<Vec<String>>()
110 /// Generates the list of lint links at the bottom of the README
112 pub fn gen_changelog_lint_list(lints: Vec<Lint>) -> Vec<String> {
113 let mut lint_list_sorted: Vec<Lint> = lints;
114 lint_list_sorted.sort_by_key(|l| l.name.clone());
121 Some(format!("[`{}`]: {}#{}", l.name, DOCS_LINK, l.name))
127 /// Generates the `register_removed` code in `./clippy_lints/src/lib.rs`.
129 pub fn gen_deprecated(lints: &[Lint]) -> Vec<String> {
133 l.clone().deprecation.map(|depr_text| {
135 " store.register_removed(".to_string(),
136 format!(" \"clippy::{}\",", l.name),
137 format!(" \"{}\",", depr_text),
143 .collect::<Vec<String>>()
147 pub fn gen_register_lint_list(lints: &[Lint]) -> Vec<String> {
148 let pre = " store.register_lints(&[".to_string();
149 let post = " ]);".to_string();
150 let mut inner = lints
153 if !l.is_internal() && l.deprecation.is_none() {
154 Some(format!(" &{}::{},", l.module, l.name.to_uppercase()))
160 .collect::<Vec<String>>();
161 inner.insert(0, pre);
166 /// Gathers all files in `src/clippy_lints` and gathers all lints inside
167 pub fn gather_all() -> impl Iterator<Item = Lint> {
168 lint_files().flat_map(|f| gather_from_file(&f))
171 fn gather_from_file(dir_entry: &walkdir::DirEntry) -> impl Iterator<Item = Lint> {
172 let content = fs::read_to_string(dir_entry.path()).unwrap();
173 let mut filename = dir_entry.path().file_stem().unwrap().to_str().unwrap();
174 // If the lints are stored in mod.rs, we get the module name from
175 // the containing directory:
176 if filename == "mod" {
186 parse_contents(&content, filename)
189 fn parse_contents(content: &str, filename: &str) -> impl Iterator<Item = Lint> {
190 let lints = DEC_CLIPPY_LINT_RE
191 .captures_iter(content)
192 .map(|m| Lint::new(&m["name"], &m["cat"], &m["desc"], None, filename));
193 let deprecated = DEC_DEPRECATED_LINT_RE
194 .captures_iter(content)
195 .map(|m| Lint::new(&m["name"], "Deprecated", &m["desc"], Some(&m["desc"]), filename));
196 // Removing the `.collect::<Vec<Lint>>().into_iter()` causes some lifetime issues due to the map
197 lints.chain(deprecated).collect::<Vec<Lint>>().into_iter()
200 /// Collects all .rs files in the `clippy_lints/src` directory
201 fn lint_files() -> impl Iterator<Item = walkdir::DirEntry> {
202 // We use `WalkDir` instead of `fs::read_dir` here in order to recurse into subdirectories.
203 // Otherwise we would not collect all the lints, for example in `clippy_lints/src/methods/`.
204 let path = clippy_project_root().join("clippy_lints/src");
207 .filter_map(Result::ok)
208 .filter(|f| f.path().extension() == Some(OsStr::new("rs")))
211 /// Whether a file has had its text changed or not
212 #[derive(PartialEq, Debug)]
213 pub struct FileChange {
215 pub new_lines: String,
218 /// Replaces a region in a file delimited by two lines matching regexes.
220 /// `path` is the relative path to the file on which you want to perform the replacement.
222 /// See `replace_region_in_text` for documentation of the other options.
223 pub fn replace_region_in_file<F>(
232 F: FnOnce() -> Vec<String>,
234 let contents = fs::read_to_string(path).unwrap_or_else(|e| panic!("Cannot read from {}: {}", path.display(), e));
235 let file_change = replace_region_in_text(&contents, start, end, replace_start, replacements);
238 if let Err(e) = fs::write(path, file_change.new_lines.as_bytes()) {
239 panic!("Cannot write to {}: {}", path.display(), e);
245 /// Replaces a region in a text delimited by two lines matching regexes.
247 /// * `text` is the input text on which you want to perform the replacement
248 /// * `start` is a `&str` that describes the delimiter line before the region you want to replace.
249 /// As the `&str` will be converted to a `Regex`, this can contain regex syntax, too.
250 /// * `end` is a `&str` that describes the delimiter line until where the replacement should happen.
251 /// As the `&str` will be converted to a `Regex`, this can contain regex syntax, too.
252 /// * If `replace_start` is true, the `start` delimiter line is replaced as well. The `end`
253 /// delimiter line is never replaced.
254 /// * `replacements` is a closure that has to return a `Vec<String>` which contains the new text.
256 /// If you want to perform the replacement on files instead of already parsed text,
257 /// use `replace_region_in_file`.
262 /// let the_text = "replace_start\nsome text\nthat will be replaced\nreplace_end";
264 /// clippy_dev::replace_region_in_text(the_text, "replace_start", "replace_end", false, || {
265 /// vec!["a different".to_string(), "text".to_string()]
268 /// assert_eq!("replace_start\na different\ntext\nreplace_end", result);
270 pub fn replace_region_in_text<F>(text: &str, start: &str, end: &str, replace_start: bool, replacements: F) -> FileChange
272 F: FnOnce() -> Vec<String>,
274 let replace_it = replacements();
275 let mut in_old_region = false;
276 let mut found = false;
277 let mut new_lines = vec![];
278 let start = Regex::new(start).unwrap();
279 let end = Regex::new(end).unwrap();
281 for line in text.lines() {
283 if end.is_match(line) {
284 in_old_region = false;
285 new_lines.extend(replace_it.clone());
286 new_lines.push(line.to_string());
288 } else if start.is_match(line) {
290 new_lines.push(line.to_string());
292 in_old_region = true;
295 new_lines.push(line.to_string());
300 // This happens if the provided regex in `clippy_dev/src/main.rs` is not found in the
301 // given text or file. Most likely this is an error on the programmer's side and the Regex
303 eprintln!("error: regex `{:?}` not found. You may have to update it.", start);
306 let mut new_lines = new_lines.join("\n");
307 if text.ends_with('\n') {
308 new_lines.push('\n');
310 let changed = new_lines != text;
311 FileChange { changed, new_lines }
314 /// Returns the path to the Clippy project directory
316 pub fn clippy_project_root() -> PathBuf {
317 let current_dir = std::env::current_dir().unwrap();
318 for path in current_dir.ancestors() {
319 let result = std::fs::read_to_string(path.join("Cargo.toml"));
320 if let Err(err) = &result {
321 if err.kind() == std::io::ErrorKind::NotFound {
326 let content = result.unwrap();
327 if content.contains("[package]\nname = \"clippy\"") {
328 return path.to_path_buf();
331 panic!("error: Can't determine root of project. Please run inside a Clippy working dir.");
335 fn test_parse_contents() {
336 let result: Vec<Lint> = parse_contents(
338 declare_clippy_lint! {
345 declare_clippy_lint!{
352 declare_deprecated_lint! {
353 pub SHOULD_ASSERT_EQ,
354 "`assert!()` will be more flexible with RFC 2011"
362 Lint::new("ptr_arg", "style", "really long text", None, "module_name"),
363 Lint::new("doc_markdown", "pedantic", "single line", None, "module_name"),
367 "`assert!()` will be more flexible with RFC 2011",
368 Some("`assert!()` will be more flexible with RFC 2011"),
372 assert_eq!(expected, result);
376 fn test_replace_region() {
377 let text = "\nabc\n123\n789\ndef\nghi";
378 let expected = FileChange {
380 new_lines: "\nabc\nhello world\ndef\nghi".to_string(),
382 let result = replace_region_in_text(text, r#"^\s*abc$"#, r#"^\s*def"#, false, || {
383 vec!["hello world".to_string()]
385 assert_eq!(expected, result);
389 fn test_replace_region_with_start() {
390 let text = "\nabc\n123\n789\ndef\nghi";
391 let expected = FileChange {
393 new_lines: "\nhello world\ndef\nghi".to_string(),
395 let result = replace_region_in_text(text, r#"^\s*abc$"#, r#"^\s*def"#, true, || {
396 vec!["hello world".to_string()]
398 assert_eq!(expected, result);
402 fn test_replace_region_no_changes() {
403 let text = "123\n456\n789";
404 let expected = FileChange {
406 new_lines: "123\n456\n789".to_string(),
408 let result = replace_region_in_text(text, r#"^\s*123$"#, r#"^\s*456"#, false, || vec![]);
409 assert_eq!(expected, result);
413 fn test_usable_lints() {
415 Lint::new("should_assert_eq", "Deprecated", "abc", Some("Reason"), "module_name"),
416 Lint::new("should_assert_eq2", "Not Deprecated", "abc", None, "module_name"),
417 Lint::new("should_assert_eq2", "internal", "abc", None, "module_name"),
418 Lint::new("should_assert_eq2", "internal_style", "abc", None, "module_name"),
420 let expected = vec![Lint::new(
427 assert_eq!(expected, Lint::usable_lints(lints.into_iter()).collect::<Vec<Lint>>());
431 fn test_by_lint_group() {
433 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
434 Lint::new("should_assert_eq2", "group2", "abc", None, "module_name"),
435 Lint::new("incorrect_match", "group1", "abc", None, "module_name"),
437 let mut expected: HashMap<String, Vec<Lint>> = HashMap::new();
439 "group1".to_string(),
441 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
442 Lint::new("incorrect_match", "group1", "abc", None, "module_name"),
446 "group2".to_string(),
447 vec![Lint::new("should_assert_eq2", "group2", "abc", None, "module_name")],
449 assert_eq!(expected, Lint::by_lint_group(lints.into_iter()));
453 fn test_gen_changelog_lint_list() {
455 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
456 Lint::new("should_assert_eq2", "group2", "abc", None, "module_name"),
457 Lint::new("incorrect_internal", "internal_style", "abc", None, "module_name"),
460 format!("[`should_assert_eq`]: {}#should_assert_eq", DOCS_LINK.to_string()),
461 format!("[`should_assert_eq2`]: {}#should_assert_eq2", DOCS_LINK.to_string()),
463 assert_eq!(expected, gen_changelog_lint_list(lints));
467 fn test_gen_deprecated() {
473 Some("has been superseded by should_assert_eq2"),
477 "another_deprecated",
480 Some("will be removed"),
483 Lint::new("should_assert_eq2", "group2", "abc", None, "module_name"),
485 let expected: Vec<String> = vec![
486 " store.register_removed(",
487 " \"clippy::should_assert_eq\",",
488 " \"has been superseded by should_assert_eq2\",",
490 " store.register_removed(",
491 " \"clippy::another_deprecated\",",
492 " \"will be removed\",",
498 assert_eq!(expected, gen_deprecated(&lints));
502 fn test_gen_modules_list() {
504 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
505 Lint::new("should_assert_eq2", "group2", "abc", Some("abc"), "deprecated"),
506 Lint::new("incorrect_stuff", "group3", "abc", None, "another_module"),
507 Lint::new("incorrect_internal", "internal_style", "abc", None, "module_name"),
510 "pub mod another_module;".to_string(),
511 "pub mod module_name;".to_string(),
513 assert_eq!(expected, gen_modules_list(lints));
517 fn test_gen_lint_group_list() {
519 Lint::new("abc", "group1", "abc", None, "module_name"),
520 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
521 Lint::new("should_assert_eq2", "group2", "abc", Some("abc"), "deprecated"),
522 Lint::new("incorrect_internal", "internal_style", "abc", None, "module_name"),
525 " LintId::of(&module_name::ABC),".to_string(),
526 " LintId::of(&module_name::SHOULD_ASSERT_EQ),".to_string(),
528 assert_eq!(expected, gen_lint_group_list(lints));