1 use itertools::Itertools;
2 use lazy_static::lazy_static;
4 use std::collections::HashMap;
7 use std::io::prelude::*;
11 static ref DEC_CLIPPY_LINT_RE: Regex = Regex::new(
13 declare_clippy_lint!\s*[\{(]
15 \s+pub\s+(?P<name>[A-Z_][A-Z_0-9]*)\s*,\s*
16 (?P<cat>[a-z_]+)\s*,\s*
17 "(?P<desc>(?:[^"\\]+|\\(?s).(?-s))*)"\s*[})]
21 static ref DEC_DEPRECATED_LINT_RE: Regex = Regex::new(
23 declare_deprecated_lint!\s*[{(]\s*
25 \s+pub\s+(?P<name>[A-Z_][A-Z_0-9]*)\s*,\s*
26 "(?P<desc>(?:[^"\\]+|\\(?s).(?-s))*)"\s*[})]
30 static ref NL_ESCAPE_RE: Regex = Regex::new(r#"\\\n\s*"#).unwrap();
31 pub static ref DOCS_LINK: String = "https://rust-lang.github.io/rust-clippy/master/index.html".to_string();
34 /// Lint data parsed from the Clippy source code.
35 #[derive(Clone, PartialEq, Debug)]
40 pub deprecation: Option<String>,
45 pub fn new(name: &str, group: &str, desc: &str, deprecation: Option<&str>, module: &str) -> Self {
47 name: name.to_lowercase(),
48 group: group.to_string(),
49 desc: NL_ESCAPE_RE.replace(&desc.replace("\\\"", "\""), "").to_string(),
50 deprecation: deprecation.map(std::string::ToString::to_string),
51 module: module.to_string(),
55 /// Returns all non-deprecated lints and non-internal lints
56 pub fn usable_lints(lints: impl Iterator<Item = Self>) -> impl Iterator<Item = Self> {
57 lints.filter(|l| l.deprecation.is_none() && !l.is_internal())
60 /// Returns the lints in a HashMap, grouped by the different lint groups
61 pub fn by_lint_group(lints: &[Self]) -> HashMap<String, Vec<Self>> {
64 .map(|lint| (lint.group.to_string(), lint.clone()))
68 pub fn is_internal(&self) -> bool {
69 self.group.starts_with("internal")
73 /// Generates the Vec items for `register_lint_group` calls in `clippy_lints/src/lib.rs`.
74 pub fn gen_lint_group_list(lints: Vec<Lint>) -> Vec<String> {
78 if l.is_internal() || l.deprecation.is_some() {
81 Some(format!(" {}::{},", l.module, l.name.to_uppercase()))
85 .collect::<Vec<String>>()
88 /// Generates the `pub mod module_name` list in `clippy_lints/src/lib.rs`.
89 pub fn gen_modules_list(lints: Vec<Lint>) -> Vec<String> {
93 if l.is_internal() || l.deprecation.is_some() {
100 .map(|module| format!("pub mod {};", module))
102 .collect::<Vec<String>>()
105 /// Generates the list of lint links at the bottom of the README
106 pub fn gen_changelog_lint_list(lints: Vec<Lint>) -> Vec<String> {
107 let mut lint_list_sorted: Vec<Lint> = lints;
108 lint_list_sorted.sort_by_key(|l| l.name.clone());
115 Some(format!("[`{}`]: {}#{}", l.name, DOCS_LINK.clone(), l.name))
121 /// Generates the `register_removed` code in `./clippy_lints/src/lib.rs`.
122 pub fn gen_deprecated(lints: &[Lint]) -> Vec<String> {
126 l.clone().deprecation.and_then(|depr_text| {
128 " store.register_removed(".to_string(),
129 format!(" \"{}\",", l.name),
130 format!(" \"{}\",", depr_text),
136 .collect::<Vec<String>>()
139 /// Gathers all files in `src/clippy_lints` and gathers all lints inside
140 pub fn gather_all() -> impl Iterator<Item = Lint> {
141 lint_files().flat_map(|f| gather_from_file(&f))
144 fn gather_from_file(dir_entry: &walkdir::DirEntry) -> impl Iterator<Item = Lint> {
145 let mut file = fs::File::open(dir_entry.path()).unwrap();
146 let mut content = String::new();
147 file.read_to_string(&mut content).unwrap();
148 let mut filename = dir_entry.path().file_stem().unwrap().to_str().unwrap();
149 // If the lints are stored in mod.rs, we get the module name from
150 // the containing directory:
151 if filename == "mod" {
161 parse_contents(&content, filename)
164 fn parse_contents(content: &str, filename: &str) -> impl Iterator<Item = Lint> {
165 let lints = DEC_CLIPPY_LINT_RE
166 .captures_iter(content)
167 .map(|m| Lint::new(&m["name"], &m["cat"], &m["desc"], None, filename));
168 let deprecated = DEC_DEPRECATED_LINT_RE
169 .captures_iter(content)
170 .map(|m| Lint::new(&m["name"], "Deprecated", &m["desc"], Some(&m["desc"]), filename));
171 // Removing the `.collect::<Vec<Lint>>().into_iter()` causes some lifetime issues due to the map
172 lints.chain(deprecated).collect::<Vec<Lint>>().into_iter()
175 /// Collects all .rs files in the `clippy_lints/src` directory
176 fn lint_files() -> impl Iterator<Item = walkdir::DirEntry> {
177 // We use `WalkDir` instead of `fs::read_dir` here in order to recurse into subdirectories.
178 // Otherwise we would not collect all the lints, for example in `clippy_lints/src/methods/`.
179 WalkDir::new("../clippy_lints/src")
181 .filter_map(std::result::Result::ok)
182 .filter(|f| f.path().extension() == Some(OsStr::new("rs")))
185 /// Whether a file has had its text changed or not
186 #[derive(PartialEq, Debug)]
187 pub struct FileChange {
189 pub new_lines: String,
192 /// Replaces a region in a file delimited by two lines matching regexes.
194 /// `path` is the relative path to the file on which you want to perform the replacement.
196 /// See `replace_region_in_text` for documentation of the other options.
197 #[allow(clippy::expect_fun_call)]
198 pub fn replace_region_in_file<F>(
207 F: Fn() -> Vec<String>,
209 let mut f = fs::File::open(path).expect(&format!("File not found: {}", path));
210 let mut contents = String::new();
211 f.read_to_string(&mut contents)
212 .expect("Something went wrong reading the file");
213 let file_change = replace_region_in_text(&contents, start, end, replace_start, replacements);
216 let mut f = fs::File::create(path).expect(&format!("File not found: {}", path));
217 f.write_all(file_change.new_lines.as_bytes())
218 .expect("Unable to write file");
219 // Ensure we write the changes with a trailing newline so that
220 // the file has the proper line endings.
221 f.write_all(b"\n").expect("Unable to write file");
226 /// Replaces a region in a text delimited by two lines matching regexes.
228 /// * `text` is the input text on which you want to perform the replacement
229 /// * `start` is a `&str` that describes the delimiter line before the region you want to replace.
230 /// As the `&str` will be converted to a `Regex`, this can contain regex syntax, too.
231 /// * `end` is a `&str` that describes the delimiter line until where the replacement should happen.
232 /// As the `&str` will be converted to a `Regex`, this can contain regex syntax, too.
233 /// * If `replace_start` is true, the `start` delimiter line is replaced as well. The `end`
234 /// delimiter line is never replaced.
235 /// * `replacements` is a closure that has to return a `Vec<String>` which contains the new text.
237 /// If you want to perform the replacement on files instead of already parsed text,
238 /// use `replace_region_in_file`.
243 /// let the_text = "replace_start\nsome text\nthat will be replaced\nreplace_end";
244 /// let result = clippy_dev::replace_region_in_text(the_text, r#"replace_start"#, r#"replace_end"#, false, || {
245 /// vec!["a different".to_string(), "text".to_string()]
248 /// assert_eq!("replace_start\na different\ntext\nreplace_end", result);
250 pub fn replace_region_in_text<F>(text: &str, start: &str, end: &str, replace_start: bool, replacements: F) -> FileChange
252 F: Fn() -> Vec<String>,
254 let lines = text.lines();
255 let mut in_old_region = false;
256 let mut found = false;
257 let mut new_lines = vec![];
258 let start = Regex::new(start).unwrap();
259 let end = Regex::new(end).unwrap();
261 for line in lines.clone() {
263 if end.is_match(&line) {
264 in_old_region = false;
265 new_lines.extend(replacements());
266 new_lines.push(line.to_string());
268 } else if start.is_match(&line) {
270 new_lines.push(line.to_string());
272 in_old_region = true;
275 new_lines.push(line.to_string());
280 // This happens if the provided regex in `clippy_dev/src/main.rs` is not found in the
281 // given text or file. Most likely this is an error on the programmer's side and the Regex
283 eprintln!("error: regex `{:?}` not found. You may have to update it.", start);
287 changed: lines.ne(new_lines.clone()),
288 new_lines: new_lines.join("\n"),
293 fn test_parse_contents() {
294 let result: Vec<Lint> = parse_contents(
296 declare_clippy_lint! {
303 declare_clippy_lint!{
310 declare_deprecated_lint! {
311 pub SHOULD_ASSERT_EQ,
312 "`assert!()` will be more flexible with RFC 2011"
320 Lint::new("ptr_arg", "style", "really long text", None, "module_name"),
321 Lint::new("doc_markdown", "pedantic", "single line", None, "module_name"),
325 "`assert!()` will be more flexible with RFC 2011",
326 Some("`assert!()` will be more flexible with RFC 2011"),
330 assert_eq!(expected, result);
334 fn test_replace_region() {
335 let text = "\nabc\n123\n789\ndef\nghi";
336 let expected = FileChange {
338 new_lines: "\nabc\nhello world\ndef\nghi".to_string(),
340 let result = replace_region_in_text(text, r#"^\s*abc$"#, r#"^\s*def"#, false, || {
341 vec!["hello world".to_string()]
343 assert_eq!(expected, result);
347 fn test_replace_region_with_start() {
348 let text = "\nabc\n123\n789\ndef\nghi";
349 let expected = FileChange {
351 new_lines: "\nhello world\ndef\nghi".to_string(),
353 let result = replace_region_in_text(text, r#"^\s*abc$"#, r#"^\s*def"#, true, || {
354 vec!["hello world".to_string()]
356 assert_eq!(expected, result);
360 fn test_replace_region_no_changes() {
361 let text = "123\n456\n789";
362 let expected = FileChange {
364 new_lines: "123\n456\n789".to_string(),
366 let result = replace_region_in_text(text, r#"^\s*123$"#, r#"^\s*456"#, false, || vec![]);
367 assert_eq!(expected, result);
371 fn test_usable_lints() {
373 Lint::new("should_assert_eq", "Deprecated", "abc", Some("Reason"), "module_name"),
374 Lint::new("should_assert_eq2", "Not Deprecated", "abc", None, "module_name"),
375 Lint::new("should_assert_eq2", "internal", "abc", None, "module_name"),
376 Lint::new("should_assert_eq2", "internal_style", "abc", None, "module_name"),
378 let expected = vec![Lint::new(
385 assert_eq!(expected, Lint::usable_lints(lints.into_iter()).collect::<Vec<Lint>>());
389 fn test_by_lint_group() {
391 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
392 Lint::new("should_assert_eq2", "group2", "abc", None, "module_name"),
393 Lint::new("incorrect_match", "group1", "abc", None, "module_name"),
395 let mut expected: HashMap<String, Vec<Lint>> = HashMap::new();
397 "group1".to_string(),
399 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
400 Lint::new("incorrect_match", "group1", "abc", None, "module_name"),
404 "group2".to_string(),
405 vec![Lint::new("should_assert_eq2", "group2", "abc", None, "module_name")],
407 assert_eq!(expected, Lint::by_lint_group(&lints));
411 fn test_gen_changelog_lint_list() {
413 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
414 Lint::new("should_assert_eq2", "group2", "abc", None, "module_name"),
415 Lint::new("incorrect_internal", "internal_style", "abc", None, "module_name"),
418 format!("[`should_assert_eq`]: {}#should_assert_eq", DOCS_LINK.to_string()),
419 format!("[`should_assert_eq2`]: {}#should_assert_eq2", DOCS_LINK.to_string()),
421 assert_eq!(expected, gen_changelog_lint_list(lints));
425 fn test_gen_deprecated() {
431 Some("has been superseded by should_assert_eq2"),
435 "another_deprecated",
438 Some("will be removed"),
441 Lint::new("should_assert_eq2", "group2", "abc", None, "module_name"),
443 let expected: Vec<String> = vec![
444 " store.register_removed(",
445 " \"should_assert_eq\",",
446 " \"has been superseded by should_assert_eq2\",",
448 " store.register_removed(",
449 " \"another_deprecated\",",
450 " \"will be removed\",",
456 assert_eq!(expected, gen_deprecated(&lints));
460 fn test_gen_modules_list() {
462 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
463 Lint::new("should_assert_eq2", "group2", "abc", Some("abc"), "deprecated"),
464 Lint::new("incorrect_stuff", "group3", "abc", None, "another_module"),
465 Lint::new("incorrect_internal", "internal_style", "abc", None, "module_name"),
468 "pub mod another_module;".to_string(),
469 "pub mod module_name;".to_string(),
471 assert_eq!(expected, gen_modules_list(lints));
475 fn test_gen_lint_group_list() {
477 Lint::new("abc", "group1", "abc", None, "module_name"),
478 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
479 Lint::new("should_assert_eq2", "group2", "abc", Some("abc"), "deprecated"),
480 Lint::new("incorrect_internal", "internal_style", "abc", None, "module_name"),
483 " module_name::ABC,".to_string(),
484 " module_name::SHOULD_ASSERT_EQ,".to_string(),
486 assert_eq!(expected, gen_lint_group_list(lints));