1 #![allow(clippy::default_hash_types)]
3 use itertools::Itertools;
4 use lazy_static::lazy_static;
6 use std::collections::HashMap;
9 use std::io::prelude::*;
13 static ref DEC_CLIPPY_LINT_RE: Regex = Regex::new(
15 declare_clippy_lint!\s*[\{(]
17 \s+pub\s+(?P<name>[A-Z_][A-Z_0-9]*)\s*,\s*
18 (?P<cat>[a-z_]+)\s*,\s*
19 "(?P<desc>(?:[^"\\]+|\\(?s).(?-s))*)"\s*[})]
23 static ref DEC_DEPRECATED_LINT_RE: Regex = Regex::new(
25 declare_deprecated_lint!\s*[{(]\s*
27 \s+pub\s+(?P<name>[A-Z_][A-Z_0-9]*)\s*,\s*
28 "(?P<desc>(?:[^"\\]+|\\(?s).(?-s))*)"\s*[})]
32 static ref NL_ESCAPE_RE: Regex = Regex::new(r#"\\\n\s*"#).unwrap();
33 pub static ref DOCS_LINK: String = "https://rust-lang.github.io/rust-clippy/master/index.html".to_string();
36 /// Lint data parsed from the Clippy source code.
37 #[derive(Clone, PartialEq, Debug)]
42 pub deprecation: Option<String>,
47 pub fn new(name: &str, group: &str, desc: &str, deprecation: Option<&str>, module: &str) -> Self {
49 name: name.to_lowercase(),
50 group: group.to_string(),
51 desc: NL_ESCAPE_RE.replace(&desc.replace("\\\"", "\""), "").to_string(),
52 deprecation: deprecation.map(std::string::ToString::to_string),
53 module: module.to_string(),
57 /// Returns all non-deprecated lints and non-internal lints
58 pub fn usable_lints(lints: impl Iterator<Item = Self>) -> impl Iterator<Item = Self> {
59 lints.filter(|l| l.deprecation.is_none() && !l.is_internal())
62 /// Returns the lints in a HashMap, grouped by the different lint groups
63 pub fn by_lint_group(lints: &[Self]) -> HashMap<String, Vec<Self>> {
66 .map(|lint| (lint.group.to_string(), lint.clone()))
70 pub fn is_internal(&self) -> bool {
71 self.group.starts_with("internal")
75 /// Generates the Vec items for `register_lint_group` calls in `clippy_lints/src/lib.rs`.
76 pub fn gen_lint_group_list(lints: Vec<Lint>) -> Vec<String> {
80 if l.is_internal() || l.deprecation.is_some() {
83 Some(format!(" {}::{},", l.module, l.name.to_uppercase()))
87 .collect::<Vec<String>>()
90 /// Generates the `pub mod module_name` list in `clippy_lints/src/lib.rs`.
91 pub fn gen_modules_list(lints: Vec<Lint>) -> Vec<String> {
95 if l.is_internal() || l.deprecation.is_some() {
102 .map(|module| format!("pub mod {};", module))
104 .collect::<Vec<String>>()
107 /// Generates the list of lint links at the bottom of the README
108 pub fn gen_changelog_lint_list(lints: Vec<Lint>) -> Vec<String> {
109 let mut lint_list_sorted: Vec<Lint> = lints;
110 lint_list_sorted.sort_by_key(|l| l.name.clone());
117 Some(format!("[`{}`]: {}#{}", l.name, DOCS_LINK.clone(), l.name))
123 /// Generates the `register_removed` code in `./clippy_lints/src/lib.rs`.
124 pub fn gen_deprecated(lints: &[Lint]) -> Vec<String> {
128 l.clone().deprecation.and_then(|depr_text| {
130 " store.register_removed(".to_string(),
131 format!(" \"{}\",", l.name),
132 format!(" \"{}\",", depr_text),
138 .collect::<Vec<String>>()
141 /// Gathers all files in `src/clippy_lints` and gathers all lints inside
142 pub fn gather_all() -> impl Iterator<Item = Lint> {
143 lint_files().flat_map(|f| gather_from_file(&f))
146 fn gather_from_file(dir_entry: &walkdir::DirEntry) -> impl Iterator<Item = Lint> {
147 let mut file = fs::File::open(dir_entry.path()).unwrap();
148 let mut content = String::new();
149 file.read_to_string(&mut content).unwrap();
150 let mut filename = dir_entry.path().file_stem().unwrap().to_str().unwrap();
151 // If the lints are stored in mod.rs, we get the module name from
152 // the containing directory:
153 if filename == "mod" {
163 parse_contents(&content, filename)
166 fn parse_contents(content: &str, filename: &str) -> impl Iterator<Item = Lint> {
167 let lints = DEC_CLIPPY_LINT_RE
168 .captures_iter(content)
169 .map(|m| Lint::new(&m["name"], &m["cat"], &m["desc"], None, filename));
170 let deprecated = DEC_DEPRECATED_LINT_RE
171 .captures_iter(content)
172 .map(|m| Lint::new(&m["name"], "Deprecated", &m["desc"], Some(&m["desc"]), filename));
173 // Removing the `.collect::<Vec<Lint>>().into_iter()` causes some lifetime issues due to the map
174 lints.chain(deprecated).collect::<Vec<Lint>>().into_iter()
177 /// Collects all .rs files in the `clippy_lints/src` directory
178 fn lint_files() -> impl Iterator<Item = walkdir::DirEntry> {
179 // We use `WalkDir` instead of `fs::read_dir` here in order to recurse into subdirectories.
180 // Otherwise we would not collect all the lints, for example in `clippy_lints/src/methods/`.
181 WalkDir::new("../clippy_lints/src")
183 .filter_map(std::result::Result::ok)
184 .filter(|f| f.path().extension() == Some(OsStr::new("rs")))
187 /// Whether a file has had its text changed or not
188 #[derive(PartialEq, Debug)]
189 pub struct FileChange {
191 pub new_lines: String,
194 /// Replaces a region in a file delimited by two lines matching regexes.
196 /// `path` is the relative path to the file on which you want to perform the replacement.
198 /// See `replace_region_in_text` for documentation of the other options.
199 #[allow(clippy::expect_fun_call)]
200 pub fn replace_region_in_file<F>(
209 F: Fn() -> Vec<String>,
211 let mut f = fs::File::open(path).expect(&format!("File not found: {}", path));
212 let mut contents = String::new();
213 f.read_to_string(&mut contents)
214 .expect("Something went wrong reading the file");
215 let file_change = replace_region_in_text(&contents, start, end, replace_start, replacements);
218 let mut f = fs::File::create(path).expect(&format!("File not found: {}", path));
219 f.write_all(file_change.new_lines.as_bytes())
220 .expect("Unable to write file");
221 // Ensure we write the changes with a trailing newline so that
222 // the file has the proper line endings.
223 f.write_all(b"\n").expect("Unable to write file");
228 /// Replaces a region in a text delimited by two lines matching regexes.
230 /// * `text` is the input text on which you want to perform the replacement
231 /// * `start` is a `&str` that describes the delimiter line before the region you want to replace.
232 /// As the `&str` will be converted to a `Regex`, this can contain regex syntax, too.
233 /// * `end` is a `&str` that describes the delimiter line until where the replacement should happen.
234 /// As the `&str` will be converted to a `Regex`, this can contain regex syntax, too.
235 /// * If `replace_start` is true, the `start` delimiter line is replaced as well. The `end`
236 /// delimiter line is never replaced.
237 /// * `replacements` is a closure that has to return a `Vec<String>` which contains the new text.
239 /// If you want to perform the replacement on files instead of already parsed text,
240 /// use `replace_region_in_file`.
245 /// let the_text = "replace_start\nsome text\nthat will be replaced\nreplace_end";
246 /// let result = clippy_dev::replace_region_in_text(the_text, r#"replace_start"#, r#"replace_end"#, false, || {
247 /// vec!["a different".to_string(), "text".to_string()]
250 /// assert_eq!("replace_start\na different\ntext\nreplace_end", result);
252 pub fn replace_region_in_text<F>(text: &str, start: &str, end: &str, replace_start: bool, replacements: F) -> FileChange
254 F: Fn() -> Vec<String>,
256 let lines = text.lines();
257 let mut in_old_region = false;
258 let mut found = false;
259 let mut new_lines = vec![];
260 let start = Regex::new(start).unwrap();
261 let end = Regex::new(end).unwrap();
263 for line in lines.clone() {
265 if end.is_match(&line) {
266 in_old_region = false;
267 new_lines.extend(replacements());
268 new_lines.push(line.to_string());
270 } else if start.is_match(&line) {
272 new_lines.push(line.to_string());
274 in_old_region = true;
277 new_lines.push(line.to_string());
282 // This happens if the provided regex in `clippy_dev/src/main.rs` is not found in the
283 // given text or file. Most likely this is an error on the programmer's side and the Regex
285 eprintln!("error: regex `{:?}` not found. You may have to update it.", start);
289 changed: lines.ne(new_lines.clone()),
290 new_lines: new_lines.join("\n"),
295 fn test_parse_contents() {
296 let result: Vec<Lint> = parse_contents(
298 declare_clippy_lint! {
305 declare_clippy_lint!{
312 declare_deprecated_lint! {
313 pub SHOULD_ASSERT_EQ,
314 "`assert!()` will be more flexible with RFC 2011"
322 Lint::new("ptr_arg", "style", "really long text", None, "module_name"),
323 Lint::new("doc_markdown", "pedantic", "single line", None, "module_name"),
327 "`assert!()` will be more flexible with RFC 2011",
328 Some("`assert!()` will be more flexible with RFC 2011"),
332 assert_eq!(expected, result);
336 fn test_replace_region() {
337 let text = "\nabc\n123\n789\ndef\nghi";
338 let expected = FileChange {
340 new_lines: "\nabc\nhello world\ndef\nghi".to_string(),
342 let result = replace_region_in_text(text, r#"^\s*abc$"#, r#"^\s*def"#, false, || {
343 vec!["hello world".to_string()]
345 assert_eq!(expected, result);
349 fn test_replace_region_with_start() {
350 let text = "\nabc\n123\n789\ndef\nghi";
351 let expected = FileChange {
353 new_lines: "\nhello world\ndef\nghi".to_string(),
355 let result = replace_region_in_text(text, r#"^\s*abc$"#, r#"^\s*def"#, true, || {
356 vec!["hello world".to_string()]
358 assert_eq!(expected, result);
362 fn test_replace_region_no_changes() {
363 let text = "123\n456\n789";
364 let expected = FileChange {
366 new_lines: "123\n456\n789".to_string(),
368 let result = replace_region_in_text(text, r#"^\s*123$"#, r#"^\s*456"#, false, || vec![]);
369 assert_eq!(expected, result);
373 fn test_usable_lints() {
375 Lint::new("should_assert_eq", "Deprecated", "abc", Some("Reason"), "module_name"),
376 Lint::new("should_assert_eq2", "Not Deprecated", "abc", None, "module_name"),
377 Lint::new("should_assert_eq2", "internal", "abc", None, "module_name"),
378 Lint::new("should_assert_eq2", "internal_style", "abc", None, "module_name"),
380 let expected = vec![Lint::new(
387 assert_eq!(expected, Lint::usable_lints(lints.into_iter()).collect::<Vec<Lint>>());
391 fn test_by_lint_group() {
393 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
394 Lint::new("should_assert_eq2", "group2", "abc", None, "module_name"),
395 Lint::new("incorrect_match", "group1", "abc", None, "module_name"),
397 let mut expected: HashMap<String, Vec<Lint>> = HashMap::new();
399 "group1".to_string(),
401 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
402 Lint::new("incorrect_match", "group1", "abc", None, "module_name"),
406 "group2".to_string(),
407 vec![Lint::new("should_assert_eq2", "group2", "abc", None, "module_name")],
409 assert_eq!(expected, Lint::by_lint_group(&lints));
413 fn test_gen_changelog_lint_list() {
415 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
416 Lint::new("should_assert_eq2", "group2", "abc", None, "module_name"),
417 Lint::new("incorrect_internal", "internal_style", "abc", None, "module_name"),
420 format!("[`should_assert_eq`]: {}#should_assert_eq", DOCS_LINK.to_string()),
421 format!("[`should_assert_eq2`]: {}#should_assert_eq2", DOCS_LINK.to_string()),
423 assert_eq!(expected, gen_changelog_lint_list(lints));
427 fn test_gen_deprecated() {
433 Some("has been superseded by should_assert_eq2"),
437 "another_deprecated",
440 Some("will be removed"),
443 Lint::new("should_assert_eq2", "group2", "abc", None, "module_name"),
445 let expected: Vec<String> = vec![
446 " store.register_removed(",
447 " \"should_assert_eq\",",
448 " \"has been superseded by should_assert_eq2\",",
450 " store.register_removed(",
451 " \"another_deprecated\",",
452 " \"will be removed\",",
458 assert_eq!(expected, gen_deprecated(&lints));
462 fn test_gen_modules_list() {
464 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
465 Lint::new("should_assert_eq2", "group2", "abc", Some("abc"), "deprecated"),
466 Lint::new("incorrect_stuff", "group3", "abc", None, "another_module"),
467 Lint::new("incorrect_internal", "internal_style", "abc", None, "module_name"),
470 "pub mod another_module;".to_string(),
471 "pub mod module_name;".to_string(),
473 assert_eq!(expected, gen_modules_list(lints));
477 fn test_gen_lint_group_list() {
479 Lint::new("abc", "group1", "abc", None, "module_name"),
480 Lint::new("should_assert_eq", "group1", "abc", None, "module_name"),
481 Lint::new("should_assert_eq2", "group2", "abc", Some("abc"), "deprecated"),
482 Lint::new("incorrect_internal", "internal_style", "abc", None, "module_name"),
485 " module_name::ABC,".to_string(),
486 " module_name::SHOULD_ASSERT_EQ,".to_string(),
488 assert_eq!(expected, gen_lint_group_list(lints));